Re: [ovs-dev] [PATCH v3] ovsdb-client: Set binary mode when doing backup/restore

2018-03-14 Thread aserdean
> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 14, 2018 8:11 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v3] ovsdb-client: Set binary mode when doing > back

Re: [ovs-dev] [PATCH] odp-util: Print eth() for Ethernet flows if packet_type is absent.

2018-03-14 Thread Ben Pfaff
Thanks, I applied this to master, branch-2.9, and branch-2.8. On Wed, Mar 14, 2018 at 03:48:26PM -0700, Yi-Hung Wei wrote: > Thanks for the fix. I tested this patch, and it does show eth() when > the OVS_KEY_ATTR_ETHERNET is all-wildcarded. > > Acked-by: Yi-Hung Wei > > On Wed, Mar 14, 2018 at

Re: [ovs-dev] [PATCH] Clean up some minor spelling and typos.

2018-03-14 Thread Justin Pettit
> On Mar 14, 2018, at 3:39 PM, Ben Pfaff wrote: > > On Wed, Mar 14, 2018 at 02:39:34PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to master. --Justin ___ dev mailing list d...@openv

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Report ct fields changes in ofproto/trace

2018-03-14 Thread Yi-Hung Wei
On Wed, Mar 14, 2018 at 3:27 PM, Ben Pfaff wrote: > On Wed, Mar 14, 2018 at 11:16:41AM -0700, Yi-Hung Wei wrote: >> With commit f6fabcc6 ("ofproto-dpif: Mark packets as "untracked" after >> call to ct()", after the ct() action, the packet conntrack state is set >> to an untracked state, and all th

Re: [ovs-dev] [PATCH] odp-util: Fix ofproto/trace with odp flow

2018-03-14 Thread Yi-Hung Wei
On Wed, Mar 14, 2018 at 2:59 PM, Ben Pfaff wrote: > I posted an alternative proposal: > https://patchwork.ozlabs.org/patch/886052/ > > I haven't checked that this solves the problem, so I would appreciate > testing. Thanks for this fix. With your patch, eth() is printed with eth_type() for the k

Re: [ovs-dev] [PATCH] odp-util: Print eth() for Ethernet flows if packet_type is absent.

2018-03-14 Thread Yi-Hung Wei
Thanks for the fix. I tested this patch, and it does show eth() when the OVS_KEY_ATTR_ETHERNET is all-wildcarded. Acked-by: Yi-Hung Wei On Wed, Mar 14, 2018 at 2:57 PM, Ben Pfaff wrote: > OVS datapaths have two different ways to indicate what kind of packet a > flow matches. One way, used by t

Re: [ovs-dev] [PATCH] Clean up some minor spelling and typos.

2018-03-14 Thread Ben Pfaff
On Wed, Mar 14, 2018 at 02:39:34PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] Upcall/Slowpath rate limiter for OVS

2018-03-14 Thread Ben Pfaff
I don't care anymore. On Tue, Mar 13, 2018 at 04:55:22PM +, Manohar Krishnappa Chidambaraswamy wrote: > Ben, > > Could you please let me know your views? Like other meters, OFPM_SLOWPATH is > also local to each bridge and tied to USERSPACE action. So OFPM_SLOWPATH > cannot be used as is fo

Re: [ovs-dev] [PATCH v1 1/1] Include bfd_status in ovs-vsctl show for interfaces

2018-03-14 Thread Ben Pfaff
On Mon, Mar 12, 2018 at 10:31:25AM +, Miguel Angel Ajo wrote: > Since OVS 2.8 OVN provides L3HA capabilities via BFD monitoring, > but checking the status of BFD is not obvious, and we provide > a simple way to visualize the status with this simple patch. > > Signed-off-by: Miguel Angel Ajo >

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Report ct fields changes in ofproto/trace

2018-03-14 Thread Ben Pfaff
On Wed, Mar 14, 2018 at 11:16:41AM -0700, Yi-Hung Wei wrote: > With commit f6fabcc6 ("ofproto-dpif: Mark packets as "untracked" after > call to ct()", after the ct() action, the packet conntrack state is set > to an untracked state, and all the conntrack fields are cleared. > This patch updates ofp

Re: [ovs-dev] [PATCH] ovsdb: Fix database compaction check

2018-03-14 Thread Ben Pfaff
On Wed, Mar 14, 2018 at 03:13:33PM -0700, Ben Pfaff wrote: > On Sat, Mar 10, 2018 at 02:48:00PM +0100, Daniel Alvarez wrote: > > We want to compact database file if it has been over 24 hours since we > > last compacted it and there's more than 100 commits regardless of the > > size of the database.

Re: [ovs-dev] [PATCH v2] ovsdb: Fix database compaction check

2018-03-14 Thread Ben Pfaff
On Sat, Mar 10, 2018 at 02:50:14PM +0100, Daniel Alvarez wrote: > We want to compact database file if it has been over 24 hours since we > last compacted it and there's more than 100 commits regardless of the > size of the database. This patch fixes the previous comparisson which > checked if 24 ho

Re: [ovs-dev] [PATCH] ovsdb: Fix database compaction check

2018-03-14 Thread Ben Pfaff
On Sat, Mar 10, 2018 at 02:48:00PM +0100, Daniel Alvarez wrote: > We want to compact database file if it has been over 24 hours since we > last compacted it and there's more than 100 commits regardless of the > size of the database. This patch fixes the previous comparisson which > checked if 24 ho

Re: [ovs-dev] [PATCH] odp-util: Fix ofproto/trace with odp flow

2018-03-14 Thread Ben Pfaff
On Sat, Mar 10, 2018 at 09:30:34AM -0800, Yi-Hung Wei wrote: > Currently, using ofproto/trace to trace a datapath flow with eth_type() > but without eth() may hit unexpected behavior because OVS sets > the packet_type to be (1, eth_type) when decoding the odp flow key. > This patch updates the logi

[ovs-dev] [PATCH] odp-util: Print eth() for Ethernet flows if packet_type is absent.

2018-03-14 Thread Ben Pfaff
OVS datapaths have two different ways to indicate what kind of packet a flow matches. One way, used by the userspace datapath, is OVS_KEY_ATTR_PACKET_TYPE. Another way, used by the kernel datapath, is OVS_KEY_ATTR_ETHERTYPE when used in the absence of OVS_KEY_ATTR_ETHERNET; when the latter is pre

[ovs-dev] [PATCH] Clean up some minor spelling and typos.

2018-03-14 Thread Justin Pettit
Signed-off-by: Justin Pettit --- Documentation/howto/docker.rst | 6 +++--- Documentation/howto/dpdk.rst | 12 ++-- Documentation/howto/firewalld.rst| 2 +- Documentation/howto/lisp.rst

Re: [ovs-dev] [PATCH] odp-util: Fix ofproto/trace with odp flow

2018-03-14 Thread Jiri Benc
On Tue, 13 Mar 2018 09:36:23 -0700, Darrell Ball wrote: > [Darrell] There was no suggestion otherwise in general. We were discussing > for one the difference b/w kernel and userspace DP for handling packet type > aware support. Specifically, the difference is here is as fundamental as it > gets - >

Re: [ovs-dev] [PATCH] python: Enable flake8 checking of ovs-pipegen.py.

2018-03-14 Thread Russell Bryant
On Wed, Mar 14, 2018 at 3:48 PM, Ben Pfaff wrote: > On Wed, Mar 14, 2018 at 11:07:44AM -0400, Russell Bryant wrote: > > Signed-off-by: Russell Bryant > > flake8-check passes for me, with this change. > > Acked-by: Ben Pfaff > ​Thanks! applied to master. -- Russell Bryant ___

Re: [ovs-dev] [PATCH] odp-util: Fix ofproto/trace with odp flow

2018-03-14 Thread Ben Pfaff
On Tue, Mar 13, 2018 at 09:36:23AM -0700, Darrell Ball wrote: > On Tue, Mar 13, 2018 at 1:24 AM, Jiri Benc wrote: > > > Darell, please fix your email client configuration to conform to > > RFC 3676 (https://tools.ietf.org/html/rfc3676#section-4.5). Your > > replies are unreadable. In particular,

Re: [ovs-dev] [PATCH v1] ovn-ctl: Trivial, remove duplicated stop_controller case option

2018-03-14 Thread Ben Pfaff
On Wed, Mar 14, 2018 at 04:41:11PM +, Lucas Alvares Gomes wrote: > Signed-off-by: Lucas Alvares Gomes Applied to master, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] python: Enable flake8 checking of ovs-pipegen.py.

2018-03-14 Thread Ben Pfaff
On Wed, Mar 14, 2018 at 11:07:44AM -0400, Russell Bryant wrote: > Signed-off-by: Russell Bryant flake8-check passes for me, with this change. Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/o

Re: [ovs-dev] [PATCH 6/6] ofp-print: Move much of the printing code into message-specific files.

2018-03-14 Thread Ben Pfaff
On Tue, Mar 13, 2018 at 04:15:08PM -0700, Justin Pettit wrote: > > > > On Mar 13, 2018, at 4:04 PM, Justin Pettit wrote: > > > > > >> On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote: > > > > It looks like this was mostly moving code around, so I didn't pore over the > > review, but let me know

Re: [ovs-dev] [PATCH 3/6] ofp-packet: Better abstract packet-in format.

2018-03-14 Thread Ben Pfaff
On Mon, Mar 12, 2018 at 06:22:06PM -0700, Justin Pettit wrote: > > > On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote: > > > > diff --git a/lib/ofp-print.c b/lib/ofp-print.c > > index b13bc380386a..c0bfa92843c6 100644 > > --- a/lib/ofp-print.c > > +++ b/lib/ofp-print.c > > @@ -2287,18 +2287,15 @@ of

Re: [ovs-dev] [PATCH 2/6] ofp-protocol: Better abstract changing the protocol used for flow matches.

2018-03-14 Thread Ben Pfaff
On Mon, Mar 12, 2018 at 06:11:48PM -0700, Justin Pettit wrote: > > > On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote: > > > > diff --git a/lib/ofp-protocol.c b/lib/ofp-protocol.c > > index 175318380f3b..32cf1c3fca40 100644 > > --- a/lib/ofp-protocol.c > > +++ b/lib/ofp-protocol.c > > ... > > +/* Re

Re: [ovs-dev] [PATCH] ovsdb-idl: Use modern form of .

2018-03-14 Thread Ben Pfaff
On Mon, Mar 12, 2018 at 05:51:23PM -0700, Justin Pettit wrote: > > > On Mar 7, 2018, at 10:26 AM, Ben Pfaff wrote: > > > > Long ago, a object in the OVSDB protocol mapped a table > > name to a single . Since then, it has mapped a table name > > to an *array of* objects, but the OVSDB IDL has

[ovs-dev] [PATCH] ofproto-dpif-xlate: Report ct fields changes in ofproto/trace

2018-03-14 Thread Yi-Hung Wei
With commit f6fabcc6 ("ofproto-dpif: Mark packets as "untracked" after call to ct()", after the ct() action, the packet conntrack state is set to an untracked state, and all the conntrack fields are cleared. This patch updates ofproto/trace report to reflect this change, so that it would be easier

Re: [ovs-dev] [PATCH v3] ovsdb-client: Set binary mode when doing backup/restore

2018-03-14 Thread Ben Pfaff
On Mon, Mar 12, 2018 at 03:17:42PM +0200, Alin Gabriel Serdean wrote: > Add some needed consistency on Windows for STD_IN/OUT file descriptors > when doing backup and restore. > > Reported-at:https://mail.openvswitch.org/pipermail/ovs-dev/2018-January/343518.html > Suggested-by: Ben Pfaff > Co-au

Re: [ovs-dev] [PATCH] vswitchd: Remove support for deprecated "null" interfaces.

2018-03-14 Thread Ben Pfaff
On Mon, Mar 12, 2018 at 05:39:55PM -0700, Justin Pettit wrote: > > > On Mar 9, 2018, at 10:45 AM, Ben Pfaff wrote: > > > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > > index f03fb567f0be..95a126d52b4a 100644 > > --- a/vswitchd/bridge.c > > +++ b/vswitchd/bridge.c > > @@ -3448,11 +3448,

[ovs-dev] [PATCH v1] ovn-ctl: Trivial, remove duplicated stop_controller case option

2018-03-14 Thread Lucas Alvares Gomes
Signed-off-by: Lucas Alvares Gomes --- ovn/utilities/ovn-ctl | 3 --- 1 file changed, 3 deletions(-) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 0e56bf8c5..dc0c26159 100755 --- a/ovn/utilities/ovn-ctl +++ b/ovn/utilities/ovn-ctl @@ -581,9 +581,6 @@ case $command in stop

Re: [ovs-dev] [PATCH v2] tests: Add some Python3 test variants on ovsdb-idl.at

2018-03-14 Thread Russell Bryant
I've applied this to master. Thanks! On Tue, Mar 13, 2018 at 10:39 AM, Timothy Redaelli wrote: > Execute the "passive tcp", "fetch columns", "idl notify", "idl notify SSL" > and "simple idl disable monitor-cond" tests also using Python3 > (when available). > > Signed-off-by: Timothy Redaelli >

Re: [ovs-dev] [PATCH] python: KeyError shouldn't be raised from __getattr__

2018-03-14 Thread Russell Bryant
I've applied this to master and branch-2.9. Thanks! On Mon, Mar 12, 2018 at 6:52 AM, Timothy Redaelli wrote: > On Python 3 hasattr only intercepts AttributeError exception. > On Python2, instead, hasattr intercepts all the exceptions. > > This means __getattr__ shouldn't return KeyError when the

[ovs-dev] [PATCH] python: Enable flake8 checking of ovs-pipegen.py.

2018-03-14 Thread Russell Bryant
Signed-off-by: Russell Bryant --- utilities/automake.mk| 3 ++- utilities/ovs-pipegen.py | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/utilities/automake.mk b/utilities/automake.mk index 1636cb93e..60cf1c5ed 100644 --- a/utilities/automake.mk +++ b/utilities/autom

Re: [ovs-dev] [PATCH] utilities: Make ovs-pipegen.py Python 3 friendly

2018-03-14 Thread Russell Bryant
I've applied this to master. I'll also submit a follow-up patch in a moment which adds this script to the list of Python files checked with flake8, which will help prevent some basic compatibility issues in the future. On Tue, Mar 13, 2018 at 12:48 PM, Timothy Redaelli wrote: > Replace "print f"

[ovs-dev] Tennis Enthusiasts

2018-03-14 Thread Tina Pearson
Hi, Would you are interested in acquiring an email list of "Tennis Enthusiasts"? from USA. Our Databases:- Table Tennis Enthusiasts, Golfers List, Sports Enthusiasts List, Boxing Enthusiasts List, Softball Enthusiasts List, Soccer Enthusiasts List, Hockey Enthusiasts List, Basketball Enthusi

[ovs-dev] Contact me

2018-03-14 Thread Arguijo, Vanessa
Mail from the family of Mavis Wanczyk regarding a donation to you. Reply back for more details. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev