Is it possible to add a test for this patch i.e testing if hypervisors
correctly updating
Chassis_NB_Cfg's nb_cfg when a new value is assigned to NB_Global's nb_cfg?
Please see other comments inline
Thanks
Anil
On Thu, Mar 22, 2018 at 4:57 AM, Han Zhou wrote:
> nb_cfg as a mechanism to "ping" O
Hi, guys
A NSH user found OVS will hit the below assert in function
commit_set_nsh_action in file lib/odp-util.c if encap(nsh) is done in
bucket of group
ovs_assert(flow->nsh.mdtype == base_flow->nsh.mdtype &&
flow->nsh.np == base_flow->nsh.np);
But it isn't an issue if encap(
Curso Online en Vivo
Fecha: 5/Abril/2018
Horario: 10:00 a 13:00 horas
En este seminario online en vivo aprenderá:
Mitos y realidades de LinkedIn.
Crear un perfil atractivo y funcional.
Realizar una difusión laboral.
Usar filtros y recomendaciones
Usar las herramientas de LinkedIn.
Como e
After the initial backport of gre/ipgre/erspan code in the first patch of
this series and as continued development and debugging occurred a number
of fixes were made as well as more code being pulled in from upstream.
This is a big, ugly patch with all of that stuff... For now let's
pretend this pa
This patch backports upstream ipv6 GRE and tunneling into the OVS
OOT (Out of Tree) datapath drivers. The primary reason for this
is to support the ERSPAN feature.
Because there is no previous history of ipv6 GRE and tunneling it is
not possible to exactly reproduce the history of all the files i
From: William Tu
Upsteam commit:
commit 39f57f6799cdd437277122d4cd1c470c08f527c0
Author: William Tu
Date: Mon Feb 5 13:35:35 2018 -0800
net: erspan: fix erspan config overwrite
When an erspan tunnel device receives an erpsan packet with different
tunnel metadata (ex:
From: William Tu
Upstream commit:
commit fc1372f89ffe1f58b589643b75f679e452350703
Author: William Tu
Date: Thu Jan 25 13:20:11 2018 -0800
openvswitch: add erspan version I and II support
The patch adds support for openvswitch to configure erspan
v1 and v2. The OVS_TU
From: William Tu
Upstream commit:
commit c69de58ba84f480879de64571d9dae5102d10ed6
Author: William Tu
Date: Thu Jan 25 13:20:09 2018 -0800
net: erspan: use bitfield instead of mask and offset
Originally the erspan fields are defined as a group into a __be16 field,
and
From: William Tu
Upstream commit:
commit 3df1928302950dfa728ab2eade28eea0da291567
Author: William Tu
Date: Mon Feb 5 13:35:34 2018 -0800
net: erspan: fix metadata extraction
Commit d350a823020e ("net: erspan: create erspan metadata uapi header")
moves the erspan 'vers
A lot of code has been pulled in. Fix it up to make sure it compiles
correctly.
Signed-off-by: Greg Rose
---
acinclude.m4| 3 +++
datapath/linux/compat/gre.c | 23
datapath/linux/compat/include/net/gre.h | 47
From: William Tu
Upstream commit:
commit f551c91de262ba36b20c3ac19538afb4f4507441
Author: William Tu
Date: Wed Dec 13 16:38:56 2017 -0800
net: erspan: introduce erspan v2 for ip_gre
The patch adds support for erspan version 2. Not all features are
supported in this
tnl_flags_to_gre_flags is also needed in both ip_gre.c and gre.c on
some kernels. Move it from ip_gre.c to the common header.
Signed-off-by: Greg Rose
---
datapath/linux/compat/include/net/gre.h | 23 +++
datapath/linux/compat/ip_gre.c | 23 ---
Fixes compile errors on some 4.x kernels.
Signed-off-by: Greg Rose
---
datapath/linux/compat/ip_gre.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c
index 9ed391d..6e75094 100644
--- a/datapath/linux/compat/ip_gre.c
+++ b/datap
Anything less than 3.10 isn't supported since a couple of releases ago
so remove the dead code.
Signed-off-by: Greg Rose
---
datapath/linux/compat/include/linux/etherdevice.h | 30 --
datapath/linux/compat/include/linux/if_vlan.h | 11 ---
datapath/linux/compat/include/linux/kconfig.
From: Haishuang Yan
Upstream commit:
commit 50670b6ee9bc4ae8f9ce3112b437987adf273245
Author: Haishuang Yan
Date: Wed Dec 20 10:07:00 2017 +0800
ip_gre: fix potential memory leak in erspan_rcv
If md is NULL, tun_dst must be freed, otherwise it will cause memory
leak.
From: William Tu
Upstream commit:
commit d91e8db5b629a3c8c81db4dc317a66c7b5591821
Author: William Tu
Date: Fri Dec 15 14:27:44 2017 -0800
net: erspan: reload pointer after pskb_may_pull
pskb_may_pull() can change skb->data, so we need to re-load pkt_md
and ershdr at t
From: Xin Long
Upstream commit:
commit cfddd4c33c254954927942599d299b3865743146
Author: Xin Long
Date: Mon Dec 18 14:24:35 2017 +0800
ip_gre: remove the incorrect mtu limit for ipgre tap
ipgre tap driver calls ether_setup(), after commit 61e84623ace3
("net: centralize
From: Haishuang Yan
Upstream commit:
commit c05fad5713b81b049ec6ac4eb2d304030b1efdce
Author: Haishuang Yan
Date: Fri Dec 15 10:46:16 2017 +0800
ip_gre: fix wrong return value of erspan_rcv
If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM.
Fixes
From: William Tu
Upstream commit:
commit 1d7e2ed22f8d9171fa8b629754022f22115b3f03
Author: William Tu
Date: Wed Dec 13 16:38:55 2017 -0800
net: erspan: refactor existing erspan code
The patch refactors the existing erspan implementation in order
to support erspan versi
From: William Tu
Upstream commit:
commit a3222dc95ca751cdc5f6ac3c9b092b160b73ed9f
Author: William Tu
Date: Thu Nov 30 11:51:27 2017 -0800
ip_gre: Refector the erpsan tunnel code.
Move two erspan functions to header file, erspan.h, so ipv6
erspan implementation can use
From: Xin Long
Upstream commit:
commit c84bed440e4e11a973e8c0254d0dfaccfca41fb0
Author: Xin Long
Date: Sun Oct 1 22:00:56 2017 +0800
ip_gre: erspan device should keep dst
The patch 'ip_gre: ipgre_tap device should keep dst' fixed
the issue ipgre_tap dev mtu couldn't b
From: Xin Long
Upstream commit:
commit 935a9749a36828af0e8be224a5cd4bc758112c34
Author: Xin Long
Date: Sun Oct 1 22:00:53 2017 +0800
ip_gre: get key from session_id correctly in erspan_rcv
erspan only uses the first 10 bits of session_id as the key to look
up the tunn
From: Xin Long
Upstream commit:
commit c122fda271717f4fc618e0a31e833941fd5f1efd
Author: Xin Long
Date: Sun Oct 1 22:00:55 2017 +0800
ip_gre: set tunnel hlen properly in erspan_tunnel_init
According to __gre_tunnel_init, tunnel->hlen should be set as the
headers' lengt
From: William Tu
Upstream commit:
commit f192970de860d3ab90aa9e2a22853201a57bde78
Author: William Tu
Date: Thu Oct 5 12:07:12 2017 -0700
ip_gre: check packet length and mtu correctly in erspan tx
Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device
is t
From: William Tu
Upstream commit:
commit 84e54fe0a5eaed696dee4019c396f8396f5a908b
Author: William Tu
Date: Tue Aug 22 09:40:28 2017 -0700
gre: introduce native tunnel support for ERSPAN
The patch adds ERSPAN type II tunnel support. The implementation
is based on the
From: William Tu
commit 1a66a836da630cd70f3639208da549b549ce576b
Author: William Tu
Date: Fri Aug 25 09:21:28 2017 -0700
gre: add collect_md mode to ERSPAN tunnel
Similar to gre, vxlan, geneve, ipip tunnels, allow ERSPAN tunnels to
operate in 'collect metadata' mode.
From: William Tu
Upstream commit:
commit e3d0328c76dde0b957f62f8c407b79f1d8fe3ef8
Author: William Tu
Date: Tue Aug 22 17:04:05 2017 -0700
gre: fix goto statement typo
Fix typo: pnet_tap_faied.
Signed-off-by: William Tu
Signed-off-by: David S. Miller
Cc: Willia
From: William Tu
Upstream commit:
commit 862a03c35ed76c50a562f7406ad23315f7862642
Author: William Tu
Date: Fri Aug 25 09:21:27 2017 -0700
gre: refactor the gre_fb_xmit
The patch refactors the gre_fb_xmit function, by creating
prepare_fb_xmit function for later ERSPAN
Recently support for ERSPAN Versions I and II (one and two) were
added to the upstream kernel. This set of patches backports that
feature. To support the feature for kernels RHEL 3.10 up to current
(4.15 as of this post) a great deal of upstream gre, ipgre, ip6gre,
ip_tunnel and ip6_tunnel code h
Test discussion @
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-March/046440.html
Tested-by: aginwala
On Sat, Feb 24, 2018 at 3:17 PM, Justin Pettit wrote:
> >
> > On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote:
> >
> > diff --git a/Documentation/ref/ovsdb.5.rst b/Documentation/ref/ov
---
ovn/controller/ovn-controller.c | 11 ---
ovn/lib/inc-proc-eng.c | 19 +++
ovn/lib/inc-proc-eng.h | 3 +++
3 files changed, 30 insertions(+), 3 deletions(-)
diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c
index 1fc41e2.
Persistents flow-table and implements change handler of flow_output
for SB lflow changes.
---
include/ovn/actions.h | 3 +
ovn/controller/lflow.c | 110 +++---
ovn/controller/lflow.h | 10 +-
ovn/controller/ofctrl.c | 242 +
---
ovn/controller/ovn-controller.c | 31 ++-
ovn/controller/physical.c | 22 ++
ovn/controller/physical.h | 6 +-
3 files changed, 57 insertions(+), 2 deletions(-)
diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-c
This patch implements change handler for port-binding in flow_output
for physical flows computing, so that physical flow computing will
be incremental.
This patch together with previous incremental processing engine
related changes supports incremental processing for lflow changes
and port-binding
Evaluates change for SB port-binding in runtime_data node.
If the port-binding change has no impact for the runtime_data it will
not trigger runtime_data change.
---
ovn/controller/binding.c| 85 +
ovn/controller/binding.h| 6 +++
ovn/contro
Create nodes for ovs_idl inputs and add ovs_idl inputs and
SB inputs as dependencies for runtime_data. With this patch
there is no recomputed if there is no change in input. For
example, pinctrl input will not trigger flow recompute any
more.
---
ovn/controller/ovn-controller.c | 37 ++
This patch expands the incremental processing by spliting SB inputs
from runtime_data and add them as input for flow_output.
---
ovn/controller/ovn-controller.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/ovn/controller/ovn-controller.c b/ovn/cont
Incremental proccessing engine is used to compute flows. In this
patch we only create 2 engine nodes with simple dependency:
runtime_data -> flow_output
In each iteration everything is still recomputed.
---
ovn/controller/ofctrl.c | 21 ++-
ovn/controller/ofctrl.h | 5 +-
o
Track OVSDB changes for future patches of incremental processing
---
ovn/controller/bfd.c| 4 ++--
ovn/controller/binding.c| 16
ovn/controller/encaps.c | 12 ++--
ovn/controller/ovn-controller.c | 24 +++-
ovn/controller/ph
This patch implements the engine which will be used in future patches
for ovn-controller incremental processing.
---
ovn/lib/automake.mk| 4 +-
ovn/lib/inc-proc-eng.c | 97
ovn/lib/inc-proc-eng.h | 118
ovn-controller currently recomputes everything when there are any changes
of input, which leads to high CPU usages and slow in end-to-end flow
enforcement in response to changes. It even wastes CPU to recompute flows
for unrelated inputs such as pinctrl events.
This patch series implements increme
Thanks for these changes, looks good to me.
Tested-by: Yifeng Sun
Reviewed-by: Yifeng Sun
On Tue, Mar 20, 2018 at 1:46 PM, Ben Pfaff wrote:
> Until now, struct ofputil_flow_mod, which represents an OpenFlow flow table
> modification request, has incorporated a struct match, which made the
>
Thanks, looks good to me.
Reviewed-by: Yifeng Sun
On Tue, Mar 20, 2018 at 1:46 PM, Ben Pfaff wrote:
> The miniflow and minimatch APIs lack several of the features of the flow
> and match APIs. This commit adds a few of the missing functions.
>
> These functions will be used for the first time
Thanks, looks good to me.
Reviewed-by: Yifeng Sun
On Tue, Mar 20, 2018 at 1:46 PM, Ben Pfaff wrote:
> Until mow, this macro has blindly read the passed-in type's size, but
> that's unnecessarily risky. This commit changes it to verify that the
> passed-in type is the same size as the field an
Thanks, looks good to me.
Reviewed-by: Yifeng Sun
On Tue, Mar 20, 2018 at 1:46 PM, Ben Pfaff wrote:
> struct match has had a 'tun_md' member for a long time, but struct
> minimatch has never had one. This doesn't matter for the purposes for
> which minimatch is currently used, but it means th
Presently, if OVS tries to setup more queues than
are allowed by a specific NIC, OVS will handle
this case by retrying with a lower amount of queues.
Rather than reporting initial failed queue setups
in the logs as ERROR, they are reported as INFO but
contain the word 'error'. Unless a user has de
To proceed to confirm your account information please follow the
instructions that will be required:
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On 03/22/2018 02:52 PM, Stokes, Ian wrote:
> >> Presently, if OVS tries to setup more queues than are allowed by a
> >> specific NIC, OVS will handle this case by retrying with a lower
> >> amount of queues.
> >>
> >> Rather than reporting initial failed queue setups in the logs as
> >> ERROR, th
On 03/22/2018 02:52 PM, Stokes, Ian wrote:
>> Presently, if OVS tries to setup more queues than are allowed by a
>> specific NIC, OVS will handle this case by retrying with a lower amount of
>> queues.
>>
>> Rather than reporting initial failed queue setups in the logs as ERROR,
>> they are reporte
> Presently, if OVS tries to setup more queues than are allowed by a
> specific NIC, OVS will handle this case by retrying with a lower amount of
> queues.
>
> Rather than reporting initial failed queue setups in the logs as ERROR,
> they are reported as INFO but contain the word 'error'. Unless a
On Thu, Mar 22, 2018 at 03:46:17PM +0200, Roi Dayan wrote:
>
>
> On 22/03/2018 15:44, Roi Dayan wrote:
> >
> >
> > On 22/03/2018 15:22, Roi Dayan wrote:
> > > Raise the error up instead of ignoring it.
> > > Before this commit beside an error an incorrect rule was also printed.
> > >
> > > Sig
On 22/03/2018 15:44, Roi Dayan wrote:
On 22/03/2018 15:22, Roi Dayan wrote:
Raise the error up instead of ignoring it.
Before this commit beside an error an incorrect rule was also printed.
Signed-off-by: Roi Dayan
Reviewed-by: Paul Blakey
Signed-off-by: Simon Horman
oops sorry about t
On 22/03/2018 15:22, Roi Dayan wrote:
Raise the error up instead of ignoring it.
Before this commit beside an error an incorrect rule was also printed.
Signed-off-by: Roi Dayan
Reviewed-by: Paul Blakey
Signed-off-by: Simon Horman
oops sorry about the signed off. i cherry-picked from maste
Raise the error up instead of ignoring it.
Before this commit beside an error an incorrect rule was also printed.
Signed-off-by: Roi Dayan
Reviewed-by: Paul Blakey
Signed-off-by: Simon Horman
---
lib/tc.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/
Hello to everyone,
my name is Alessandro Rosetti and I'd like some feedback on my work.
I wrote a patch that implements a new netdev that uses Netmap framework for
fast packet I/O in ovs.
I'm working on this for University of Pisa. My group develops Netmap and
intends to mantain the support in ovs
On 21/03/2018 12:55, Simon Horman wrote:
On Mon, Mar 12, 2018 at 02:58:46PM +0200, Roi Dayan wrote:
Raise the error up instead of ignoring it.
Before this commit beside an error an incorrect rule was also printed.
Signed-off-by: Roi Dayan
Reviewed-by: Paul Blakey
Thanks, applied to master
On 21/03/2018 22:11, Ian Stokes wrote:
"sparse" complains with the warning 'incorrect type in argument 1
(different base types)' in function nl_parse_flower_ip when parsing a key
flag and in function nl_msg_put_flower_options when writing the key
flag. Fix this by using network byte order when
> >-Original Message-
> >From: Stokes, Ian
> >Sent: 21. marts 2018 14:38
> >To: Finn Christensen ; 'Yuanhan Liu'
> >; d...@openvswitch.org; Shahaf Shuler
> >
> >Cc: Darrell Ball ; Chandran, Sugesh
> >; Simon Horman
> >Subject: RE: [PATCH v7 3/6] netdev-dpdk: implement flow offload with
>
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Wednesday, March 21, 2018 3:07 PM
> To: Weglicki, MichalX ; ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Ben Pfaff ; Stokes,
> Ian
> Subject: Re: [PATCH] netdev-dpdk: Refactor custom stats.
>
> On 20.03.20
59 matches
Mail list logo
