Re: [ovs-dev] [PATCH V1 2/2] netdev-tc-offloads: Add support for IP fragmentation

2018-03-24 Thread Roi Dayan
On 12/03/2018 14:58, Roi Dayan wrote: Add support for frag no, first and later. Signed-off-by: Roi Dayan Reviewed-by: Shahar Klein Reviewed-by: Paul Blakey --- acinclude.m4 | 6 +++--- include/linux/pkt_cls.h |

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

2018-03-24 Thread Jan Scheurich
Hi Yi, Part of the seemingly strange behavior of the encap(nsh) action in a group is caused by the (often forgotten) fact that group buckets do not contain action *lists* but action *sets*. I have no idea why it was defined like this when groups were first introduced in OpenFlow 1.1. In my

Re: [ovs-dev] [PATCH 15/15] ovsdb: Introduce experimental support for clustered databases. (2/2)

2018-03-24 Thread Ben Pfaff
I applied this series to master, with the exception of ovn-ctl, which needs some extra work and will come in a separate patch to be posted later. On Fri, Mar 23, 2018 at 03:27:24PM -0700, Ben Pfaff wrote: > Thank you for the review. As before, I am applying most of your > comments and not

[ovs-dev] [PATCH] checkpatch: Avoid warnings for /* or */.

2018-03-24 Thread Ben Pfaff
checkpatch would sometimes confuse comment markers for operators. This fixes the problem. Signed-off-by: Ben Pfaff --- utilities/checkpatch.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index

Re: [ovs-dev] [PATCH 0/3] checkpatch: the comment years!

2018-03-24 Thread Aaron Conole
Aaron Conole writes: > This series tries to get checkpatch a little better at skipping > stylistic things within comments, as well as growing a new feature > to actually spell check words in the comments. > > Patch 1 just cleans up the patch line-type state machine a little.