Re: [ovs-dev] [PATCH 1/4] ovs-kmod-ctl: introduce a kernel module load script

2018-03-26 Thread Ansis Atteka
On 26 March 2018 at 19:58, Joe Stringer wrote: > On 26 March 2018 at 14:32, Aaron Conole wrote: >> Thanks for the review, Ansis! >> >> Ansis Atteka writes: >> >>> On 20 March 2018 at 14:05, Aaron Conole wrote: +.

Re: [ovs-dev] [PATCH 1/4] ovs-kmod-ctl: introduce a kernel module load script

2018-03-26 Thread Joe Stringer
On 26 March 2018 at 14:32, Aaron Conole wrote: > Thanks for the review, Ansis! > > Ansis Atteka writes: > >> On 20 March 2018 at 14:05, Aaron Conole wrote: >>> +. >>> +.PP >>> +Each of \fBovs\-ctl\fR's commands is described

Re: [ovs-dev] Test result. RE: [patch v1] conntrack-tcp: Handle tcp session reuse.

2018-03-26 Thread Darrell Ball
Thanks much for testtng Neo On Sun, Mar 18, 2018 at 1:30 AM, Yangxiaoliang (Neo) < david.yangxiaoli...@huawei.com> wrote: > Hi Darrell, > > > > Sorry for delay. > > > > During the last week, I have tried sveral live migration script, and found > that > > > > 1. sctipt1: Tcp stream will stop

Re: [ovs-dev] [PATCH 4/4] rhel: selinux-policy to invoke proper label macros

2018-03-26 Thread Ansis Atteka
On 20 March 2018 at 14:05, Aaron Conole wrote: > The rpm doesn't invoke all of the required selinux helpers to enact labeling > or relabeling on all versions of Fedora/RHEL. According to: > https://fedoraproject.org/wiki/SELinux/IndependentPolicy > > This commit switches to

Re: [ovs-dev] [PATCH 3/4] selinux: introduce domain transitioned kmod helper

2018-03-26 Thread Ansis Atteka
On 20 March 2018 at 14:05, Aaron Conole wrote: > This commit uses the previously defined selinux label to transition > from the openvswitch_t to openvswitch_load_module_t domain, by way of > a specially labelled ovs-kmod-ctl helper. s/by way of a specially labelled

Re: [ovs-dev] [PATCH 2/4] selinux: create a transition type for module loading

2018-03-26 Thread Ansis Atteka
On 20 March 2018 at 14:05, Aaron Conole wrote: > Defines a type 'openvswitch_load_module_t' used exclusively for loading > modules. This means that the 'openvswitch_t' domain won't require > modules Are you sure the bootstrapping to intended openvswitch_load_module_t happens

Re: [ovs-dev] [PATCH] checkpatch: Avoid warnings for /* or */.

2018-03-26 Thread Aaron Conole
Ben Pfaff writes: > checkpatch would sometimes confuse comment markers for operators. This > fixes the problem. > > Signed-off-by: Ben Pfaff > --- Looks good to me. Acked-by: Aaron Conole ___ dev

[ovs-dev] Clustered DB commits causes sandbox errors

2018-03-26 Thread Mark Michelson
Hi, I'm currently on the master branch of OVS, commit "1b1d2e6da ovsdb: Introduce experimental support for clustered databases." I started the OVS sandbox using `make sandbox SANDBOXFLAGS="--ovn"` . I tried to run some tests to add some logical switch ports to OVN. Running `ovn-nbctl

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-03-26 Thread Jan Scheurich
Hi Aaron, Thanks for the feedback. A few good suggestions are always welcome. I will include fixes for your comments in the (hopefully) final version. Regards, Jan > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Monday, 26 March, 2018 23:27 > To: Jan

Re: [ovs-dev] [PATCH 1/4] ovs-kmod-ctl: introduce a kernel module load script

2018-03-26 Thread Aaron Conole
Thanks for the review, Ansis! Ansis Atteka writes: > On 20 March 2018 at 14:05, Aaron Conole wrote: >> Currently, Open vSwitch on linux embeds the logic of loading and unloading >> kernel modules into the ovs-ctl and ovs-lib script files. This works,

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-03-26 Thread Aaron Conole
Hi Jan, Some stylistic type comments follow. Sorry to jump in at the end - but you asked for checkpatch changes, so I improved and ran it against your patch and found some stuff for which I have an opinion. :) Maybe nothing to hold up merging but cleanup stuff. Jan Scheurich

Re: [ovs-dev] [PATCH 1/4] ovs-kmod-ctl: introduce a kernel module load script

2018-03-26 Thread Ansis Atteka
On 20 March 2018 at 14:05, Aaron Conole wrote: > Currently, Open vSwitch on linux embeds the logic of loading and unloading > kernel modules into the ovs-ctl and ovs-lib script files. This works, but > it means that there is no way to leverage extended filesystem attributes >

[ovs-dev] [PATCH] ovn: Recirculate packets after a unSNAT.

2018-03-26 Thread Gurucharan Shetty
commit f6fabcc6245 (ofproto-dpif: Mark packets as "untracked" after call to ct().) changed the behavior after a call to ct(). The +trk bit would automatically be unset if packet is sent to ct() and not forked. This caused a bug in the OVN gateway pipeline when there is SNAT rule as well as

[ovs-dev] Sucursales y Puntos de Venta

2018-03-26 Thread Compartir la Carga de Trabajo
Administración y control de sucursales y puntos de venta Abril 10 - webinar Interactivo Dirigido a: Gerentes de sucursales, supervisores comerciales, oficiales de negocios, profesionales que deseen obtener un alto potencial con proyección gerencial. Temas: - Cómo compartir la carga

Re: [ovs-dev] [PATCH] json: Avoid extra memory allocation and string copy parsing object members.

2018-03-26 Thread Yifeng Sun
Thanks for the fix, looks good to me. Reviewed-by: Yifeng Sun On Fri, Mar 23, 2018 at 3:46 PM, Ben Pfaff wrote: > Until now, every time the JSON parser added an object member, it made an > extra copy of the member name and then freed the original copy.

Re: [ovs-dev] [PATCH] seq: Avoid some "possible leak" warnings from valgrind.

2018-03-26 Thread Yifeng Sun
Thanks for the fix. Reviewed-by: Yifeng Sun On Fri, Mar 23, 2018 at 3:46 PM, Ben Pfaff wrote: > valgrind regards a block to be "possibly" leaked when no pointers exist to > the beginning of the block but some pointers do point to the middle of the >

[ovs-dev] . A few of your incoming messages has been suspended

2018-03-26 Thread Ferdinand Sarindat (HA-GTO/ADKU)
Your Messages Has Been Suspended By Microsoft Outlook Team A few of your incoming messages has been suspended by microsoft verification Team because your email box account has not been properly verify. Do verify now to receive your suspended messages now.

[ovs-dev] [PATCH] xlate: Correct handling of double encap() actions

2018-03-26 Thread Jan Scheurich
When the same encap() header was pushed twice onto a packet (e.g in the case of NSH in NSH), the translation logic only generated a datapath push action for the first encap() action. The second encap() did not emit a push action because the packet type was unchanged. commit_encap_decap_action()

[ovs-dev] [PATCH] ofp-actions: Correct execution of encap/decap actions in action set

2018-03-26 Thread Jan Scheurich
The actions encap, decap and dec_nsh_ttl were wrongly flagged as set_field actions in ofpact_is_set_or_move_action(). This caused them to be executed twice in the action set or a group bucket, once explicitly in ofpacts_execute_action_set() and once again as part of the list of set_field or move

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

2018-03-26 Thread Jan Scheurich
Thanks for the confirmation Yi. I will post the fix straight away. The other fix for double encap() is also ready. BR, Jan > -Original Message- > From: Yang, Yi [mailto:yi.y.y...@intel.com] > Sent: Monday, 26 March, 2018 03:42 > To: Jan Scheurich > Cc: