[ovs-dev] [PATCH v1] Avoid packet drop on LACP bond after link up

Problem: During port DOWN->UP of link (slave) in a LACP bond, after receiving the LACPDU with SYNC set for both actor and partner, the bond-slave remains "disabled" until OVS main thread runs LACP state machine and eventually "enables" the bond-slave. With this, we have observed delays in

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

Hi Ben, Replies inline: Regards & thanks Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Thursday, May 10, 2018 1:59 AM To: Anju Thomas Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action On Tue, May 08, 2018 at 12:3

Re: [ovs-dev] [PATCH v1] Fix crash when processing malformed Bundle Add message in OVS

Hi Ben, Yes. This patch certainly looks more cleaner and better to me . Thanks Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Thursday, May 10, 2018 2:33 AM To: Anju Thomas Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash when processing malform

[ovs-dev] Invitation: I NEED YOUR SUPORT @ Thu 10 May 2018 08:00 - 09:00 (EDT) (d...@openvswitch.org)

You have been invited to the following event. Title: I NEED YOUR SUPORT I am, 45 years old African American, from Ohio, United States of America. I am a builder with over 15 ears experience building high end projects, Oil Rigs, Concrete Silos, Malls, High Rise Condominiums, Turnkey Government

Re: [ovs-dev] [PATCH] Factor prerequisites out of AND/OR trees with unique symbol

On Wed, 9 May 2018 13:02:55 -0700 Ben Pfaff wrote: > On Thu, Apr 26, 2018 at 09:54:06PM +0200, Jakub Sitnicki wrote: > > Appending prerequisites to sub-expressions of OR that are all over one > > symbol prevents the expression-to-matches converter from applying > > conjunctive matching. This happ

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

Hi, Friday, April 20, 2018 11:07 AM, Stokes, Ian: > Subject: RE: [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow > > > > Hi, > > > > > > Here is a joint work from Mellanox and Napatech, to enable the flow > > > hw offload with the DPDK generic flow interface (rte_flow). > > > > Hi folks, I fee

[ovs-dev] Delivery In progress.

___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 0/5] selinux: introduce a transition domain for loading kmods

Ansis Atteka writes: > On Fri, 4 May 2018 at 11:28, Aaron Conole wrote: > >> On linux systems, the initial start of openvswitch attempts to load >> the openvswitch.ko kernel module. This module allows openvswitch to >> utilize the kernel datapath. > >> Some of these linux systems, notably Fedor

[ovs-dev] [PATCH] Fix datapath compilation on RHEL >= 7.5

On RHEL 7.5 we get compilation errors due to field ndo_change_mtu missing. This patch checks the RHEL version and redefines it to ndo_change_mtu_rh74. Reported-by: Lucas Alvares Signed-off-by: Daniel Alvarez --- datapath/datapath.h | 5 + 1 file changed, 5 insertions(+) diff --git a/datapa

Re: [ovs-dev] [PATCH v7] Configurable Link State Change (LSC) detection mode

> It is possible to set LSC detection mode to polling or interrupt mode for > DPDK interfaces. The default is polling mode. To set interrupt mode, > option dpdk-lsc-interrupt has to be set to true. > > For detailed description and usage see the dpdk install documentation. > Thanks Robert, LGTM,

[ovs-dev] Interop ITX Show 2018 Attendees List

Hi, Good day to you, This is an outstanding offer for the Interop ITX Show 2018. I am writing to check if you would be interested in acquiring the list of *19,623 *attendees participated in Interop ITX Show 2018 for your marketing and sales initiatives. This is an opportunity to acquire the

[ovs-dev] [PATCH] rhel: openvswitch-fedora.spec.in: Specify PYTHON and PYTHON3

Currently python2 and python3 binaries are searched by following the PATHs, but, on Fedora, the python2 package does not provides /bin/python2 and so if the PATH contains /bin before /usr/bin (for example by using the ansible poc) then the resulting RPM file will require /bin/python2 instead of /us

Re: [ovs-dev] ovsdb-tool: error while loading shared libraries: librte_eal.so.6.1

I don't know how to configure mininet. If CPqD solves your problems, then of course it's a reasonable choice. On Thu, May 10, 2018 at 08:15:21AM +0800, Mingming Chen wrote: > Hi Ben, > I have solved that problem(set up all in the same terminal, and > http://dpdk.org/ml/archives/dev/2016-June/042

Re: [ovs-dev] [PATCH] ovn: Add a new action 'nd_na_router' to handle NS requests for router IPs

On Tue, May 8, 2018 at 3:26 PM, Mark Michelson wrote: > On 05/08/2018 05:36 AM, Numan Siddique wrote: > >> >> >> On Tue, May 8, 2018 at 1:20 PM, Miguel Angel Ajo Pelayo < >> majop...@redhat.com > wrote: >> >> Thank you Numan! >> >> It took me a bit to find what

[ovs-dev] Estrategia de Fijación de Precios

MAYO 23 - webinar Interactivo Pricing: Estrategia de Fijación de Precios Introducción: El Pricing es el proceso mediante el cual una empresa establece el precio al que venderá sus productos y servicios, y puede ser parte del plan de marketing de la empresa. Temas a tratar: Factores psicoló

[ovs-dev] [PATCH v6] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

From: SatyaValli This Patch provides implementation Existing flow entry statistics are redefined as standard OXS(OpenFlow Extensible Statistics) fields for displaying the arbitrary flow stats. To support this implementation below messages are newly added OFPRAW_OFPT15_FLOW_REMOVED, OFPRAW_OFPST

Re: [ovs-dev] [PATCH v2 0/5] selinux: introduce a transition domain for loading kmods

Ansis Atteka writes: > On Fri, 4 May 2018 at 11:28, Aaron Conole wrote: > >> On linux systems, the initial start of openvswitch attempts to load >> the openvswitch.ko kernel module. This module allows openvswitch to >> utilize the kernel datapath. > >> Some of these linux systems, notably Fedor

Re: [ovs-dev] [PATCH] tests: Fix typo in test name.

On Fri, Apr 13, 2018 at 10:38:53AM -0700, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff This still needs a review. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] faq: Start an OVN FAQ by giving a rationale for how it uses tunnels.

On Mon, Apr 16, 2018 at 12:16:24PM -0700, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff This still needs a review. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovn: Add a new action 'nd_na_router' to handle NS requests for router IPs

On Tue, May 08, 2018 at 03:20:25PM +0530, nusid...@redhat.com wrote: > (Please note: There are 3 'Line length is >79-characters' warnings in ovn.at > which > I couldn't resolve.) That's actually a bug in checkpatch, see my fix here: https://patchwork.ozlabs.org/patch/911103/ _

Re: [ovs-dev] [PATCH] checkpatch: Fix filename matching.

On Wed, May 9, 2018 at 11:56 PM, Ben Pfaff wrote: > The .match() method only matches at the beginning of a string but the > blacklists here need to match anywhere in a string. > > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique Thanks Ben. With this patch I don't see the warnings which I

Re: [ovs-dev] [PATCH] tests: Fix typo in test name.

Acked-by: Alin Gabriel Serdean mailto:aserd...@ovn.org>> > On 10 May 2018, at 20:26, Ben Pfaff wrote: > > On Fri, Apr 13, 2018 at 10:38:53AM -0700, Ben Pfaff wrote: >> Signed-off-by: Ben Pfaff > > This still needs a review. > ___ > dev mailing list >

[ovs-dev] [PATCH v3] ovn: Set proper Neighbour Adv flag when replying for NS request for router IP

From: Numan Siddique Presently when a VM's IPv6 stack sends a Neighbor Solicitation request for its router IP, (mostly when the ND cache entry for the router is in STALE state) ovn-controller responds with a Neighbor Adv packet (using the action nd_na). But it doesn't set 'ND_RSO_ROUTER' in the R

Re: [ovs-dev] [PATCH] faq: Start an OVN FAQ by giving a rationale for how it uses tunnels.

Ben Pfaff writes: > On Mon, Apr 16, 2018 at 12:16:24PM -0700, Ben Pfaff wrote: >> Signed-off-by: Ben Pfaff > > This still needs a review. Looks good, but I found one part slightly confusing. >> +These compromises wouldn't suit every site, since some might want to >> +allocate more bits

Re: [ovs-dev] [PATCH] checkpatch: Fix filename matching.

Ben Pfaff writes: > The .match() method only matches at the beginning of a string but the > blacklists here need to match anywhere in a string. > > Signed-off-by: Ben Pfaff > --- d'oh! At least the debian/rules part should have matched :) Acked-by: Aaron Conole __

Re: [ovs-dev] [PATCH] rhel: openvswitch-fedora.spec.in: Specify PYTHON and PYTHON3

On Thu, 10 May 2018 at 08:21, Timothy Redaelli wrote: > Currently python2 and python3 binaries are searched by following the > PATHs, but, on Fedora, the python2 package does not provides /bin/python2 > and so if the PATH contains /bin before /usr/bin (for example by using > the ansible poc) then

Re: [ovs-dev] [PATCH] doc: Final cleanup of the DPDK documents

> This concludes the cleanup by fixing some nits and adding some additional > cross-references. > > Signed-off-by: Stephen Finucane > --- > This was initially sent as part of a larger series but excluded from a > recent merge due to label issues. I wasn't able to reproduce these so I'm > resendin

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Thursday, May 10, 2018 1:41 PM > To: Stokes, Ian ; f...@napatech.com > Cc: ovs-dev@openvswitch.org; simon.hor...@netronome.com; Flavio Leitner > > Subject: RE: [PATCH v9 0/7] OVS-DPDK flow offload with rte_f

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

On Thu, May 10, 2018 at 08:51:03AM +, Anju Thomas wrote: > It looks like your commit message describes at least two other bugs in > OVS, though. First, if OVS crashes when it pushes tunnel headers, > even if there's not enough headroom, that's really bad. At worst, it > should drop the packet

Re: [ovs-dev] [PATCH] Avoid crash in OvS while transmitting fragmented packets over tunnel.

Thanks Rohith I see this patch was applied, but I have one question inline. On 4/20/18, 1:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Rohith Basavaraja" wrote: Currently when fragmented packets are to be transmitted in to tunnel, base_flow->nw_frag which was initially non-zero

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fixed netdev_dpdk structure alignment

> Thanks for this, Eelco. > > (Sorry for the double email, missed the ML on the first one.) > > On 25/04/2018 16:48, Eelco Chaudron wrote: > > Currently, the code tells us we have 4 pad bytes left in cacheline0 > > while actually we are 8 bytes short: > > > > This was caused by commit 5e925cc ("

Re: [ovs-dev] [PATCH] compat: Fix upstream 4.4.119 kernel

On 5/8/2018 7:44 PM, Pravin Shelar wrote: On Fri, Apr 20, 2018 at 11:13 AM, Greg Rose wrote: The Linux 4.4.119 kernel (and perhaps others) from kernel.org backports some dst_cache code that breaks the openvswitch kernel due to a duplicated name "dst_cache_destroy". For most cases the "USE_UPST

Re: [ovs-dev] [PATCH] datapath: compat: Fix build on RHEL 7.5

On 5/9/2018 6:21 PM, Yi-Hung Wei wrote: 1) OVS datapath compat modules breaks on RHEL 7.5, because it moves ndo_change_mtu function pointer from 'struct net_device_ops' to 'struct net_device_ops_extended'. 2) RHEL 7.5 introduces the MTU range checking as mentioned in 6c0bf091 ("datapath: use cor

Re: [ovs-dev] [PATCH] Fix datapath compilation on RHEL >= 7.5

On 5/10/2018 7:11 AM, Daniel Alvarez wrote: On RHEL 7.5 we get compilation errors due to field ndo_change_mtu missing. This patch checks the RHEL version and redefines it to ndo_change_mtu_rh74. Reported-by: Lucas Alvares Signed-off-by: Daniel Alvarez --- datapath/datapath.h | 5 + 1 fi

Re: [ovs-dev] [PATCH] Fix datapath compilation on RHEL >= 7.5

Yes, let’s go with that one then. Thanks a lot! Daniel > On 10 May 2018, at 23:15, Gregory Rose wrote: > >> On 5/10/2018 7:11 AM, Daniel Alvarez wrote: >> On RHEL 7.5 we get compilation errors due to field ndo_change_mtu >> missing. This patch checks the RHEL version and redefines it to >> ndo_

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

On Thu, Apr 12, 2018 at 10:19 AM, Ben Pfaff wrote: > > On Wed, Apr 11, 2018 at 11:29:28PM -0700, Han Zhou wrote: > > On Tue, Apr 10, 2018 at 6:21 PM, Han Zhou wrote: > > > > > > > > > > > > On Tue, Apr 10, 2018 at 5:04 PM, Ben Pfaff wrote: > > > > > > > > On Fri, Apr 06, 2018 at 02:40:21PM -0700

[ovs-dev] [PATCH 1/7] ofproto-dpif-xlate: Fix reference leak in xlate_dp_hash_select_group().

xlate_group_action() takes a reference to the ofgroup and passes it down to xlate_group_action__(), xlate_select_group(), and finally to xlate_dp_hash_select_group(), which is supposed to consume it but fails to do so. This commit fixes the problem. Found by inspection. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH 2/7] ofproto-dpif-xlate: Simplify translation for groups.

Translation of groups had a lot of redundant code. This commit eliminates most of it. It should also make it harder to accidentally reintroduce the reference leak fixed in a previous commit. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 131 +++

[ovs-dev] [PATCH 3/7] ofp-group: Require watch_port or watch_group when parsing ff groups.

Fast failover buckets must have a watch_port or a watch_group (or both), and ovs-vswitchd enforces this, but the bucket parsing code didn't check it. This meant that when it was omitted, the error messages were harder to understand. Signed-off-by: Ben Pfaff --- lib/ofp-group.c | 4 1 file

[ovs-dev] [PATCH 5/7] ofp-group: Move formatting code for groups into ofp-group.

This does a better job of putting related code together. Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-group.h | 19 ++- lib/ofp-group.c | 306 ++ lib/ofp-print.c | 317 +--- 3 files c

[ovs-dev] [PATCH 4/7] Add OpenFlow extensions for group support in OpenFlow 1.0.

Signed-off-by: Ben Pfaff --- include/openflow/openflow-1.5.h | 3 +- include/openvswitch/ofp-errors.h | 54 + include/openvswitch/ofp-msgs.h | 35 --- lib/nx-match.c | 11 +--- lib/ofp-group.c | 120 +--

[ovs-dev] [PATCH 6/7] ofp-print: Handle statistics more systematically.

ofp_to_string__() is supposed to call ofp_print_stats() for all kinds of statistics, but it was only doing so haphazardly. This commit makes it systematic and in the process adds it to at least one case where it was missing (and fixes up a test case). Signed-off-by: Ben Pfaff --- include/openvs

[ovs-dev] [PATCH 7/7] ofproto-dpif-xlate: Improve tracing through groups.

This makes it clear which buckets from a group are executed and why. The update to nsh.at provides an example. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-trace.c | 2 ++ ofproto/ofproto-dpif-trace.h | 1 + ofproto/ofproto-dpif-xlate.c | 48 ++--

Re: [ovs-dev] [PATCH] checkpatch: Fix filename matching.

On Thu, May 10, 2018 at 11:12:39PM +0530, Numan Siddique wrote: > On Wed, May 9, 2018 at 11:56 PM, Ben Pfaff wrote: > > > The .match() method only matches at the beginning of a string but the > > blacklists here need to match anywhere in a string. > > > > Signed-off-by: Ben Pfaff > > > > Acked-

Re: [ovs-dev] [PATCH] faq: Start an OVN FAQ by giving a rationale for how it uses tunnels.

On Thu, May 10, 2018 at 01:55:31PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, Apr 16, 2018 at 12:16:24PM -0700, Ben Pfaff wrote: > >> Signed-off-by: Ben Pfaff > > > > This still needs a review. > > Looks good, but I found one part slightly confusing. > > >> +These comprom

Re: [ovs-dev] [PATCH] tests: Fix typo in test name.

Thanks, applied to master. On Thu, May 10, 2018 at 08:46:58PM +0300, Alin Gabriel Serdean wrote: > Acked-by: Alin Gabriel Serdean mailto:aserd...@ovn.org>> > > > On 10 May 2018, at 20:26, Ben Pfaff wrote: > > > > On Fri, Apr 13, 2018 at 10:38:53AM -0700, Ben Pfaff wrote: > >> Signed-off-by: Ben

Re: [ovs-dev] [PATCH v3] ovn: Set proper Neighbour Adv flag when replying for NS request for router IP

On Thu, May 10, 2018 at 11:18:23PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Presently when a VM's IPv6 stack sends a Neighbor Solicitation request for its > router IP, (mostly when the ND cache entry for the router is in STALE state) > ovn-controller responds with a Neighbor A

Re: [ovs-dev] [PATCH v1] Fix crash when processing malformed Bundle Add message in OVS

Thanks. I applied this to master and branch-2.9. On Thu, May 10, 2018 at 09:13:41AM +, Anju Thomas wrote: > Hi Ben, > > Yes. This patch certainly looks more cleaner and better to me . > > Thanks > Anju > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday,

Re: [ovs-dev] [PATCH v2] Add mirror/ovs-tcpdump support for slow protocols' Rx path.

On Thu, May 10, 2018 at 06:56:22AM +, Manohar Krishnappa Chidambaraswamy wrote: > Ben, > > Here is the v2 patch based on your suggestion. Please let me know if you have > any other comments. Thanks, applied to master. ___ dev mailing list d...@ope

Re: [ovs-dev] [PATCH v2] ovn-nbctl: Support ACL commands on port groups.

On Wed, May 09, 2018 at 11:32:04PM -0700, Han Zhou wrote: > Add support for using ovn-nbctl to add/delete/list ACLs on port > groups. > > A new option --type is also supported for these commands to > explicitely specify, when needed, whether the operation is on a > port-group or a logical switch.

Re: [ovs-dev] [PATCH v2 1/5] ovs-kmod-ctl: introduce a kernel module load script

On Fri, 4 May 2018 at 11:28, Aaron Conole wrote: > Currently, Open vSwitch on linux embeds the logic of loading and unloading > kernel modules into the ovs-ctl and ovs-lib script files. This works, but > it means that there is no way to leverage extended filesystem attributes > to grant fine gra

Re: [ovs-dev] [PATCH] Avoid crash in OvS while transmitting fragmented packets over tunnel.

Hi Darell, I reproduce the issue by making VM to transmit fragmented packets and in OvS if we have corresponding rule to transmit the received fragmented packet (from VM) over tunnel then I always hit the crash. Thanks Rohith On 11/05/18, 2:16 AM, "Darrell Ball" wrote: Thanks Rohith

[ovs-dev] [PATCH] tunnel: cleanup geneve md before forwarding to another port.

When there is a flow rule which forwards a packet from geneve port to another tunnel port, ex: gre, the tun_metadata carried from the geneve port needs to be clean up. Otherwise, the output tunnel port will incorrectly have geneve option being set. For example, without the patch, the datapath act