Re: [ovs-dev] [PATCH v1] ovndb-servers.ocf: add LB support for managing ovsdb cluster

2018-05-17 Thread Numan Siddique
Hi Aliasgar, I will try it out and come back with my comments. Thanks Numan On Tue, May 8, 2018 at 10:37 AM, aginwala wrote: > using pacemaker so that controllers can be placed in different fault > domains. > > Signed-off-by: aginwala > --- > ovn/utilities/ovndb-servers.ocf | 63 +++

Re: [ovs-dev] [PATCH] ovn pacemaker: Fix the promotion issue in other cluster nodes when the master node is reset

2018-05-17 Thread Numan Siddique
On Fri, May 18, 2018 at 4:24 AM, aginwala wrote: > Hi: > > I tried and it didnt help where Ip resource is always showing stopped > where my private VIP IP is 192.168.220.108 > # kernel panic on active node > root@test7:~# echo c > /proc/sysrq-trigger > > > root@test6:~# crm stat > Last updated:

Re: [ovs-dev] [PATCH V2 00/41] Add ERSPAN support

2018-05-17 Thread Gregory Rose
On 5/17/2018 9:59 PM, Gregory Rose wrote: On 5/17/2018 9:04 PM, Ben Pfaff wrote: On Thu, May 17, 2018 at 06:57:13PM -0700, Greg Rose wrote: This series of patches is the backport of the Linux kernel upstream ERSPAN feature support. Thanks a lot for humoring me. Now I've run "make check".  I g

Re: [ovs-dev] [PATCH V2 00/41] Add ERSPAN support

2018-05-17 Thread Gregory Rose
On 5/17/2018 9:04 PM, Ben Pfaff wrote: On Thu, May 17, 2018 at 06:57:13PM -0700, Greg Rose wrote: This series of patches is the backport of the Linux kernel upstream ERSPAN feature support. Thanks a lot for humoring me. Now I've run "make check". I get a lot of unexpected failures. At first

Re: [ovs-dev] [PATCH V2 00/41] Add ERSPAN support

2018-05-17 Thread Ben Pfaff
On Thu, May 17, 2018 at 06:57:13PM -0700, Greg Rose wrote: > This series of patches is the backport of the Linux kernel upstream > ERSPAN feature support. Thanks a lot for humoring me. Now I've run "make check". I get a lot of unexpected failures. At first I thought I might have introduced them

[ovs-dev] Bug in OVS2.8.0+DPDK17.05+Intel_82599_IXGBE sriov?

2018-05-17 Thread Sam
Hi all, I'm using OVS2.8.0+DPDK17.05+Intel_82599_IXGBE for test, the vf driver is ixgbevf-4.0.3. I use sriov follow like this: echo 1 > /sys/bus/pci/devices/:01:00.0/max_vfs Then test l3fwd-vf demo, it is OK. Then test OVS2.8.0, and assign pf for ovs like this: ovs-vsctl add-port br_t dpdk-

[ovs-dev] Question: why ovs flush all datapath flows when destroying br/ofproto?

2018-05-17 Thread Lilijun (Jerry, Cloud Networking)
Hi all, In my test, there are many VMs sending and receiving random flows using ovs. Per VM has one virtio-net NIC and connect to ovs bridge named such as br-plyXXX. These ovs bridges br-plyXXX are all connected to br-int using patch port. All VM's traffic can generate about 200 thousand datapa

[ovs-dev] [PATCH V2 41/41] erspan: fix invalid erspan version.

2018-05-17 Thread Greg Rose
From: William Tu ERSPAN only support version 1 and 2. When packets send to an erspan device which does not have proper version number set, drop the packet. In real case, we observe multicast packets sent to the erspan pernet device, erspan0, which does not have erspan version configured. Repor

[ovs-dev] [PATCH V2 40/41] gre: Resolve gre receive issues

2018-05-17 Thread Greg Rose
On newer Linux kernels or on older kernels such as Red Hat that backport from newer upstream Linux kernel releases the built-in gre kernel module will interfere with OVS gre code in the receive path. Fix this up by placing the gre kernel code within the openvswitch driver so it will not have to de

[ovs-dev] [PATCH V2 39/41] rhel: Enable ERSPAN features for RHEL 7.x

2018-05-17 Thread Greg Rose
Enable ERSPAN on RHEL 7.x Signed-off-by: Greg Rose --- acinclude.m4| 15 ++- datapath/linux/compat/ip6_gre.c | 13 ++--- datapath/linux/compat/ip_gre.c | 12 ++-- 3 files changed, 26 insertions(+), 14 deletions(-) diff --git a/acinclude.m4 b/acin

[ovs-dev] [PATCH V2 38/41] tunnel: add support for erspan and ip6erspan type.

2018-05-17 Thread Greg Rose
From: William Tu This patch adds support for erspan and ip6erspan. Signed-off-by: William Tu --- lib/odp-util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index 2109fac..d7b5bcd 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -2882

[ovs-dev] [PATCH V2 37/41] erspan: set bso when truncated bit is set.

2018-05-17 Thread Greg Rose
From: William Tu Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not handled. BSO has 4 possible values: 00 --> Good frame with no error, or unknown integrity 11 --> Payload is a Bad Frame with CRC or Alignment Error 01 --> Payload is a Short Frame 10 --> Payload is an Over

[ovs-dev] [PATCH V2 36/41] erspan: auto detect truncated ipv6 packets.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit d5db21a3e6977dcb42cee3d16cd69901fa66510a Author: William Tu Date: Fri May 11 05:49:47 2018 -0700 erspan: auto detect truncated ipv6 packets. Currently the truncated bit is set only when 1) the mirrored packet is larger than mtu

[ovs-dev] [PATCH V2 35/41] ip6erspan: make sure enough headroom at xmit.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit e41c7c68ea771683cae5a7f81c268f38d7912ecb Author: William Tu Date: Fri Mar 9 07:34:42 2018 -0800 ip6erspan: make sure enough headroom at xmit. The patch adds skb_cow_header() to ensure enough headroom at ip6erspan_tunnel_xmit be

[ovs-dev] [PATCH V2 34/41] ip6erspan: improve error handling for erspan version number.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit d6aa71197ffcb68850bfebfc3fc160abe41df53b Author: William Tu Date: Fri Mar 9 07:34:41 2018 -0800 ip6erspan: improve error handling for erspan version number. When users fill in incorrect erspan version number through the struct

[ovs-dev] [PATCH V2 32/41] erspan: Add flow-based erspan options

2018-05-17 Thread Greg Rose
The patch add supports for flow-based erspan options. The erspan_ver, erspan_idx, erspan_dir, and erspan_hwid can be set as "flow" so that its value is set by the openflow rule, instead of statically configured at port creation time. Signed-off-by: William Tu --- V2 - A portion of this patch fro

[ovs-dev] [PATCH V2 31/41] lib/dpif-netlink: Fix miscompare of gre ports

2018-05-17 Thread Greg Rose
In netdev_to_ovs_vport_type() it checks for netdev types matching "gre" with a strstr(). This makes it match ip6gre as well and return OVS_VPORT_TYPE_GRE, which is clearly wrong. Move the usage of strstr() *after* all the exact matches with strcmp() to avoid the problem permanently because when I

[ovs-dev] [PATCH V2 33/41] ip6gre: add erspan v2 to tunnel lookup

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 3b04caab81649a9e8d5375b919b6653d791951df Author: William Tu Date: Fri Mar 9 07:34:40 2018 -0800 ip6gre: add erspan v2 to tunnel lookup The patch adds the erspan v2 proto in ip6gre_tunnel_lookup so the erspan v2 tunnel can be fo

[ovs-dev] [PATCH V2 30/41] ip6gre: Add ip6gre vport type

2018-05-17 Thread Greg Rose
Add handlers for OVS_VPORT_TYPE_IP6GRE Cc: Ben Pfaff Signed-off-by: Greg Rose --- V2 - Folded in additional change from Ben Pfaff as per his suggestion. --- lib/dpif-netlink-rtnl.c | 4 +++- lib/dpif-netlink.c | 7 +-- lib/netdev-native-tnl.c | 8 ++-- lib/netdev-vport.c | 4

[ovs-dev] [PATCH V2 26/41] userspace: add erspan tunnel support.

2018-05-17 Thread Greg Rose
From: William Tu ERSPAN is a tunneling protocol based on GRE tunnel. The patch add erspan tunnel support for ovs-vswitchd with userspace datapath. Configuring erspan tunnel is similar to gre tunnel, but with additional erspan's parameters. Matching a flow on erspan's metadata is also supported,

[ovs-dev] [PATCH V2 27/41] erspan: add kernel datapath support

2018-05-17 Thread Greg Rose
From: William Tu pass check, check-kernel (4.16-rc4), check-system-userspace Signed-off-by: William Tu --- lib/dpif-netlink-rtnl.c | 20 +++--- lib/dpif-netlink.c| 3 + lib/odp-util.c| 150 +- tests/odp.at

[ovs-dev] [PATCH V2 29/41] erspan: auto detect truncated packets.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 1baf5ebf8954d9bff8fa4e7dd6c416a0cebdb9e2 Author: William Tu Date: Fri Apr 27 14:16:32 2018 -0700 erspan: auto detect truncated packets. Currently the truncated bit is set only when the mirrored packet is larger than mtu. For c

[ovs-dev] [PATCH V2 28/41] openvswitch: fix vport packet length check.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 46e371f0e78a82186a83cbcb4f4b8850417c7dd5 Author: William Tu Date: Wed Mar 7 15:38:48 2018 -0800 openvswitch: fix vport packet length check. When sending a packet to a tunnel device, the dev's hard_header_len could be larger tha

[ovs-dev] [PATCH V2 25/41] userspace: add gre sequence number support.

2018-05-17 Thread Greg Rose
From: William Tu The patch adds support for gre sequence number. Default is disable. When enable with 'options:seq=true', the outgoing gre packet will have its sequence number incremented by one. Signed-off-by: William Tu --- lib/netdev-native-tnl.c | 19 ++- lib/netdev-vport

[ovs-dev] [PATCH V2 24/41] netdev-native-tnl: refactor the tunnel push header.

2018-05-17 Thread Greg Rose
From: William Tu The patch adds additional 'struct netdev *' to the native tunnel's push_header() interface. This is used for later GRE sequence number support. Signed-off-by: William Tu --- lib/netdev-native-tnl.c | 6 -- lib/netdev-native-tnl.h | 6 -- lib/netdev-provider.h | 3 ++

[ovs-dev] [PATCH V2 23/41] datapath: add erspan version I and II support

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit fc1372f89ffe1f58b589643b75f679e452350703 Author: William Tu Date: Thu Jan 25 13:20:11 2018 -0800 openvswitch: add erspan version I and II support The patch adds support for openvswitch to configure erspan v1 and v2. The OVS_TU

[ovs-dev] [PATCH V2 21/41] datapath: erspan: introduce erspan v2 for ip_gre

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit f551c91de262ba36b20c3ac19538afb4f4507441 Author: William Tu Date: Wed Dec 13 16:38:56 2017 -0800 net: erspan: introduce erspan v2 for ip_gre The patch adds support for erspan version 2. Not all features are supported in this

[ovs-dev] [PATCH V2 22/41] compat: erspan: use bitfield instead of mask and offset

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit c69de58ba84f480879de64571d9dae5102d10ed6 Author: William Tu Date: Thu Jan 25 13:20:09 2018 -0800 net: erspan: use bitfield instead of mask and offset Originally the erspan fields are defined as a group into a __be16 field, and

[ovs-dev] [PATCH V2 20/41] datapath: Use correct tunnel receive for ip6gre

2018-05-17 Thread Greg Rose
During backports of ip6 gre I used ovs_ip_tunnel_rcv() for the ip6gre_rcv() function but that is wrong because it processes ipv4 tunnels. Use the correct backported ip6 tunnel receive in ip6 tunnel.c ip6_tnl_rcv(). Signed-off-by: Greg Rose --- datapath/linux/compat/ip6_gre.c | 3 +-- 1 file cha

[ovs-dev] [PATCH V2 19/41] datapath: Add dellink op to ip6gre and ip6erspan tap ops

2018-05-17 Thread Greg Rose
Fix an oversight in the ip6gre_tap_ops and ip6erspan_tap_ops in which the .dellink field was not initialized leading to bugs when trying to remove and re-add those type of ports. Signed-off-by: Greg Rose --- datapath/linux/compat/ip6_gre.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/da

[ovs-dev] [PATCH V2 17/41] compat: Fixups for some compile warnings and errors

2018-05-17 Thread Greg Rose
A lot of code has been pulled in. Fix it up to make sure it compiles correctly. Signed-off-by: Greg Rose --- datapath/linux/compat/gre.c | 23 datapath/linux/compat/include/net/gre.h | 47 - datapath/linux/compat/ip_gre.c |

[ovs-dev] [PATCH V2 16/41] compat: Add #define for gre_handle_offloads

2018-05-17 Thread Greg Rose
Fixes compile errors on some 4.x kernels. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index f849971..b1493e0 100644 --- a/datapath/linux/compat/ip_gre.c +++ b/datap

[ovs-dev] [PATCH V2 15/41] compat: Move function to header

2018-05-17 Thread Greg Rose
tnl_flags_to_gre_flags is also needed in both ip_gre.c and gre.c on some kernels. Move it from ip_gre.c to the common header. Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/gre.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/datapath/linux/compat/i

[ovs-dev] [PATCH V2 14/41] ip_gre: remove the incorrect mtu limit for ipgre tap

2018-05-17 Thread Greg Rose
From: Xin Long Upstream commit: commit cfddd4c33c254954927942599d299b3865743146 Author: Xin Long Date: Mon Dec 18 14:24:35 2017 +0800 ip_gre: remove the incorrect mtu limit for ipgre tap ipgre tap driver calls ether_setup(), after commit 61e84623ace3 ("net: centralize

[ovs-dev] [PATCH V2 13/41] ip_gre: erspan: reload pointer after pskb_may_pull

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit d91e8db5b629a3c8c81db4dc317a66c7b5591821 Author: William Tu Date: Fri Dec 15 14:27:44 2017 -0800 net: erspan: reload pointer after pskb_may_pull pskb_may_pull() can change skb->data, so we need to re-load pkt_md and ershdr at t

[ovs-dev] [PATCH V2 11/41] compat/erspan: refactor existing erspan code

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 1d7e2ed22f8d9171fa8b629754022f22115b3f03 Author: William Tu Date: Wed Dec 13 16:38:55 2017 -0800 net: erspan: refactor existing erspan code The patch refactors the existing erspan implementation in order to support erspan versi

[ovs-dev] [PATCH V2 12/41] ip_gre: fix wrong return value of erspan_rcv

2018-05-17 Thread Greg Rose
From: Haishuang Yan Upstream commit: commit c05fad5713b81b049ec6ac4eb2d304030b1efdce Author: Haishuang Yan Date: Fri Dec 15 10:46:16 2017 +0800 ip_gre: fix wrong return value of erspan_rcv If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM. Fixes

[ovs-dev] [PATCH V2 10/41] ip_gre: Refactor the erpsan tunnel code.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit a3222dc95ca751cdc5f6ac3c9b092b160b73ed9f Author: William Tu Date: Thu Nov 30 11:51:27 2017 -0800 ip_gre: Refector the erpsan tunnel code. Move two erspan functions to header file, erspan.h, so ipv6 erspan implementation can use

[ovs-dev] [PATCH V2 09/41] ip_gre: erspan device should keep dst

2018-05-17 Thread Greg Rose
From: Xin Long Upstream commit: commit c84bed440e4e11a973e8c0254d0dfaccfca41fb0 Author: Xin Long Date: Sun Oct 1 22:00:56 2017 +0800 ip_gre: erspan device should keep dst The patch 'ip_gre: ipgre_tap device should keep dst' fixed the issue ipgre_tap dev mtu couldn't b

[ovs-dev] [PATCH V2 08/41] ip_gre: set tunnel hlen properly in erspan_tunnel_init

2018-05-17 Thread Greg Rose
From: Xin Long Upstream commit: commit c122fda271717f4fc618e0a31e833941fd5f1efd Author: Xin Long Date: Sun Oct 1 22:00:55 2017 +0800 ip_gre: set tunnel hlen properly in erspan_tunnel_init According to __gre_tunnel_init, tunnel->hlen should be set as the headers' lengt

[ovs-dev] [PATCH V2 02/41] gre: introduce native tunnel support for ERSPAN

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 84e54fe0a5eaed696dee4019c396f8396f5a908b Author: William Tu Date: Tue Aug 22 09:40:28 2017 -0700 gre: introduce native tunnel support for ERSPAN The patch adds ERSPAN type II tunnel support. The implementation is based on the

[ovs-dev] [PATCH V2 07/41] ip_gre: get key from session_id correctly in erspan_rcv

2018-05-17 Thread Greg Rose
From: Xin Long Upstream commit: commit 935a9749a36828af0e8be224a5cd4bc758112c34 Author: Xin Long Date: Sun Oct 1 22:00:53 2017 +0800 ip_gre: get key from session_id correctly in erspan_rcv erspan only uses the first 10 bits of session_id as the key to look up the tunn

[ovs-dev] [PATCH V2 06/41] ip_gre: check packet length and mtu correctly in erspan tx

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit f192970de860d3ab90aa9e2a22853201a57bde78 Author: William Tu Date: Thu Oct 5 12:07:12 2017 -0700 ip_gre: check packet length and mtu correctly in erspan tx Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device is t

[ovs-dev] [PATCH V2 05/41] compat/gre: add collect_md mode

2018-05-17 Thread Greg Rose
From: William Tu commit 1a66a836da630cd70f3639208da549b549ce576b Author: William Tu Date: Fri Aug 25 09:21:28 2017 -0700 gre: add collect_md mode to ERSPAN tunnel Similar to gre, vxlan, geneve, ipip tunnels, allow ERSPAN tunnels to operate in 'collect metadata' mode.

[ovs-dev] [PATCH V2 04/41] gre: refactor the gre_fb_xmit

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 862a03c35ed76c50a562f7406ad23315f7862642 Author: William Tu Date: Fri Aug 25 09:21:27 2017 -0700 gre: refactor the gre_fb_xmit The patch refactors the gre_fb_xmit function, by creating prepare_fb_xmit function for later ERSPAN

[ovs-dev] [PATCH V2 03/41] gre: fix goto statement typo

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit e3d0328c76dde0b957f62f8c407b79f1d8fe3ef8 Author: William Tu Date: Tue Aug 22 17:04:05 2017 -0700 gre: fix goto statement typo Fix typo: pnet_tap_faied. Signed-off-by: William Tu Signed-off-by: David S. Miller Cc: Willia

[ovs-dev] [PATCH V2 01/41] compat: Remove unsupported kernel compat code

2018-05-17 Thread Greg Rose
Anything less than 3.10 isn't supported since a couple of releases ago so remove the dead code. Signed-off-by: Greg Rose --- datapath/linux/compat/include/linux/etherdevice.h | 30 -- datapath/linux/compat/include/linux/if_vlan.h | 11 --- datapath/linux/compat/include/linux/kconfig.

[ovs-dev] [PATCH V2 00/41] Add ERSPAN support

2018-05-17 Thread Greg Rose
This series of patches is the backport of the Linux kernel upstream ERSPAN feature support. The first patch does some cleanup of unsupported kernel code. The remaining patches in the series begin the backport of the ERSPAN code. As part of the ERSPAN backport it was necessary to fixup the curren

[ovs-dev] [PATCH v1] ovndb-servers.ocf: add LB support for managing ovsdb cluster

2018-05-17 Thread aginwala
using pacemaker so that controllers can be placed in different fault domains. Signed-off-by: aginwala --- ovn/utilities/ovndb-servers.ocf | 63 + 1 file changed, 51 insertions(+), 12 deletions(-) diff --git a/ovn/utilities/ovndb-servers.ocf b/ovn/utilitie

Re: [ovs-dev] [PATCH 29/41] lib/dpif-netlink: Fix miscompare of gre ports

2018-05-17 Thread Gregory Rose
On 5/17/2018 4:12 PM, Ben Pfaff wrote: On Thu, May 17, 2018 at 02:15:21PM -0700, Greg Rose wrote: In netdev_to_ovs_vport_type() it checks for netdev types matching "gre" with a strstr(). This makes it match ip6gre as well and return OVS_VPORT_TYPE_GRE, which is clearly wrong. Move the usage of

Re: [ovs-dev] [PATCH 00/41] Add ERSPAN support

2018-05-17 Thread Gregory Rose
On 5/17/2018 4:24 PM, Ben Pfaff wrote: On Thu, May 17, 2018 at 02:14:52PM -0700, Greg Rose wrote: This series of patches is the backport of the Linux kernel upstream ERSPAN feature support. Thanks a lot for implementing this. I did some basic review and sent out my suggestions. If they make s

Re: [ovs-dev] [PATCH 00/41] Add ERSPAN support

2018-05-17 Thread Ben Pfaff
On Thu, May 17, 2018 at 02:14:52PM -0700, Greg Rose wrote: > This series of patches is the backport of the Linux kernel upstream > ERSPAN feature support. Thanks a lot for implementing this. I did some basic review and sent out my suggestions. If they make sense, would you mind sending a final p

Re: [ovs-dev] [PATCH 28/41] ip6gre: Add ip6gre vport type

2018-05-17 Thread Ben Pfaff
On Thu, May 17, 2018 at 02:15:20PM -0700, Greg Rose wrote: > Add handlers for OVS_VPORT_TYPE_IP6GRE > > Signed-off-by: Greg Rose I suggest folding in the following incremental: --8<--cut here-->8-- diff --git a/lib/netdev-native-tnl.c b/lib/netde

Re: [ovs-dev] [PATCH 24/41] userspace: add erspan tunnel support.

2018-05-17 Thread Ben Pfaff
On Thu, May 17, 2018 at 02:15:16PM -0700, Greg Rose wrote: > From: William Tu > > ERSPAN is a tunneling protocol based on GRE tunnel. The patch > add erspan tunnel support for ovs-vswitchd with userspace datapath. > Configuring erspan tunnel is similar to gre tunnel, but with > additional erspan

Re: [ovs-dev] [PATCH 32/41] datapath: Use correct tunnel receive for ip6gre

2018-05-17 Thread Ben Pfaff
On Thu, May 17, 2018 at 02:15:24PM -0700, Greg Rose wrote: > During backports of ip6 gre I used ovs_ip_tunnel_rcv() for the > ip6gre_rcv() function but that is wrong because it processes ipv4 > tunnels. Use the correct backported ip6 tunnel receive in ip6 > tunnel.c ip6_tnl_rcv(). > > Signed-off-

Re: [ovs-dev] [PATCH 31/41] datapath: Add dellink op to ip6gre and ip6erspan tap ops

2018-05-17 Thread Ben Pfaff
On Thu, May 17, 2018 at 02:15:23PM -0700, Greg Rose wrote: > Fix an oversight in the ip6gre_tap_ops and ip6erspan_tap_ops in > which the .dellink field was not initialized leading to bugs > when trying to remove and re-add those type of ports. > > Signed-off-by: Greg Rose I'd think that this sho

Re: [ovs-dev] [PATCH 30/41] erspan: Add flow-based erspan options

2018-05-17 Thread Ben Pfaff
On Thu, May 17, 2018 at 02:15:22PM -0700, Greg Rose wrote: > From: William Tu > > The patch add supports for flow-based erspan options. > The erspan_ver, erspan_idx, erspan_dir, and erspan_hwid can be > set as "flow" so that its value is set by the openflow rule, > instead of statically configure

Re: [ovs-dev] [PATCH 29/41] lib/dpif-netlink: Fix miscompare of gre ports

2018-05-17 Thread Ben Pfaff
On Thu, May 17, 2018 at 02:15:21PM -0700, Greg Rose wrote: > In netdev_to_ovs_vport_type() it checks for netdev types matching > "gre" with a strstr(). This makes it match ip6gre as well and return > OVS_VPORT_TYPE_GRE, which is clearly wrong. > > Move the usage of strstr() *after* all the exact

Re: [ovs-dev] [RFC v6 00/11] Support multi-segment mbufs

2018-05-17 Thread Lam, Tiago
Hi Ilya, Thanks for having look, much appreciated! On 17/05/2018 14:26, Ilya Maximets wrote: > Hello. > Thanks for working on this. But it seems that this patch > completely breaks build without dpdk. There are a lot of places > where dpdk functions in use regardless of define DPDK_NETDEV. Thank

[ovs-dev] Incremente la motivación y la participación

2018-05-17 Thread Gamificación - Webinar
Introducción: El término Gamificación o Gamification es la aplicación de principios y elementos propios del juego en un ambiente de educación o trabajo y tiene el propósito de influir positivamente en los participantes de las dinámicas, incrementar la motivación y fomentar la participación y el

Re: [ovs-dev] [PATCH] ovn pacemaker: Fix the promotion issue in other cluster nodes when the master node is reset

2018-05-17 Thread aginwala
Hi: I tried and it didnt help where Ip resource is always showing stopped where my private VIP IP is 192.168.220.108 # kernel panic on active node root@test7:~# echo c > /proc/sysrq-trigger root@test6:~# crm stat Last updated: Thu May 17 22:46:38 2018 Last change: Thu May 17 22:45:03 2018 by ro

[ovs-dev] Medidas Preventivas - En Línea

2018-05-17 Thread Riesgos Psicosociales en el Trabajo
Prevención de Riesgos Psicosociales en el TRABAJO Fecha: 01/Junio/2018 Horario: 10:00 a 13:00 y 15:00 a 18:00 horas "Estrés, agotamiento laboral (burnout), acoso psicológico (mobbing) y mal ambiente laboral, entre otros riesgos psicosociales afectan el bienestar y la salud (física, psíq

Re: [ovs-dev] [PATCH] ovsdb: Use new ovsdb_log_write_and_free().

2018-05-17 Thread Justin Pettit
> On May 17, 2018, at 11:20 AM, Ben Pfaff wrote: > > On Thu, May 17, 2018 at 11:07:32AM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Thanks for the cleanup. > > Acked-by: Ben Pfaff Thanks. I pushed this to master. --Justin _

[ovs-dev] [PATCH 40/41] gre: Resolve gre receive issues

2018-05-17 Thread Greg Rose
On newer Linux kernels or on older kernels such as Red Hat that backport from newer upstream Linux kernel releases the built-in gre kernel module will interfere with OVS gre code in the receive path. Fix this up by placing the gre kernel code within the openvswitch driver so it will not have to de

[ovs-dev] [PATCH 41/41] erspan: fix invalid erspan version.

2018-05-17 Thread Greg Rose
From: William Tu ERSPAN only support version 1 and 2. When packets send to an erspan device which does not have proper version number set, drop the packet. In real case, we observe multicast packets sent to the erspan pernet device, erspan0, which does not have erspan version configured. Repor

[ovs-dev] [PATCH 38/41] tunnel: add support for erspan and ip6erspan type.

2018-05-17 Thread Greg Rose
From: William Tu This patch adds support for erspan and ip6erspan. Signed-off-by: William Tu --- lib/odp-util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index 29b5fb8..acc1586 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -2885

[ovs-dev] [PATCH 39/41] rhel: Enable ERSPAN features for RHEL 7.x

2018-05-17 Thread Greg Rose
Enable ERSPAN on RHEL 7.x Signed-off-by: Greg Rose --- acinclude.m4| 15 ++- datapath/linux/compat/ip6_gre.c | 13 ++--- datapath/linux/compat/ip_gre.c | 12 ++-- 3 files changed, 26 insertions(+), 14 deletions(-) diff --git a/acinclude.m4 b/acin

[ovs-dev] [PATCH 37/41] erspan: set bso when truncated bit is set.

2018-05-17 Thread Greg Rose
From: William Tu Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not handled. BSO has 4 possible values: 00 --> Good frame with no error, or unknown integrity 11 --> Payload is a Bad Frame with CRC or Alignment Error 01 --> Payload is a Short Frame 10 --> Payload is an Over

[ovs-dev] [PATCH 36/41] erspan: auto detect truncated ipv6 packets.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit d5db21a3e6977dcb42cee3d16cd69901fa66510a Author: William Tu Date: Fri May 11 05:49:47 2018 -0700 erspan: auto detect truncated ipv6 packets. Currently the truncated bit is set only when 1) the mirrored packet is larger than mtu

[ovs-dev] [PATCH 35/41] ip6erspan: make sure enough headroom at xmit.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit e41c7c68ea771683cae5a7f81c268f38d7912ecb Author: William Tu Date: Fri Mar 9 07:34:42 2018 -0800 ip6erspan: make sure enough headroom at xmit. The patch adds skb_cow_header() to ensure enough headroom at ip6erspan_tunnel_xmit be

[ovs-dev] [PATCH 34/41] ip6erspan: improve error handling for erspan version number.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit d6aa71197ffcb68850bfebfc3fc160abe41df53b Author: William Tu Date: Fri Mar 9 07:34:41 2018 -0800 ip6erspan: improve error handling for erspan version number. When users fill in incorrect erspan version number through the struct

[ovs-dev] [PATCH 33/41] ip6gre: add erspan v2 to tunnel lookup

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 3b04caab81649a9e8d5375b919b6653d791951df Author: William Tu Date: Fri Mar 9 07:34:40 2018 -0800 ip6gre: add erspan v2 to tunnel lookup The patch adds the erspan v2 proto in ip6gre_tunnel_lookup so the erspan v2 tunnel can be fo

[ovs-dev] [PATCH 32/41] datapath: Use correct tunnel receive for ip6gre

2018-05-17 Thread Greg Rose
During backports of ip6 gre I used ovs_ip_tunnel_rcv() for the ip6gre_rcv() function but that is wrong because it processes ipv4 tunnels. Use the correct backported ip6 tunnel receive in ip6 tunnel.c ip6_tnl_rcv(). Signed-off-by: Greg Rose --- datapath/linux/compat/ip6_gre.c | 3 +-- 1 file cha

[ovs-dev] [PATCH 31/41] datapath: Add dellink op to ip6gre and ip6erspan tap ops

2018-05-17 Thread Greg Rose
Fix an oversight in the ip6gre_tap_ops and ip6erspan_tap_ops in which the .dellink field was not initialized leading to bugs when trying to remove and re-add those type of ports. Signed-off-by: Greg Rose --- datapath/linux/compat/ip6_gre.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/da

[ovs-dev] [PATCH 30/41] erspan: Add flow-based erspan options

2018-05-17 Thread Greg Rose
From: William Tu The patch add supports for flow-based erspan options. The erspan_ver, erspan_idx, erspan_dir, and erspan_hwid can be set as "flow" so that its value is set by the openflow rule, instead of statically configured at port creation time. Signed-off-by: William Tu --- lib/match.c

[ovs-dev] [PATCH 24/41] userspace: add erspan tunnel support.

2018-05-17 Thread Greg Rose
From: William Tu ERSPAN is a tunneling protocol based on GRE tunnel. The patch add erspan tunnel support for ovs-vswitchd with userspace datapath. Configuring erspan tunnel is similar to gre tunnel, but with additional erspan's parameters. Matching a flow on erspan's metadata is also supported,

[ovs-dev] [PATCH 29/41] lib/dpif-netlink: Fix miscompare of gre ports

2018-05-17 Thread Greg Rose
In netdev_to_ovs_vport_type() it checks for netdev types matching "gre" with a strstr(). This makes it match ip6gre as well and return OVS_VPORT_TYPE_GRE, which is clearly wrong. Move the usage of strstr() *after* all the exact matches with strcmp() to avoid the problem permanently because when I

[ovs-dev] [PATCH 28/41] ip6gre: Add ip6gre vport type

2018-05-17 Thread Greg Rose
Add handlers for OVS_VPORT_TYPE_IP6GRE Signed-off-by: Greg Rose --- lib/dpif-netlink-rtnl.c | 4 +++- lib/dpif-netlink.c | 7 +-- lib/netdev-native-tnl.c | 5 - lib/netdev-vport.c | 4 lib/odp-util.c | 9 +++-- lib/tnl-ports.c | 2 +- 6 files changed,

[ovs-dev] [PATCH 25/41] erspan: add kernel datapath support

2018-05-17 Thread Greg Rose
From: William Tu pass check, check-kernel (4.16-rc4), check-system-userspace Signed-off-by: William Tu --- lib/dpif-netlink-rtnl.c | 20 +++--- lib/dpif-netlink.c| 3 + lib/odp-util.c| 150 +- tests/odp.at

[ovs-dev] [PATCH 27/41] erspan: auto detect truncated packets.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 1baf5ebf8954d9bff8fa4e7dd6c416a0cebdb9e2 Author: William Tu Date: Fri Apr 27 14:16:32 2018 -0700 erspan: auto detect truncated packets. Currently the truncated bit is set only when the mirrored packet is larger than mtu. For c

[ovs-dev] [PATCH 26/41] openvswitch: fix vport packet length check.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 46e371f0e78a82186a83cbcb4f4b8850417c7dd5 Author: William Tu Date: Wed Mar 7 15:38:48 2018 -0800 openvswitch: fix vport packet length check. When sending a packet to a tunnel device, the dev's hard_header_len could be larger tha

[ovs-dev] [PATCH 23/41] userspace: add gre sequence number support.

2018-05-17 Thread Greg Rose
From: William Tu The patch adds support for gre sequence number. Default is disable. When enable with 'options:seq=true', the outgoing gre packet will have its sequence number incremented by one. Signed-off-by: William Tu --- lib/netdev-native-tnl.c | 19 ++- lib/netdev-vport

[ovs-dev] [PATCH 22/41] netdev-native-tnl: refactor the tunnel push header.

2018-05-17 Thread Greg Rose
From: William Tu The patch adds additional 'struct netdev *' to the native tunnel's push_header() interface. This is used for later GRE sequence number support. Signed-off-by: William Tu --- lib/netdev-native-tnl.c | 6 -- lib/netdev-native-tnl.h | 6 -- lib/netdev-provider.h | 3 ++

[ovs-dev] [PATCH 21/41] datapath: add erspan version I and II support

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit fc1372f89ffe1f58b589643b75f679e452350703 Author: William Tu Date: Thu Jan 25 13:20:11 2018 -0800 openvswitch: add erspan version I and II support The patch adds support for openvswitch to configure erspan v1 and v2. The OVS_TU

[ovs-dev] [PATCH 20/41] compat: erspan: use bitfield instead of mask and offset

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit c69de58ba84f480879de64571d9dae5102d10ed6 Author: William Tu Date: Thu Jan 25 13:20:09 2018 -0800 net: erspan: use bitfield instead of mask and offset Originally the erspan fields are defined as a group into a __be16 field, and

[ovs-dev] [PATCH 17/41] compat: Fixups for some compile warnings and errors

2018-05-17 Thread Greg Rose
A lot of code has been pulled in. Fix it up to make sure it compiles correctly. Signed-off-by: Greg Rose --- datapath/linux/compat/gre.c | 23 datapath/linux/compat/include/net/gre.h | 47 - datapath/linux/compat/ip_gre.c |

[ovs-dev] [PATCH 19/41] datapath: erspan: introduce erspan v2 for ip_gre

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit f551c91de262ba36b20c3ac19538afb4f4507441 Author: William Tu Date: Wed Dec 13 16:38:56 2017 -0800 net: erspan: introduce erspan v2 for ip_gre The patch adds support for erspan version 2. Not all features are supported in this

[ovs-dev] [PATCH 16/41] compat: Add #define for gre_handle_offloads

2018-05-17 Thread Greg Rose
Fixes compile errors on some 4.x kernels. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index f849971..b1493e0 100644 --- a/datapath/linux/compat/ip_gre.c +++ b/datap

[ovs-dev] [PATCH 15/41] compat: Move function to header

2018-05-17 Thread Greg Rose
tnl_flags_to_gre_flags is also needed in both ip_gre.c and gre.c on some kernels. Move it from ip_gre.c to the common header. Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/gre.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/datapath/linux/compat/i

[ovs-dev] [PATCH 14/41] ip_gre: remove the incorrect mtu limit for ipgre tap

2018-05-17 Thread Greg Rose
From: Xin Long Upstream commit: commit cfddd4c33c254954927942599d299b3865743146 Author: Xin Long Date: Mon Dec 18 14:24:35 2017 +0800 ip_gre: remove the incorrect mtu limit for ipgre tap ipgre tap driver calls ether_setup(), after commit 61e84623ace3 ("net: centralize

[ovs-dev] [PATCH 13/41] ip_gre: erspan: reload pointer after pskb_may_pull

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit d91e8db5b629a3c8c81db4dc317a66c7b5591821 Author: William Tu Date: Fri Dec 15 14:27:44 2017 -0800 net: erspan: reload pointer after pskb_may_pull pskb_may_pull() can change skb->data, so we need to re-load pkt_md and ershdr at t

[ovs-dev] [PATCH 10/41] ip_gre: Refactor the erpsan tunnel code.

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit a3222dc95ca751cdc5f6ac3c9b092b160b73ed9f Author: William Tu Date: Thu Nov 30 11:51:27 2017 -0800 ip_gre: Refector the erpsan tunnel code. Move two erspan functions to header file, erspan.h, so ipv6 erspan implementation can use

[ovs-dev] [PATCH 12/41] ip_gre: fix wrong return value of erspan_rcv

2018-05-17 Thread Greg Rose
From: Haishuang Yan Upstream commit: commit c05fad5713b81b049ec6ac4eb2d304030b1efdce Author: Haishuang Yan Date: Fri Dec 15 10:46:16 2017 +0800 ip_gre: fix wrong return value of erspan_rcv If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM. Fixes

[ovs-dev] [PATCH 09/41] ip_gre: erspan device should keep dst

2018-05-17 Thread Greg Rose
From: Xin Long Upstream commit: commit c84bed440e4e11a973e8c0254d0dfaccfca41fb0 Author: Xin Long Date: Sun Oct 1 22:00:56 2017 +0800 ip_gre: erspan device should keep dst The patch 'ip_gre: ipgre_tap device should keep dst' fixed the issue ipgre_tap dev mtu couldn't b

[ovs-dev] [PATCH 11/41] compat/erspan: refactor existing erspan code

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 1d7e2ed22f8d9171fa8b629754022f22115b3f03 Author: William Tu Date: Wed Dec 13 16:38:55 2017 -0800 net: erspan: refactor existing erspan code The patch refactors the existing erspan implementation in order to support erspan versi

[ovs-dev] [PATCH 02/41] gre: introduce native tunnel support for ERSPAN

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit 84e54fe0a5eaed696dee4019c396f8396f5a908b Author: William Tu Date: Tue Aug 22 09:40:28 2017 -0700 gre: introduce native tunnel support for ERSPAN The patch adds ERSPAN type II tunnel support. The implementation is based on the

[ovs-dev] [PATCH 08/41] ip_gre: set tunnel hlen properly in erspan_tunnel_init

2018-05-17 Thread Greg Rose
From: Xin Long Upstream commit: commit c122fda271717f4fc618e0a31e833941fd5f1efd Author: Xin Long Date: Sun Oct 1 22:00:55 2017 +0800 ip_gre: set tunnel hlen properly in erspan_tunnel_init According to __gre_tunnel_init, tunnel->hlen should be set as the headers' lengt

[ovs-dev] [PATCH 07/41] ip_gre: get key from session_id correctly in erspan_rcv

2018-05-17 Thread Greg Rose
From: Xin Long Upstream commit: commit 935a9749a36828af0e8be224a5cd4bc758112c34 Author: Xin Long Date: Sun Oct 1 22:00:53 2017 +0800 ip_gre: get key from session_id correctly in erspan_rcv erspan only uses the first 10 bits of session_id as the key to look up the tunn

[ovs-dev] [PATCH 06/41] ip_gre: check packet length and mtu correctly in erspan tx

2018-05-17 Thread Greg Rose
From: William Tu Upstream commit: commit f192970de860d3ab90aa9e2a22853201a57bde78 Author: William Tu Date: Thu Oct 5 12:07:12 2017 -0700 ip_gre: check packet length and mtu correctly in erspan tx Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device is t

[ovs-dev] [PATCH 05/41] compat/gre: add collect_md mode

2018-05-17 Thread Greg Rose
From: William Tu commit 1a66a836da630cd70f3639208da549b549ce576b Author: William Tu Date: Fri Aug 25 09:21:28 2017 -0700 gre: add collect_md mode to ERSPAN tunnel Similar to gre, vxlan, geneve, ipip tunnels, allow ERSPAN tunnels to operate in 'collect metadata' mode.

  1   2   >