Re: [ovs-dev] [PATCH] ofp-flow: Fix uninitialized data decoding OF1.5 flow stats.

2018-05-23 Thread Ben Pfaff
Thanks, applied to master. On Wed, May 23, 2018 at 08:44:57PM -0700, Darrell Ball wrote: > Acked-by: Darrell Ball > > > On Wed, May 23, 2018 at 1:51 PM, Ben Pfaff wrote: > > > Reported-by: Paul Greenberg > > Reported-at:

Re: [ovs-dev] [PATCH] rconn: Introduce new invariant to fix assertion failure in corner case.

2018-05-23 Thread Ben Pfaff
On Wed, May 23, 2018 at 06:06:44PM -0700, Han Zhou wrote: > On Wed, May 23, 2018 at 5:14 PM, Ben Pfaff wrote: > > > > Until now, rconn_get_version() has only reported the OpenFlow version in > > use when the rconn is actually connected. This makes sense, but it has a > > harsh

Re: [ovs-dev] [PATCH] ofp-flow: Fix uninitialized data decoding OF1.5 flow stats.

2018-05-23 Thread Darrell Ball
Acked-by: Darrell Ball On Wed, May 23, 2018 at 1:51 PM, Ben Pfaff wrote: > Reported-by: Paul Greenberg > Reported-at: https://github.com/openvswitch/ovs-issues/issues/149 > Fixes: c7b02b800615 ("Add support for OpenFlow 1.5 statistics (OXS).") > Signed-off-by:

[ovs-dev] 答复: Question: why ovs flush all datapath flows when destroying br/ofproto?

2018-05-23 Thread Lilijun (Jerry, Cloud Networking)
Are there anybody has some ideas about this question? Thanks. -邮件原件- 发件人: Lilijun (Jerry, Cloud Networking) 发送时间: 2018年5月18日 11:02 收件人: d...@openvswitch.org; 'Ben Pfaff' ; ovs-disc...@openvswitch.org 抄送: liucheng (J) ; lixiao (H)

Re: [ovs-dev] [patch v3] netdev-native-tnl: Fix alignment for erspan index.

2018-05-23 Thread Darrell Ball
On Wed, May 23, 2018 at 11:27 AM, Ben Pfaff wrote: > On Tue, May 22, 2018 at 10:58:24AM -0700, Darrell Ball wrote: > > Flagged by clang. > > > > CC: Greg Rose > > Fixes: 068794b43f0e ("erspan: Add flow-based erspan options") > > Signed-off-by: Darrell Ball

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-23 Thread Rohith Basavaraja
Hi Ben, Only changes in datapath/linux/compat/include/linux/openvswitch.h are related to OvS Kernel module. The changes in openvswitch.h are not upstreamed yet. Can you please let me know the procedure for submitting the Changes for OvS Kernel Module?. In the meanwhile can I get code review

[ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-23 Thread Darrell Ball
The struct erspan_metadata is updated to replace the 'version' placeholder with the erspan base hdr. Also, the erspan index is defined explicitly as ovs_16aligned_be32 to mirror its encoding. Changes to odp_util result from updating the erspan index type. CC: William Tu

[ovs-dev] [patch v4 1/2] netdev-native-tnl: Fix alignment for erspan index.

2018-05-23 Thread Darrell Ball
Flagged by clang. CC: William Tu Fixes: 068794b43f0e ("erspan: Add flow-based erspan options") Signed-off-by: Darrell Ball --- lib/netdev-native-tnl.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git

Re: [ovs-dev] [PATCH] ovn-controller: fix crash after br-int.mgmt rconn disconnect

2018-05-23 Thread Han Zhou
On Wed, May 23, 2018 at 5:15 PM, Ben Pfaff wrote: > > On Sat, May 19, 2018 at 02:25:05PM -0700, Han Zhou wrote: > > ovn-controller abort was found in pinctrl_run() when debugging > > an occasional test case failure of: > > ovn-controller.at: Chassis external-id > > Thanks a lot.

Re: [ovs-dev] [PATCH] rconn: Introduce new invariant to fix assertion failure in corner case.

2018-05-23 Thread Han Zhou
On Wed, May 23, 2018 at 5:14 PM, Ben Pfaff wrote: > > Until now, rconn_get_version() has only reported the OpenFlow version in > use when the rconn is actually connected. This makes sense, but it has a > harsh consequence. Consider code like this: > > if

Re: [ovs-dev] [PATCH] ovn-controller: fix crash after br-int.mgmt rconn disconnect

2018-05-23 Thread Ben Pfaff
On Sat, May 19, 2018 at 02:25:05PM -0700, Han Zhou wrote: > ovn-controller abort was found in pinctrl_run() when debugging > an occasional test case failure of: > ovn-controller.at: Chassis external-id Thanks a lot. I think I understand the problem now. I think that the approach that this

[ovs-dev] [PATCH] rconn: Introduce new invariant to fix assertion failure in corner case.

2018-05-23 Thread Ben Pfaff
Until now, rconn_get_version() has only reported the OpenFlow version in use when the rconn is actually connected. This makes sense, but it has a harsh consequence. Consider code like this: if (rconn_is_connected(rconn) && rconn_get_version(rconn) >= 0) { for (int i = 0; i < 2; i++)

[ovs-dev] [PATCH] vconn: Remove obsolete comment.

2018-05-23 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/vconn.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/vconn.c b/lib/vconn.c index aeb2cd7dd826..52a6b3a98235 100644 --- a/lib/vconn.c +++ b/lib/vconn.c @@ -1408,10 +1408,6 @@ pvconn_close(struct pvconn *pvconn) * connection in

Re: [ovs-dev] [PATCH] ovn-controller: fix crash after br-int.mgmt rconn disconnect

2018-05-23 Thread Han Zhou
On Wed, May 23, 2018 at 1:08 PM, Ben Pfaff wrote: > > On Sat, May 19, 2018 at 02:25:05PM -0700, Han Zhou wrote: > > ovn-controller abort was found in pinctrl_run() when debugging > > an occasional test case failure of: > > ovn-controller.at: Chassis external-id > > Thanks for

[ovs-dev] [PATCH v2] ovn-controller: fix crash after br-int.mgmt rconn disconnect

2018-05-23 Thread Han Zhou
ovn-controller abort was found in pinctrl_run() when debugging an occasional test case failure of: ovn-controller.at: Chassis external-id Backtrace: (gdb) bt 0 0x7fd0f84878d7 in raise () from /lib64/libc.so.6 1 0x7fd0f848953a in abort () from /lib64/libc.so.6 2 0x004a6c9e

Re: [ovs-dev] [PATCH 01/10] ovn-controller: Incremental processing engine

2018-05-23 Thread Ben Pfaff
On Mon, May 14, 2018 at 07:23:20PM -0700, Han Zhou wrote: > This patch implements the engine which will be used in future patches > for ovn-controller incremental processing. > > Signed-off-by: Han Zhou Thanks a lot for working on this. I read through it in detail and I have

Re: [ovs-dev] [PATCH] datapath: compat: Fix ndo_size in RHEL 7.5 backport

2018-05-23 Thread Ben Pfaff
On Fri, May 18, 2018 at 11:32:11AM +0200, Jiri Benc wrote: > On Thu, 17 May 2018 12:39:51 -0700, Yi-Hung Wei wrote: > > If 'ndo_size' is not set in 'struct net_device_ops', RHEL kernel will not > > make use of functions in 'struct net_device_ops_extended'. > > > > Fixes: 39ca338374ab ("datapath:

[ovs-dev] No ponga en riesgo su empresa

2018-05-23 Thread Embargo de Cuentas Bancarias
Embargo de Cuentas Bancarias Fecha: 13/Junio/2018 Horario: 10:00 a 13:00 y 15:00 a 18:00 horas "Usted debe saber qué está sucediendo actualmente y cómo anticiparse ante cualquier situación que ponga en riesgo a su compañía. " Los participantes conocerán las claves del éxito de las

Re: [ovs-dev] [PATCH 4/6] openvswitch: convert to genradix

2018-05-23 Thread Kent Overstreet
On Wed, May 23, 2018 at 05:34:01AM -0700, Matthew Wilcox wrote: > On Tue, May 22, 2018 at 09:18:19PM -0400, Kent Overstreet wrote: > > the new generic radix trees have a simpler API and implementation, and > > no limitations on number of elements, so all flex_array users are being > > converted >

Re: [ovs-dev] [PATCH 2/6] proc: commit to genradix

2018-05-23 Thread Kent Overstreet
On Wed, May 23, 2018 at 04:28:23AM -0700, Matthew Wilcox wrote: > On Tue, May 22, 2018 at 09:18:17PM -0400, Kent Overstreet wrote: > > @@ -2140,11 +2140,12 @@ proc_map_files_readdir(struct file *file, struct > > dir_context *ctx) > > struct task_struct *task; > > struct mm_struct *mm; > >

[ovs-dev] [PATCH] tests: Avoid printing Python exception for hosts without IPv6 support.

2018-05-23 Thread Ben Pfaff
The tests probe whether the host has IPv6 support and, if it doesn't, skip the tests that require IPv6. However, until now, when the host lacks support, this caused a Python exception to be printed, like this: Traceback (most recent call last): File "", line 3, in File

Re: [ovs-dev] [PATCH 6/6] Drop flex_arrays

2018-05-23 Thread Kent Overstreet
On Wed, May 23, 2018 at 10:24:18AM -0700, Dave Hansen wrote: > Thanks for the heads-up, Matthew! Sorry, I was just using scripts/get_maintainers, forgot to check the actual file for the original author :) > On 05/22/2018 06:18 PM, Kent Overstreet wrote: > > All existing users have been converted

Re: [ovs-dev] [PATCH] ovn.at: Fix occasional failure - IPv6 Neighbor Solicitation for unknown MAC

2018-05-23 Thread Han Zhou
On Wed, May 23, 2018 at 1:08 PM, Ben Pfaff wrote: > > On Sat, May 19, 2018 at 02:23:22PM -0700, Han Zhou wrote: > > This case fails occasionally because although it waits until port > > binding is completed on HV, the patch port creation may not be > > completed yet on HV for the

[ovs-dev] [PATCH] ofp-flow: Fix uninitialized data decoding OF1.5 flow stats.

2018-05-23 Thread Ben Pfaff
Reported-by: Paul Greenberg Reported-at: https://github.com/openvswitch/ovs-issues/issues/149 Fixes: c7b02b800615 ("Add support for OpenFlow 1.5 statistics (OXS).") Signed-off-by: Ben Pfaff --- AUTHORS.rst| 1 + lib/ofp-flow.c | 1 + 2 files changed, 2 insertions(+) diff --git

[ovs-dev] Estimado usuario

2018-05-23 Thread 12116 PFG
Estimado usuario Su buzón ha excedido el límite de almacenamiento de 20 GB establecido por el administrador, actualmente se ejecuta en 20.9 GB, no puede enviar ni recibir mensajes nuevos hasta que verifique su buzón. Vuelva a validar su cuenta por correo, complete la siguiente información a

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-23 Thread Ben Pfaff
I see that this adds code to the OVS kernel module. Are these changes upstream already in Linux? Usually we use an "upstream first" philosophy regarding the kernel module. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [RFC 1/3] ovn-controller: Count calls to lflow_run()

2018-05-23 Thread Ben Pfaff
On Fri, May 18, 2018 at 06:55:35PM +0200, Jakub Sitnicki wrote: > lflow_run() is the main logical flows processing routine that we spend > most of the CPU time in when testing at scale. > > With the switch to incremental processing approach in the controller, > we will be trying to avoid calling

Re: [ovs-dev] [PATCH] rhel: Use openvswitch user/group for the log directory

2018-05-23 Thread Ben Pfaff
On Wed, May 23, 2018 at 03:52:04PM +0100, Markos Chandras wrote: > On 23/05/18 14:46, Timothy Redaelli wrote: > > Commit 94cd8383e297 ("rhel: fix log directory permissions") restored the > > old 755 permission on /var/log/openvswitch and this can result in the > > exposure of sensitive

Re: [ovs-dev] [PATCH v3] ofproto-collectors: Windows - Trigger an ARP request before sending IPFIX packet

2018-05-23 Thread Ben Pfaff
On Fri, May 18, 2018 at 03:16:43PM -0700, Sairam Venugopal wrote: > IPFIX templates and flow packets are silently dropped when a corresponding > ARP entry is missing for the Collector. The fix is to explicitly trigger an > ARP request before sending UDP packets to the collector. > > Making

Re: [ovs-dev] [PATCH] ovn-controller: fix crash after br-int.mgmt rconn disconnect

2018-05-23 Thread Ben Pfaff
On Sat, May 19, 2018 at 02:25:05PM -0700, Han Zhou wrote: > ovn-controller abort was found in pinctrl_run() when debugging > an occasional test case failure of: > ovn-controller.at: Chassis external-id Thanks for finding the problem. I don't think that this is actually the right solution

Re: [ovs-dev] [PATCH] ovn.at: Fix occasional failure - IPv6 Neighbor Solicitation for unknown MAC

2018-05-23 Thread Ben Pfaff
On Sat, May 19, 2018 at 02:23:22PM -0700, Han Zhou wrote: > This case fails occasionally because although it waits until port > binding is completed on HV, the patch port creation may not be > completed yet on HV for the localnet port, so if the packets are sent > out at this moment, the case will

Re: [ovs-dev] [PATCH v2] ovndb-servers.ocf: add support for managing cluster

2018-05-23 Thread Numan Siddique
On Wed, May 9, 2018 at 12:13 AM, aginwala wrote: > using pacemaker so that controllers can be placed in different fault > domains. > > Signed-off-by: aginwala > I see the below warning when applying the patch .git/rebase-apply/patch:153: new blank line

[ovs-dev] MAERSK VESSEL DAMAGED CARGO 7806W - SNB INTERNATIONAL

2018-05-23 Thread NAJI KHOURY MAERSKLINE
Good day, Sorry for late reply, I called your office number but no responds Kindly Check Attached report on the cargo/vessel 7806W - SNB INTERNATIONAL. Kindly confirm attached and treat with urgency. Thanks and Regards Mr NAJI KHOURY Account Office MAERSKLINE SHIPPING EUROPE B.V. Vab

Re: [ovs-dev] [patch v3] netdev-native-tnl: Fix alignment for erspan index.

2018-05-23 Thread Ben Pfaff
On Tue, May 22, 2018 at 10:58:24AM -0700, Darrell Ball wrote: > Flagged by clang. > > CC: Greg Rose > Fixes: 068794b43f0e ("erspan: Add flow-based erspan options") > Signed-off-by: Darrell Ball > --- > lib/netdev-native-tnl.c | 15 ++- > 1

Re: [ovs-dev] [PATCH 6/6] Drop flex_arrays

2018-05-23 Thread Dave Hansen
Thanks for the heads-up, Matthew! On 05/22/2018 06:18 PM, Kent Overstreet wrote: > All existing users have been converted to generic radix trees Well, flex_arrays had a good run, and the new radix trees do look quite a bit nicer. Feel free to add my ack.

[ovs-dev] [RFC v7 13/13] dpdk-tests: Add test coverage for multi-seg mbufs.

2018-05-23 Thread Tiago Lam
In order to create a minimal environment that allows the tests to get mbufs from an existing mempool, the following approach is taken: - EAL is initialised (by using the main dpdk_init()) and a (very) small mempool is instantiated (mimicking the logic in dpdk_mp_create()). This mempool

[ovs-dev] [RFC v7 12/13] netdev-dpdk: support multi-segment jumbo frames

2018-05-23 Thread Tiago Lam
From: Mark Kavanagh Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain an entire jumbo frame of a user-defined size. Typically, for each

[ovs-dev] [RFC v7 11/13] netdev-dpdk: copy large packet to multi-seg. mbufs

2018-05-23 Thread Tiago Lam
From: Mark Kavanagh Currently, packets are only copied to a single segment in the function dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames, particularly when multi-segment mbufs are involved. This patch calculates the number of segments needed by

[ovs-dev] [RFC v7 10/13] dp-packet: copy data from multi-seg. DPDK mbuf

2018-05-23 Thread Tiago Lam
From: Michael Qiu When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Also, lots of DPDK mbuf's info is missed during a copy, like packet type, ol_flags, etc. That information is very

[ovs-dev] [RFC v7 09/13] dp-packet: Handle multi-seg mbufs in resize__().

2018-05-23 Thread Tiago Lam
When enabled with DPDK OvS relies on mbufs allocated by mempools to receive and output data on DPDK ports. Until now, each OvS dp_packet has only one mbuf associated, which is allocated with the maximum possible size, taking the MTU into account. This approach, however, doesn't allow us to

[ovs-dev] [RFC v7 08/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-05-23 Thread Tiago Lam
A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise allocation and free operations by non-pmd threads on a given mempool. This mutex is wrapped by dpdk_buf_alloc() and free_dpdk_buf(), which are used by dp_packet_resize__() in a lter commit to allocate or free mbufs, as needed.

[ovs-dev] [RFC v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

2018-05-23 Thread Tiago Lam
In its current implementation dp_packet_shift() is also unaware of multi-seg mbufs (that holds data in memory non-contiguously) and assumes that data exists contiguously in memory, memmove'ing data to perform the shift. To add support for multi-seg mbuds a new set of functions was introduced,

[ovs-dev] [RFC v7 06/13] dp-packet: Handle multi-seg mbufs in put*() funcs.

2018-05-23 Thread Tiago Lam
The dp_packet_put*() function - dp_packet_put_uninit(), dp_packet_put() and dp_packet_put_zeros() - are, in their current implementation, operating on the data buffer of a dp_packet as if it were contiguous, which in the case of multi-segment mbufs means they operate on the first mbuf in the

[ovs-dev] [RFC v7 05/13] dp-packet: Handle multi-seg mbufs in helper funcs.

2018-05-23 Thread Tiago Lam
Most helper functions in dp-packet assume that the data held by a dp_packet is contiguous, and perform operations such as pointer arithmetic under that assumption. However, with the introduction of multi-segment mbufs, where data is non-contiguous, such assumptions are no longer possible. Some

[ovs-dev] [RFC v7 04/13] dp-packet: Fix data_len handling multi-seg mbufs.

2018-05-23 Thread Tiago Lam
When a dp_packet is from a DPDK source, and it contains multi-segment mbufs, the data_len is not equal to the packet size, pkt_len. Instead, the data_len of each mbuf in the chain should be considered while distributing the new (provided) size. To account for the above dp_packet_set_size() has

[ovs-dev] [RFC v7 03/13] dp-packet: Fix allocated size on DPDK init.

2018-05-23 Thread Tiago Lam
When enabled with DPDK OvS deals with two types of packets, the ones coming from the mempool and the ones locally created by OvS - which are copied to mempool mbufs before output. In the latter, the space is allocated from the system, while in the former the mbufs are allocated from a mempool,

[ovs-dev] [RFC v7 02/13] dp-packet: Init specific mbuf fields.

2018-05-23 Thread Tiago Lam
From: Mark Kavanagh dp_packets are created using xmalloc(); in the case of OvS-DPDK, it's possible the the resultant mbuf portion of the dp_packet contains random data. For some mbuf fields, specifically those related to multi-segment mbufs and/or offload features,

[ovs-dev] [RFC v7 01/13] netdev-dpdk: fix mbuf sizing

2018-05-23 Thread Tiago Lam
From: Mark Kavanagh There are numerous factors that must be considered when calculating the size of an mbuf: - the data portion of the mbuf must be sized in accordance With Rx buffer alignment (typically 1024B). So, for example, in order to successfully receive and

[ovs-dev] [RFC v7 00/13] Support multi-segment mbufs

2018-05-23 Thread Tiago Lam
Overview This patchset introduces support for multi-segment mbufs to OvS-DPDK. Multi-segment mbufs are typically used when the size of an mbuf is insufficient to contain the entirety of a packet's data. Instead, the data is split across numerous mbufs, each carrying a portion, or

Re: [ovs-dev] New Release for branch 2.9, 2.8, 2.7, 2.6

2018-05-23 Thread Justin Pettit
Sure. No problem. --Justin > On May 23, 2018, at 1:59 AM, Stokes, Ian wrote: > > Hi Justin, > > A bug has been discovered that is present from branches 2.9 -> 2.6 that can > break DPDK compilation for users. > >

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Stokes, Ian
> rte_mempool_ops_get_count is not exported by DPDK so it means it cannot be > used by OVS when using DPDK as a shared library. > > Remove rte_mempool_ops_get_count but still use rte_mempool_full and > document it's behavior. > Thanks for the v2, I've merged this to dpdk_merge and backported

Re: [ovs-dev] [PATCH] rhel: Use openvswitch user/group for the log directory

2018-05-23 Thread Markos Chandras
On 23/05/18 14:46, Timothy Redaelli wrote: > Commit 94cd8383e297 ("rhel: fix log directory permissions") restored the > old 755 permission on /var/log/openvswitch and this can result in the > exposure of sensitive information. > > Since commit f624bf23b62a ("rhel: user/group openvswitch does not

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: Don't use PMD driver if not configured successfully

2018-05-23 Thread Stokes, Ian
> On 23/05/18 15:42, Stokes, Ian wrote: > >> When initialization of the DPDK PMD driver fails > >> (dpdk_eth_dev_init()), the reconfigure_datapath() function will > >> remove the port from dp_netdev, and the port is not used. > >> > >> Now when bridge_reconfigure() is called again, no changes to

[ovs-dev] edit your images

2018-05-23 Thread Peter
Hi, Not sure if you received my email from last week? I would like to speak with the person in charge of images editing for your company? We have 20 image editors and on daily basis 1000 images can be processed, if you want to know more about us. Please reply back. If you want to check our

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: Don't use PMD driver if not configured successfully

2018-05-23 Thread Eelco Chaudron
On 23/05/18 15:42, Stokes, Ian wrote: When initialization of the DPDK PMD driver fails (dpdk_eth_dev_init()), the reconfigure_datapath() function will remove the port from dp_netdev, and the port is not used. Now when bridge_reconfigure() is called again, no changes to the previous failing

Re: [ovs-dev] [PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Kevin Traynor
On 05/23/2018 01:05 PM, Stokes, Ian wrote: >> On 05/23/2018 12:53 PM, Stokes, Ian wrote: > rte_mempool_ops_get_count is not exported by DPDK so it means it > cannot be used by OVS when using DPDK as a shared library. > > It was only being used for extra paranoid, things might

[ovs-dev] [PATCH] rhel: Use openvswitch user/group for the log directory

2018-05-23 Thread Timothy Redaelli
Commit 94cd8383e297 ("rhel: fix log directory permissions") restored the old 755 permission on /var/log/openvswitch and this can result in the exposure of sensitive information. Since commit f624bf23b62a ("rhel: user/group openvswitch does not exist") moved the user/group creations in %pre phase

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: Don't use PMD driver if not configured successfully

2018-05-23 Thread Stokes, Ian
> When initialization of the DPDK PMD driver fails (dpdk_eth_dev_init()), > the reconfigure_datapath() function will remove the port from dp_netdev, > and the port is not used. > > Now when bridge_reconfigure() is called again, no changes to the previous > failing netdev configuration are

[ovs-dev] [PATCH v2] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Kevin Traynor
rte_mempool_ops_get_count is not exported by DPDK so it means it cannot be used by OVS when using DPDK as a shared library. Remove rte_mempool_ops_get_count but still use rte_mempool_full and document it's behavior. Fixes: 91fccdad72a2 ("netdev-dpdk: Free mempool only when no in-use mbufs.")

Re: [ovs-dev] [PATCH 6/6] Drop flex_arrays

2018-05-23 Thread Jonathan Corbet
On Tue, 22 May 2018 21:18:21 -0400 Kent Overstreet wrote: > All existing users have been converted to generic radix trees > > Signed-off-by: Kent Overstreet > --- > Documentation/core-api/flexible-arrays.rst | 130 --- >

Re: [ovs-dev] [PATCH 4/6] openvswitch: convert to genradix

2018-05-23 Thread Matthew Wilcox
On Tue, May 22, 2018 at 09:18:19PM -0400, Kent Overstreet wrote: > the new generic radix trees have a simpler API and implementation, and > no limitations on number of elements, so all flex_array users are being > converted This doesn't really feel like it should be a flexarray / genradix user.

Re: [ovs-dev] [PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Stokes, Ian
> On 05/23/2018 12:53 PM, Stokes, Ian wrote: > >>> rte_mempool_ops_get_count is not exported by DPDK so it means it > >>> cannot be used by OVS when using DPDK as a shared library. > >>> > >>> It was only being used for extra paranoid, things might change in > >>> the future mode anyway, so remove

Re: [ovs-dev] [PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Kevin Traynor
On 05/23/2018 12:53 PM, Stokes, Ian wrote: >>> rte_mempool_ops_get_count is not exported by DPDK so it means it >>> cannot be used by OVS when using DPDK as a shared library. >>> >>> It was only being used for extra paranoid, things might change in the >>> future mode anyway, so remove it and just

Re: [ovs-dev] [PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Stokes, Ian
> > rte_mempool_ops_get_count is not exported by DPDK so it means it > > cannot be used by OVS when using DPDK as a shared library. > > > > It was only being used for extra paranoid, things might change in the > > future mode anyway, so remove it and just use rte_mempool_full. > > How about

Re: [ovs-dev] [PATCH 2/6] proc: commit to genradix

2018-05-23 Thread Matthew Wilcox
On Tue, May 22, 2018 at 09:18:17PM -0400, Kent Overstreet wrote: > @@ -2140,11 +2140,12 @@ proc_map_files_readdir(struct file *file, struct > dir_context *ctx) > struct task_struct *task; > struct mm_struct *mm; > unsigned long nr_files, pos, i; > - struct flex_array *fa =

Re: [ovs-dev] [PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Ilya Maximets
> rte_mempool_ops_get_count is not exported by DPDK so it means it > cannot be used by OVS when using DPDK as a shared library. > > It was only being used for extra paranoid, things might change in > the future mode anyway, so remove it and just use rte_mempool_full. How about keeping the

Re: [ovs-dev] [PATCH] ovn pacemaker: Fix the promotion issue in other cluster nodes when the master node is reset

2018-05-23 Thread Numan Siddique
On Sat, May 19, 2018 at 3:12 AM, aginwala wrote: > Sure. > > I tried with the settings you suggested but still its not able to promote > new master during kernel panic :( : > > Current DC: test7 (version 1.1.14-70404b0) - partition WITHOUT quorum > 2 nodes and 3 resources

Re: [ovs-dev] Build failures with openvswitch-{2.9.1, 2.8.3} due to missing rte_mempool_ops_get_count DPDK symbol

2018-05-23 Thread Kevin Traynor
On 05/23/2018 10:10 AM, Markos Chandras wrote: > On 23/05/18 10:08, Stokes, Ian wrote: >>> On 05/23/2018 09:38 AM, Markos Chandras wrote: On 23/05/18 09:14, Kevin Traynor wrote: > On 05/23/2018 08:48 AM, Markos Chandras wrote: >> On 23/05/18 08:41, Markos Chandras wrote: >>>

[ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-23 Thread Rohith Basavaraja
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the

[ovs-dev] [branch-2.6 PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Kevin Traynor
rte_mempool_ops_get_count is not exported by DPDK so it means it cannot be used by OVS when using DPDK as a shared library. It was only being used for extra paranoid, things might change in the future mode anyway, so remove it and just use rte_mempool_full. The mempools are still removed later

[ovs-dev] [branch-2.9 PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Kevin Traynor
rte_mempool_ops_get_count is not exported by DPDK so it means it cannot be used by OVS when using DPDK as a shared library. It was only being used for extra paranoid, things might change in the future mode anyway, so remove it and just use rte_mempool_full. The mempools are still removed later

[ovs-dev] [branch-2.8/branch-2.7 PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Kevin Traynor
rte_mempool_ops_get_count is not exported by DPDK so it means it cannot be used by OVS when using DPDK as a shared library. It was only being used for extra paranoid, things might change in the future mode anyway, so remove it and just use rte_mempool_full. The mempools are still removed later

[ovs-dev] [PATCH] netdev-dpdk: Remove use of rte_mempool_ops_get_count.

2018-05-23 Thread Kevin Traynor
rte_mempool_ops_get_count is not exported by DPDK so it means it cannot be used by OVS when using DPDK as a shared library. It was only being used for extra paranoid, things might change in the future mode anyway, so remove it and just use rte_mempool_full. The mempools are still removed later

Re: [ovs-dev] Build failures with openvswitch-{2.9.1, 2.8.3} due to missing rte_mempool_ops_get_count DPDK symbol

2018-05-23 Thread Markos Chandras
On 23/05/18 10:08, Stokes, Ian wrote: >> On 05/23/2018 09:38 AM, Markos Chandras wrote: >>> On 23/05/18 09:14, Kevin Traynor wrote: On 05/23/2018 08:48 AM, Markos Chandras wrote: > On 23/05/18 08:41, Markos Chandras wrote: >> Hello, >> [...] >> >> This was added in commit

Re: [ovs-dev] Build failures with openvswitch-{2.9.1, 2.8.3} due to missing rte_mempool_ops_get_count DPDK symbol

2018-05-23 Thread Stokes, Ian
> On 05/23/2018 09:38 AM, Markos Chandras wrote: > > On 23/05/18 09:14, Kevin Traynor wrote: > >> On 05/23/2018 08:48 AM, Markos Chandras wrote: > >>> On 23/05/18 08:41, Markos Chandras wrote: > Hello, > [...] > > This was added in commit

[ovs-dev] New Release for branch 2.9, 2.8, 2.7, 2.6

2018-05-23 Thread Stokes, Ian
Hi Justin, A bug has been discovered that is present from branches 2.9 -> 2.6 that can break DPDK compilation for users. https://mail.openvswitch.org/pipermail/ovs-dev/2018-May/347435.html There is ongoing work to address this, is it possible once we have the fix to create a new release for

Re: [ovs-dev] Build failures with openvswitch-{2.9.1, 2.8.3} due to missing rte_mempool_ops_get_count DPDK symbol

2018-05-23 Thread Kevin Traynor
On 05/23/2018 09:38 AM, Markos Chandras wrote: > On 23/05/18 09:14, Kevin Traynor wrote: >> On 05/23/2018 08:48 AM, Markos Chandras wrote: >>> On 23/05/18 08:41, Markos Chandras wrote: Hello, [...] This was added in commit 91fccdad72a253a3892dcb3c4453a31833851bb7

Re: [ovs-dev] Build failures with openvswitch-{2.9.1, 2.8.3} due to missing rte_mempool_ops_get_count DPDK symbol

2018-05-23 Thread Markos Chandras
On 23/05/18 09:14, Kevin Traynor wrote: > On 05/23/2018 08:48 AM, Markos Chandras wrote: >> On 23/05/18 08:41, Markos Chandras wrote: >>> Hello, >>> [...] >>> >>> This was added in commit 91fccdad72a253a3892dcb3c4453a31833851bb7 >>> ("netdev-dpdk: Free mempool only when no in-use mbufs."). I am

Re: [ovs-dev] [PATCH branch 2.9] NEWS: Add LSC support for DPDK.

2018-05-23 Thread Stokes, Ian
> On Tue, May 22, 2018 at 03:59:09PM +0100, Ian Stokes wrote: > > LSC support was previously added but no entry was made to the NEWS > > document. Fix this by adding it to NEWS for OVS 2.9.1. > > These patches to NEWS seem fine to me. I assume you will add them to your > next pull requests?

Re: [ovs-dev] Build failures with openvswitch-{2.9.1, 2.8.3} due to missing rte_mempool_ops_get_count DPDK symbol

2018-05-23 Thread Kevin Traynor
On 05/23/2018 08:48 AM, Markos Chandras wrote: > On 23/05/18 08:41, Markos Chandras wrote: >> Hello, >> [...] >> >> This was added in commit 91fccdad72a253a3892dcb3c4453a31833851bb7 >> ("netdev-dpdk: Free mempool only when no in-use mbufs."). I am not sure >> how that ever built since that symbol

Re: [ovs-dev] Build failures with openvswitch-{2.9.1, 2.8.3} due to missing rte_mempool_ops_get_count DPDK symbol

2018-05-23 Thread Markos Chandras
On 23/05/18 08:41, Markos Chandras wrote: > Hello, > [...] > > This was added in commit 91fccdad72a253a3892dcb3c4453a31833851bb7 > ("netdev-dpdk: Free mempool only when no in-use mbufs."). I am not sure > how that ever built since that symbol was never exported by the > rte_mempool DPDK library >

[ovs-dev] Build failures with openvswitch-{2.9.1, 2.8.3} due to missing rte_mempool_ops_get_count DPDK symbol

2018-05-23 Thread Markos Chandras
Hello, I was trying to update the openSUSE package to 2.9.1 (2.8.3 has the same issue) but the following build error occurs [ 58s] libtool: link: gcc -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter

Re: [ovs-dev] [PATCH] compat: Fix for the packet loop issue in vxlan

2018-05-23 Thread Neelakantam Gaddam
Hi Greg, I have sent the patch in another mail with the suggested changes. On Tue, May 22, 2018 at 11:36 PM, Gregory Rose wrote: > On 5/21/2018 11:48 PM, Neelakantam Gaddam wrote: > >> This patch fixes the kernel soft lockup issue with vxlan configuration >> where >> the