Re: [ovs-dev] [PATCH 2/2] ofp-print: Move significant formatting code into more specific .c files.

2018-06-17 Thread Justin Pettit
> On May 17, 2018, at 8:22 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff I assume this is mostly just moving code around, so I didn't look too closely. Let me know if you want a closer look. Acked-by: Justin Pettit Thanks, --Justin ___ d

Re: [ovs-dev] [PATCH] ovs-sim: Don't install manpage at all (except from ovs-sim itself).

2018-06-17 Thread Roi Dayan
On 14/06/2018 23:43, Ben Pfaff wrote: > ovs-sim is a funny utility since it only works from a build tree, not from > an installed OVS. That means that we shouldn't install its manpage when > we run "make install". But we do want to install the manpage when we're > inside ovs-sim itself, so tha

[ovs-dev] [PATCH] python: add IDL examples

2018-06-17 Thread Toms Atteka
created sample python scripts, which helps to learn how to use OVSDB library Signed-off-by: Toms Atteka --- python/howto/IDL/delete_bridges.py | 70 + python/howto/IDL/insert_bridge.py | 75 +++ python/howto/IDL/ovs_monitor.py| 102 +

[ovs-dev] Guest on top of DPDK-OVN.

2018-06-17 Thread Leon Goldberg
Hey, I'm trying to figure out how to run a guest on top of DPDK-OVN. Typically, when running guests on top of OVN, I would include the virtualport element. Now, with DPDK, I am passing the location of the vhostuser (I am using QEMU as server, OVS as client) to QEMU and adding a vhostuser port in

Re: [ovs-dev] [PATCH v3 1/6] ovs-kmod-ctl: introduce a kernel module load script

2018-06-17 Thread Ansis Atteka
On Wed, 6 Jun 2018 at 07:31, Aaron Conole wrote: > > Aaron Conole writes: > > > Currently, Open vSwitch on linux embeds the logic of loading and unloading > > kernel modules into the ovs-ctl and ovs-lib script files. This works, but > > it means that there is no way to leverage extended filesyst

Re: [ovs-dev] [PATCH v3 2/6] selinux: create a transition type for module loading

2018-06-17 Thread Ansis Atteka
On Fri, 1 Jun 2018 at 11:28, Aaron Conole wrote: > > Defines a type 'openvswitch_load_module_t' used exclusively for loading > modules. This means that the 'openvswitch_t' domain won't require > access to the module loading facility - such access can only happen > after transitioning through the

Re: [ovs-dev] [PATCH v3 3/6] selinux: allow openvswitch_t net_broadcast and net_raw

2018-06-17 Thread Ansis Atteka
On Fri, 1 Jun 2018 at 11:28, Aaron Conole wrote: > > The ovs-vswitchd daemon requires both CAP_NET_RAW and > CAP_NET_BROADCAST, but these are generally policy prevented by > selinux. This allows these capabilities to be retained by the > openvswitch_t domain. > > example: > > type=AVC msg=audit

Re: [ovs-dev] [PATCH v3] datapath-windows: Optimize conntrack performance

2018-06-17 Thread Anand Kumar
Abandoning this change. I have couple of patches to optimize conntrack, will be sending it out as a series. Thanks, Anand Kumar On 6/11/18, 11:39 AM, "Anand Kumar" wrote: - Use spinlock instead of read/write lock for conntrack entry. - Use NdisInterlockedXX wrapper api's instead of Int

[ovs-dev] [PATCH v1 0/4] Optimize conntrack performance

2018-06-17 Thread Anand Kumar
This patch series is primarily to refactor conntrack code for better throughput with conntrack. With this patch series TCP throughput with conntrack increased by ~50%. Testing: Verified loading/unloading the driver with driver verified enabled. Ran TCP/UDP and ICMP traffic. Anand Kumar (4): da

[ovs-dev] [PATCH v4 4/4] datapath-windows: Compute ct hash based on 5-tuple and zone

2018-06-17 Thread Anand Kumar
Conntrack 5-tuple consists of src address, dst address, src port, dst port and protocol which will be unique to a ct session. Use this information along with zone to compute hash. Also re-factor conntrack code related to parsing netlink attributes. Signed-off-by: Anand Kumar --- datapath-window

[ovs-dev] [PATCH v4 1/4] datapath-windows: Use spinlock instead of RW lock for ct entry

2018-06-17 Thread Anand Kumar
This patch mainly changes a ndis RW lock for conntrack entry to a spinlock along with some minor refactor in conntrack. Using spinlock instead of RW lock as RW locks causes performance hits when acquired/released multiple times. - Use NdisInterlockedXX wrapper api's instead of InterlockedXX. - Upd

[ovs-dev] [PATCH v4 2/4] datapath-windows: Remove NAT locks in conntrack.

2018-06-17 Thread Anand Kumar
This patch primarily gets rid of NdisRWLock in conntrack for NAT functionality along with some conntrack optimization. The subsequent patch will have a lock implementation inside NAT module. - Introduce a new function OvsGetTcpHeader() to retrieve TCP header and payload length, to optimize for T

[ovs-dev] [PATCH v4 3/4] datapath-windows: Implement locking in conntrack NAT.

2018-06-17 Thread Anand Kumar
The 'ovsNatTable' and 'ovsUnNatTable' tables are shared between cleanup threads and packet processing thread. In order to protect these two tables use a spinlock. Also introduce counters to track number of nat entries. Signed-off-by: Anand Kumar --- datapath-windows/ovsext/Conntrack-nat.c | 27