Re: [ovs-dev] 64Byte packet performance regression on 2.9 from 2.7

2018-07-02 Thread Nitin Katiyar
Hi, I had tested 2.8.1/2 earlier which uses 17.05.01 or 17.05.02 and found around 10% drop for udp traffic. OVS 2.7.4 gave the similar result as OVS 2.6.2 (DPDK 16.11.4). I was using Intel Niantic 82599 for testing. Regards, Nitin -Original Message- From: Ilya Maximets [mailto:i.maxim..

[ovs-dev] LET'S DO THIS.

2018-07-02 Thread Y.T. Chan
Compliments!! I have access to very vital information that can be used to move huge amount of money. I have done my homework very well and I have the machineries in place to get it done since I am still in active service. If it was possible for me to do it alone I would not have bothered contac

Re: [ovs-dev] [ovs-dev, RFC] OVN: native support for tunnel encryption

2018-07-02 Thread 0-day Robot
Bleep bloop. Greetings Qiuyu Xiao, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: No signatures found. Lines checked: 237, Warnings: 0, Errors: 1 Please check this out.

[ovs-dev] [RFC PATCH] OVN: native support for tunnel encryption

2018-07-02 Thread Qiuyu Xiao
This patch adds IPsec support for OVN tunnel. Basically, OVN offers a binary option to its user for encryption configuration. If the IPsec option is turned on, all tunnels will be encrypted. Otherwise, no tunnel will be encrypted. The changes are summarized as below: 1) Added a ipsec column on the

[ovs-dev] [PATCH] release-process.rst: Add "soft freeze" stage.

2018-07-02 Thread Ben Pfaff
The last few OVS releases have included a "soft freeze" stage in the release process, but this stage has never been formalized in the documentation. This adds a description. Signed-off-by: Ben Pfaff --- Documentation/internals/release-process.rst | 87 - 1 file chang

[ovs-dev] [PATCH 00/23] Don't use ctl_fatal() in command handlers from db-ctl-base

2018-07-02 Thread Jakub Sitnicki
This patch series is preparatory work for turning any of the tools from db-ctl family (ovs-vsctl, vtep-ctl, ovn-nbctl, or ovn-sbctl) into a long-lived server/daemon that processes database commands on client request. The goal of this patch set it to prevent dying (terminating the process) when run

[ovs-dev] [PATCH 00/23] Don't use ctl_fatal() in command handlers from db-ctl-base

2018-07-02 Thread Jakub Sitnicki
This patch series is preparatory work for turning any of the tools from db-ctl family (ovs-vsctl, vtep-ctl, ovn-nbctl, or ovn-sbctl) into a long-lived server/daemon that processes database commands on client request. The goal of this patch set it to prevent dying (terminating the process) when run

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 17.11.3 release.

2018-07-02 Thread Flavio Leitner
On Wed, Jun 20, 2018 at 10:39:46AM +0100, Ian Stokes wrote: > Modify travis linux build script to use the latest > DPDK stable release 17.11.3. Update docs for latest > DPDK stable releases. > > Signed-off-by: Ian Stokes > --- > .travis/linux-build.sh | 2 +- > Documentation/fa

[ovs-dev] [PATCH v2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-02 Thread nusiddiq
From: Numan Siddique Calling ovs.stream.open_block(ovs.stream.open("tcp:127.0.0.1:6641")) returns success even if there is no server listening on 6641. To check if the connection is established or not, Stream class makes use of ovs.socket_util.check_connection_completion(). This function returns

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-07-02 Thread Lam, Tiago
On 25/06/2018 13:15, Anju Thomas wrote: > Hi Ben, > > We are facing multiple such crashes on different computes in our deployments. > Seems to be a pretty common problem in our setup. As you suggested, it would > be good if we can make the below changes as well.How do you suggest we > move

Re: [ovs-dev] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-02 Thread Numan Siddique
On Mon, Jul 2, 2018, 10:25 PM 0-day Robot wrote: > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > Thanks Robot. I thought I fixed this issue. L

Re: [ovs-dev] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-02 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/build-aux/missing autom4te --lang

Re: [ovs-dev] 64Byte packet performance regression on 2.9 from 2.7

2018-07-02 Thread Ilya Maximets
Sure, you need to collect perf records for the same binary, i.e. built with the same compiler options (and on the same machine), to make them useful. Unfortunately, I have no setup to test your case right now. Data for 2.8 could help bisecting the issue. On 02.07.2018 18:04, Shahaji Bhosle wrote:

[ovs-dev] OVS frozen for release

2018-07-02 Thread Ben Pfaff
According to our release process, we should fork branch-2.10 from master July 1 (yesterday), then release on August 15. I'm going to propose that we modify this in the same way that has been successful in the past, by calling for an approximately 2-week "soft freeze". During the freeze period, we

Re: [ovs-dev] OVS-DPDK public meeting

2018-07-02 Thread Vishal Deep Ajmera
Hi, Awaiting comments on "dpif-netdev: Avoid reordering of packets in a batch with same megaflow". Did anyone tried and see any issues ? Warm Regards, Vishal Ajmera > -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Kevin Traynor > Sent:

[ovs-dev] [PATCH] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-07-02 Thread nusiddiq
From: Numan Siddique Calling ovs.stream.open_block(ovs.stream.open("tcp:127.0.0.1:6641")) returns success even if there is no server listening on 6641. To check if the connection is established or not, Stream class makes use of ovs.socket_util.check_connection_completion(). This function returns

[ovs-dev] [PATCH] OVN: add ICMPv6 time exceeded support to OVN logical router

2018-07-02 Thread Lorenzo Bianconi
Using icmp6 action, send an ICMPv6 time exceeded frame whenever an OVN logical router receives an IPv6 packets whose TTL has expired (ip.ttl == {0, 1}) Signed-off-by: Lorenzo Bianconi --- ovn/northd/ovn-northd.8.xml | 12 +++- ovn/northd/ovn-northd.c | 31

Re: [ovs-dev] 64Byte packet performance regression on 2.9 from 2.7

2018-07-02 Thread Shahaji Bhosle via dev
Hi Ilya, Thanks for the reply. For performance traffic testing we are running with -O2. You are right about the perf report, when were running with perf record we had set "-g -O0". Do you need us to run with just "-g -O2" and give you the profile, or any other optimization setting. Do you have a te

Re: [ovs-dev] 64Byte packet performance regression on 2.9 from 2.7

2018-07-02 Thread Ilya Maximets
Hi. Sorry for late response. Looking at your perf data, I see functions like "dp_packet_batch_size" consuming ~0.5 - 0.7 % of time. Are you building with all compiler optimizations disabled? Otherwise where should be no such symbols in perf report. They should be completely inlined. Best regards,

Re: [ovs-dev] [PATCH 01/23] db-ctl-base: Don't die in parse_column_names() on error.

2018-07-02 Thread Mark Michelson
Hi Jakub, Your cover letter still hasn't come through, so feel free to tell me if my comments here are misguided. I'm guessing that you did not remove ctl_fatal() calls from parse_commands() and ctl_parse_commands() because there is no ctl_context present. However, it's not clear why the ctl

Re: [ovs-dev] [PATCH 07/23] db-ctl-base: Don't die in get_row_by_id() on multiple matches.

2018-07-02 Thread Mark Michelson
I'm not sure why you went with a different approach on this compared to the other functions. I would have expected you would change get_row_by_id() to return a string (NULL if no error, otherwise an error string). Then return the row as an output parameter. On 07/02/2018 06:50 AM, Jakub Sitnic

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Fix probing multi mask per prio

2018-07-02 Thread Simon Horman
On Mon, Jul 02, 2018 at 12:07:58PM +0300, Roi Dayan wrote: > When adding TC rules we save the prio so can reuse same prio > for same mask since different mask will have to use different prio. > The multi mask per prio probe broke this by using a prio but > get_prio_for_tc_flower() didn't know about

Re: [ovs-dev] [PATCH] rconn: Suppress 'connected' log for unreliable connections.

2018-07-02 Thread Ilya Maximets
So, what about this patch? Best regards, Ilya Maximets. On 20.06.2018 10:44, Ilya Maximets wrote: > Recent assertion failure fix changed rconn workflow for unreliable > connections (such as connections from ovs-ofctl) from > > |rconn|DBG|br-int<->unix#151: entering ACTIVE > |rconn|DBG|br

[ovs-dev] [PATCH] utilities: Add upcall related commands to the GDB script

2018-07-02 Thread Eelco Chaudron
This commit adds ovs_dump_udpif_keys and ovs_show_upcall commands to the GDB script. Here are some examples of the output: (gdb) ovs_show_upcall netdev@ovs-netdev: flows : (current 0) (avg 0) (max 0) (limit 1) dump duration : 1ms ufid enabled : true 39: (keys 0) 42: (keys

Re: [ovs-dev] [ovs-dev, 01 of 23] db-ctl-base: Don't die in parse_column_names() on error.

2018-07-02 Thread Jakub Sitnicki
On Mon, 2 Jul 2018 06:55:57 -0400 0-day Robot wrote: > Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > WARNING: Line is 80

Re: [ovs-dev] [ovs-dev, 01 of 23] db-ctl-base: Don't die in parse_column_names() on error.

2018-07-02 Thread 0-day Robot
Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #62 FILE: lib/db-ctl-base.c:988

[ovs-dev] [PATCH 23/23] db-ctl-base: Don't die in cmd_destroy() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error via the context instead of calling ctl_fatal() so that the caller can decide how to handle it. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index f5492aadb..b

[ovs-dev] [PATCH 22/23] db-ctl-base: Don't die in cmd_clear() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error via the context instead of calling ctl_fatal() so that the caller can decide how to handle it. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 585cf67a0..f549

[ovs-dev] [PATCH 21/23] db-ctl-base: Don't die in cmd_remove() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error via the context instead of calling ctl_fatal() so that the caller can decide how to handle it. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 7c1e10373..

[ovs-dev] [PATCH 20/23] db-ctl-base: Don't die in cmd_get() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error via the context instead of calling ctl_fatal() so that the caller can decide how to handle it. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c ind

[ovs-dev] [PATCH 19/23] db-ctl-base: Kill die_if_error() helper.

2018-07-02 Thread Jakub Sitnicki
All users are gone. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 8 1 file changed, 8 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index d3ca4ca70..c670236da 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -186,14 +186,6 @@ print_command_arguments(

[ovs-dev] [PATCH 16/23] db-ctl-base: Fix resource deallocation on error path in cmd_get().

2018-07-02 Thread Jakub Sitnicki
Release resources now that we are returning to the caller on error. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 2fff7127b..8d4799433 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -

[ovs-dev] [PATCH 18/23] db-ctl-base: Fix resource deallocation on error path in cmd_find().

2018-07-02 Thread Jakub Sitnicki
Release resources now that we are returning to the caller on error. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 5f386cab5..d3ca4ca70 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -

[ovs-dev] [PATCH 17/23] db-ctl-base: Fix resource deallocation on error path in cmd_list().

2018-07-02 Thread Jakub Sitnicki
Release resources now that we are returning to the caller on error. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 8d4799433..5f386cab5 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -

[ovs-dev] [PATCH 14/23] db-ctl-base: Extend ctl_context with an error message.

2018-07-02 Thread Jakub Sitnicki
Prepare for the command handlers (pre_cmd_*() cmd_*() functions) to report errors by storing them in the context. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 22 ++ lib/db-ctl-base.h | 3 +++ ovn/utilities/ovn-nbctl.c | 9 + ovn/utilities/o

[ovs-dev] [PATCH 15/23] db-ctl-base: Stop using die_if_error().

2018-07-02 Thread Jakub Sitnicki
Propagate the error via the context for the caller to handle it. Result of applying the following semantic patch (Coccinelle): @@ expression s; @@ - die_if_error(s); + ctx->error = s; + if (ctx->error) { + return; + } Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 294 ++

[ovs-dev] [PATCH 13/23] db-ctl-base: Don't die in ctl_set_column() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 19 ++- lib/db-ctl-base.h | 5 ++--- ovn/utilities/ov

[ovs-dev] [PATCH 12/23] db-ctl-base: Don't die in pre_list_columns() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/db

[ovs-dev] [PATCH 11/23] db-ctl-base: Don't die in pre_parse_column_key_value() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Also, we no longer return the column as it was not used by any of existing callers. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 2

[ovs-dev] [PATCH 10/23] db-ctl-base: Don't die in pre_get_table() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-

[ovs-dev] [PATCH 09/23] db-ctl-base: Don't die in pre_get_column() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/li

[ovs-dev] [PATCH 08/23] db-ctl-base: Don't die in ctl_get_row() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 49 +++ lib/db-ctl-base.h

[ovs-dev] [PATCH 06/23] db-ctl-base: Don't die in create_symbol() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --

[ovs-dev] [PATCH 07/23] db-ctl-base: Don't die in get_row_by_id() on multiple matches.

2018-07-02 Thread Jakub Sitnicki
Signal that multiple rows match the record identifier via a new output parameter instead of reporting the problem and dying, so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 23 ++- 1 file

[ovs-dev] [PATCH 05/23] db-ctl-base: Don't die in set_column() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 61 +-- 1 file changed, 41 inserti

[ovs-dev] [PATCH 04/23] db-ctl-base: Don't die in check_mutable() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/l

[ovs-dev] [PATCH 02/23] db-ctl-base: Don't die in get_table() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 51 +-- 1 file changed, 29 insertions(

[ovs-dev] [PATCH 03/23] db-ctl-base: Don't die in is_condition_satisfied() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Also, rename the function as it is no longer a typical predicate, so that the users don't assume that the result is passed in return value. S

[ovs-dev] [PATCH 01/23] db-ctl-base: Don't die in parse_column_names() on error.

2018-07-02 Thread Jakub Sitnicki
Return the error message to the caller instead of reporting it and dying so that the caller can handle the error without terminating the process if needed. Signed-off-by: Jakub Sitnicki --- lib/db-ctl-base.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a

[ovs-dev] [PATCH] netdev-tc-offloads: Fix probing multi mask per prio

2018-07-02 Thread Roi Dayan
When adding TC rules we save the prio so can reuse same prio for same mask since different mask will have to use different prio. The multi mask per prio probe broke this by using a prio but get_prio_for_tc_flower() didn't know about it. Also multi mask per prio support changes the hash calculation.

Re: [ovs-dev] [PATCH] lib: Add initalize when xmalloc ofproto: Add initalize when recv from sdn controller

2018-07-02 Thread 孙文杰
Hi,by our talking before the memory issue ,could you provide the fixed patch? 孙文杰 于2018年6月19日 周二10:25写道: > We use ovs 2.9.0. > > Ben Pfaff 于2018年6月16日周六 上午2:24写道: > >> [Dropping invalid email address findtheonly...@example.com.] >> >> Thanks. >> >> I believe that we've found and fixed related me