Re: [ovs-dev] [PATCH] ofproto: Return error codes for Rule insertions

Hi Ben/Aaron/All, Kindly review the patch and let me know your views. On Thu, Jul 12, 2018 at 11:34 PM, Aravind Prasad S wrote: > Currently, rule_insert() API does not have return value. There are some > possible > scenarios where rule insertions can fail at run-time even though the static >

[ovs-dev] [patch v8 9/9] ipf: Add fragmentation status reporting.

A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status, fragment counters and ipf lists state. Signed-off-by: Darrell Ball --- NEWS | 2 + lib/ct-dpif.c

[ovs-dev] [patch v8 8/9] ipf: Add set maximum fragments supported command.

A new command "ovs-appctl dpctl/ipf-set-max-nfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 30

[ovs-dev] [patch v8 5/9] Userspace datapath: Add fragmentation handling.

Fragmentation handling is added for supporting conntrack. Both v4 and v6 are supported. After discussion with several people, I decided to not store configuration state in the database to be more consistent with the kernel in future, similarity with other conntrack configuration which will not be

[ovs-dev] [patch v8 7/9] ipf: Add set minimum fragment size command.

A new command "ovs-appctl dpctl/ipf-set-min-frag" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 2 ++ lib/dpctl.c | 40

[ovs-dev] [patch v8 6/9] ipf: Add command to disable fragmentation handling.

Commands are added to disable and also enable fragmentation handling for conntrack. Signed-off-by: Darrell Ball --- NEWS| 4 lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 50 ++

[ovs-dev] [patch v8 4/9] conntrack: Reword conntrack_execute() description.

Use 'must' instead of 'should'. Signed-off-by: Darrell Ball --- lib/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 682feb9..3f50fc8 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1294,7 +1294,7 @@

[ovs-dev] [patch v8 3/9] tests: Add missed local stack checks.

Signed-off-by: Darrell Ball Acked-by: Justin Pettit --- tests/system-traffic.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index cbd9542..43a104d 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2530,6 +2530,7 @@

[ovs-dev] [patch v8 2/9] flow: Enhance parse_ipv6_ext_hdrs.

Enhance the api parse_ipv6_ext_hdrs to return the fragmentation header to be used in later patches. Signed-off-by: Darrell Ball Acked-by: Justin Pettit --- lib/conntrack.c | 4 ++-- lib/flow.c | 31 +-- lib/flow.h | 3 ++- 3 files changed, 25

[ovs-dev] [patch v8 1/9] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball Acked-by: Justin Pettit --- lib/dp-packet.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index ba91e58..ecf16fb 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@

[ovs-dev] [patch v8 0/9] Userspace datapath: Add fragmentation support.

Fragmentation support for userspace datapath conntrack is added; both v4 and v6 are supported. See the patches for additional details. Fragmentation tests for the userspace datapath are enabled by the patches and other test enhancements are added. v7->v8: Fix argument index (-1 vs -2) for

[ovs-dev] [PATCH v3 4/4] Add support to offload QinQ double VLAN headers match

Currently the inner VLAN header is ignored when using the TC data-path. As TC flower supports QinQ, now we can offload the rules to match on both outer and inner VLAN headers. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- acinclude.m4 | 6 ++--- include/linux/pkt_cls.h |

[ovs-dev] [PATCH v3 3/4] flow: Refactor some of VLAN helper functions

By default, these function are to change the first vlan vid and pcp in the flow. Add a parameter as index for vlans if we want to handle the second ones. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 4 ++-- lib/flow.c | 14 +++---

[ovs-dev] [PATCH v3 1/4] tc: Add VLAN tpid for push action

Currently we only support 802.1q, so we can offload push action without specifying any vlan type. Kernel will push 802.1q ethertype by default. But to support QinQ, we need to tell what ethertype is in push action as it could be 802.1ad. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan ---

[ovs-dev] [PATCH v3 2/4] netdev-tc-offloads: Add support to match on 802.1AD ethertype

Currently, we assume VLAN ethtertype is 0x8100, but it could be 0x88a8 if QinQ is supported. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 6 +++--- lib/tc.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH v3 0/4] Add support to offload QinQ

This patchset is to support QinQ offloading, as TC flower supports QinQ. v3: fix checkpatch warning in patch 4. v2: fix compile issue in patch 3. Jianbo Liu (4): tc: Add VLAN tpid for push action netdev-tc-offloads: Add support to match on 802.1AD ethertype flow: Refactor some of

[ovs-dev] [PATCH 4/4] datapath: Don't swap table in nlattr_set() after OVS_ATTR_NESTED is found

From: Stefano Brivio Upstream commit: commit 72f17baf2352ded6a1d3f4bb2d15da8c678cd2cb Author: Stefano Brivio Date: Thu May 3 18:13:25 2018 +0200 openvswitch: Don't swap table in nlattr_set() after OVS_ATTR_NESTED is found If an OVS_ATTR_NESTED attribute type is found

[ovs-dev] [PATCH 3/4] datapath: NAT support for shifted portmap ranges

This patch backports the following upstream commit from net-next, and defines HAVE_NF_NAT_RANGE2 to determine whether to use 'struct nf_nat_range2'. Upstream commit: commit 2eb0f624b709e78ec8e2f4c3412947703db99301 Author: Thierry Du Tre Date: Wed Apr 4 15:38:22 2018 +0200

[ovs-dev] [PATCH 2/4] datapath: Introduce net_rwsem and remove rtnl_lock()

This patch backports the following two upstream commits and add a new symbol HAVE_NET_RWSEM in acinclude.m4 to determine whether to use new introduced rw_semaphore, net_rwsem. Upstream commit: commit f0b07bb151b098d291fd1fd71ef7a2df56fb124a Author: Kirill Tkhai Date: Thu Mar 29

[ovs-dev] [PATCH 1/4] datapath: meter: fix the incorrect calculation of max delta_t

From: zhangliping Upstream commit: commit ddc502dfed600bff0b61d899f70d95b76223fdfc Author: zhangliping Date: Fri Mar 9 10:08:50 2018 +0800 openvswitch: meter: fix the incorrect calculation of max delta_t Max delat_t should be the full_bucket/rate instead of the

[ovs-dev] [PATCH 0/4] Kernel backports from net-next

This patch series backports the following patches from net-next that modify ./net/openvswitch/* from the previous backport commit, 46e371f0 ("openvswitch: fix vport packet length check."). 1) b2d6cee1 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2) 72f17baf openvswitch: Don't

[ovs-dev] Comunicación en el entorno web

--- Este correo electrónico ha sido comprobado en busca de virus por AVG. http://www.avg.com ___ dev

Re: [ovs-dev] [branch-2.9] Revert "flow: Fix buffer overread for crafted IPv6 packets."

> On Jul 16, 2018, at 6:34 AM, Lucas Alvares Gomes > wrote: > > Thanks Justin, > > In networking-ovn (the OVN driver for OpenStack Neutron) we are seem > an IPv6 related test failure right now [0] and I can confirm that > after I've applied this patch locally and re-ran the test it works >

[ovs-dev] [patch v1] db-ctl-base: Fix build with gcc 7.3 with O3.

Signed-off-by: Darrell Ball --- lib/db-ctl-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index ab35d63..34fb836 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -1279,7 +1279,7 @@ cmd_find(struct ctl_context *ctx)

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

This occurs with O3 in gcc 6 It was previously fixed with commit bfd2c0eccedf024e2c2baaf8f43ad4d97480ea0d(ovn-nbctl: Always initialize output arguments in *_by_name_or_uuid().) On Sat, Jul 14, 2018 at 1:05 PM, Justin Pettit wrote: > Interesting. I don't see those errors with gcc 7.3.0. I

Re: [ovs-dev] [PATCH v3 00/17] Daemon mode for ovn-nbctl

I've had a look through again and this series addresses the findings I previously had, so in short: Acked-by: Mark Michelson I decided to do some testing to see what sort of performance gain we see with this patch. I'm attaching four scripts that I used for testing. In all of the tests, I

Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

Thanks. Looks good to me. Reviewed-by: Yifeng Sun On Thu, Jul 12, 2018 at 2:55 PM, Ben Pfaff wrote: > The macros are hard to read. This makes it a little more readable. > > Signed-off-by: Ben Pfaff > --- > configure.ac | 1 + > lib/netdev-dpdk.c | 235

Re: [ovs-dev] [PATCH 2/5] netdev-dpdk: Fix sparse complaints.

Thanks for the fix. I am wondering why there was no running issue when dl_type is compared with wrong byte order. Reviewed-by: Yifeng Sun On Thu, Jul 12, 2018 at 2:55 PM, Ben Pfaff wrote: > Neither of these is a real problem. > > Signed-off-by: Ben Pfaff > --- > lib/netdev-dpdk.c | 6 +++---

Re: [ovs-dev] [PATCH 1/5] netdev-dpdk: Fix incorrect byte order conversion in log message.

Thanks. Reviewed-by: Yifeng Sun On Thu, Jul 12, 2018 at 2:55 PM, Ben Pfaff wrote: > uint8_t values shouldn't be passed to ntohs(). > > Found by soarse. > > Signed-off-by: Ben Pfaff > --- > lib/netdev-dpdk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote: > > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote: > > From: Stefano Brivio > > > > Open vSwitch sends to userspace all received packets that have > > no associated flow (thus doing an "upcall"). Then the userspace > > program creates a

[ovs-dev] [PATCH V2] Documentation: Add netstat to testing instructions

Add netstat when mentioning testing. Many check-kmod failures result when it is not present. Signed-off-by: Greg Rose --- V2 - Fix commit title --- Documentation/intro/install/general.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/intro/install/general.rst

[ovs-dev] A few of your incoming messages has been suspended

Your Messages Has Been Suspended By Microsoft Outlook Team A few of your incoming messages has been suspended by microsoft verification Team because your email box account has not been properly verify. Do verify now to receive your suspended messages now.

Re: [ovs-dev] Conntrack performance drop in OVS 2.8

On Fri, Jun 29, 2018 at 2:29 AM, Nitin Katiyar wrote: > Hi, > The performance of OVS 2.8 (with DPDK 17.05.02) with conntrack > configuration has dropped significantly (especially for single flow case) > as compared to OVS 2.6 (with DPDK 16.11.4). > > Following is the comparison between 2.6.2 and

Re: [ovs-dev] [branch-2.9] Revert "flow: Fix buffer overread for crafted IPv6 packets."

It looks like the code flow ordering was changed recently by 62b0859dd89d(flow: Introduce IP packet sanity checks). -if (OVS_UNLIKELY(size < sizeof *nh)) { +if (OVS_UNLIKELY(!ipv6_sanity_check(nh, size))) { goto out; } -nh = data_pull(, , sizeof

Re: [ovs-dev] [ovs-dev, v2, 4 of 4] Add support to offload QinQ double VLAN headers match

Bleep bloop. Greetings Jianbo Liu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #117 FILE:

[ovs-dev] [PATCH v2 4/4] Add support to offload QinQ double VLAN headers match

Currently the inner VLAN header is ignored when using the TC data-path. As TC flower supports QinQ, now we can offload the rules to match on both outer and inner VLAN headers. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- acinclude.m4 | 6 ++--- include/linux/pkt_cls.h |

[ovs-dev] [PATCH v2 3/4] flow: Refactor some of VLAN helper functions

By default, these function are to change the first vlan vid and pcp in the flow. Add a parameter as index for vlans if we want to handle the second ones. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 4 ++-- lib/flow.c | 14 +++---

[ovs-dev] [PATCH v2 0/4] Add support to offload QinQ

This patchset is to support QinQ offloading, as TC flower supports QinQ. v2: fix compile issue in patch 3. Jianbo Liu (4): tc: Add VLAN tpid for push action netdev-tc-offloads: Add support to match on 802.1AD ethertype flow: Refactor some of VLAN helper functions Add support to

[ovs-dev] [PATCH v2 2/4] netdev-tc-offloads: Add support to match on 802.1AD ethertype

Currently, we assume VLAN ethtertype is 0x8100, but it could be 0x88a8 if QinQ is supported. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 6 +++--- lib/tc.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH v2 1/4] tc: Add VLAN tpid for push action

Currently we only support 802.1q, so we can offload push action without specifying any vlan type. Kernel will push 802.1q ethertype by default. But to support QinQ, we need to tell what ethertype is in push action as it could be 802.1ad. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan ---

Re: [ovs-dev] [branch-2.9] Revert "flow: Fix buffer overread for crafted IPv6 packets."

Thanks Justin, In networking-ovn (the OVN driver for OpenStack Neutron) we are seem an IPv6 related test failure right now [0] and I can confirm that after I've applied this patch locally and re-ran the test it works again. [0]

Re: [ovs-dev] [ovs-dev, v5] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

Comments inline. It'll be nice if you will add me in CC for the next versions. Thanks. Best regards, Ilya Maximets. On 11.07.2018 15:22, Vishal Deep Ajmera wrote: > OVS reads packets in batches from a given port and packets in the > batch are subjected to potentially 3 levels of lookups to

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix failure to configure flow control at netdev-init.

Regards _Sugesh > -Original Message- > From: Stokes, Ian > Sent: Monday, July 16, 2018 1:52 PM > To: Chandran, Sugesh ; ovs- > d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH] netdev-dpdk: Fix failure to configure flow > control > at netdev-init. > > > Hi Ian, > > > > Regards >

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix failure to configure flow control at netdev-init.

> Hi Ian, > > Regards > _Sugesh > > > -Original Message- > ... > > > make sure all the 'rte_eth_fc_conf' fields are populated with > > > default values before the dev init. > > > > > > > Thanks for the patch Sugesh, I've applied to dpdk_merge and it will be > > part of this weeks pull

[ovs-dev] Could you give me some help about how to add new match field in ovs?

Hi, I'm recently study openflow, I want to add a new match field, and add this new flow only from ofctl command, rather than through the controller, but when I add the code according to this page: http://docs.openvswitch.org/en/latest/faq/contributing/, I'm not sure if ovs switch could match

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix failure to configure flow control at netdev-init.

Hi Ian, Regards _Sugesh > -Original Message- ... > > make sure all the 'rte_eth_fc_conf' fields are populated with default > > values before the dev init. > > > > Thanks for the patch Sugesh, I've applied to dpdk_merge and it will be part of > this weeks pull request. > > I assume it

Re: [ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

Update: I fixed these errors in the attached patch that supersedes the patch here (https://patchwork.ozlabs.org/patch/942118/) The major change is that I add the following line for each fuzz target binary in the tests/oss-fuzz/automake.mk file: e.g., tests_oss_fuzz_flow_extract_target_LDFLAGS =

Re: [ovs-dev] [ovs-dev, 3 of 4] flow: Refactor some of VLAN helper functions

Bleep bloop. Greetings Jianbo Liu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I

[ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

When ovsdb-server is starting, it performs some DB steps such as creating and upgrading the OvS DB. When we are running as 'non-root' user, the 'runuser' tool is used to manage the privileges. However, when this happens during systemd boot, we observe the following errors in journald: Jun 21

[ovs-dev] [PATCH 2/4] netdev-tc-offloads: Add support to match on 802.1AD ethertype

Currently, we assume VLAN ethtertype is 0x8100, but it could be 0x88a8 if QinQ is supported. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 6 +++--- lib/tc.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH 0/4] Add support to offload QinQ

This patchset is to support QinQ offloading, as TC flower supports QinQ. Jianbo Liu (4): tc: Add VLAN tpid for push action netdev-tc-offloads: Add support to match on 802.1AD ethertype flow: Refactor some of VLAN helper functions Add support to offload QinQ double VLAN headers match

[ovs-dev] [PATCH 1/4] tc: Add VLAN tpid for push action

Currently we only support 802.1q, so we can offload push action without specifying any vlan type. Kernel will push 802.1q ethertype by default. But to support QinQ, we need to tell what ethertype is in push action as it could be 802.1ad. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan ---

[ovs-dev] [PATCH 4/4] Add support to offload QinQ double VLAN headers match

Currently the inner VLAN header is ignored when using the TC data-path. As TC flower supports QinQ, now we can offload the rules to match on both outer and inner VLAN headers. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- acinclude.m4 | 6 ++--- include/linux/pkt_cls.h |

[ovs-dev] [PATCH 3/4] flow: Refactor some of VLAN helper functions

By default, these function are to change the first vlan vid and pcp in the flow. Add a parameter as index for vlans if we want to handle the second ones. Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 4 ++-- lib/flow.c | 14 +++---

Re: [ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

Oops, here's the link failure log: ``` /usr/lib/gcc/x86_64-linux-gnu/5.4.0/../../../x86_64-linux-gnu/crt1.o: In function `_start': (.text+0x20): undefined reference to `main' clang-7: error: linker command failed with exit code 1 (use -v to see invocation) Makefile:4159: recipe for target

Re: [ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

Hi Ben, > Never mind that one, I failed to check in some of that. > > I sent it formally: > https://patchwork.ozlabs.org/patch/942118/ Thanks for the patch. This fixes the previous error. Now, there are some new errors during the compilation/linking process. I think most of this can be

Re: [ovs-dev] [PATCH v5 08/14] dp-packet: Handle multi-seg mbufs in resize__().

On 13/07/2018 18:54, Darrell Ball wrote: > Thanks for the patch. > > A few queries inline. > Hi Darrell, Thanks for your inputs. I've replied in-line as well. > On Wed, Jul 11, 2018 at 11:23 AM, Tiago Lam > wrote: > > When enabled with DPDK OvS relies on