Re: [ovs-dev] [ovs-discuss] ovsdb-server core dump and ovsdb corruption using raft cluster

2018-07-26 Thread Girish Moodalbail
Hello Ben, Sorry, got distracted with something else at work. I am still able to reproduce the issue, and this is what I have and what I did (if you need the core, let me know and I can share it with you) - 3-cluster RAFT setup in Ubuntu VM (2 VCPUs with 8GB RAM) $ uname -r Linux u1804-HVM-do

[ovs-dev] [PATCH] nx-match: Fix memory leak in oxm_pull_field_array() error case.

2018-07-26 Thread Ben Pfaff
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9424 Signed-off-by: Ben Pfaff --- lib/nx-match.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/nx-match.c b/lib/nx-match.c index 6b1b563ea7b0..3b030833cb2c 100644 --- a/lib/nx-match.c +++ b/lib/nx-ma

Re: [ovs-dev] [PATCH] compat: Allow IPv6 GRE/ERSPAN Tx when ip6_gre is loaded

2018-07-26 Thread Yifeng Sun
I tested and it fixed the loading issue on kernel 4.14. Thanks for the patch. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Thu, Jul 26, 2018 at 9:11 AM, Greg Rose wrote: > When for some reason the built-in kernel ip6_gre module is loaded that > would prevent the openvswitch kernel driver

Re: [ovs-dev] [PATCH 4/4] lib/tc: Support matching on ip tunnel tos and ttl

2018-07-26 Thread Or Gerlitz
On Thu, Jul 26, 2018 at 11:19 PM, Simon Horman wrote: > On Wed, Jul 25, 2018 at 09:20:09PM +0300, Or Gerlitz wrote: >> +++ b/lib/tc.c >> @@ -298,6 +298,10 @@ static const struct nl_policy tca_flower_policy[] = { >>.optional = true, }, >> [TCA_FLOWE

Re: [ovs-dev] [PATCH v2 1/2] ovsdb-idl: New function ovsdb_idl_create_unconnected().

2018-07-26 Thread Mark Michelson
Better late than never Acked-by: Mark Michelson On 06/18/2018 02:36 PM, Ben Pfaff wrote: This new function makes it possible to create an instance of the IDL without connecting it to a remote OVSDB server. The caller can then connect and disconnect using ovsdb_idl_set_remote(); the ability to

Re: [ovs-dev] [PATCH 1/4] lib/tc: Handle ttl for ipv6 too

2018-07-26 Thread Simon Horman
On Thu, Jul 26, 2018 at 05:54:51PM +0300, Or Gerlitz wrote: > On Thu, Jul 26, 2018 at 5:41 PM, Simon Horman > wrote: > > On Wed, Jul 25, 2018 at 09:20:06PM +0300, Or Gerlitz wrote: > >> TTL can and should be used to match on IPv6's hop-limit, fix that. > > >> Fixes: ab7ecf266b0a ('netdev-tc-offlo

Re: [ovs-dev] [PATCH 4/4] lib/tc: Support matching on ip tunnel tos and ttl

2018-07-26 Thread Simon Horman
On Wed, Jul 25, 2018 at 09:20:09PM +0300, Or Gerlitz wrote: > Support matching on tos and ttl of ip tunnels > for the TC data-path. > > Signed-off-by: Or Gerlitz > Reviewed-by: Roi Dayan > --- ... > diff --git a/lib/tc.c b/lib/tc.c > index aa3147f..f5901d1 100644 > --- a/lib/tc.c > +++ b/lib/t

Re: [ovs-dev] [PATCH] Introduce ovs-appctl command to monitor HVs sb connection status

2018-07-26 Thread Mark Michelson
Hi Lorenzo, I have some comments inline below. Also, I think there should be a test for this. You could start OVN, run `ovn-appctl -t ovn-controller connection-status` and make sure it returns "connected". Then you could run `ovn-sbctl set-connection random TCP port>`, and then ensure that whe

Re: [ovs-dev] The “overlay” mode issue while setting up OVS with DPDK

2018-07-26 Thread Sandeep Adapala
thanks a lot Guru you have been great help let me try this. On Thu, Jul 26, 2018 at 2:03 PM, Guru Shetty wrote: > I have a 2 node vagrant scripts in a private repo that I use to test the > Docker integration with OVN here: https://github.com/ > shettyg/ovn-docker/tree/master/vagrant_overlay > >

Re: [ovs-dev] The “overlay” mode issue while setting up OVS with DPDK

2018-07-26 Thread Guru Shetty
I have a 2 node vagrant scripts in a private repo that I use to test the Docker integration with OVN here: https://github.com/shettyg/ovn-docker/tree/master/vagrant_overlay I tested this again today with OVS 2.9.2 and the latest docker and it passes my sanity tests. If you have a mac and virtualbo

[ovs-dev] Can this marvell switch CPU connected SGMII ports be DPDK NIC binded ?

2018-07-26 Thread Kapil A
Hi, Need help in understanding the possibility of using DPDK on the attached product. In the attached product block diagram, there is a Marvel 88e6190 switch connected to Intel Denverton C3000 CPU through 2.5G SGMII ports. I want to lift all packets from Marvel 88e6190 and send it to CPU using th

Re: [ovs-dev] The “overlay” mode issue while setting up OVS with DPDK

2018-07-26 Thread Sandeep Adapala
After building the ovs also I get the same error Guru. On Wed, Jul 25, 2018 at 4:15 PM, Sandeep Adapala wrote: > After installing openvswitch-switch-dpdk I am getting this error. > > WARN[0041] Unable to locate plugin: openvswitch, retrying in 1s > WARN[0042] Unable to locate plugin: openvswit

[ovs-dev] [PATCH 7/7] ovsdb-tool: Only check leader completeness when we can, in "check-cluster".

2018-07-26 Thread Ben Pfaff
Generally when we know the leader for a term, in "check-cluster", it's because we read that leader's log file. In that case, we have the leader's log_end because it told us. However, taking a snapshot can discard that data. In that case, log_end is 0 and we should not try to check for leader com

[ovs-dev] [PATCH 6/7] ovsdb-tool: Check for duplicate server IDs in "check-cluster".

2018-07-26 Thread Ben Pfaff
The user shouldn't provide a given server's log more than once but this check makes sure. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-tool.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c index 6832ef7c17c0..8ac6a1b21670 100644 --- a/ovsdb/ovsdb-t

[ovs-dev] [PATCH 5/7] ovsdb-tool: Read server headers first, before full logs, in "check-cluster".

2018-07-26 Thread Ben Pfaff
Having the headers available before reading the complete logs means that server IDs can be associated with the server file names earlier, which can improve error messages in some cases. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-tool.c | 21 + 1 file changed, 13 insertions(+),

[ovs-dev] [PATCH 4/7] ovsdb-tool: Fix logic for displaying server names in "check-cluster".

2018-07-26 Thread Ben Pfaff
Without this patch, server names are displayed as UUIDs even when we know the file name; file names are easier for the user to read. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-tool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c index 5

[ovs-dev] [PATCH 3/7] tests: Suppress "long poll interval" messages for ovsdb-cluster tests.

2018-07-26 Thread Ben Pfaff
The cluster torture tests can provoke these messages, especially if run in parallel or with valgrind, and they shouldn't cause a failure. Signed-off-by: Ben Pfaff --- tests/ovsdb-cluster.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovsdb-cluster.at b/tests/ovs

[ovs-dev] [PATCH 1/7] tests: Fix cluster torture test.

2018-07-26 Thread Ben Pfaff
A previous commit to improve timing also caused the cluster torture test to be skipped (unless it failed early). This is related to the shell "while" loop's use of a variable $phase to indicate how far it got in the test procedure. A very fast machine, or one on which the races went just the righ

[ovs-dev] [PATCH 2/7] tests: Fix use of variable in cluster torture test.

2018-07-26 Thread Ben Pfaff
remove_server() is supposed to deal with its argument $i, not $victim. In this case they happen to have the same value so the difference is moot, but it's still best to be clear. Signed-off-by: Ben Pfaff --- tests/ovsdb-cluster.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[ovs-dev] [PATCH] compat: Allow IPv6 GRE/ERSPAN Tx when ip6_gre is loaded

2018-07-26 Thread Greg Rose
When for some reason the built-in kernel ip6_gre module is loaded that would prevent the openvswitch kernel driver from loading. Even when the built-in kernel ip6_gre module is loaded we can still perform port mirroring via Tx. Adjust the error handling and detect when the ip6_gre kernel module i

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

2018-07-26 Thread Justin Pettit
> On Jul 26, 2018, at 7:29 AM, Gavi Teitz wrote: > > From: Justin Pettit, sent: Thursday, July 26, 2018 12:02 AM: >> Commit ab15e70eb587 ("dpctl: Expand the flow dump type filter") had a number >> of issues with style, build breakage, and failing unit tests. >> The patch is being reverted so t

Re: [ovs-dev] [PATCH 1/4] lib/tc: Handle ttl for ipv6 too

2018-07-26 Thread Or Gerlitz
On Thu, Jul 26, 2018 at 5:41 PM, Simon Horman wrote: > On Wed, Jul 25, 2018 at 09:20:06PM +0300, Or Gerlitz wrote: >> TTL can and should be used to match on IPv6's hop-limit, fix that. >> Fixes: ab7ecf266b0a ('netdev-tc-offloads: Add nw_ttl matching using flower') >> Fixes: 0b4b5203d12e ('tc: Add

Re: [ovs-dev] [PATCH 2/4] lib/tc: Support matching on ip tos

2018-07-26 Thread Or Gerlitz
On Thu, Jul 26, 2018 at 5:44 PM, Simon Horman wrote: > On Wed, Jul 25, 2018 at 09:20:07PM +0300, Or Gerlitz wrote: >> Add the missing code to match on ip tos when dealing >> with the TC data-path. >> --- a/lib/netdev-tc-offloads.c >> +++ b/lib/netdev-tc-offloads.c >> @@ -455,6 +455,7 @@ parse_tc_

Re: [ovs-dev] [PATCH 2/4] lib/tc: Support matching on ip tos

2018-07-26 Thread Simon Horman
Hi Or, On Wed, Jul 25, 2018 at 09:20:07PM +0300, Or Gerlitz wrote: > Add the missing code to match on ip tos when dealing > with the TC data-path. > > Signed-off-by: Or Gerlitz > Reviewed-by: Roi Dayan > --- > include/openvswitch/match.h | 1 + > lib/match.c | 7 +++ > li

Re: [ovs-dev] [PATCH 1/4] lib/tc: Handle ttl for ipv6 too

2018-07-26 Thread Simon Horman
Hi Or, On Wed, Jul 25, 2018 at 09:20:06PM +0300, Or Gerlitz wrote: > TTL can and should be used to match on IPv6's hop-limit, fix that. > > Fixes: ab7ecf266b0a ('netdev-tc-offloads: Add nw_ttl matching using flower') > Fixes: 0b4b5203d12e ('tc: Add ip layer ttl matching') > Signed-off-by: Or Gerl

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

2018-07-26 Thread Gavi Teitz
From: Justin Pettit, sent: Thursday, July 26, 2018 12:02 AM: > Commit ab15e70eb587 ("dpctl: Expand the flow dump type filter") had a number > of issues with style, build breakage, and failing unit tests. > The patch is being reverted so that they can addressed. I acknowledge the build breakage is

Re: [ovs-dev] [PATCH v6 1/3] Avoid tunneling for VLAN packets redirected to a gateway chassis

2018-07-26 Thread Anil Venkata
Thanks Mark for the review. I will address the review comments. On Thu, Jul 19, 2018 at 6:54 PM, Mark Michelson wrote: > I've had a look through and have some notes in-line. I know some of them > will be a bit nit-picky, but...sometimes that's just how I am :) > > > On 06/25/2018 03:53 PM, vkomm

[ovs-dev] [PATCH 2/3] ovn-northd: Make use of svec for storing lists of addresses.

2018-07-26 Thread Jakub Sitnicki
Get rid of what is, esentially, an open-coded version of svec. Signed-off-by: Jakub Sitnicki --- ovn/northd/ovn-northd.c | 47 +++--- tests/ovn.at| 50 + 2 files changed, 65 insertions(+), 32 dele

[ovs-dev] [PATCH 3/3] ovn-northd: Propagate dynamic addresses to port group address sets.

2018-07-26 Thread Jakub Sitnicki
If a logical switch port belongs to a port group and has dynamic addresses assigned, propagate the addresses to the auto-generated address sets for the port group. Signed-off-by: Jakub Sitnicki --- ovn/northd/ovn-northd.c | 34 +++- tests/ovn.at| 59 ++

[ovs-dev] [PATCH 1/3] ovn-nbctl: Allow referring to port groups by name.

2018-07-26 Thread Jakub Sitnicki
Be user-friendly and allow using port group's name as its identifier in database commands. Signed-off-by: Jakub Sitnicki --- ovn/utilities/ovn-nbctl.c | 3 +++ tests/ovn-nbctl.at| 14 ++ 2 files changed, 17 insertions(+) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilitie

[ovs-dev] [PATCH 0/3] Port Group fixes

2018-07-26 Thread Jakub Sitnicki
This series addresses two issues noticed with Port Groups: (1) Port Group name cannot be used to refer to a row in NB DB. (2) LSP dynamic addresses don't get copied to port group address sets. The series depends on recent fixes for IPAM from Mark Michelson [1]. Thanks, Jakub [1] https://patchwo

Re: [ovs-dev] OVS-DPDK public meeting

2018-07-26 Thread Kevin Traynor
Next meeting: 8th August 16:00 UTC. Minutes of meeting Wed 25th July. Attendees: Flavio, Shahaf, Johann, Aaron, Thomas, Yipeng, Ian, Frikkie, Olga, Tiago, Simon, Sameh, Kevin === GENERAL === - OVS 2.10 -- Branch created Wednesday 25th -- Release targeted for 13th August -- Feature freeze

Re: [ovs-dev] [PATCH 1/1] ovn-nbctl: Initialize arguments to avoid compilation warnings.

2018-07-26 Thread Jakub Sitnicki
On Wed, 25 Jul 2018 15:00:43 +0100 Ian Stokes wrote: > Output arguments for parse_priority() and dhcp_options_get() may not be > initialized when either function returns an error. > > This causes compilation warnings for GCC 6.3.x regarding use of > uninitialized variable use and null-pointer-ar

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

2018-07-26 Thread Justin Pettit
> On Jul 25, 2018, at 11:29 PM, Simon Horman wrote: > > Sorry about this. I agree a revert was the correct course of action. Thanks. I pushed the series to master. --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/m