> > Currently, rule_insert() API does not have return value. There are
some possible
> > scenarios where rule insertions can fail at run-time even though the
static
> > checks during rule_construct() had passed previously.
> > Some possible scenarios for failure of rule insertions:
> > **) Rule
I have an check that I run before I run performance tests which sends a
ping along all of the paths that I run perf testing on. It runs `ping -q -c
1 -s 1472 -M do ` from every source to every destination running an
iperf server It passes. I've set the MTU on all our network devices to
Just for
Hello Ben/Guru,
Wanted to check if you were able to reproduce the issue on your end, and
whether you guys needed any more info from me.
If you guys have any patch, then we are more than happy to verify it.
regards,
~Girish
On Thu, Jul 26, 2018 at 11:14 PM, Girish Moodalbail
wrote:
> Hello
The debian packaging is the same as the packaging we previously had.
For debian package, I tested it by installing it in ubuntu 16.04 with
'dpkg -i'. For rpm package, I tested it by installing it in Fedora 27
with 'rpm -i'. Is there any standard method to test packaging?
Thanks,
Qiuyu
On Tue,
On Tue, Jul 31, 2018 at 12:43 PM, Matteo Croce wrote:
> On Mon, Jul 16, 2018 at 4:54 PM Matteo Croce wrote:
>>
>> On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote:
>> >
>> > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote:
>> > > From: Stefano Brivio
>> > >
>> > > Open vSwitch sends to
Bleep bloop. Greetings Qiuyu Xiao, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#141 FILE:
This looks good. Thanks for fixing them!
-Qiuyu
On Tue, Jul 31, 2018 at 3:29 PM, Ben Pfaff wrote:
> On Tue, Jul 31, 2018 at 02:08:49PM -0700, Qiuyu Xiao wrote:
>> This patch reintroduces ovs-monitor-ipsec daemon that
>> was previously removed by commit 2b02d770 ("openvswitch:
>> Allow external
On Tue, Jul 31, 2018 at 02:08:50PM -0700, Qiuyu Xiao wrote:
> Added rules and files to create debian and rpm ovs-ipsec packages.
>
> Signed-off-by: Qiuyu Xiao
> Signed-off-by: Ansis Atteka
> Co-authored-by: Ansis Atteka
Do you or Ansis test the packaging? (Or, for the Debian packaging, is
it
On Tue, Jul 31, 2018 at 02:08:49PM -0700, Qiuyu Xiao wrote:
> This patch reintroduces ovs-monitor-ipsec daemon that
> was previously removed by commit 2b02d770 ("openvswitch:
> Allow external IPsec tunnel management.")
>
> After this patch, there are no IPsec flavored tunnels anymore.
> IPsec is
On Tue, Jul 31, 2018 at 02:08:46PM -0700, Qiuyu Xiao wrote:
> This patch adds transport ports information for route lookup so that
> IPsec can select geneve tunnel traffic to do encryption.
>
> Signed-off-by: Qiuyu Xiao
> Reviewed-by: Greg Rose
> Tested-by: Greg Rose
Thanks. I'll hold off on
On Tue, Jul 31, 2018 at 02:08:48PM -0700, Qiuyu Xiao wrote:
> This patch adds transport ports information for route lookup so that
> IPsec can select stt tunnel traffic to do encryption.
>
> Signed-off-by: Qiuyu Xiao
> Reviewed-by: Greg Rose
> Tested-by: Greg Rose
Applied to master, thanks!
On Tue, Jul 31, 2018 at 02:08:47PM -0700, Qiuyu Xiao wrote:
> This patch adds transport ports information for route lookup so that
> IPsec can select vxlan tunnel traffic to do encryption.
>
> Signed-off-by: Qiuyu Xiao
> Reviewed-by: Greg Rose
> Tested-by: Greg Rose
Applied to master, thanks!
On Thu, Jul 05, 2018 at 02:31:00PM -0700, Ben Pfaff wrote:
> The last few OVS releases have included a "soft freeze" stage in the
> release process, but this stage has never been formalized in the
> documentation. This adds a description.
>
> Signed-off-by: Ben Pfaff
> Acked-by: Ian Stokes
>
On Tue, Jul 31, 2018 at 07:43:34PM +, Matteo Croce wrote:
> On Mon, Jul 16, 2018 at 4:54 PM Matteo Croce wrote:
> >
> > On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote:
> > >
> > > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote:
> > > > From: Stefano Brivio
> > > >
> > > > Open
All the users of mf_vl_mff_mf_from_nxm_header() expect it to always obtain
a valid field or to report an error. In practice, it did not report an
error in the case where the field was unknown (although it did report an
error in some other cases). This commit fixes the problem.
Reported-at:
On Tue, Jul 31, 2018 at 01:40:35PM +0300, Or Gerlitz wrote:
> This series comes to address the case to set (encap) and match (decap)
> also the tos and ttl fields of TC based IP tunnels. This happens e.g
> due to inherit setup of tunnel port for tos or due to specific OF rule.
>
> The series is
This patch adds step-by-step guide for configuring OVN Role-Based Access
Control and IPsec.
Signed-off-by: Qiuyu Xiao
---
Documentation/automake.mk | 2 +
Documentation/tutorials/index.rst | 2 +
Documentation/tutorials/ovn-ipsec.rst | 144 ++
tutorials/index.rst gives a step-by-setp guide to set up OVS IPsec
tunnel.
tutorials/ipsec.rst gives detailed explanation on the IPsec tunnel
configuration methods and forwarding modes.
Signed-off-by: Qiuyu Xiao
Signed-off-by: Ansis Atteka
Co-authored-by: Ansis Atteka
---
This patch adds IPsec support for OVN tunnel. Basically, OVN offers a
binary option to its user for encryption configuration. If the IPsec
option is turned on, all tunnels will be encrypted. Otherwise, no tunnel
will be encrypted.
The changes are summarized as below:
1) Added a ipsec column on
This patch modifies ovs-pki to generate x.509 version 3 certificate.
Compared with the x.509 v1 certificate generated by ovs-pki, version 3
certificate adds subjectAltName field and sets its value the same as
common name (CN). The main reason for this change is to enable
strongSwan IKE daemon to
Added rules and files to create debian and rpm ovs-ipsec packages.
Signed-off-by: Qiuyu Xiao
Signed-off-by: Ansis Atteka
Co-authored-by: Ansis Atteka
---
debian/automake.mk| 3 +
debian/control| 21 ++
This patch reintroduces ovs-monitor-ipsec daemon that
was previously removed by commit 2b02d770 ("openvswitch:
Allow external IPsec tunnel management.")
After this patch, there are no IPsec flavored tunnels anymore.
IPsec is enabled by setting up the right values in:
1. OVSDB:Interface:options
This patch adds transport ports information for route lookup so that
IPsec can select stt tunnel traffic to do encryption.
Signed-off-by: Qiuyu Xiao
Reviewed-by: Greg Rose
Tested-by: Greg Rose
---
datapath/linux/compat/stt.c | 15 ++-
1 file changed, 10 insertions(+), 5
This patch adds transport ports information for route lookup so that
IPsec can select vxlan tunnel traffic to do encryption.
Signed-off-by: Qiuyu Xiao
Reviewed-by: Greg Rose
Tested-by: Greg Rose
---
datapath/linux/compat/vxlan.c | 14 --
1 file changed, 12 insertions(+), 2
This patch adds transport ports information for route lookup so that
IPsec can select geneve tunnel traffic to do encryption.
Signed-off-by: Qiuyu Xiao
Reviewed-by: Greg Rose
Tested-by: Greg Rose
---
datapath/linux/compat/geneve.c | 29 +++--
1 file changed, 19
This patch series reintroduce IPsec support for OVS tunneling and enable OVN to
use IPsec tunnels. GRE, VXLAN, GENEVE, and STT IPsec tunnels are supported.
StrongSwan and LibreSwan IKE daemons are supported.
Changes from v1 to v2
-
1. Merge the ovs-monitor-ipsec code to a
On Sat, Jul 21, 2018 at 09:22:06AM +0530, Aravind Prasad wrote:
> > Currently, rule_insert() API does not have return value. There are some
> > possible
> > scenarios where rule insertions can fail at run-time even though the static
> > checks during rule_construct() had passed previously.
> >
On Mon, Jul 30, 2018 at 10:47:18PM -0700, Martin Xu wrote:
> As part of "force-reload-kmod," conntrack flush command is issued as
> 'action "ovs-appctl dpctl/flush-conntrack"'. In case no datapath exists
> yet when issuing "force-reload-kmod," there is an error message
> "ovs-vswitchd: no
void functions do not need to have a return statement, because
such statements are redundant. Warn the user of such instances.
An interim line check is added to allow gathering additional
context for each line that is being processed.
Signed-off-by: Bala Sankaran
---
utilities/checkpatch.py |
On Tue, Jul 31, 2018 at 04:25:32PM -0400, Aaron Conole wrote:
> Justin Pettit writes:
>
> >> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote:
> >>
> >> The 0-day Robot needs to lay off the pipe.
> >
> > Yeah, I'm not sure what was happening there. I emailed Aaron about it.
>
> Sorry about
On Tue, Jul 31, 2018 at 04:01:47PM -0400, Aaron Conole wrote:
> Timothy Redaelli writes:
>
> > The new 'map' action is needed for 'hugetlbfs_t:file' too.
> >
> > CC: Aaron Conole
> > Fixes: d2675a146130 ("selinux: changes to support newer hugetlbfs
> > restrictions")
> >
> > Signed-off-by:
On Tue, Jul 31, 2018 at 01:35:33PM -0700, Ben Pfaff wrote:
> On Tue, Jul 31, 2018 at 04:01:47PM -0400, Aaron Conole wrote:
> > Timothy Redaelli writes:
> >
> > > The new 'map' action is needed for 'hugetlbfs_t:file' too.
> > >
> > > CC: Aaron Conole
> > > Fixes: d2675a146130 ("selinux: changes
Signed-off-by: Ben Pfaff
---
lib/pcap-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/pcap-file.c b/lib/pcap-file.c
index 981d56d48830..ea5cfa3b274e 100644
--- a/lib/pcap-file.c
+++ b/lib/pcap-file.c
@@ -163,7 +163,7 @@ ovs_pcap_read(FILE *file, struct dp_packet
Reported-by: Oscar Wilde
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047070.html
Signed-off-by: Ben Pfaff
---
AUTHORS.rst | 1 +
utilities/ovs-ofctl.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/AUTHORS.rst b/AUTHORS.rst
index
Justin Pettit writes:
>> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote:
>>
>> The 0-day Robot needs to lay off the pipe.
>
> Yeah, I'm not sure what was happening there. I emailed Aaron about it.
Sorry about that. I'll work on protecting the list for when the robot
indulges in
Thanks.
I applied this patch to master.
On Wed, Jul 18, 2018 at 10:13:05AM -0700, Yifeng Sun wrote:
> Sorry I made a mistake in the previous review. Operator '||' has higher
> precedence
> than operator '?:'. So the patch is correct.
>
> Thanks,
> Yifeng
>
> On Tue, Jul 17, 2018 at 1:57 PM,
Ben Pfaff writes:
> Today we've seen some failure reports from the robot because the build
> was broken on master. That will happen occasionally (often, as in this
> case, because the robot uses a GCC version different from the
> submitter). Maybe the robot should even report it, probably in a
On Wed, Jul 18, 2018 at 10:34:37AM -0700, William Tu wrote:
> On Wed, Jul 18, 2018 at 9:22 AM, Greg Rose wrote:
> > Upstream commit:
> > Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not
> > handled. BSO has 4 possible values:
> > 00 --> Good frame with no error, or
On Wed, Jul 18, 2018 at 11:43:10AM -0400, Aaron Conole wrote:
> Greg Rose writes:
>
> > Add netstat when mentioning testing. Many check-kmod failures result
> > when it is not present.
> >
> > Signed-off-by: Greg Rose
> >
> > ---
>
> Acked-by: Aaron Conole
Thanks Greg and Aaron. Applied to
On Fri, Jul 27, 2018 at 01:43:54PM -0700, Gregory Rose wrote:
> On 7/27/2018 9:30 AM, William Tu wrote:
> >When loading compact ip6 tunnel, if the system already loads upstream
> s/compact/compat/
>
> >kernel's ip6 tunnel, print error message before return.
> >
> >Signed-off-by: William Tu
>
Timothy Redaelli writes:
> The new 'map' action is needed for 'hugetlbfs_t:file' too.
>
> CC: Aaron Conole
> Fixes: d2675a146130 ("selinux: changes to support newer hugetlbfs
> restrictions")
>
> Signed-off-by: Timothy Redaelli
> ---
Good catch.
Acked-by: Aaron Conole
I don't understand the conclusion in this thread. Does anyone want me
to apply some patch? Or should I stay tuned for further discussion?
Thanks,
Ben.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Today we've seen some failure reports from the robot because the build
was broken on master. That will happen occasionally (often, as in this
case, because the robot uses a GCC version different from the
submitter). Maybe the robot should even report it, probably in a
general email to the list
On Thu, Jul 26, 2018 at 10:05:01AM +0200, Jakub Sitnicki wrote:
> On Wed, 25 Jul 2018 15:00:43 +0100
> Ian Stokes wrote:
>
> > Output arguments for parse_priority() and dhcp_options_get() may not be
> > initialized when either function returns an error.
> >
> > This causes compilation warnings
On Tue, Jul 31, 2018 at 05:35:00PM +0200, Lorenzo Bianconi wrote:
> Add 'connection-status' command to ovs-appctl utility in order to check
> if a given chassis is currently connected to SB db
>
> Acked-by: Mark Michelson
> Co-authored-by: aginwala
> Signed-off-by: aginwala
> Signed-off-by:
These caused the test to fail.
CC: Jakub Sitnicki
Fixes: 984c7d5ea8fe ("ovn-northd: Propagate dynamic addresses to port group
address sets.")
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index
On Mon, Jul 16, 2018 at 4:54 PM Matteo Croce wrote:
>
> On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote:
> >
> > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote:
> > > From: Stefano Brivio
> > >
> > > Open vSwitch sends to userspace all received packets that have
> > > no associated
On Wed, Jul 25, 2018 at 05:26:54PM +0200, Jakub Sitnicki wrote:
> Because getopt() will set optopt for both known and unknown options,
> we need to differentiate between them ourselves by checking if we
> know the option. Do that by looking up its value.
>
> Also, because we are using GNU
I applied this series to master and branch-2.10. Thank you!
If it should be backported to branch-2.9, let me know.
On Mon, Jul 30, 2018 at 04:37:46PM +0200, Jakub Sitnicki wrote:
> This series addresses two issues noticed with Port Groups:
>
> (1) Port Group name cannot be used to refer to a
MTU? Big drops in performance numbers are usually because of packet
fragmentation. Keep the MTU of your packet origin to, say 1450 and retry?
On 31 July 2018 at 12:01, Carl Baldwin wrote:
> My apologies. I failed to include the ovs version number that I'm using. It
> is 2.7.3. Is there anything
My apologies. I failed to include the ovs version number that I'm using. It
is 2.7.3. Is there anything else I could check that maybe I'm not thinking
of?
Carl
On Tue, Jul 31, 2018 at 11:01 AM Ben Pfaff wrote:
> On Mon, Jul 30, 2018 at 02:02:16PM -0600, Carl Baldwin wrote:
> > I recently tried
Nuevas Disposiciones RAE (Real Academia Española)
Redacción de documentos ejecutivos y técnicos para profesionales
Agosto 21
Introducción:
Su desarrollo brinda herramientas para la comprensión de aspectos gramaticales
del español necesarios para la redacción de textos coherentes,
> On Jul 16, 2018, at 7:39 PM, Darrell Ball wrote:
>
> Use 'must' instead of 'should'.
>
> Signed-off-by: Darrell Ball
> ---
> lib/conntrack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index 682feb9..3f50fc8 100644
> ---
> On Jul 16, 2018, at 7:39 PM, Darrell Ball wrote:
>
> diff --git a/lib/flow.c b/lib/flow.c
> index 76a8b9a..e84a40d 100644
> --- a/lib/flow.c
> +++ b/lib/flow.c
> @@ -453,9 +453,14 @@ invalid:
> return true;
> }
>
> +/* datap points to the first extension header and advances as parsing
>
The new 'map' action is needed for 'hugetlbfs_t:file' too.
CC: Aaron Conole
Fixes: d2675a146130 ("selinux: changes to support newer hugetlbfs restrictions")
Signed-off-by: Timothy Redaelli
---
selinux/openvswitch-custom.te.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Jul 31, 2018 at 10:00:42AM -0700, Justin Pettit wrote:
>
> > On Jul 31, 2018, at 9:58 AM, Ben Pfaff wrote:
> >
> > On Tue, Jul 31, 2018 at 09:13:37AM -0700, Justin Pettit wrote:
> >>
> >>> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote:
> >>>
> >>> The 0-day Robot needs to lay off
On Tue, Jul 31, 2018 at 10:01:40AM -0700, Justin Pettit wrote:
>
> > On Jul 31, 2018, at 9:57 AM, Ben Pfaff wrote:
> >
> > Some GCC versions don't like ".x.y =", complaining about an uninitialized
> > field.
> >
> > Without this patch we get travis failures, e.g.
> >
On Mon, Jul 30, 2018 at 02:02:16PM -0600, Carl Baldwin wrote:
> I recently tried pushing MPLS labels using OVS in a lab.
>
> Before adding MPLS push to the mix, I had four hosts: two pairs, each
> connected to a different set of TOR switches running VRRP. OVS (using
> kernel datapath) had a flow
> On Jul 31, 2018, at 9:57 AM, Ben Pfaff wrote:
>
> Some GCC versions don't like ".x.y =", complaining about an uninitialized
> field.
>
> Without this patch we get travis failures, e.g.
> https://travis-ci.org/openvswitch/ovs/jobs/410404752:
>
>ovn/controller/ofctrl.c: In function
> On Jul 31, 2018, at 9:58 AM, Ben Pfaff wrote:
>
> On Tue, Jul 31, 2018 at 09:13:37AM -0700, Justin Pettit wrote:
>>
>>> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote:
>>>
>>> The 0-day Robot needs to lay off the pipe.
>>
>> Yeah, I'm not sure what was happening there. I emailed
On Tue, Jul 31, 2018 at 09:13:37AM -0700, Justin Pettit wrote:
>
> > On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote:
> >
> > The 0-day Robot needs to lay off the pipe.
>
> Yeah, I'm not sure what was happening there. I emailed Aaron about it.
It's just a GCC warning. Fix:
Some GCC versions don't like ".x.y =", complaining about an uninitialized
field.
Without this patch we get travis failures, e.g.
https://travis-ci.org/openvswitch/ovs/jobs/410404752:
ovn/controller/ofctrl.c: In function ‘ofctrl_put’:
ovn/controller/ofctrl.c:1086:9: error: missing
On Tue, Jul 31, 2018 at 03:08:13PM +0300, Alin Gabriel Serdean wrote:
> Until now we only had optind defined in the header.
>
> Since we are using the BSD getopt variant add opterr and optopt.
>
> Fixes: current Windows build failures.
Usually Fixes is used like this:
CC: Jakub Sitnicki
> On Jul 31, 2018, at 5:07 AM, Mark Michelson wrote:
>
> I figured more than anything I should bring this to your attention in case
> you had not noticed it. Given that you provide an 'ovn-nbctl meter-add'
> command, it strikes me that most people will probably add meters this way. If
>
> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote:
>
> The 0-day Robot needs to lay off the pipe.
Yeah, I'm not sure what was happening there. I emailed Aaron about it.
> Acked-by: Mark Michelson
Thanks! I pushed this to master and branch-2.10.
--Justin
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo ovn/controller/lflow.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Add 'connection-status' command to ovs-appctl utility in order to check
if a given chassis is currently connected to SB db
Acked-by: Mark Michelson
Co-authored-by: aginwala
Signed-off-by: aginwala
Signed-off-by: Lorenzo Bianconi
---
Changes since v3:
- add const qualifier to result and idl
> On Tue, 31 Jul 2018 15:22:38 +0200
> Lorenzo Bianconi wrote:
>
> > Add 'connection-status' command to ovs-appctl utility in order to check
> > if a given chassis is currently connected to SB db
> >
> > Acked-by: Mark Michelson
> > Co-authored-by: aginwala
> > Signed-off-by: aginwala
> >
On Tue, 31 Jul 2018 15:22:38 +0200
Lorenzo Bianconi wrote:
> Add 'connection-status' command to ovs-appctl utility in order to check
> if a given chassis is currently connected to SB db
>
> Acked-by: Mark Michelson
> Co-authored-by: aginwala
> Signed-off-by: aginwala
> Signed-off-by: Lorenzo
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo ovn/controller/lflow.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Hi Han,
I've given this patchset a look, and I was following along pretty well
until I got to about patch 11. From that point on, I had to re-read the
code more times than I care to admit before I finally understood what
was going on :)
What you have is a structure (lflow_ref_list_node)
Add 'connection-status' command to ovs-appctl utility in order to check
if a given chassis is currently connected to SB db
Acked-by: Mark Michelson
Co-authored-by: aginwala
Signed-off-by: aginwala
Signed-off-by: Lorenzo Bianconi
---
Changes since v2:
- check idl->session pointer in
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo ovn/controller/lflow.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
The 0-day Robot needs to lay off the pipe.
Acked-by: Mark Michelson
On 07/31/2018 02:03 AM, Justin Pettit wrote:
This also add some OVN action parsing tests.
Suggested-by: Ben Pfaff
Signed-off-by: Justin Pettit
---
ovn/lib/actions.c | 9 -
tests/ovn.at | 19
Until now we only had optind defined in the header.
Since we are using the BSD getopt variant add opterr and optopt.
Fixes: current Windows build failures.
Signed-off-by: Alin Gabriel Serdean
---
include/windows/getopt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 07/30/2018 09:00 PM, Justin Pettit wrote:
On Jul 30, 2018, at 11:40 AM, Mark Michelson wrote:
Hi Justin,
I took a look through the patch series, and this is the only one that I had
some immediate feedback on.
First, it would be nice if we could refer to Meters by name when issuing DB
Bleep bloop. Greetings Sugesh Chandran, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo ovn/controller/lflow.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
Configuring flow control at ixgbe netdev-init is throwing error in port
start.
For eg: without this fix, user cannot configure flow control on ixgbe dpdk
port as below,
"
ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \
options:dpdk-devargs=:05:00.1
Allow to set the tos and ttl for TC tunnels.
Signed-off-by: Or Gerlitz
Reviewed-by: Roi Dayan
---
acinclude.m4 | 6 +++---
include/linux/tc_act/tc_tunnel_key.h | 10 --
lib/netdev-tc-offloads.c | 16
lib/tc.c
This series comes to address the case to set (encap) and match (decap)
also the tos and ttl fields of TC based IP tunnels. This happens e.g
due to inherit setup of tunnel port for tos or due to specific OF rule.
The series is rebased over Jianbo's patches for QinQ [1]
Or.
v2 changes:
-
Support matching on tos and ttl of ip tunnels
for the TC data-path.
Signed-off-by: Or Gerlitz
Reviewed-by: Roi Dayan
---
acinclude.m4 | 10 +-
include/linux/pkt_cls.h | 7 ++-
lib/netdev-tc-offloads.c | 8
lib/tc.c | 26
Add the missing code to match on ip tos when dealing
with the TC data-path.
Signed-off-by: Or Gerlitz
Reviewed-by: Roi Dayan
---
include/openvswitch/match.h | 1 +
lib/match.c | 7 +++
lib/netdev-tc-offloads.c| 6 --
lib/tc.c| 10 ++
TTL can and should be used to match on IPv6's hop-limit, fix that.
Fixes: ab7ecf266b0a ('netdev-tc-offloads: Add nw_ttl matching using flower')
Fixes: 0b4b5203d12e ('tc: Add ip layer ttl matching')
Signed-off-by: Or Gerlitz
Reviewed-by: Roi Dayan
---
lib/netdev-tc-offloads.c | 4 ++--
lib/tc.c
On Jul 31, Jakub Sitnicki wrote:
> On Mon, 30 Jul 2018 17:10:23 +0200
> Lorenzo Bianconi wrote:
>
> > Add 'connection-status' command to ovs-appctl utility in order to check
> > if a given chassis is currently connected to SB db
> >
> > Co-authored-by: aginwala
> > Signed-off-by: aginwala
> >
On Mon, 30 Jul 2018 17:10:23 +0200
Lorenzo Bianconi wrote:
> Add 'connection-status' command to ovs-appctl utility in order to check
> if a given chassis is currently connected to SB db
>
> Co-authored-by: aginwala
> Signed-off-by: aginwala
> Signed-off-by: Lorenzo Bianconi
> ---
> Changes
On Mon, 30 Jul 2018 09:47:45 -0400
Mark Michelson wrote:
> The --restart flag allows for uninterrupted packet flowage when exiting
> ovn-controller. This patch modifies the restart_controller argument to
> ovn-ctl to use --restart.
>
> Signed-off-by: Mark Michelson
> ---
>
Hi Ian,
Regards
_Sugesh
> -Original Message-
> From: Stokes, Ian
> Sent: Monday, July 30, 2018 7:53 PM
> To: Chandran, Sugesh ; ovs-
> d...@openvswitch.org
> Subject: RE: [PATCHv2] netdev-dpdk: Fix failure to configure flow control at
> netdev-init.
>
> > Configuring flow control at
Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo ovn/controller/lflow.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99
> On Jul 30, 2018, at 5:58 PM, Justin Pettit wrote:
>
> Thanks for the review! I've pushed this series to master.
I also just pushed this to branch-2.10.
The rate-limiting is implemented using meters. Unfortunately, there's a bug in
the current kernels that prevents meters from working
This also add some OVN action parsing tests.
Suggested-by: Ben Pfaff
Signed-off-by: Justin Pettit
---
ovn/lib/actions.c | 9 -
tests/ovn.at | 19 +++
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c
index
90 matches
Mail list logo
