Re: [ovs-dev] [patch v8 9/9] ipf: Add fragmentation status reporting.

2018-08-15 Thread Darrell Ball
Thanks Justin By the way, I just noticed that you reviewed most patches on Aug 1. Since the company e-mail is filtering some OVS list e-mails and I have relied on it just for notifications and was otherwise busy, I missed those. I am going through those carefully now. One outstanding comment inli

Re: [ovs-dev] [PATCH] ovsdb-idl: Adjust indexes during transactions.

2018-08-15 Thread Han Zhou
On Wed, Aug 15, 2018 at 8:53 PM, Han Zhou wrote: > > > > On Tue, Aug 14, 2018 at 12:39 PM, Han Zhou wrote: > > > > > > > > On Tue, Aug 14, 2018 at 11:31 AM, Ben Pfaff wrote: > > > > > > When transactions modified tables with indexes, the indexes were not > > > properly updated to reflect the cha

Re: [ovs-dev] [PATCH] ovsdb-idl: Adjust indexes during transactions.

2018-08-15 Thread Han Zhou
On Tue, Aug 14, 2018 at 12:39 PM, Han Zhou wrote: > > > > On Tue, Aug 14, 2018 at 11:31 AM, Ben Pfaff wrote: > > > > When transactions modified tables with indexes, the indexes were not > > properly updated to reflect the changes. For deleted rows, in particular, > > this could cause use-after-f

Re: [ovs-dev] [PATCH] ofp-ed-props: Fix hang for crafted OpenFlow encap/decap properties.

2018-08-15 Thread Darrell Ball
On Wed, Aug 15, 2018 at 3:03 PM, Ben Pfaff wrote: > decode_ed_prop() accepted encap/decap properties with a reported length of > 0, without consuming any data from the property list, which yielded an > infinite loop. > > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9918 > Si

[ovs-dev] [PATCH] ofp-ed-props: Fix hang for crafted OpenFlow encap/decap properties.

2018-08-15 Thread Ben Pfaff
decode_ed_prop() accepted encap/decap properties with a reported length of 0, without consuming any data from the property list, which yielded an infinite loop. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9918 Signed-off-by: Ben Pfaff --- lib/ofp-ed-props.c | 2 +- 1 file

[ovs-dev] [PATCH] ofp-actions: Avoid assertion failure for clone(ct(...bad actions...)).

2018-08-15 Thread Ben Pfaff
decode_NXAST_RAW_CT() temporarily pulls data off the beginning of its ofpacts output ofpbuf and, on its error path, fails to push it back on. At a higher layer, decode_NXAST_RAW_CLONE() asserts, via ofpact_finish_CLONE(), that the ofpact_clone that it put is still in the place where it put it, whic

Re: [ovs-dev] [PATCH 10/11] dpctl: Implement dpctl commands for conntrack per zone limit

2018-08-15 Thread Darrell Ball
sorry, totally missed this e-mail On Thu, Aug 2, 2018 at 2:35 PM, Yi-Hung Wei wrote: > On Wed, Aug 1, 2018 at 10:37 PM, Darrell Ball wrote: > > On Wed, Aug 1, 2018 at 3:46 PM, Yi-Hung Wei > wrote: > > > > Do these commands need a ‘zone’ keyword > > > > eg) ct-set-zone-limits > > > >> > >> $ ov

Re: [ovs-dev] [patch v8] dpctl: Make opt_dpif_open() more general.

2018-08-15 Thread Darrell Ball
On 8/15/18, 1:52 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Fri, Aug 10, 2018 at 08:56:17AM -0700, Darrell Ball wrote: > By making opt_dpif_open() more general, it can be used effectively > by all potential callers and avoids trying to open potentially

Re: [ovs-dev] [patch v8] dpctl: Make opt_dpif_open() more general.

2018-08-15 Thread Ben Pfaff
On Fri, Aug 10, 2018 at 08:56:17AM -0700, Darrell Ball wrote: > By making opt_dpif_open() more general, it can be used effectively > by all potential callers and avoids trying to open potentially bogus > datapaths provided by the user. Also, the error handling is improved by > reducing bogus errors

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-15 Thread Ben Pfaff
On Mon, Aug 13, 2018 at 05:39:07PM -0700, Ben Pfaff wrote: > On Mon, Aug 13, 2018 at 02:07:45PM +0200, Daniel Alvarez wrote: > > This patch in glibc [0] is fixing a bug where we may be getting > > inconsistent dumps from the kernel when listing interfaces due to > > a race condition. > > > > This

Re: [ovs-dev] [PATCH] ip_tunnel: Fix bugs that could crash kernel

2018-08-15 Thread Ben Pfaff
On Fri, Jul 20, 2018 at 04:13:14PM -0700, William Tu wrote: > On Fri, Jul 20, 2018 at 11:04 AM, Yifeng Sun wrote: > > Without this patch, OVS kernel module can delete itn->fb_tunnel_dev > > one more time than necessary, which causes kernel crash. > > > > On kernel 4.4.0-116-generic, the crash can

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

2018-08-15 Thread Ben Pfaff
On Wed, Aug 15, 2018 at 11:17:21AM -0700, Ben Pfaff wrote: > On Wed, Aug 15, 2018 at 01:49:45PM +0100, Ian Stokes wrote: > > On 8/14/2018 10:19 PM, Ben Pfaff wrote: > > >On Tue, Aug 14, 2018 at 04:42:06PM +, Stokes, Ian wrote: > > >>Recently at the OVS DPDK community meeting the case for 2 new

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix for flow limit issue in revalidator

2018-08-15 Thread Ben Pfaff
On Fri, Aug 03, 2018 at 06:04:23AM +0530, Vishal Deep Ajmera wrote: > When the revalidator thread takes a long time to dump data path > flows (e.g. due to busy CPU), it reduces the maximum limit for > new flows that can be added. This results in more upcalls for > packets which do not find data pat

Re: [ovs-dev] [PATCH 0/3] tests: Environment variable for default timeout.

2018-08-15 Thread Ben Pfaff
On Tue, Aug 14, 2018 at 10:53:14AM +0300, Ilya Maximets wrote: > This was inspired by my previous patch set about syslog [1] and > the new environment variable for syslog method [2]. > > Patch set introduces new env. variable 'OVS_CTL_TIMEOUT', which > is used as a default timeout for control util

[ovs-dev] [PATCH v2 4/4] system-traffic: Add 5 new tunnel tests that don't depend on native linux modules

2018-08-15 Thread Yifeng Sun
Introduce 5 new tests that don't require native gre or erspan tunnels but sends simulated raw packets. These tests are supposed to only run for kernel version from 3.10.x to 4.15.x where compatible gre is being used by OVS kernel module. Signed-off-by: Yifeng Sun --- v1->v2: Add support for kern

[ovs-dev] [PATCH v2 3/4] system-traffic: Skip 5 tunnel tests on certain kernel versions

2018-08-15 Thread Yifeng Sun
Skip gre, erspan and ip6erspan related tests on kernel version from 3.10.x to 4.15.x because compatable gre is used and these tests will always fail. Signed-off-by: Yifeng Sun --- tests/system-traffic.at | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/system-traffic.at b/tests/sys

[ovs-dev] [PATCH v2 2/4] test: Add two m4 functions to skip tests for certain kernel versions

2018-08-15 Thread Yifeng Sun
Some tests depend on native Linux gre modules to setup testing environments. However, some kernel versions require OVS to use compatable gre modules. In this case, these tests always fail. This patch helps to skip a test if it fails due to this reason. The new m4 functions will be used by later pa

[ovs-dev] [PATCH v2 1/4] ip6_gre: Fix a bug that clears address bits

2018-08-15 Thread Yifeng Sun
In compatable gre module, skb->cb is solely used as ovs_gso_cb. However, IPCB(skb) also points to skb->cb. IPCB(skb)->flags overlaps with ovs_gso_cb.tun_dst. As a result, this bug clears the 16-23 bit in the address of ovs_gso_cb.tun_dst and causes kernel to crash. Signed-off-by: Yifeng Sun --- v

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

2018-08-15 Thread Ben Pfaff
On Wed, Aug 15, 2018 at 01:49:45PM +0100, Ian Stokes wrote: > On 8/14/2018 10:19 PM, Ben Pfaff wrote: > >On Tue, Aug 14, 2018 at 04:42:06PM +, Stokes, Ian wrote: > >>Recently at the OVS DPDK community meeting the case for 2 new branches was > >>raised. > >> > >>https://mail.openvswitch.org/pip

[ovs-dev] www.apprendre.ovh

2018-08-15 Thread henry
Épanouissez-vous en aidant les autres ! Découvrez notre formation en .M.A.G.N.E.T.I.S.M.E. Apprenez, par simple imposition des mains à soulager en ré-harmonisant les énergies. Découvrez, comprenez et contrôlez ces incroyables pouvoirs qui sont cac

Re: [ovs-dev] [PATCH 2/2] test-unixctl.py: Don't suppress exceptions.

2018-08-15 Thread Ben Pfaff
On Fri, Jul 13, 2018 at 02:38:36PM +0530, Numan Siddique wrote: > On Sat, Jun 16, 2018 at 3:42 AM Ben Pfaff wrote: > > > A user reported a failure of test 2364 "vlog - RFC5424 facility - Python2" > > with an exit code that says that the test-unixctl process died from an > > uncaught exception. U

Re: [ovs-dev] [PATCH] configure: Enable GCC relevant new 8.x warning options.

2018-08-15 Thread Ben Pfaff
On Fri, Jul 13, 2018 at 11:17:16AM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > These don't trigger any new actual warnings in my own build. > > > > GCC 8.x adds other new warning options that are enabled by -Wall or > > -Wextra. This commit doesn't explicitly enable those because OVS al

Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

2018-08-15 Thread Ben Pfaff
On Wed, Aug 01, 2018 at 03:23:38PM +0100, Ian Stokes wrote: > On 7/12/2018 10:55 PM, Ben Pfaff wrote: > >The macros are hard to read. This makes it a little more readable. > > > > Thanks for this Ben, one minor comment below. > > >Signed-off-by: Ben Pfaff > >--- > > configure.ac | 1

[ovs-dev] [PATCH v2] netdev: Clean up class initialization.

2018-08-15 Thread Ben Pfaff
The macros are hard to read. This makes it a little more readable. Signed-off-by: Ben Pfaff --- v1->v2: Refactor DPDK_FLOW_OFFLOAD_API as Ian requested. configure.ac | 1 + lib/netdev-dpdk.c | 234 -- lib/netdev-dpdk.h | 4 + lib/netdev-dumm

Re: [ovs-dev] [PATCH v4 0/2] Partial cluster support in Python IDL client

2018-08-15 Thread Ben Pfaff
On Wed, Aug 15, 2018 at 02:39:42PM +0530, Numan Siddique wrote: > On Wed, Aug 15, 2018 at 12:20 AM Ben Pfaff wrote: > > > On Tue, Aug 07, 2018 at 05:07:19PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > Python IDL library is lacking the functionality to connect to the

[ovs-dev] Response

2018-08-15 Thread Mr. Justin H.Murphy
Hi! My name is Justin Murphy; I am a lawyer from the UK. I contact you because of my dead client. My client died without a surviving family member. I want to nominate you as her heir because you have the same surname as my client, he left a large amount of money. This is legal and safe, come to

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

2018-08-15 Thread Ben Pfaff
On Wed, Aug 15, 2018 at 11:52:16AM -0400, Aaron Conole wrote: > Probably best to follow the existing branch convention: > > "branch-XXX" > > So, "branch-dpdk-next" and "branch-dpdk-hwol" For what it's worth, the current branches' names start with "branch-" only because, e.g. "2.10" seems like

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

2018-08-15 Thread Ian Stokes
On 8/15/2018 4:52 PM, Aaron Conole wrote: Ian Stokes writes: On 8/15/2018 10:51 AM, Ophir Munk wrote: Hi, Please find comments inline. -Original Message- From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- boun...@openvswitch.org] On Behalf Of Stokes, Ian Sent: Tuesday, August 14

Re: [ovs-dev] [PATCH] conntrack.c: Add missing return value check to prevent nptr dereference.

2018-08-15 Thread Aaron Conole
Jiecheng Wu writes: > Function ovs_ct_limit_cmd_get() defined in net/openvswitch/conntrack.c may > cause a null pointer dereference as it calls nla_nest_start which may return > NULL. The returned value is used in function nla_nest_end() later where the > pointer is dereferenced. > --- > net/

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

2018-08-15 Thread Aaron Conole
Ian Stokes writes: > On 8/15/2018 10:51 AM, Ophir Munk wrote: >> Hi, >> Please find comments inline. >> >>> -Original Message- >>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >>> boun...@openvswitch.org] On Behalf Of Stokes, Ian >>> Sent: Tuesday, August 14, 2018 7:42 PM >>> To

[ovs-dev] Hej, har brug for et lån

2018-08-15 Thread har brug for et lån
Hej, har brug for et lån. Uanset din økonomiske situation. Jeg er en person, der giver uanset mængden, enhver type af lån til en rente på 2 % til 3 % over en periode på højst 15 år til alle mennesker i stand til at respektere hans kompromis, så du kan fortælle mig, din månedlig betalinger. De

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

2018-08-15 Thread Ian Stokes
On 8/15/2018 10:51 AM, Ophir Munk wrote: Hi, Please find comments inline. -Original Message- From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- boun...@openvswitch.org] On Behalf Of Stokes, Ian Sent: Tuesday, August 14, 2018 7:42 PM To: Ben Pfaff (b...@ovn.org) Cc: d...@openvswitch

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

2018-08-15 Thread Ian Stokes
On 8/14/2018 10:19 PM, Ben Pfaff wrote: On Tue, Aug 14, 2018 at 04:42:06PM +, Stokes, Ian wrote: Recently at the OVS DPDK community meeting the case for 2 new branches was raised. https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350898.html These branches would be: (i) OVS DPDK

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

2018-08-15 Thread Ophir Munk
Hi, Please find comments inline. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Stokes, Ian > Sent: Tuesday, August 14, 2018 7:42 PM > To: Ben Pfaff (b...@ovn.org) > Cc: d...@openvswitch.org > Subject: [ovs-dev] OVS DP

[ovs-dev] (no subject)

2018-08-15 Thread lindacarter
good news ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 0/2] Partial cluster support in Python IDL client

2018-08-15 Thread Numan Siddique
On Wed, Aug 15, 2018 at 12:20 AM Ben Pfaff wrote: > On Tue, Aug 07, 2018 at 05:07:19PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Python IDL library is lacking the functionality to connect to the > > clustered db servers by providing multiple remotes (like - > > "tcp:10.0

Re: [ovs-dev] [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-08-15 Thread Pravin Shelar
Hi Stefano On Tue, Aug 7, 2018 at 6:31 AM, Stefano Brivio wrote: > Hi Pravin, > > On Tue, 31 Jul 2018 16:12:03 -0700 > Pravin Shelar wrote: > >> Rather than reducing number of thread down to 1, we could find better >> number of FDs per port. >> How about this simple solution: >> 1. Allocate (N *