Any comment here?
This seems like a very easy commit :-)
On Thu, 23 Aug 2018 at 13:34, Ian Stokes wrote:
> On 8/22/2018 6:14 PM, Federico Iezzi wrote:
> > DPDK exposes API all the way from 10Mbps to 100Gbps.
> > http://doc.dpdk.org/api/rte__ethdev_8h_source.html
> >
> > Can other cards be adde
Dearest Friend,
My name is Mrs. AISYAH BASRI, an Indonesian Origin. I have an important project
to discuss with you. It's very urgent and important. For more details, please
kindly contact me as soon as you read this message so that I shall explain
better to you in details.
Mrs. AISYAH.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Aug 22, 2018 at 03:04:44PM -0400, Mark Michelson wrote:
> This patch alters the 'ovn-nbctl lsp-set-addresses' command to check if
> the addresses being added are duplicates of already-set addresses. In
> the case of MAC addresses, it compares to all switch ports across the
> logical network
On Thu, Aug 30, 2018 at 05:08:15PM -0400, 0-day Robot wrote:
> Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> build:
> enum vlog_level
On Tue, Aug 28, 2018 at 02:25:37PM +0100, Markos Chandras wrote:
> This fixes the following warning when building Open vSwitch on the
> openSUSE Build Service:
>
> W: non-executable-script
> /usr/share/bash-completion/completions/ovs-appctl-bashcomp.bash
> This text file contains a shebang or
Applied to master, thanks Darrell and Yifeng!
On Wed, Aug 29, 2018 at 11:36:57AM -0700, Yifeng Sun wrote:
> Thanks for the fix.
>
> Tested-by: Yifeng Sun
>
> Reviewed-by: Yifeng Sun
>
> On Tue, Aug 28, 2018 at 7:54 PM Darrell Ball wrote:
>
> > On older kernels, for example 3.19, the functio
On Tue, Aug 28, 2018 at 02:58:22PM +0100, Billy O'Mahony wrote:
> Signed-off-by: Billy O'Mahony
Please put documentation for a feature in the same patch that adds the
feature.
Thanks,
Ben.
___
dev mailing list
d...@openvswitch.org
https://mail.openvsw
On Tue, Aug 28, 2018 at 05:21:22PM +0100, Kevin Traynor wrote:
> Signed-off-by: Kevin Traynor
> Acked-by: Eelco Chaudron
Please put the NEWS item for a feature in the same patch that adds the
feature.
Thanks,
Ben.
___
dev mailing list
d...@openvswitc
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
enum vlog_level level__ = LEVEL;\
^
./include/ope
On Tue, Aug 28, 2018 at 05:46:13PM -0700, Justin Pettit wrote:
> xcalloc() can't return null.
>
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
This will make it harder for bugs found by oss-fuzz to reappear.
Signed-off-by: Ben Pfaff
Tested-by: Yifeng Sun
Reviewed-by: Yifeng Sun
---
tests/automake.mk | 33 +
tests/fuzz-regression-list.at | 23 ++
t
This fixes leaks on the error path in parse_intel_port_custom_property().
ofp_print_ofpst_port_reply() failed to free the custom_stats in decoded
port stats. This fixes the problem.
parse_intel_port_custom_property() had a memory leak if there was more than
one custom stats property (which there
v1->v2:
- Applied patches 1 and 2 and dropped them from the series.
- Patch 3 rewritten based on Yifeng's comments and some more code
inspection.
- Patch 4 unchanged.
Ben Pfaff (2):
ofp-port: Further cleanups and fixes for ofputil_decode_port_stats().
tests: Add regression tests for al
Thanks, applied and backported.
On Mon, Aug 27, 2018 at 03:57:04PM -0700, Yifeng Sun wrote:
> Looks good to me, thanks for the fix.
>
> Reviewed-by: Yifeng Sun
>
> On Fri, Aug 24, 2018 at 2:50 PM Ben Pfaff wrote:
>
> > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9966
>
Thanks, applied and backported.
On Thu, Aug 30, 2018 at 11:25:51AM -0700, Yifeng Sun wrote:
> Looks good to me and the added tests run fine.
>
> Tested-by: Yifeng Sun
> Reviewed-by: Yifeng Sun
>
> On Fri, Aug 24, 2018 at 5:09 PM Ben Pfaff wrote:
>
> > This should actually be at the end of th
On Thu, Aug 30, 2018 at 01:15:03PM -0700, Ben Pfaff wrote:
> On Mon, Aug 27, 2018 at 04:13:03PM -0700, Yifeng Sun wrote:
> > It seems (struct ofputil_port_stats).custom_stats.counters is still leaked
> > by
> > the below code path even after this fix.
> >
> > parse_intel_port_custom_property
> > <
On Mon, Aug 27, 2018 at 04:13:03PM -0700, Yifeng Sun wrote:
> It seems (struct ofputil_port_stats).custom_stats.counters is still leaked
> by
> the below code path even after this fix.
>
> parse_intel_port_custom_property
> <- ofputil_pull_ofp14_port_stats
> <- ofputil_decode_port_stats
> <- ofput
This allows a controller to change the name of OpenFlow flow tables in the
OVS software switch.
CC: Brad Cowie
Signed-off-by: Ben Pfaff
---
NEWS | 4 +
include/openvswitch/ofp-errors.h | 3 +
include/openvswitch/ofp-msgs.h | 2 +-
include/openvswitch/ofp-tabl
Signed-off-by: Ben Pfaff
---
ofproto/ofproto.c | 84 +--
1 file changed, 44 insertions(+), 40 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index d65a3fea1559..54f56d9f100e 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.
OpenFlow has a concept of multipart messages, that is, messages that can be
broken into multiple pieces that are sent separately. Before OpenFlow 1.3,
only replies could actually have multiple pieces. OpenFlow 1.3 introduced
the idea that requests could have multiple pieces. This is only useful
Signed-off-by: Ben Pfaff
---
include/openflow/openflow-1.3.h | 24 +++-
include/openvswitch/ofp-table.h | 14 ++-
lib/ofp-table.c | 83 +
3 files changed, 118 insertions(+), 3 deletions(-)
diff --git a/include/openflow/openflow-
Table features should indicate the table number as well as the table
name. Before this, the first line for each table looked like this:
table myname ("myname"):
but it's more useful if it's:
table 123 ("myname"):
Signed-off-by: Ben Pfaff
---
include/openvswitch/ofp-table.h | 1 -
lib/ofp
OpenFlow table feature replies contain a per-table bitmap that indicates
which tables a flow can point to in goto_table actions. OpenFlow requires
that a table only be able to go to higher-numbered tables. This means that
a switch that is general as possible will always have different features
fo
Before this patch, most dump-table-stats outputs would contain about
250 lines of the form:
table #: ditto
With this patch, they have one line like this:
tables 2...254: ditto
which is much easier to read.
Signed-off-by: Ben Pfaff
---
include/openvswitch/ofp-table.h | 5 +++-
lib/ofp-pr
Sometimes the 'errors' list is passed as null, and in that case it should
not be used.
Found by inspection.
Signed-off-by: Ben Pfaff
---
lib/vconn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vconn.c b/lib/vconn.c
index e95ecbfa78a3..4d5f308d8836 100644
--- a/lib/vc
--
Brauchen Sie ein Darlehen von jeder Art? Wenn ja, bitte E-Mail:
jan_hendrick...@outlook.com, jetzt für weitere Informationen.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Looks good to me and the added tests run fine.
Tested-by: Yifeng Sun
Reviewed-by: Yifeng Sun
On Fri, Aug 24, 2018 at 5:09 PM Ben Pfaff wrote:
> This should actually be at the end of the series because the series
> fixes some of the bugs that it tests for. Other than ordering, the
> series is
Looks good to me, thanks.
Tested-by: Yifeng Sun
Reviewed-by: Yifeng Sun
On Fri, Aug 24, 2018 at 2:51 PM Ben Pfaff wrote:
> A previous commit attempted to fix the error path when the actions nested
> within clone provoked an error. However, this commit just introduced a new
> problem in anoth
Found this when searching "BIOS Settings" for use with DPDK.
CC: Stephen Finucane
Fixes: c50938a24031 ("doc: Convert INSTALL.DPDK-ADVANCED to rST")
Signed-off-by: Cian Ferriter
---
Documentation/howto/dpdk.rst |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentati
On 08/30/2018 03:34 PM, Ian Stokes wrote:
> On 8/30/2018 2:51 PM, Ophir Munk wrote:
>> Hi Ian,
>> Please find comments inline.
>>
>>> -Original Message-
>>> From: Ian Stokes [mailto:ian.sto...@intel.com]
>>> Sent: Thursday, August 30, 2018 1:15 PM
>>> To: ovs-dev@openvswitch.org
>>> Cc: Oph
Thanks for the answer Ben.
It was a simple config issue. When a vlan subinterface recieves a tagged
frame it just pops the tag. Just adding eth0 to the ovs solved the problem.
El mié., 29 ago. 2018 a las 0:35, Ben Pfaff () escribió:
> On Wed, Aug 29, 2018 at 12:10:03AM +0200, Alvaro Jimenez wrote
Hi Ilya,
Thanks for the comments, I have some responses in-line. I'll cook up the
fixes for the next iteration, but would be interested in getting on your
views, mainly on 1., 2. and 3..
On 30/08/2018 12:06, Ilya Maximets wrote:
> Hi, Tiago. I applied that whole patch-set and looked through the
>
Hi everyone,
I'm trying to figure out how to implement a multiple table forwarding
configuration based on packet headers. I am only managing packets with vlan
tags (101,201,301) and tcp header (http and ftp services). I want to
implement multiple flow tables:
1st table: ethernet destination addres
On 30/08/2018 14:33, Simon Horman wrote:
> Hi Pieter,
>
> On Tue, Aug 21, 2018 at 02:49:45PM +0100, Pieter Jansen van Vuuren wrote:
>> Add TC offload support for encapsulating geneve tunnels with options.
>>
>> Signed-off-by: Pieter Jansen van Vuuren
>>
>> Reviewed-by: Simon Horman
>
> thanks
On 30/08/2018 14:28, Simon Horman wrote:
> Hi Pieter,
>
> On Thu, Aug 23, 2018 at 03:47:58PM +0100, Pieter Jansen van Vuuren wrote:
>> Add TC offload support for classifying single MPLS tagged traffic.
>>
>> Signed-off-by: Pieter Jansen van Vuuren
>>
>> Reviewed-by: Simon Horman
>> Reviewed-by:
On 8/30/2018 2:51 PM, Ophir Munk wrote:
Hi Ian,
Please find comments inline.
-Original Message-
From: Ian Stokes [mailto:ian.sto...@intel.com]
Sent: Thursday, August 30, 2018 1:15 PM
To: ovs-dev@openvswitch.org
Cc: Ophir Munk ; Ben Pfaff ; Aaron
Conole ; Kevin Traynor
Subject: Re: [ovs
On Tue, Aug 28, 2018 at 05:46:14PM -0700, Justin Pettit wrote:
> dpif_netdev_meter_get() retrieved a pointer to a meter entry without
> holding a lock. It's possible that another thread could have deleted
> that entry between retrieving the pointer and dereferencing the pointer.
> This makes the f
On Tue, Aug 28, 2018 at 05:46:13PM -0700, Justin Pettit wrote:
> xcalloc() can't return null.
>
> Signed-off-by: Justin Pettit
> ---
I couldn't find another instance of the problem and
this looks good.
Acked-by: Flavio Leitner
___
dev mailing list
> > From: "Ian Stokes"
> > To: "Bala Sankaran" , d...@openvswitch.org
> > Cc: "Aaron Conole" , "Ciara Loftus"
> >
> > Sent: Thursday, 30 August, 2018 5:15:13 AM
> > Subject: Re: [PATCH v3 0/6] system-dpdk: Add support to connect two
> > namespaces
> >
> > On 8/28/2018 6:47 PM, Bala Sankaran wrote
Hi Ian,
Please find comments inline.
> -Original Message-
> From: Ian Stokes [mailto:ian.sto...@intel.com]
> Sent: Thursday, August 30, 2018 1:15 PM
> To: ovs-dev@openvswitch.org
> Cc: Ophir Munk ; Ben Pfaff ; Aaron
> Conole ; Kevin Traynor
> Subject: Re: [ovs-dev] OVS DPDK Latest & HWOL
Hello Ian,
- Original Message -
> From: "Ian Stokes"
> To: "Bala Sankaran" , d...@openvswitch.org
> Cc: "Aaron Conole" , "Ciara Loftus"
>
> Sent: Thursday, 30 August, 2018 5:15:13 AM
> Subject: Re: [PATCH v3 0/6] system-dpdk: Add support to connect two namespaces
>
> On 8/28/2018 6:47
Hi Pieter,
On Tue, Aug 21, 2018 at 02:49:45PM +0100, Pieter Jansen van Vuuren wrote:
> Add TC offload support for encapsulating geneve tunnels with options.
>
> Signed-off-by: Pieter Jansen van Vuuren
> Reviewed-by: Simon Horman
thanks for your patch. In general I am happy with this and would
Hi Pieter,
On Thu, Aug 23, 2018 at 03:47:58PM +0100, Pieter Jansen van Vuuren wrote:
> Add TC offload support for classifying single MPLS tagged traffic.
>
> Signed-off-by: Pieter Jansen van Vuuren
> Reviewed-by: Simon Horman
> Reviewed-by: John Hurley
thanks for your patch. In general I am h
On Mon, Aug 27, 2018 at 01:56:53PM +0200, Simon Horman wrote:
> On Fri, Aug 24, 2018 at 06:13:19PM +0300, Ilya Maximets wrote:
> > The set of supported values specified.
> > Style fixed to look good in man page. Fixed indents.
> >
> > CC: Paul Blakey
> > Fixes: 691d20cbdcf3 ("other-config: Add tc
On Fri, Aug 10, 2018 at 11:30:08AM +0300, Gavi Teitz wrote:
> Added new types to the flow dump filter, and allowed multiple filter
> types to be passed at once, as a comma separated list. The new types
> added are:
> * tc - specifies flows handled by the tc dp
> * non-offloaded - specifies flows
Hi, Tiago. I applied that whole patch-set and looked through the
code. Didn't finish review yet, but have a few concerns about current
implementation:
1. dp_packet_l3/l4/others returns the pointer and checks only that
offset is less than the size of the first segment. But this check
doesn't
> Hi:
>
> Currently with user space datapath, only internal tap device can be
> used to communicate with kernel. Because packets must be copied from
> user space to kernel, the throughput of tap implementation is very
> slow, not suitable for data plane. Now DPDK provides some alternative
> soluti
On 8/30/2018 9:31 AM, Stokes, Ian wrote:
On Tue, Aug 28, 2018 at 11:32:31AM +0100, Ian Stokes wrote:
On 8/27/2018 5:16 PM, Ben Pfaff wrote:
On Mon, Aug 27, 2018 at 04:05:39PM +, Ophir Munk wrote:
4. How can I inspect the new branches? Currently I am not seeing them.
I do not think that I
On 8/30/2018 1:08 AM, Bala Sankaran wrote:
- Original Message -
From: "Aaron Conole"
To: "Bala Sankaran"
Cc: "Tiago Lam" , d...@openvswitch.org
Sent: Wednesday, 29 August, 2018 5:14:41 PM
Subject: Re: [ovs-dev] [PATCH v3 6/6] system-dpdk: Connect network namespaces
via dpdkvhostuser p
Hi:
Currently with user space datapath, only internal tap device can be
used to communicate with kernel. Because packets must be copied from
user space to kernel, the throughput of tap implementation is very
slow, not suitable for data plane. Now DPDK provides some alternative
solutions.
1. KNI i
On 8/28/2018 6:47 PM, Bala Sankaran wrote:
This allows system-dpdk test suite to ping two namespaces via a veth
and dpdkvhostuser port, using testpmd as a forwarding agent.
For the initial test, testpmd included with 18.11-rc0 is used, while
ovs is linked against DPDK 17.11 LTS.
Some additional
> Ian Stokes writes:
>
> > On 8/27/2018 5:16 PM, Ben Pfaff wrote:
> >> I can help with some of these.
> >>
> >> On Mon, Aug 27, 2018 at 04:05:39PM +, Ophir Munk wrote:
> >>> Ian, can you please specify the practical steps regarding the new
> branches?
> >>> Specifically, what is the procedure
> On Tue, Aug 28, 2018 at 11:32:31AM +0100, Ian Stokes wrote:
> > On 8/27/2018 5:16 PM, Ben Pfaff wrote:
> > >On Mon, Aug 27, 2018 at 04:05:39PM +, Ophir Munk wrote:
> > >>4. How can I inspect the new branches? Currently I am not seeing them.
> > >
> > >I do not think that Ian has created the n
I don't think the patch will resolve the problem. Once ctb->lock is
released, other thread may have chance to acquire the lock and modify
ctb. In general, ctb->lock can not be released in this function,
another approach is needed.
On Wed, Aug 29, 2018 at 3:31 PM Darrell Ball wrote:
>
> nat_clean
Hi Ilya,
Since you've shown some concerns on the latest revision, does this
address you concerns? More specifically, does patch 09/14 address the
points you made on v7 of the series, where dp_packet_data() was being
used to traverse the whole data, even if segmented?
Thanks,
Tiago.
On 24/08/2018
56 matches
Mail list logo
