[ovs-dev] [PATCH v2] bundle: add symmetric_l3 hash method for multipath

2018-09-11 Thread Martin Xu
Add a symmetric_l3 hash method that uses both network destination address and network source address. VMware-BZ: #2112940 Signed-off-by: Martin Xu CC: Ben Pfaff --- include/openflow/nicira-ext.h | 4 +++- lib/bundle.c | 2 ++ lib/flow.c| 44 ++

Re: [ovs-dev] [ovs-dev, v1] bundle: add symmetric_l3 hash method for multipath

2018-09-11 Thread 0-day Robot
Bleep bloop. Greetings Martin Xu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #79 F

Re: [ovs-dev] [PATCH] ovsdb-idlc: Use ALIGNED_CAST to avoid spurious warnings for index rows.

2018-09-11 Thread Han Zhou
On Mon, Sep 10, 2018 at 1:01 PM Ben Pfaff wrote: > > The *_index_init_row() function casts a generic ovsdb_idl_row pointer to > a specific type of row pointer. This can cause an increase in required > alignment with some kinds of data on some architectures. GCC complains, > e.g.: > > lib/vsw

[ovs-dev] [PATCH v1] bundle: add symmetric_l3 hash method for multipath

2018-09-11 Thread Martin Xu
Add a symmetric_l3 hash method that uses both network destination address and network source address. VMware-BZ: #2112940 Signed-off-by: Martin Xu CC: Ben Pfaff --- include/openflow/nicira-ext.h | 4 +++- lib/bundle.c | 2 ++ lib/flow.c| 44 ++

Re: [ovs-dev] Update tutorial for newer versions of Faucet and Open vSwitch.

2018-09-11 Thread 0-day Robot
Bleep bloop. Greetings Brad Cowie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 158 characters long (recommended limit is 79) #81 FILE: Documentation/tutorials/

[ovs-dev] [PATCH] Update tutorial for newer versions of Faucet and Open vSwitch.

2018-09-11 Thread Brad Cowie
Newer versions of Faucet use a dynamic OpenFlow pipeline based on what features are enabled in the configuration file. Update log output, flow table dumps and explanations to be consistent with newer Faucet versions. Remove mentions of bugs that we have since fixed in Faucet since the tutorial was

Re: [ovs-dev] [PATCH v4 6/6] system-dpdk: Connect network namespaces via dpdkvhostuser ports

2018-09-11 Thread Lam, Tiago
On 10/09/2018 16:47, Bala Sankaran wrote: > Hello Tiago, > > Here's an incremental diff of the patch 6 which I tested. It looks to pass > the tests. I would be submitting the > new version (v5) applying these changes: > > diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at > index baa74da..

Re: [ovs-dev] Revert "Revert "utilities/ovs-ctl: Force removal of ip_gre/gre""

2018-09-11 Thread Gregory Rose
On 9/11/2018 6:52 AM, Yifeng Sun wrote: Please backport this patch to upstream OVS down to 2.10. Author: Greg Rose Date: Wed Jun 6 15:34:44 2018 -0700 This reverts commit a94f9524dbc11c78c83d1a49959497f5e73bf949. Signed-off-by: Greg Rose I guess someone else will have to review this one.

Re: [ovs-dev] gre: Rename fallback devices to avoid udev's interference

2018-09-11 Thread Gregory Rose
On 9/11/2018 6:52 AM, Yifeng Sun wrote: Please backport this patch to upstream OVS down to 2.9. On certain kernel versions, when openvswitch kernel module creates a gre0 interface, the kernel’s gre module will jump out and compete to control the gre0 interface. This will cause the failure of ope

Re: [ovs-dev] [PATCH v2] rhel: Ship ovs shared libraries, fedora

2018-09-11 Thread Flavio Leitner
On Tue, Sep 11, 2018 at 02:40:05PM -0700, Martin Xu wrote: > Hi Flavio, > > I don't see the lib*.so packaged in either fedora subpackage. I guess I > might have missed some configurations when I build. Do you mind pointing me > to it? I'd rather use the already shipped version than adding a new pa

Re: [ovs-dev] [PATCH v2] rhel: Ship ovs shared libraries, fedora

2018-09-11 Thread Martin Xu
Hi Flavio, I don't see the lib*.so packaged in either fedora subpackage. I guess I might have missed some configurations when I build. Do you mind pointing me to it? I'd rather use the already shipped version than adding a new patch, of course. Thanks! Martin On Tue, Sep 11, 2018 at 12:58 PM Fla

Re: [ovs-dev] [ovs-dev, dpdk-howl, v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-11 Thread Ian Stokes
On 9/11/2018 10:35 AM, Ilya Maximets wrote: Comments inline. Best regards, Ilya Maximets. On 11.09.2018 02:04, Ophir Munk wrote: 1. Enable compilation and linkage with dpdk 18.08.0 The following dpdk commits which were introduced after dpdk 17.11.x require OVS updates to accommodate to the dpd

Re: [ovs-dev] [PATCH] datapath: lisp: Fix uninitialized field in tunnel_cfg.

2018-09-11 Thread Gregory Rose
On 9/11/2018 12:12 AM, wangyunjian wrote: From: Yunjian Wang The tunnel_cfg had the gro_receive and gro_complete fields uninitialized in function lisp_open(). This caused an uninitialized memory read. Signed-off-by: Yunjian Wang --- datapath/linux/compat/lisp.c | 1 + 1 file changed, 1 ins

Re: [ovs-dev] [PATCH v2] rhel: Ship ovs shared libraries, fedora

2018-09-11 Thread Flavio Leitner
On Tue, Sep 11, 2018 at 12:33:06PM -0700, Martin Xu wrote: > Hi Flavio, > > I must have misread the suggestions there. The intention of the v1 patch > was to package the shared libraries in openvswitch RPM. The rhel6 spec file > seems to have packaged those shared libraries into both openvswitch a

Re: [ovs-dev] [RFC] Federating the 0-day robot, and improving the testing

2018-09-11 Thread Aaron Conole
Ophir Munk writes: >> -Original Message- >> From: Aaron Conole [mailto:acon...@bytheb.org] >> Sent: Thursday, September 06, 2018 11:56 AM >> To: Ian Stokes ; Kevin Traynor >> ; Ophir Munk ; Ferruh >> Yigit ; Luca Boccassi ; Jeremy >> Plsek ; Sugesh Chandran >> ; Jean-Tsung Hsiao ; >> Chri

Re: [ovs-dev] [PATCH v2] rhel: Ship ovs shared libraries, fedora

2018-09-11 Thread Martin Xu
Hi Flavio, I must have misread the suggestions there. The intention of the v1 patch was to package the shared libraries in openvswitch RPM. The rhel6 spec file seems to have packaged those shared libraries into both openvswitch and openvswitch-devel. I don't know the history how it came along. We

Re: [ovs-dev] [PATCH v2] rhel: Ship ovs shared libraries, fedora

2018-09-11 Thread Flavio Leitner
On Tue, Sep 11, 2018 at 11:44:59AM -0700, Martin Xu wrote: > This patch extends 4886d4d2495b (debian, rhel: Ship ovs shared libraries > and header files) to fedora, by packaging the shared libraries in > openvswitch RPM. These files are always packaged in the RPM built with > rhel6 spec file. > >

[ovs-dev] Revert "Revert "utilities/ovs-ctl: Force removal of ip_gre/gre""

2018-09-11 Thread Yifeng Sun
Please backport this patch to upstream OVS down to 2.10. Author: Greg Rose Date: Wed Jun 6 15:34:44 2018 -0700 This reverts commit a94f9524dbc11c78c83d1a49959497f5e73bf949. Signed-off-by: Greg Rose --- utilities/ovs-lib.in | 8 1 file changed, 8 insertions(+) diff --git a/utilitie

[ovs-dev] gre: Rename fallback devices to avoid udev's interference

2018-09-11 Thread Yifeng Sun
Please backport this patch to upstream OVS down to 2.9. On certain kernel versions, when openvswitch kernel module creates a gre0 interface, the kernel’s gre module will jump out and compete to control the gre0 interface. This will cause the failure of openvswitch kernel module loading. This fix

Re: [ovs-dev] [PATCH v1] rhel: add build option to package ovs shared libraries, fedora

2018-09-11 Thread Martin Xu
Thanks Ben and Flavio. I'm removing the condition around it, and have sent out a second patch. Martin On Mon, Sep 10, 2018 at 6:54 PM Ben Pfaff wrote: > On Mon, Sep 10, 2018 at 08:58:37PM -0300, Flavio Leitner wrote: > > On Mon, Sep 10, 2018 at 02:53:54PM -0700, Ben Pfaff wrote: > > > On Mon, S

[ovs-dev] [PATCH v2] rhel: Ship ovs shared libraries, fedora

2018-09-11 Thread Martin Xu
This patch extends 4886d4d2495b (debian, rhel: Ship ovs shared libraries and header files) to fedora, by packaging the shared libraries in openvswitch RPM. These files are always packaged in the RPM built with rhel6 spec file. VMware-BZ: #2036847 Signed-off-by: Martin Xu CC: Flavio Leitner ---

Re: [ovs-dev] [RFC] Federating the 0-day robot, and improving the testing

2018-09-11 Thread Ophir Munk
> -Original Message- > From: Aaron Conole [mailto:acon...@bytheb.org] > Sent: Thursday, September 06, 2018 11:56 AM > To: Ian Stokes ; Kevin Traynor > ; Ophir Munk ; Ferruh > Yigit ; Luca Boccassi ; Jeremy > Plsek ; Sugesh Chandran > ; Jean-Tsung Hsiao ; > Christian Trautman ; Ben Pfaff

[ovs-dev] Perfil profesional de Alta Demanda

2018-09-11 Thread Controller Financiero
--- Este correo electrónico ha sido comprobado en busca de virus por AVG. http://www.avg.com ___ dev mailing list d...@openvswitch.org https://mail.openvswi

Re: [ovs-dev] [PATCH v2] ovsdb-server: Alleviate the possible data loss in an active/standby setup

2018-09-11 Thread Han Zhou
On Tue, Sep 11, 2018 at 10:30 AM wrote: > > From: Numan Siddique > > The present code resets the database when it is in the state - > 'RPL_S_SCHEMA_REQUESTED' and repopulates the database when it > receives the monitor reply when it is in the state - > 'RPL_S_MONITOR_REQUESTED'. If however, it go

Re: [ovs-dev] [PATCH] ovsdb-server: Fix the possible data loss in an active/standby setup

2018-09-11 Thread Numan Siddique
On Tue, Sep 11, 2018 at 12:56 AM Han Zhou wrote: > On Mon, Sep 10, 2018 at 12:56 AM wrote: > > > > From: Numan Siddique > > > > The present code resets the database when it is in the state - > > 'RPL_S_SCHEMA_REQUESTED' and repopulates the database when it > > receives the monitor reply when it

[ovs-dev] [PATCH v2] ovsdb-server: Alleviate the possible data loss in an active/standby setup

2018-09-11 Thread nusiddiq
From: Numan Siddique The present code resets the database when it is in the state - 'RPL_S_SCHEMA_REQUESTED' and repopulates the database when it receives the monitor reply when it is in the state - 'RPL_S_MONITOR_REQUESTED'. If however, it goes to active mode before it processes the monitor repl

Re: [ovs-dev] [RFC] Federating the 0-day robot, and improving the testing

2018-09-11 Thread Ian Stokes
On 9/11/2018 4:51 PM, Aaron Conole wrote: "Eelco Chaudron" writes: On 6 Sep 2018, at 10:56, Aaron Conole wrote: As of June, the 0-day robot has tested over 450 patch series. Occasionally it spams the list (apologies for that), but for the majority of the time it has caught issues before they

Re: [ovs-dev] [PATCH] ovs-save: Don't always include the default flow during restore

2018-09-11 Thread Flavio Leitner
On Tue, Sep 11, 2018 at 01:06:48PM -0300, Flavio Leitner wrote: > On Sun, Sep 09, 2018 at 02:20:02PM +0200, Timothy Redaelli wrote: > > Currently the default flow (actions=NORMAL) is present in the flow table > > after > > the flow table is restored also when the default flow is removed. > > > >

Re: [ovs-dev] [PATCH] ovs-save: Don't always include the default flow during restore

2018-09-11 Thread Flavio Leitner
On Sun, Sep 09, 2018 at 02:20:02PM +0200, Timothy Redaelli wrote: > Currently the default flow (actions=NORMAL) is present in the flow table after > the flow table is restored also when the default flow is removed. > > This commit changes the behaviour of the "ovs-save save-flows" command to use >

Re: [ovs-dev] [RFC] Federating the 0-day robot, and improving the testing

2018-09-11 Thread Aaron Conole
"Eelco Chaudron" writes: > On 6 Sep 2018, at 10:56, Aaron Conole wrote: > >> As of June, the 0-day robot has tested over 450 patch series. >> Occasionally it spams the list (apologies for that), but for the >> majority of the time it has caught issues before they made it to the >> tree - so it's

Re: [ovs-dev] [RFC] Federating the 0-day robot, and improving the testing

2018-09-11 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Sep 06, 2018 at 04:56:18AM -0400, Aaron Conole wrote: >> As of June, the 0-day robot has tested over 450 patch series. >> Occasionally it spams the list (apologies for that), but for the >> majority of the time it has caught issues before they made it to the >> tree -

Re: [ovs-dev] [ovs-dev,v4] Improved Packet Drop Statistics in OVS

2018-09-11 Thread 0-day Robot
Bleep bloop. Greetings Keshav Gupta, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: :44: trailing whitespace. * enum ovs_drop_reason - Reasons for installing %OVS_ACTION_ATTR_DROP.

Re: [ovs-dev] [PATCH v3] Improved Packet Drop Statistics in OVS

2018-09-11 Thread Keshav Gupta
Thanks Ben for prompt reply. I have incorporated the comment & warning and sent out a v4 patch. Thanks keshav -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Tuesday, September 11, 2018 1:21 AM To: Keshav Gupta Cc: d...@openvswitch.org; Anju Thomas ; Rohith Basavaraja

Re: [ovs-dev] [PATCH v5] dpif-netdev: Add round-robin based rxq to pmd assignment.

2018-09-11 Thread Stokes, Ian
> > Looks good to me. > > Acked-by: Ilya Maximets > I'll pull this in with this week's pull request, thanks all for the effort. Thanks Ian > On 31.08.2018 11:47, Kevin Traynor wrote: > > Prior to OVS 2.9 automatic assignment of Rxqs to PMDs (i.e. CPUs) was > > done by round-robin. > > > > Th

Re: [ovs-dev] [PATCH] lib/tc: treat vlan id and prio as independent fields

2018-09-11 Thread Pieter Jansen van Vuuren
On 10/09/2018 14:24, Simon Horman wrote: > On Mon, Sep 10, 2018 at 11:08:25AM +0100, Pieter Jansen van Vuuren wrote: >> Previously the key was used to check the presence of vlan id and >> prio fields instead of using the mask. Additionally the vlan id >> field was considered to be present if only t

Re: [ovs-dev] [PATCH ovs-2.8] lib/tc: reject offloading of non-Ethernet packets

2018-09-11 Thread Simon Horman
On Mon, Sep 10, 2018 at 08:37:40PM +0200, Louis Peens wrote: > When a packet is marked with the special ethtype of OFP_DL_TYPE_NOT_ETH_TYPE > it got wrongly installed into tc datapath as a match on a packet with that > ethtype. This prevents that from happening. > > Signed-off-by: Louis Peens > R

Re: [ovs-dev] [ovs-dev, dpdk-howl, v2] netdev-dpdk: Upgrade to dpdk v18.08.0

2018-09-11 Thread Ilya Maximets
Comments inline. Best regards, Ilya Maximets. On 11.09.2018 02:04, Ophir Munk wrote: > 1. Enable compilation and linkage with dpdk 18.08.0 > The following dpdk commits which were introduced after dpdk 17.11.x > require OVS updates to accommodate to the dpdk changes. > - ce17eddefc20 ("ethdev: int

[ovs-dev] [PATCH] datapath: lisp: Fix uninitialized field in tunnel_cfg.

2018-09-11 Thread wangyunjian
From: Yunjian Wang The tunnel_cfg had the gro_receive and gro_complete fields uninitialized in function lisp_open(). This caused an uninitialized memory read. Signed-off-by: Yunjian Wang --- datapath/linux/compat/lisp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/linux/compat/