Re: [ovs-dev] [PATCH] flow: Fix uninitialized flow fields in IPv6 error case.

2018-09-21 Thread Ben Pfaff
Thanks, applied and backported. On Fri, Sep 21, 2018 at 04:01:59PM -0700, Yifeng Sun wrote: > Thanks, looks good to me. > > Reviewed-by: Yifeng Sun > > On Fri, Sep 21, 2018 at 11:26 AM Ben Pfaff wrote: > > > When parse_ipv6_ext_hdrs__() returned false, half a 64-bit word had been > > pushed

[ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

2018-09-21 Thread amginwal
When starting OVN DBs in HA using pacemaker with ssl, we need to pass ssl certs for starting standby DBs. Hence, we need this change. Signed-off-by: aginwala --- ovn/utilities/ovndb-servers.ocf | 74 - 1 file changed, 73 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

2018-09-21 Thread amginwal
For OVN DBs to work with SSL in HA, we need to have capability to pass ssl certs when starting OVN DBs. Say when starting OVN DBs in active passive mode, in order for the standby DBs to sync from master node, it cannot sync because the required ssl certs are not passed when standby DBs are

Re: [ovs-dev] [PATCH] flow: Fix uninitialized flow fields in IPv6 error case.

2018-09-21 Thread Yifeng Sun
Thanks, looks good to me. Reviewed-by: Yifeng Sun On Fri, Sep 21, 2018 at 11:26 AM Ben Pfaff wrote: > When parse_ipv6_ext_hdrs__() returned false, half a 64-bit word had been > pushed into the miniflow and the second half was left uninitialized. This > commit fixes the problem. > >

Re: [ovs-dev] [PATCH v1 1/2] rhel: use _datadir as path prefix for ovs-kmod-manage.sh, fedora

2018-09-21 Thread Martin Xu
Thanks for the review! Martin On Fri, Sep 21, 2018 at 5:24 AM Flavio Leitner wrote: > On Thu, Sep 20, 2018 at 12:19:29PM -0700, Martin Xu wrote: > > This patch fixes the path for ovs-kmod-manage.sh script in the > > openvswitch-kmod RPM in fedora spec file. Currently the path prefix is > >

Re: [ovs-dev] [PATCH] tests: Fix broken test of 'truncate and output to gre tunnel'

2018-09-21 Thread Yifeng Sun
No need to backport. Thanks Ben. On Fri, Sep 21, 2018 at 1:23 PM Ben Pfaff wrote: > On Thu, Sep 20, 2018 at 10:49:08AM -0700, Gregory Rose wrote: > > On 9/18/2018 2:39 PM, Yifeng Sun wrote: > > >The test 'truncate and output to gre tunnel' is broken on certain > kernels > > >where OVS kernel

Re: [ovs-dev] New config with an issue

2018-09-21 Thread Peter Eisch
Okay, the dupes come from the flooding which happens when we pass through the flow rules without matching the MAC and landing at the default action. Got it. It also seems our outages came on the heels of ipv6 probes messing out the routing. We now have ipv6 disabled in the kernel on our

Re: [ovs-dev] [PATCH] dpif-netlink: don't allocate per thread netlink sockets

2018-09-21 Thread Ben Pfaff
On Wed, Sep 19, 2018 at 02:47:03PM +0200, Matteo Croce wrote: > When using the kernel datapath, OVS allocates a pool of sockets to handle > netlink events. The number of sockets is: ports * n-handler-threads, where > n-handler-threads is user configurable and defaults to 3/4*number of cores. > >

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix NXT_RESUME flow stats

2018-09-21 Thread Yi-Hung Wei
On Fri, Sep 21, 2018 at 1:22 PM Ben Pfaff wrote: > > On Fri, Sep 21, 2018 at 09:46:51AM -0700, Yi-Hung Wei wrote: > > Currently, OVS does not update the flow stats after a packet is > > restarted by NXT_RESUME message. This patch fixes the aforementioned > > issue and adds an unit test to

Re: [ovs-dev] [PATCH] tests: Fix broken test of 'truncate and output to gre tunnel'

2018-09-21 Thread Ben Pfaff
On Thu, Sep 20, 2018 at 10:49:08AM -0700, Gregory Rose wrote: > On 9/18/2018 2:39 PM, Yifeng Sun wrote: > >The test 'truncate and output to gre tunnel' is broken on certain kernels > >where OVS kernel module and upstream GRE module can't co-exist. This > >patch creates a test that doesn't depend

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix NXT_RESUME flow stats

2018-09-21 Thread Ben Pfaff
On Fri, Sep 21, 2018 at 09:46:51AM -0700, Yi-Hung Wei wrote: > Currently, OVS does not update the flow stats after a packet is > restarted by NXT_RESUME message. This patch fixes the aforementioned > issue and adds an unit test to prevent regression. > > Fixes: 77ab5fd2a95b ("Implement

Re: [ovs-dev] [branch 2.9] dhparams: Fix .c file generation with OpenSSL >= 1.1.1-pre9

2018-09-21 Thread Ben Pfaff
On Fri, Sep 21, 2018 at 06:25:22PM +0200, Timothy Redaelli wrote: > Since OpenSSL upstream commit 201b305a2409 > ("apps/dsaparam.c generates code that is intended to be pasted or included > into > an existing source file: the function is static, and the code doesn't include > dsa.h. Match the

Re: [ovs-dev] [PATCH v2] OVN: add CT_LB action to ovn-trace

2018-09-21 Thread Ben Pfaff
On Fri, Sep 21, 2018 at 03:45:00PM +0200, Lorenzo Bianconi wrote: > > Here's a version that improves on these dimensions. I have not tested > > it. What do you think? > > thx for fixing these bits. The patch works properly, just one comment inline ... > > +} else { > > +

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

2018-09-21 Thread Numan Siddique
On Fri, Sep 21, 2018 at 11:06 PM Guru Shetty wrote: > > > > > > I have tried to make sense of this patch series a few times. I think > > adding increasing complications like this will make gateway code > > unmaintainable. The whole gateway redirect chassis already makes it > > un-understandable

Re: [ovs-dev] [PATCH] ovn: Add DHCP support for option 252.

2018-09-21 Thread Mark Michelson
Thanks! On 09/21/2018 02:38 PM, Ben Pfaff wrote: OK, done. On Fri, Sep 21, 2018 at 02:30:44PM -0400, Mark Michelson wrote: Hi Ben, Sorry for this, but it looks like the OpenStack team wants this in 2.9 as well. If the patch is low-risk enough, is it OK to move there as well? Thanks On

Re: [ovs-dev] [PATCH] ovn: Add DHCP support for option 252.

2018-09-21 Thread Ben Pfaff
OK, done. On Fri, Sep 21, 2018 at 02:30:44PM -0400, Mark Michelson wrote: > Hi Ben, > > Sorry for this, but it looks like the OpenStack team wants this in 2.9 as > well. If the patch is low-risk enough, is it OK to move there as well? > > Thanks > > On 09/18/2018 12:09 AM, Ben Pfaff wrote: >

Re: [ovs-dev] [PATCH] ovs-save: save and restore groups on restart

2018-09-21 Thread Ben Pfaff
On Fri, Sep 21, 2018 at 10:38:41AM -0700, Zak Whittington wrote: > VMware-BZ: 2192560 > Signed-off-by: Zak Whittington Thanks for working on this! It seems odd to me to separate the --bundle option into a separate "echo" command. Why not just put $bundle into each printf? Thanks, Ben.

Re: [ovs-dev] [PATCH] ovs-save: save and restore groups on restart

2018-09-21 Thread Guru Shetty
On Fri, 21 Sep 2018 at 10:38, Zak Whittington wrote: > VMware-BZ: 2192560 > Signed-off-by: Zak Whittington > Acked-by: Gurucharan Shetty > --- > utilities/ovs-save | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/utilities/ovs-save b/utilities/ovs-save

Re: [ovs-dev] [PATCH] ovn: Add DHCP support for option 252.

2018-09-21 Thread Mark Michelson
Hi Ben, Sorry for this, but it looks like the OpenStack team wants this in 2.9 as well. If the patch is low-risk enough, is it OK to move there as well? Thanks On 09/18/2018 12:09 AM, Ben Pfaff wrote: Looks low risk, applies and builds cleanly, so I applied it to branch-2.10. On Mon, Sep

[ovs-dev] [PATCH] flow: Fix uninitialized flow fields in IPv6 error case.

2018-09-21 Thread Ben Pfaff
When parse_ipv6_ext_hdrs__() returned false, half a 64-bit word had been pushed into the miniflow and the second half was left uninitialized. This commit fixes the problem. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10518 Signed-off-by: Ben Pfaff --- lib/flow.c | 11

[ovs-dev] [PATCH] ovs-save: save and restore groups on restart

2018-09-21 Thread Zak Whittington
VMware-BZ: 2192560 Signed-off-by: Zak Whittington --- utilities/ovs-save | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/utilities/ovs-save b/utilities/ovs-save index 2294583..902d331 100755 --- a/utilities/ovs-save +++ b/utilities/ovs-save @@ -121,11 +121,23

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

2018-09-21 Thread Guru Shetty
> > > I have tried to make sense of this patch series a few times. I think > adding increasing complications like this will make gateway code > unmaintainable. The whole gateway redirect chassis already makes it > un-understandable and now this will mean that no one will be able to > understand it

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

2018-09-21 Thread Guru Shetty
On Wed, 1 Aug 2018 at 05:18, wrote: > From: venkata anil > > Previous patches in the series doesn't address issue 1 explained in [1] > i.e > 1) removal of router gateway port MAC address on external switches >after expiring of aging time. > 2) then external switches unable to learn the

Re: [ovs-dev] dhparams: Fix .c file generation with OpenSSL >= 1.1.1-pre9

2018-09-21 Thread 0-day Robot
Bleep bloop. Greetings Timothy Redaelli, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 dhparams: Fix .c file generation with

[ovs-dev] [PATCH] ofproto-dpif: Fix NXT_RESUME flow stats

2018-09-21 Thread Yi-Hung Wei
Currently, OVS does not update the flow stats after a packet is restarted by NXT_RESUME message. This patch fixes the aforementioned issue and adds an unit test to prevent regression. Fixes: 77ab5fd2a95b ("Implement serializing the state of packet traversal in

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

2018-09-21 Thread Justin Pettit
Yes, sorry. I'll take a look early next week. --Justin > On Sep 21, 2018, at 5:47 AM, Anil Venkata wrote: > > Gentle ping :) Thanks > > On Thu, Aug 16, 2018 at 2:05 PM Anil Venkata wrote: > Thanks Ben > > On Wed, Aug 15, 2018 at 6:40 AM, Ben Pfaff wrote: > I've asked Justin to take a

[ovs-dev] [branch 2.9] dhparams: Fix .c file generation with OpenSSL >= 1.1.1-pre9

2018-09-21 Thread Timothy Redaelli
Since OpenSSL upstream commit 201b305a2409 ("apps/dsaparam.c generates code that is intended to be pasted or included into an existing source file: the function is static, and the code doesn't include dsa.h. Match the generated C source style of dsaparam.") "openssl dhparam -C" generates the