Re: [ovs-dev] [PATCH 0/2] Fix Python C extension unicode issues

2018-09-25 Thread Ben Pfaff
Thanks for improving OVS and its tests. When I apply these I get flake8 complaints: ../tests/test-json.py:69:80: E501 line too long (86 > 79 characters) ../tests/test-json.py:85:27: F821 undefined name 'error' Can you do a v2 to avoid those? ___ dev

Re: [ovs-dev] [PATCH v1 1/2] rhel: use _datadir as path prefix for ovs-kmod-manage.sh, fedora

2018-09-25 Thread Ben Pfaff
On Thu, Sep 20, 2018 at 12:19:29PM -0700, Martin Xu wrote: > This patch fixes the path for ovs-kmod-manage.sh script in the > openvswitch-kmod RPM in fedora spec file. Currently the path prefix is > hard coded to /usr/share. Use %{_datadir} instead. > > Fixes 22c33c303932 (rhel: support kmod

Re: [ovs-dev] [PATCH v1 2/2] rhel: fix wrong condition check for ovs-kmod-manage.sh, fedora

2018-09-25 Thread Ben Pfaff
On Thu, Sep 20, 2018 at 12:19:30PM -0700, Martin Xu wrote: > In post-install in kmod fedora spec file, the variables storing > different parts of kernel version numbers are renamed. The condition > check to run ovs-kmod-manage.sh for RHEL 7.2 and 7.4 uses the older > variables. > > Fixes

Re: [ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

2018-09-25 Thread Ben Pfaff
On Tue, Sep 25, 2018 at 10:51:05AM +0200, Matteo Croce wrote: > When using the kernel datapath, OVS allocates a pool of sockets to handle > netlink events. The number of sockets is: ports * n-handler-threads, where > n-handler-threads is user configurable and defaults to 3/4*number of cores. > >

[ovs-dev] [PATCH] dpif: Remove support for multiple queues per port.

2018-09-25 Thread Ben Pfaff
Commit 69c51582ff78 ("dpif-netlink: don't allocate per thread netlink sockets") removed dpif-netlink support for multiple queues per port. No remaining dpif provider supports multiple queues per port, so remove infrastructure for the feature. CC: Matteo Croce Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] ofproto: Handle OpenFlow version mismatch for requestforward with groups.

2018-09-25 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I

Re: [ovs-dev] [PATCH] ovs-save: save and restore groups on restart

2018-09-25 Thread Ben Pfaff
On Tue, Sep 25, 2018 at 02:21:00PM -0700, Guru Shetty wrote: > On Tue, 25 Sep 2018 at 14:18, Ben Pfaff wrote: > > > On Mon, Sep 24, 2018 at 11:18:03AM -0700, Zak Whittington wrote: > > > VMware-BZ: 2192560 > > > Signed-off-by: Zak Whittington > > > > Thanks, applied to master. > > > > Do we

Re: [ovs-dev] [ovs-discuss] RX Mirroing issue with Decap in vxlan case

2018-09-25 Thread Limaye, Namrata
Hi John, Here's the answer to your questions - 1. Can you give more information on your setup? ===Nam) I have back to back connected hosts with OVS running and 2 VMs on each side. VxLan is configured on both sides. Port 101 carries tunneled traffic. This is the configuration. The traffic is

Re: [ovs-dev] [PATCH] ovs-save: save and restore groups on restart

2018-09-25 Thread Guru Shetty
On Tue, 25 Sep 2018 at 14:18, Ben Pfaff wrote: > On Mon, Sep 24, 2018 at 11:18:03AM -0700, Zak Whittington wrote: > > VMware-BZ: 2192560 > > Signed-off-by: Zak Whittington > > Thanks, applied to master. > > Do we need backports for this? > Backports don't hurt. >

Re: [ovs-dev] [PATCH] ovs-save: save and restore groups on restart

2018-09-25 Thread Ben Pfaff
On Mon, Sep 24, 2018 at 11:18:03AM -0700, Zak Whittington wrote: > VMware-BZ: 2192560 > Signed-off-by: Zak Whittington Thanks, applied to master. Do we need backports for this? ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] sparse: check if floatn-common.h is available.

2018-09-25 Thread Ben Pfaff
On Tue, Sep 25, 2018 at 05:46:24PM -0300, Flavio Leitner wrote: > This skip including floatn-common.h if it's not available since it > was introduced in glibc 2.27 and OVS doesn't not actually require > that to work with previous glibc version. > > Fixes: 07aec2ac1 sparse: Support newer GCC/glibc

[ovs-dev] [PATCH] dp-packet.h: move funcs to be within cond block

2018-09-25 Thread Flavio Leitner
There is already an ifdef DPDK_NETDEV block, so instead of checking on each and every function, move them to the right block. No functional change. Signed-off-by: Flavio Leitner --- lib/dp-packet.h | 260 +++- 1 file changed, 146

[ovs-dev] [PATCH] sparse: check if floatn-common.h is available.

2018-09-25 Thread Flavio Leitner
This skip including floatn-common.h if it's not available since it was introduced in glibc 2.27 and OVS doesn't not actually require that to work with previous glibc version. Fixes: 07aec2ac1 sparse: Support newer GCC/glibc versions. Signed-off-by: Flavio Leitner --- configure.ac

Re: [ovs-dev] OVN/OVS split document: Feedback requested

2018-09-25 Thread Aaron Conole
Mark Michelson writes: > What's below the dashed line was originally a Google Doc, which I have > copy-pasted into text form. Some of the formatting has been lost as a > result, but it should still be readable. > > There are quite a few open points of discussion below, including > 1) Ideal repo

[ovs-dev] setting inactivity_probe for Raft connections

2018-09-25 Thread Yun Zhou
Hi, We are scale testing our Raft cluster setup, and saw messages like below in ovsdb-server-sb.log: "2018-09-24T17:36:03.279Z|01246|reconnect|ERR|tcp:10.0.0.88:6644: no response to inactivity probe after 5 seconds, disconnecting" We saw this kind of error before for ovn-central NB/SB

[ovs-dev] (no subject)

2018-09-25 Thread mary moses via dev
Greetings, how are you? I am Mrs. Mary Moses please contact me for more details Mrs. Mary Moses ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

2018-09-25 Thread Flavio Leitner
On Tue, Sep 25, 2018 at 10:51:05AM +0200, Matteo Croce wrote: > When using the kernel datapath, OVS allocates a pool of sockets to handle > netlink events. The number of sockets is: ports * n-handler-threads, where > n-handler-threads is user configurable and defaults to 3/4*number of cores. > >

[ovs-dev] OVN/OVS split document: Feedback requested

2018-09-25 Thread Mark Michelson
What's below the dashed line was originally a Google Doc, which I have copy-pasted into text form. Some of the formatting has been lost as a result, but it should still be readable. There are quite a few open points of discussion below, including 1) Ideal repo structure for OVN, including

Re: [ovs-dev] [PATCH] ovn: Support configuring the BFD params for the tunnel interfaces

2018-09-25 Thread Miguel Angel Ajo Pelayo
Nak, Great work, this will be useful to adjust parameters based on specific network conditions, or while debugging network issues (to reduce flapping). I miss the "mult" parameter to setup the detection multiplier (rx_interval * mult). Thanks a lot, Miguel Ángel. On Tue, Sep 25, 2018 at 5:46

[ovs-dev] [PATCH] dpif-netdev-perf: Clarify frequency number.

2018-09-25 Thread Ilya Maximets
'dpif-netdev/pmd-perf-show' command prints the frequency number calculated from the total number of cycles spent for iterations for the measured period. This number could be confusing, because users may think that it should be equal to CPU frequency, especially on non-x86 systems where TSC

Re: [ovs-dev] [PATCH] IPv6: Add support for match and set nd_options_type and reserved fields.

2018-09-25 Thread Ben Pfaff
On Tue, Sep 18, 2018 at 02:53:00PM +, Vishal Deep Ajmera wrote: > > > > Thanks Ben. Yes, the inner structure is not required. Earlier we > > > defined it as union and later changed it to structure. Instead those > > > fields can be simply defined outside of inner structure. I will fix this >

Re: [ovs-dev] [PATCH] ovn: Support configuring the BFD params for the tunnel interfaces

2018-09-25 Thread Anil Venkata
On Mon, Sep 24, 2018 at 3:12 PM wrote: > From: Numan Siddique > > With this commit the users can override the default BFD params - > min_rx, min_tx and decay_min_rx if desired. This can be useful > to debug any issues related to BFD, like BFD state changes are > seen frequently. > >

Re: [ovs-dev] CPU performance measurement - OvS+DPDK

2018-09-25 Thread Shahaji Bhosle via dev
Hi Ilya, Sorry your emails were going into social folder for some reason, I have marked them important now :) I do the pmd-stats-clear before all the runs and the traffic is started after clear-stats. I am not changing SMAC, just DMAC, and my packet generator (Ixia) is directly connected to my

Re: [ovs-dev] ovs-appctl dpif-netdev/pmd-perf-show

2018-09-25 Thread Shahaji Bhosle via dev
Thanks Ilya, Sorry your emails were going into social media folder on gmail :(, just saw it. One more thing I notice, that the idle and busy cycles %ages will drift if I leave the traffic running over nightI was expecting them to stay same for the same traffic pattern. Thanks, Shahaji On Tue,

Re: [ovs-dev] ovs-appctl dpif-netdev/pmd-perf-show

2018-09-25 Thread Ilya Maximets
Hi. "Cycles" are the total number of cycles measured for the period. The number of GHz is just that number divided by the time, i.e it should be equal to your TSC frequency. I think we need to clarify it more, because it's unclear. On x86 systems this number will usually be equal to the CPU

Re: [ovs-dev] [PATCH] IPv6: Add support for match and set nd_options_type and reserved fields.

2018-09-25 Thread Vishal Deep Ajmera
> > > > That is good to know, but the inner struct is not the main issue as I see > > it. > > The main issue is that the change breaks the ABI. This change must be > > implemented in some way that does not break the ABI. > > Hi Ben, > Are there any guidelines or mechanism available to extend

[ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

2018-09-25 Thread Matteo Croce
When using the kernel datapath, OVS allocates a pool of sockets to handle netlink events. The number of sockets is: ports * n-handler-threads, where n-handler-threads is user configurable and defaults to 3/4*number of cores. This because vswitchd starts n-handler-threads threads, each one with a

[ovs-dev] Bug: select group with dp_hash causing recursive recirculation

2018-09-25 Thread Zang MingJie
Hi, we found a serious problem where one pmd is stop working, I want to share the problem and find solution here. vswitchd log: 2018-09-13T23:36:44.377Z|40269235|dpif_netdev(pmd45)|WARN|Packet dropped. Max recirculation depth exceeded.

Re: [ovs-dev] [PATCH] conntrack: invalid packet should not modify ct state

2018-09-25 Thread Zang MingJie
On Thu, Sep 20, 2018 at 8:47 AM Darrell Ball wrote: > > > On Fri, Sep 14, 2018 at 1:46 AM, Zang MingJie > wrote: > >> >> > Did you notice this check ? >> >> > >> >> > if (src->state < CT_DPIF_TCPS_SYN_SENT) { >> >> > /* First packet from this end. Set its state */ >> >> >> >> Yes,

Re: [ovs-dev] Wachtwoord verloopt enkele dagen tijd

2018-09-25 Thread Lizelotte Smits
Beste e-mailgebruiker. Uw Outlook E-MAILACCOUNT PASSWORD verloopt enkele dagen, en u wordt binnen 24 uur verzocht aan de ICT Help Desk om uw e-mailaccount van Outlook uit te schakelen. Klik op ICT Help