From: Numan Siddique
With this commit the users can override the default values of
the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
This can be useful to debug any issues related to BFD, like BFD
state changes seen frequently.
ovn-controller checks for the options 'ovn-bfd-min-
From: Numan Siddique
With this commit the users can override the default values of
the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
This can be useful to debug any issues related to BFD, like BFD
state changes seen frequently.
ovn-controller checks for the options 'ovn-bfd-min-
On Tue, Sep 25, 2018 at 10:18 PM Miguel Angel Ajo Pelayo <
majop...@redhat.com> wrote:
> Nak,
>
> Great work, this will be useful to adjust parameters based on specific
> network conditions, or while debugging network issues (to reduce flapping).
>
> I miss the "mult" parameter to setup the detect
Hello,
The attached patch plugs memory leaked by calls to ovn_extend_table_init
in tests/test-ovn.c that are missing a corresponding
ovn_extend_table_destroy.
The patch fixes leaks for the group_table and meter_table objects.
Regards,
Bhargava
Bhargava Shastry
Security in Telecommunications
T
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
---
net/o
Looks great! but you forgot the testing for the mult option. Rather simple
anyway it's obvious it works, but it's my only nit :)
On Wed, Sep 26, 2018 at 10:30 AM Numan Siddique wrote:
>
>
> On Tue, Sep 25, 2018 at 10:18 PM Miguel Angel Ajo Pelayo <
> majop...@redhat.com> wrote:
>
>> Nak,
>>
On 09/21/2018 11:12 AM, Ophir Munk wrote:
> 1. Enable compilation and linkage with dpdk 18.08.0
> The following dpdk commits which were introduced after dpdk 17.11.x
> require OVS updates to accommodate to the dpdk changes.
> - ce17edde ("ethdev: introduce Rx queue offloads API")
> - ab3ce1e0 ("eth
Hi Pravin,
On Wed, 15 Aug 2018 00:19:39 -0700
Pravin Shelar wrote:
> I understand fairness has cost, but we need to find right balance
> between performance and fairness. Current fairness scheme is a
> lockless algorithm without much computational overhead, did you try to
> improve current algor
From: Numan Siddique
With this commit the users can override the default values of
the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
This can be useful to debug any issues related to BFD, like BFD
state changes seen frequently.
ovn-controller checks for the options 'ovn-bfd-min-
From: Bhargava Shastry
Signed-off-by: Bhargava Shastry
---
tests/test-ovn.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/test-ovn.c b/tests/test-ovn.c
index 5e6d1c3b4..ebaf21673 100644
--- a/tests/test-ovn.c
+++ b/tests/test-ovn.c
@@ -1347,6 +1347,8 @@ test_parse_actions(struct o
Thank you,
Acked-By: Miguel Angel Ajo Pelayo
On Wed, Sep 26, 2018 at 12:46 PM wrote:
> From: Numan Siddique
>
> With this commit the users can override the default values of
> the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
> This can be useful to debug any issues related t
Bleep bloop. Greetings Bhargava Shastry, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Bhargava Shastry needs to sign
off.
WARNING: Unexpected sign-offs from deve
On Tue, Sep 25, 2018 at 10:22 PM Limaye, Namrata
wrote:
>
> Hi John,
>
> Here's the answer to your questions -
>
Thanks for the info.
> 1. Can you give more information on your setup?
> ===Nam) I have back to back connected hosts with OVS running and 2 VMs on
> each side. VxLan is configured on
This patch addresses the issue that the conntrack fields associated
with a packet are missing after a packet is resumed by NXT_RESUME.
For example, the last rule in the following OpenFlow pipeline is not
working without this patch.
table=0, arp,in_port=1 action=2
table=0, arp,in_port=2 action=1
ta
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Yi-Hung Wei needs to sign off.
Lines checked: 41, Warnings: 0, Errors: 1
Please
Hi,
It looks like your attachment is not present. I'm not sure if you forgot
to attach it or if one of the hops along the way stripped the patch off.
The easiest way to send a patch to this list is to use `git send-email`.
This will send the e-mail in-line. You can find more information about
Ilya Maximets (2):
dpif-netdev-unixctl: Change 'masked' to 'megaflow'.
dpif-netdev-perf: Print SMC statistics.
lib/dpif-netdev-perf.c | 3 +++
lib/dpif-netdev-perf.h | 2 +-
lib/dpif-netdev-unixctl.man | 3 ++-
3 files changed, 6 insertions(+), 2 deletions(-)
--
2.17.1
__
Printing of the SMC hits missed in the 'dpif-netdev/pmd-perf-show'
appctl command.
CC: Yipeng Wang
Fixes: 60d8ccae135f ("dpif-netdev: Add SMC cache after EMC cache")
Signed-off-by: Ilya Maximets
---
lib/dpif-netdev-perf.c | 3 +++
lib/dpif-netdev-perf.h | 2 +-
lib/dpif-netdev-unixctl
In the review process of the original patch 'masked hits' stat
was renamed to 'megaflow hits', but the man page wasn't updated.
Fixes: 6553d06bd179 ("dpif-netdev: Add dpif-netdev/pmd-stats-*
appctl commands.")
Signed-off-by: Ilya Maximets
---
lib/dpif-netdev-unixctl.man | 2
Hi Ben,
Flavio acked this patch as well. I received the email with no problem.
Martin
On Tue, Sep 25, 2018 at 3:25 PM Ben Pfaff wrote:
> On Thu, Sep 20, 2018 at 12:19:30PM -0700, Martin Xu wrote:
> > In post-install in kmod fedora spec file, the variables storing
> > different parts of kernel
From: YueHaibing
Date: Wed, 26 Sep 2018 17:15:38 +0800
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_t
Looks good to me, thanks.
Reviewed-by: Yifeng Sun
On Mon, Sep 24, 2018 at 9:33 PM Ben Pfaff wrote:
> The call to ovsdb_datum_diff() initializes 'new', so it's not necessary to
> also do it in ovsdb_datum_apply_diff().
>
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ovsdb-da
Ben Pfaff writes:
> I've noticed recently an annoying quantity of error messages like the
> following in builds in various places:
>
> gcc: error: unrecognized command line option ‘-Wunknown-warning-option’
>
> This didn't really make sense because OVS checks whether the compiler
> supports w
On Fri, Sep 7, 2018 at 4:59 PM Han Zhou wrote:
>
>
>
> On Fri, Sep 7, 2018 at 2:51 PM Ben Pfaff wrote:
> >
> > On Fri, Sep 07, 2018 at 02:50:34PM -0700, Ben Pfaff wrote:
> > > On Wed, Sep 05, 2018 at 05:11:01PM -0700, Han Zhou wrote:
> > > > On Wed, Sep 5, 2018 at 2:34 PM Ben Pfaff wrote:
> > >
Hi Zang,
Thanks for reporting this bug. As I see it, the check on dp_hash != 0 in
ofproto-dpif-xlate.c is there to guarantee that a dp_hash value has been
computed for the packet once before, not necessarily that a new one is computed
for each translated select group. That's why a check for a v
On Wed, Sep 26, 2018 at 01:26:46PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > I've noticed recently an annoying quantity of error messages like the
> > following in builds in various places:
> >
> > gcc: error: unrecognized command line option ‘-Wunknown-warning-option’
> >
> > This
Thanks, applied to master.
On Wed, Sep 26, 2018 at 10:25:23AM -0700, Yifeng Sun wrote:
> Looks good to me, thanks.
>
> Reviewed-by: Yifeng Sun
>
> On Mon, Sep 24, 2018 at 9:33 PM Ben Pfaff wrote:
>
> > The call to ovsdb_datum_diff() initializes 'new', so it's not necessary to
> > also do it i
Thanks, applied to master also.
On Wed, Sep 26, 2018 at 10:19:44AM -0700, Martin Xu wrote:
> Hi Ben,
>
> Flavio acked this patch as well. I received the email with no problem.
>
> Martin
>
> On Tue, Sep 25, 2018 at 3:25 PM Ben Pfaff wrote:
>
> > On Thu, Sep 20, 2018 at 12:19:30PM -0700, Marti
On Wed, Sep 26, 2018 at 09:33:27AM -0700, Yi-Hung Wei wrote:
> This patch addresses the issue that the conntrack fields associated
> with a packet are missing after a packet is resumed by NXT_RESUME.
> For example, the last rule in the following OpenFlow pipeline is not
> working without this patch
Move the IPHelper Instance to the main header file and update the usage to
explicitly point to POVS_IPHELPER_INSTANCE instead of PVOID. Also rename
the ipn->context to ipn->instance to make it more readable.
Found by inspection.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/IpHelp
On Wed, Sep 26, 2018 at 03:11:40PM +0200, bshas...@sect.tu-berlin.de wrote:
> From: Bhargava Shastry
>
> Signed-off-by: Bhargava Shastry
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo
On Wed, Sep 26, 2018 at 04:14:18PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> With this commit the users can override the default values of
> the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
> This can be useful to debug any issues related to BFD, like BFD
> st
There have been fixed to column tracking since then. Try a newer
version.
On Thu, Sep 20, 2018 at 05:10:46PM +0530, Arunkumar Rg wrote:
> Forgot to mention that I'm using OVS 2.7.2.
>
> Thanks,
> Arun.
>
> On Thu, Sep 20, 2018 at 5:08 PM Arunkumar Rg wrote:
>
> > Hi,
> >
> > I have a ovsdb-cl
Hi Kevin,
I have reviews to be addressed in v5 which may change v4.
Therefore I suggest sending v5 (hopefully) as the final version for this PATCH.
Please let me know if you still want me to resend v4 to the ML.
Regards,
Ophir
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@re
On Fri, Sep 14, 2018 at 05:19:24PM +0200, Lorenzo Bianconi wrote:
> Add buffering support for IPv4 packets that will be processed
> by arp {} action when L2 address is not discovered yet since
> otherwise the packet will be substituted with an ARP frame and
> this will result in the lost of the fir
On Wed, Sep 26, 2018 at 03:07:52PM -0700, Ben Pfaff wrote:
> On Fri, Sep 14, 2018 at 05:19:24PM +0200, Lorenzo Bianconi wrote:
> > Add buffering support for IPv4 packets that will be processed
> > by arp {} action when L2 address is not discovered yet since
> > otherwise the packet will be substitu
This patch addresses the issue that the conntrack fields associated
with a packet are missing after a packet is resumed by NXT_RESUME.
For example, the last rule in the following OpenFlow pipeline is not
working without this patch.
table=0, arp,in_port=1 action=2
table=0, arp,in_port=2 action=1
ta
On Wed, Sep 26, 2018 at 1:33 PM Ben Pfaff wrote:
>
> On Wed, Sep 26, 2018 at 09:33:27AM -0700, Yi-Hung Wei wrote:
> > This patch addresses the issue that the conntrack fields associated
> > with a packet are missing after a packet is resumed by NXT_RESUME.
> > For example, the last rule in the fol
---
Este correo electrónico ha sido comprobado en busca de virus por AVG.
http://www.avg.com
___
dev mailin
On Wed, Sep 26, 2018 at 03:08:03PM -0700, Yi-Hung Wei wrote:
> This patch addresses the issue that the conntrack fields associated
> with a packet are missing after a packet is resumed by NXT_RESUME.
> For example, the last rule in the following OpenFlow pipeline is not
> working without this patch
It looks good to me, and testing shows no problem. Thanks.
Tested-by: Yifeng Sun
Reviewed-by: Yifeng Sun
On Tue, Sep 25, 2018 at 3:14 PM Ben Pfaff wrote:
> Commit 69c51582ff78 ("dpif-netlink: don't allocate per thread netlink
> sockets") removed dpif-netlink support for multiple queues per po
This patch addresses the issue that the conntrack fields associated
with a packet are missing after a packet is resumed by NXT_RESUME.
For example, the last rule in the following OpenFlow pipeline is not
working without this patch.
table=0, arp,in_port=1 action=2
table=0, arp,in_port=2 action=1
ta
On Wed, Sep 26, 2018 at 3:27 PM Ben Pfaff wrote:
>
> On Wed, Sep 26, 2018 at 03:08:03PM -0700, Yi-Hung Wei wrote:
> > This patch addresses the issue that the conntrack fields associated
> > with a packet are missing after a packet is resumed by NXT_RESUME.
> > For example, the last rule in the fol
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -W
On Mon, Sep 24, 2018 at 10:59:34PM +0530, Anju Thomas wrote:
> OVS does not do load balancing for select group buckets in case of mpls
> tagged packets.
> After an MPLS pop action, the expectation is to trigger recirculation .
> This recirculation will ensure an RSS re-computation which will ensur
Thanks, applied to master.
On Wed, Sep 26, 2018 at 03:29:16PM -0700, Yifeng Sun wrote:
> It looks good to me, and testing shows no problem. Thanks.
>
> Tested-by: Yifeng Sun
> Reviewed-by: Yifeng Sun
>
> On Tue, Sep 25, 2018 at 3:14 PM Ben Pfaff wrote:
>
> > Commit 69c51582ff78 ("dpif-netlin
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -W
On Wed, Sep 26, 2018 at 03:47:15PM -0700, Yi-Hung Wei wrote:
> This patch addresses the issue that the conntrack fields associated
> with a packet are missing after a packet is resumed by NXT_RESUME.
> For example, the last rule in the following OpenFlow pipeline is not
> working without this patch
On Wed, Sep 26, 2018 at 10:29 PM Yifeng Sun wrote:
>
> It looks good to me, and testing shows no problem. Thanks.
>
> Tested-by: Yifeng Sun
> Reviewed-by: Yifeng Sun
>
Works fine here too.
Regards,
--
Matteo Croce
per aspera ad upstream
___
dev maili
GCC 4.8.x and possibly other versions don't like a designated initializer
for an anonymous struct, see e.g.
https://travis-ci.org/openvswitch/ovs/jobs/433747674
Fixes: f836888d28ec ("ofproto: Handle OpenFlow version mismatch for
requestforward with groups.")
Signed-off-by: Ben Pfaff
---
ofproto
Signed-off-by: Ben Pfaff
---
datapath-windows/ovsext/IpFragment.c | 4 ++--
datapath-windows/ovsext/IpFragment.h | 2 +-
ovn/controller/pinctrl.c | 2 +-
tests/ofproto-dpif.at| 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/datapath-windows/ovse
On Wed, Sep 26, 2018 at 03:53:17PM -0700, Yi-Hung Wei wrote:
> On Wed, Sep 26, 2018 at 3:27 PM Ben Pfaff wrote:
> >
> > On Wed, Sep 26, 2018 at 03:08:03PM -0700, Yi-Hung Wei wrote:
> > > This patch addresses the issue that the conntrack fields associated
> > > with a packet are missing after a pac
On Wed, Sep 26, 2018 at 4:07 PM Ben Pfaff wrote:
>
> On Wed, Sep 26, 2018 at 03:47:15PM -0700, Yi-Hung Wei wrote:
> > This patch addresses the issue that the conntrack fields associated
> > with a packet are missing after a packet is resumed by NXT_RESUME.
> > For example, the last rule in the fol
On Wed, Sep 19, 2018 at 01:32:57PM -0700, Justin Pettit wrote:
> If an agent address is not provided, OVS tries to choose a source
> address based on the source IP that would be used to connect to the
> sFlow collector. The code previously set the agent address to the
> collector's address instead
On Wed, Sep 26, 2018 at 04:15:17PM -0700, Yi-Hung Wei wrote:
> On Wed, Sep 26, 2018 at 4:07 PM Ben Pfaff wrote:
> >
> > On Wed, Sep 26, 2018 at 03:47:15PM -0700, Yi-Hung Wei wrote:
> > > This patch addresses the issue that the conntrack fields associated
> > > with a packet are missing after a pac
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstr
Hello
Please i still await your response regarding my previous email.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Sep 26, 2018, at 4:12 PM, Ben Pfaff wrote:
>
> Signed-off-by: Ben Pfaff
Ha.
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Sep 26, 2018, at 4:11 PM, Ben Pfaff wrote:
>
> GCC 4.8.x and possibly other versions don't like a designated initializer
> for an anonymous struct, see e.g.
> https://travis-ci.org/openvswitch/ovs/jobs/433747674
>
> Fixes: f836888d28ec ("ofproto: Handle OpenFlow version mismatch for
> re
Hi Simon,
Thanks for your review comments. Please see my response inline.
On Mon, Sep 24, 2018 at 8:02 PM Simon Horman wrote:
>
> On Sat, Sep 15, 2018 at 09:40:08PM +0530, Sriharsha Basavapatna via dev wrote:
> > This is the first patch in the patch-set to support dynamic rebalancing
> > of offl
Hi Simon,
Thanks for your review comments; please see my response inline.
On Mon, Sep 24, 2018 at 8:07 PM Simon Horman wrote:
>
> Hi Sriharsha,
>
> thanks for your patch.
>
> On Sat, Sep 15, 2018 at 09:40:09PM +0530, Sriharsha Basavapatna via dev wrote:
> > This is the second patch in the patch-
Hi Simon,
Thanks for your review comments; please see my response inline.
On Mon, Sep 24, 2018 at 8:16 PM Simon Horman wrote:
>
> Hi Sriharsha,
>
> thanks for your patch.
>
> I am pleased to see work in this area. I do however, have some questions
> about the implementation. Please see comments
With the current OVS offload design, when an offload-device fails to add a
flow rule and returns an error, OVS adds the rule to the kernel datapath.
The flow gets processed by the kernel datapath for the entire life of that
flow. This is fine when an error is returned by the device due to lack of
s
This is the first patch in the patch-set to support dynamic rebalancing
of offloaded flows.
The patch detects OOR condition on a netdev port when ENOSPC error is
returned by TC-Flower while adding a flow rule. A new structure is added
to the netdev called "netdev_hw_info", to store OOR related inf
This is the second patch in the patch-set to support dynamic rebalancing
of offloaded flows.
The packets-per-second (pps) rate for each flow is computed in the context
of revalidator threads when the flow stats are retrieved. The pps-rate is
computed only after a flow is revalidated and is not sch
This is the third patch in the patch-set to support dynamic rebalancing
of offloaded flows.
The dynamic rebalancing functionality is implemented in this patch. The
ukeys that are not scheduled for deletion are obtained and passed as input
to the rebalancing routine. The rebalancing is done in the
Bleep bloop. Greetings Sriharsha Basavapatna via dev, I am a robot and I have
tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Sriharsha Basavapatna via dev needs to
sign off.
WARNING: Unex
Bleep bloop. Greetings Sriharsha Basavapatna via dev, I am a robot and I have
tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: sha1 information is lacking or useless (lib/dpif-netlink.c).
Repository lac
68 matches
Mail list logo
