On 3 Oct 2018, at 1:02, Ben Pfaff wrote:
> The function comment for netdev_queue_dump_next() said that it cleared its
> 'detail' argument, but it didn't actually do that, which meant that details
> could be incorrectly carried along from one queue to the next.
>
> Reported-by: Flavio Leitner
> Si
On 3 Oct 2018, at 1:03, Ben Pfaff wrote:
This reverts commit 6b4d0211e84a ("bridge: Fix ovs-appctl qos/show
repeated queue information"), which is no longer necessary now that
commit 65f3c34c7417 ("netdev: Properly clear 'details' when iterating
in NETDEV_QOS_FOR_EACH.") has been applied. Th
Hello,
My name is Zhanghao and I am a student major in software engineering of
Tsinghua university. I am learning SDN and very interested in ovs. I want to do
some contribution to it but meet some difficulties.
To be exactly, I want to add a new kind of flow, which may need process
specially.
On Wed, Oct 3, 2018 at 2:46 PM zhang hao wrote:
> Hello,
>
> My name is Zhanghao and I am a student major in software engineering of
> Tsinghua university. I am learning SDN and very interested in ovs. I want
> to do some contribution to it but meet some difficulties.
>
> To be exactly, I want to
Hi Gowrishankar,
Thanks for your comments & suggestions
Replies inline ..
Regards & Thanks
Anju
-Original Message-
From: Gowrishankar Muthukrishnan [mailto:gmuth...@redhat.com]
Sent: Thursday, September 27, 2018 4:28 PM
To: Keshav Gupta
Cc: d...@openvswitch.org; Anju Thomas
Subject:
---
Este correo electrónico ha sido comprobado en busca de virus por AVG.
http://www.avg.com
___
dev mailing list
d...@openvs
On Fri, Sep 21, 2018 at 2:29 AM Mark Michelson wrote:
> Hi Numan,
>
> I understand the code and the use case pretty well here. There's another
> open issue from OpenStack regarding SR-IOV:
> https://bugzilla.redhat.com/show_bug.cgi?id=1613384
>
> With this patch, this will mean that an external p
On Fri, Sep 28, 2018 at 05:15:03PM +0100, Tiago Lam wrote:
> From: Mark Kavanagh
>
> dp_packets are created using xmalloc(); in the case of OvS-DPDK, it's
> possible the the resultant mbuf portion of the dp_packet contains
> random data. For some mbuf fields, specifically those related to
> multi
Hi Tiago,
Thanks for working on this. This is my first pass trying to wrap my head
around the whole thing, so I may have missed something.
See below.
On Fri, Sep 28, 2018 at 05:15:02PM +0100, Tiago Lam wrote:
> From: Mark Kavanagh
>
> There are numerous factors that must be considered when c
On Fri, Sep 28, 2018 at 05:15:04PM +0100, Tiago Lam wrote:
> When enabled with DPDK OvS deals with two types of packets, the ones
> coming from the mempool and the ones locally created by OvS - which are
> copied to mempool mbufs before output. In the latter, the space is
> allocated from the syste
On Fri, Sep 28, 2018 at 05:15:05PM +0100, Tiago Lam wrote:
> A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise
> allocation and free operations by non-pmd threads on a given mempool.
>
> free_dpdk_buf() has been modified to make use of the introduced mutex.
>
> Signed-off-by: Tiago
On Fri, Sep 28, 2018 at 05:15:06PM +0100, Tiago Lam wrote:
> When a dp_packet is from a DPDK source, and it contains multi-segment
> mbufs, the data_len is not equal to the packet size, pkt_len. Instead,
> the data_len of each mbuf in the chain should be considered while
> distributing the new (pro
On Fri, Sep 28, 2018 at 05:15:07PM +0100, Tiago Lam wrote:
> Most helper functions in dp-packet assume that the data held by a
> dp_packet is contiguous, and perform operations such as pointer
> arithmetic under that assumption. However, with the introduction of
> multi-segment mbufs, where data is
On Fri, Sep 28, 2018 at 05:15:09PM +0100, Tiago Lam wrote:
> From: Michael Qiu
>
> When doing packet clone, if packet source is from DPDK driver,
> multi-segment must be considered, and copy the segment's data one by
> one.
>
> Also, lots of DPDK mbuf's info is missed during a copy, like packet
On Fri, Sep 28, 2018 at 05:15:08PM +0100, Tiago Lam wrote:
> In its current implementation dp_packet_shift() is also unaware of
> multi-seg mbufs (that holds data in memory non-contiguously) and assumes
> that data exists contiguously in memory, memmove'ing data to perform the
> shift.
>
> To add
Hi Tiago,
There is a lot to digest in this patch, so I only have a general
comment about it for now.
See below.
On Fri, Sep 28, 2018 at 05:15:10PM +0100, Tiago Lam wrote:
> Previous commits have added support to the dp_packet API to handle
> multi-segmented packets, where data is not stored co
On Fri, Sep 28, 2018 at 05:15:11PM +0100, Tiago Lam wrote:
> From: Mark Kavanagh
>
> Currently, packets are only copied to a single segment in the function
> dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames,
> particularly when multi-segment mbufs are involved.
>
> This patc
On Fri, Sep 28, 2018 at 05:15:12PM +0100, Tiago Lam wrote:
> From: Mark Kavanagh
>
> Currently, jumbo frame support for OvS-DPDK is implemented by
> increasing the size of mbufs within a mempool, such that each mbuf
> within the pool is large enough to contain an entire jumbo frame of
> a user-de
On Fri, Sep 28, 2018 at 05:15:14PM +0100, Tiago Lam wrote:
> As it stands, OVS_DPDK_START() won't allow other configs to be set
> before starting the ovs-vswitchd daemon. This is a problem since some
> configs, such as the "dpdk-multi-seg-mbufs=true" for enabling the
> multi-segment mbufs, need to
On Fri, Sep 28, 2018 at 05:15:13PM +0100, Tiago Lam wrote:
> In order to create a minimal environment that allows the tests to get
> mbufs from an existing mempool, the following approach is taken:
> - EAL is initialised (by using the main dpdk_init()) and a (very) small
> mempool is instantiated
On Mon, Oct 01, 2018 at 02:12:29PM -0700, Han Zhou wrote:
> From: Han Zhou
>
> When there are tunnel ports with BFD enabled, all UDP flows will have
> dst port as match condition in datapath, which causes unnecessarily
> high flow miss for all UDP traffic, and results in latency increase.
> For m
On Wed, Oct 03, 2018 at 02:05:30PM -0700, Ben Pfaff wrote:
> On Mon, Oct 01, 2018 at 02:12:29PM -0700, Han Zhou wrote:
> > From: Han Zhou
> >
> > When there are tunnel ports with BFD enabled, all UDP flows will have
> > dst port as match condition in datapath, which causes unnecessarily
> > high
Thanks Flavio and Eelco. I applied these patches to master and
backported as far as they would go.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Signed-off-by: Mark Michelson
---
ovn/utilities/ovn-nbctl.8.xml | 22 +
ovn/utilities/ovn-nbctl.c | 72 +++
tests/ovn.at | 37 ++
3 files changed, 131 insertions(+)
diff --git a/ovn/utilities/ovn-nbctl.8
pcap files with nanosecond resolution use a different magic number in
the pcap header than those with microsecond resolution.
Signed-off-by: Mark Michelson
---
utilities/ovs-pcap.in | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/utilities/ovs-pcap.in b/utilities/ovs-p
On Wed, Oct 03, 2018 at 05:14:42PM -0400, Mark Michelson wrote:
> pcap files with nanosecond resolution use a different magic number in
> the pcap header than those with microsecond resolution.
>
> Signed-off-by: Mark Michelson
Thanks for the fix.
Would you mind fixing ovs_pcap_read_header() in
On Wed, Oct 03, 2018 at 01:15:58AM +0200, bshas...@sect.tu-berlin.de wrote:
> From: Bhargava Shastry
>
> This patch adds a new oss-fuzz target for the ODP
> parser. The target harness has been adapted from test-odp.c. Prominently, it
> leaves out "parse_filter" due to an unresolvable bug in th
On Wed, Oct 03, 2018 at 01:09:41AM +0200, bshas...@sect.tu-berlin.de wrote:
> This patch adds a new oss-fuzz target for the ODP parser. The
> target harness has been adapted from test-odp.c. Prominently, it leaves out
> "parse_filter" due to an unresolvable bug in that code at the time of
> wri
On Wed, Oct 3, 2018 at 2:05 PM Ben Pfaff wrote:
>
> On Mon, Oct 01, 2018 at 02:12:29PM -0700, Han Zhou wrote:
> > From: Han Zhou
> >
> > When there are tunnel ports with BFD enabled, all UDP flows will have
> > dst port as match condition in datapath, which causes unnecessarily
> > high flow miss
On Wed, Oct 03, 2018 at 03:02:54PM -0700, Han Zhou wrote:
> On Wed, Oct 3, 2018 at 2:05 PM Ben Pfaff wrote:
> >
> > On Mon, Oct 01, 2018 at 02:12:29PM -0700, Han Zhou wrote:
> > > From: Han Zhou
> > >
> > > When there are tunnel ports with BFD enabled, all UDP flows will have
> > > dst port as ma
On Wed, Oct 3, 2018 at 3:27 PM Ben Pfaff wrote:
>
> On Wed, Oct 03, 2018 at 03:02:54PM -0700, Han Zhou wrote:
> > On Wed, Oct 3, 2018 at 2:05 PM Ben Pfaff wrote:
> > >
> > > On Mon, Oct 01, 2018 at 02:12:29PM -0700, Han Zhou wrote:
> > > > From: Han Zhou
> > > >
> > > > When there are tunnel por
This header only defines sockaddr_pkt, which this source file doesn't use.
This was the only user of net/if_packet.h, so also remove the
configure-time test for it (which netdev-linux wasn't using anyway).
Reported-by: Andre McCurdy
Reported-at: https://github.com/openvswitch/ovs/pull/253
Signed
> On Oct 2, 2018, at 3:53 PM, Ben Pfaff wrote:
>
> -Anupam Chanda acha...@nicira.com
> +Anupam Chanda acha...@vmware.com
I don't think Anupam is at VMware anymore.
> -Shih-Hao Lis...@nicira.com
> +Shih-Hao Li
Shih-Hao is still
> On Oct 3, 2018, at 3:39 PM, Ben Pfaff wrote:
>
> This header only defines sockaddr_pkt, which this source file doesn't use.
>
> This was the only user of net/if_packet.h, so also remove the
> configure-time test for it (which netdev-linux wasn't using anyway).
>
> Reported-by: Andre McCurdy
> On Sep 6, 2018, at 7:30 PM, Ben Pfaff wrote:
>
> Open vSwitch 2.4 introduced an OVSDB extension in which a column with
> type optional integer or real could be compared with the operators <,
> <=, >, and >=. At the same time, it broke the implementation of the
> operators ==, !=, includes, a
This patch exposes jsonrpc.h for inclusion in C++, which will be
used by NSX.
It added [extern "C"] to the header file and fixed other places
to accommodate this change.
Signed-off-by: Yifeng Sun
---
include/openvswitch/automake.mk | 1 +
include/openvswitch/jsonrpc.h | 153
> On Sep 6, 2018, at 7:30 PM, Ben Pfaff wrote:
>
> When relational comparisons against optional scalars were introduced, it
> was meant to work only when the right-hand side of the comparison was a
> scalar, not the empty set. The implementation wasn't that picky. This
> commit fixes the prob
> On Sep 6, 2018, at 7:30 PM, Ben Pfaff wrote:
>
> "must have exactly one member" is much better than "must have 1 to 1
> members".
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://
On Wed, Oct 03, 2018 at 04:10:03PM -0700, Justin Pettit wrote:
>
> > On Sep 6, 2018, at 7:30 PM, Ben Pfaff wrote:
> >
> > "must have exactly one member" is much better than "must have 1 to 1
> > members".
> >
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Justin Pettit
Thanks. I applied all of
On Thu, Sep 06, 2018 at 07:30:10PM -0700, Ben Pfaff wrote:
> Open vSwitch 2.4 introduced an OVSDB extension in which a column with
> type optional integer or real could be compared with the operators <,
> <=, >, and >=. At the same time, it broke the implementation of the
> operators ==, !=, inclu
On Wed, Oct 03, 2018 at 04:07:22PM -0700, Yifeng Sun wrote:
> This patch exposes jsonrpc.h for inclusion in C++, which will be
> used by NSX.
>
> It added [extern "C"] to the header file and fixed other places
> to accommodate this change.
>
> Signed-off-by: Yifeng Sun
Is this useful by itself?
On Wed, Oct 03, 2018 at 03:51:40PM -0700, Justin Pettit wrote:
>
> > On Oct 3, 2018, at 3:39 PM, Ben Pfaff wrote:
> >
> > This header only defines sockaddr_pkt, which this source file doesn't use.
> >
> > This was the only user of net/if_packet.h, so also remove the
> > configure-time test for
On Wed, Oct 03, 2018 at 03:49:46PM -0700, Justin Pettit wrote:
>
> > On Oct 2, 2018, at 3:53 PM, Ben Pfaff wrote:
> >
> > -Anupam Chanda acha...@nicira.com
> > +Anupam Chanda acha...@vmware.com
>
> I don't think Anupam is at VMware anymore.
>
> > -Shih
On Wed, Oct 03, 2018 at 03:30:48PM -0700, Han Zhou wrote:
> On Wed, Oct 3, 2018 at 3:27 PM Ben Pfaff wrote:
> >
> > On Wed, Oct 03, 2018 at 03:02:54PM -0700, Han Zhou wrote:
> > > On Wed, Oct 3, 2018 at 2:05 PM Ben Pfaff wrote:
> > > >
> > > > On Mon, Oct 01, 2018 at 02:12:29PM -0700, Han Zhou wr
From: Han Zhou
Current ovs-ctl forces to set full hostname in external-ids. In
some situation users may want to set short hostname. For example,
in OpenStack - OVN integration, Neutron uses the host-id provided
by Nova, which is usually short hostname, to set "requested-chassis"
in OVN. The misma
We need a proper method for external code to send queries to db.sock.
The jsonrpc.h does expose more than what is needed.
Do you have any better suggestion?
Thanks,
Yifeng
On Wed, Oct 3, 2018 at 6:26 PM Ben Pfaff wrote:
> On Wed, Oct 03, 2018 at 04:07:22PM -0700, Yifeng Sun wrote:
> > This patc
Hi Anju,
Thank you reviewing my suggestions.
On 10/03/2018 04:54 PM, Anju Thomas wrote:
> Hi Gowrishankar,
>
> Thanks for your comments & suggestions
>
> Replies inline ..
>
> Regards & Thanks
> Anju
>
>
> -Original Message-
> From: Gowrishankar Muthukrishnan [mailto:gmuth...@redhat.com]
47 matches
Mail list logo
