Sure. I will add ssl usage example with some brief in the ovn-ctl.8.xml and
send v3 for this patch . Does that sound good?
On Mon, Oct 8, 2018 at 5:32 PM Han Zhou wrote:
>
>
> On Mon, Oct 8, 2018 at 4:55 PM aginwala aginwala
> wrote:
> >
> >
> >
> > On Mon, Oct 8, 2018 at 10:47 AM Han Zhou
Hallo mein Geliebter.
Ich grüße dich mit dem Namen unseres Herrn Jesus Christus. Es ist wahr, dass
dieser Brief als Überraschung zu dir kommen kann. Dennoch bitte ich Sie
demütig, mir Ihre Aufmerksamkeit zu schenken und mich gut zu hören. Mein Name
ist Frau Gertrude aus den Vereinigten
On Mon, Oct 8, 2018 at 4:55 PM aginwala aginwala wrote:
>
>
>
> On Mon, Oct 8, 2018 at 10:47 AM Han Zhou wrote:
>>
>>
>>
>> On Fri, Oct 5, 2018 at 6:48 PM aginwala aginwala
wrote:
>> >
>> > Thanks for the review Han. Please find the comments inline below:
>> > On Thu, Oct 4, 2018 at 9:58 AM Han
On Mon, Oct 08, 2018 at 04:23:53PM -0400, Mark Michelson wrote:
> This adds the following commands:
>
> pg-add: Add a new port group, optionally adding switch ports at
> creation.
> pg-set-ports: Sets the logical switch ports on a port group
> pg-del: Remove a port group.
>
> The main motivation
Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author amgin...@gmail.com needs to sign off.
WARNING: Unexpected sign-offs from
Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author amgin...@gmail.com needs to sign off.
WARNING: Unexpected sign-offs from
On Mon, Oct 8, 2018 at 10:47 AM Han Zhou wrote:
>
>
> On Fri, Oct 5, 2018 at 6:48 PM aginwala aginwala
> wrote:
> >
> > Thanks for the review Han. Please find the comments inline below:
> > On Thu, Oct 4, 2018 at 9:58 AM Han Zhou wrote:
> >>
> >> Thanks Ali, please see my comments below
> >>
>
On Mon, Oct 8, 2018 at 2:17 PM Han Zhou wrote:
>
>
> On Mon, Oct 8, 2018 at 11:55 AM aginwala aginwala
> wrote:
> >
> > Yes, that's right. I will send out v2 in a bit with Han's ack.
> >
> >
> > Regards,
> > Aliasgar
> >
> > On Mon, Oct 8, 2018 at 11:04 AM Ben Pfaff wrote:
> >>
> >> On Mon,
When starting OVN DBs in HA using pacemaker with ssl, we need to pass ssl
certs for starting standby DBs. Hence, we need this change.
Signed-off-by: aginwala
Acked-by: Han Zhou
---
ovn/utilities/ovndb-servers.ocf | 72 -
1 file changed, 71 insertions(+),
For OVN DBs to work with SSL in HA, we need to have capability to pass ssl
certs when starting OVN DBs. Say when starting OVN DBs in active passive mode,
in order for the standby DBs to sync from master node, it cannot sync
because the required ssl certs are not passed when standby DBs are
On Windows 2016 LTSC(RTM) the Container feature and Hyper-V feature both had
DCOM API to add and delete internal (management) ports on the Hyper-V switch.
Starting from the 1703 release and above, enabling only the Container feature
does not fulfil this requirement anymore.
We need new ways to
This patch adds the new powershell module HNSHelper.psm1 to the OVS windows
installer.
Signed-off-by: Alin Gabriel Serdean
---
windows/automake.mk | 1 +
windows/ovs-windows-installer/Product.wxs | 6 ++
2 files changed, 7 insertions(+)
diff --git
We introduce a new powershell module for interacting with HNS (host network
service):
https://github.com/Microsoft/SDN/blob/master/Kubernetes/windows/hns.psm1
In our repository this shall be named HNSHelper.psm1.
We also add five new commandlets in our OVS powershell module:
On Mon, Oct 8, 2018 at 1:24 PM Mark Michelson wrote:
>
> This adds the following commands:
>
> pg-add: Add a new port group, optionally adding switch ports at
> creation.
> pg-set-ports: Sets the logical switch ports on a port group
> pg-del: Remove a port group.
>
> The main motivation for these
On Mon, Oct 8, 2018 at 11:55 AM aginwala aginwala
wrote:
>
> Yes, that's right. I will send out v2 in a bit with Han's ack.
>
>
> Regards,
> Aliasgar
>
> On Mon, Oct 8, 2018 at 11:04 AM Ben Pfaff wrote:
>>
>> On Mon, Oct 08, 2018 at 10:58:49AM -0700, Han Zhou wrote:
>> > On Fri, Oct 5, 2018 at
Thanks Ben. Let me try it out this week and report back.
On 10/8/18, 1:15 PM, "Ben Pfaff" wrote:
>I think I see a problem in the implementation of bonding when
>recirculation is available. Are you able to try out a patch? If so,
>try the following. It is not a good way to solve the issue,
This adds the following commands:
pg-add: Add a new port group, optionally adding switch ports at
creation.
pg-set-ports: Sets the logical switch ports on a port group
pg-del: Remove a port group.
The main motivation for these commands is that it allows for adding
logical switch ports by name
I think I see a problem in the implementation of bonding when
recirculation is available. Are you able to try out a patch? If so,
try the following. It is not a good way to solve the issue, but it
should illustrate whether recirculation is the problem.
diff --git a/ofproto/bond.c
On Mon, Oct 08, 2018 at 02:49:06PM -0400, Mark Michelson wrote:
> ovn-nbctl when run in daemon mode has two issues:
> 1) An extra newline is prepended to table output
> 2) Table formatting issues are ignored.
>
> This patch series fixes both issues.
> ---
> v1 -> v2: Added tests on each patch
On Thu, Oct 04, 2018 at 02:23:39PM -0700, Yifeng Sun wrote:
> In the default case when nsh's md_type is not recognized by nsh parser,
> uninitialized data in key->context can sneak into miniflow. This
> patch fixes it.
>
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10519
>
Yes, that's right. I will send out v2 in a bit with Han's ack.
Regards,
Aliasgar
On Mon, Oct 8, 2018 at 11:04 AM Ben Pfaff wrote:
> On Mon, Oct 08, 2018 at 10:58:49AM -0700, Han Zhou wrote:
> > On Fri, Oct 5, 2018 at 6:34 PM aginwala aginwala
> wrote:
> > >
> > > Thanks for the review Han.
On 10/08/2018 11:40 AM, Ben Pfaff wrote:
On Fri, Oct 05, 2018 at 04:05:22PM -0400, Mark Michelson wrote:
Thanks for the feedback Han. Interestingly, when I move the tests from
ovn.at to ovn-nbctl.at, the tests no longer pass. When running in non-daemon
mode, for whatever reason, trying to get
When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse
table formatting options. The problem is that this then removes the table
formatting options from the array of options passed to the server loop. The
server loop resets the table formatting options to the defaults and then
Table formatting has a local static integer that is intended to insert
line breaks between tables. This works exactly as intended, as long as
each call to table_format() is done as a single unit within the run of a
process.
When ovn-nbctl is run in daemon mode, it is a long-running process that
ovn-nbctl when run in daemon mode has two issues:
1) An extra newline is prepended to table output
2) Table formatting issues are ignored.
This patch series fixes both issues.
---
v1 -> v2: Added tests on each patch
---
Mark Michelson (2):
table: Create method for resetting table formatting.
On Mon, 8 Oct 2018 at 11:12, Ben Pfaff wrote:
> On Sun, Oct 07, 2018 at 09:53:15PM -0700, Gurucharan Shetty wrote:
> > We now have an extra space in the o/p of `ovs-ofctl dump-tlv-map`.
> >
> > Fixes: 5a0e4aec1af (treewide: Convert leading tabs to spaces.)
> > Signed-off-by: Gurucharan Shetty
>
On Sat, Oct 06, 2018 at 08:04:09PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> With this commit the users can override the default values of
> the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
> This can be useful to debug any issues related to BFD (like
>
On Sun, Oct 07, 2018 at 09:53:15PM -0700, Gurucharan Shetty wrote:
> We now have an extra space in the o/p of `ovs-ofctl dump-tlv-map`.
>
> Fixes: 5a0e4aec1af (treewide: Convert leading tabs to spaces.)
> Signed-off-by: Gurucharan Shetty
> ---
> utilities/ovs-save | 2 +-
> 1 file changed, 1
On Mon, Oct 08, 2018 at 05:39:04PM +, Stokes, Ian wrote:
> > For what it's worth, Ian, I'm hoping that you'll take a look at this and
> > decide whether to merge it.
>
> Sure, thanks for flagging Ben, apologies for the delay, I've been on
> vacation the past 2 weeks but will have time to look
Thanks for the review! I will come up with a new version.
Yifeng
On Mon, Oct 8, 2018 at 11:02 AM Ben Pfaff wrote:
> On Thu, Oct 04, 2018 at 04:30:10PM -0700, Yifeng Sun wrote:
> > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10714
> > Signed-off-by: Yifeng Sun
> >
On Mon, Oct 08, 2018 at 10:58:49AM -0700, Han Zhou wrote:
> On Fri, Oct 5, 2018 at 6:34 PM aginwala aginwala wrote:
> >
> > Thanks for the review Han. Please find the comments inline below:
> >
> > On Thu, Oct 4, 2018 at 10:16 AM Han Zhou wrote:
> >>
> >> Thanks Ali, please see my comm
> >>
> >>
On Thu, Oct 04, 2018 at 04:30:10PM -0700, Yifeng Sun wrote:
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10714
> Signed-off-by: Yifeng Sun
> Suggested-by: Ben Pfaff
Thanks for fixing this bug.
In parse_chassis_resident(), in two error cases, paren_depth is
incremented
On Fri, Oct 5, 2018 at 6:34 PM aginwala aginwala wrote:
>
> Thanks for the review Han. Please find the comments inline below:
>
> On Thu, Oct 4, 2018 at 10:16 AM Han Zhou wrote:
>>
>> Thanks Ali, please see my comm
>>
>> On Fri, Sep 21, 2018 at 5:38 PM wrote:
>> >
>> > When starting OVN DBs in
On Fri, Oct 5, 2018 at 6:48 PM aginwala aginwala wrote:
>
> Thanks for the review Han. Please find the comments inline below:
> On Thu, Oct 4, 2018 at 9:58 AM Han Zhou wrote:
>>
>> Thanks Ali, please see my comments below
>>
>> On Fri, Sep 21, 2018 at 5:34 PM wrote:
>> >
>> > For OVN DBs to
Hi Ian (or others), do you have any thoughts about this?
On Fri, Sep 28, 2018 at 04:24:33PM -0700, Ben Pfaff wrote:
> I have been playing with the OFTest framework off and on over the last
> few months and I believe it's caught an actual bug with its
> DirectVlanPackets test. I'm appending a
On Thu, Oct 04, 2018 at 01:01:09PM -0700, Han Zhou wrote:
> From: Han Zhou
>
> Current ovs-ctl forces to set full hostname in external-ids. In
> some situation users may want to set short hostname. For example,
> in OpenStack - OVN integration, Neutron uses the host-id provided
> by Nova, which
On Mon, Oct 08, 2018 at 10:23:55AM -0700, Han Zhou wrote:
> On Mon, Oct 8, 2018 at 8:42 AM Ben Pfaff wrote:
> >
> > On Fri, Oct 05, 2018 at 12:14:23PM -0700, Han Zhou wrote:
> > > From: Han Zhou
> > >
> > > This is an enhancement for commit:
> > > 102781c ovsdb-idl: Track changes for table
> For what it's worth, Ian, I'm hoping that you'll take a look at this and
> decide whether to merge it.
Sure, thanks for flagging Ben, apologies for the delay, I've been on vacation
the past 2 weeks but will have time to look at this now.
Thanks
Ian
>
> On Tue, Oct 02, 2018 at 10:32:40AM
On Fri, Oct 05, 2018 at 03:16:50PM -0700, Yifeng Sun wrote:
> This seems to be a copy and paste bug that iterates and frees
> the wrong table. This commit fixes that.
>
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10730
> Co-authored-by: Ben Pfaff
> Signed-off-by: Yifeng
On Mon, Oct 8, 2018 at 8:42 AM Ben Pfaff wrote:
>
> On Fri, Oct 05, 2018 at 12:14:23PM -0700, Han Zhou wrote:
> > From: Han Zhou
> >
> > This is an enhancement for commit:
> > 102781c ovsdb-idl: Track changes for table references.
> >
> > The seqno change is needed so that the change-tracking
Thanks, applied to master, backported as far as 2.7.
On Fri, Oct 05, 2018 at 03:43:03PM -0700, Yifeng Sun wrote:
> This patch should also fix the bug reported at
> https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10802
>
> On Fri, Oct 5, 2018 at 2:50 PM Yifeng Sun wrote:
>
> > After
On Fri, Oct 05, 2018 at 09:19:54AM -0700, Yi-Hung Wei wrote:
> The patch address vswitchd crash when it receives NXT_RESUME with geneve
> tunnel metadata. The crash is due to segmentation fault with the
> following stack trace, and it is observed only in kernel datapath.
> A test is added to
On Fri, Oct 05, 2018 at 06:57:24PM +0200, Lorenzo Bianconi wrote:
> Add buffering support for IPv4/IPv6 packets that will be processed
> by arp{}/nd_ns{} action when L2 address is not discovered yet since
> otherwise the packet will be substituted with an ARP/Neighbor
> Solicitation frame and this
On Fri, Oct 05, 2018 at 10:58:35AM +0100, Markos Chandras wrote:
> On 05/10/2018 09:55, Matteo Croce wrote:
> > On Fri, Oct 5, 2018 at 8:32 AM Markos Chandras wrote:
> >>
> >> On 25/09/2018 22:14, Ben Pfaff wrote:
> >>>
> >>> Applied to master thanks!
> >>>
> >>> I sent a patch to remove support
Current patch-set breaks a lot of STP unit tests:
## --- ##
## openvswitch 2.10.90 test suite. ##
## --- ##
ofproto-dpif
1149: ofproto-dpif - MPLS handlingFAILED
(ofproto-dpif.at:2068)
1164: ofproto-dpif - VLAN+MPLS
We now have an extra space in the o/p of `ovs-ofctl dump-tlv-map`.
Fixes: 5a0e4aec1af (treewide: Convert leading tabs to spaces.)
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-save | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-save b/utilities/ovs-save
On Fri, Oct 05, 2018 at 12:14:23PM -0700, Han Zhou wrote:
> From: Han Zhou
>
> This is an enhancement for commit:
> 102781c ovsdb-idl: Track changes for table references.
>
> The seqno change is needed so that the change-tracking helper function
> ..._is_new() can work properly.
>
>
On Fri, Oct 05, 2018 at 04:05:22PM -0400, Mark Michelson wrote:
> Thanks for the feedback Han. Interestingly, when I move the tests from
> ovn.at to ovn-nbctl.at, the tests no longer pass. When running in non-daemon
> mode, for whatever reason, trying to get the port group's ports from the
>
On Fri, Oct 05, 2018 at 06:40:33PM -0400, Mark Michelson wrote:
> Table formatting has a local static integer that is intended to insert
> line breaks between tables. This works exactly as intended, as long as
> each call to table_format() is done as a single unit within the run of a
> process.
>
On Fri, Oct 05, 2018 at 06:40:34PM -0400, Mark Michelson wrote:
> When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse
> table formatting options. The problem is that this then removes the table
> formatting options from the array of options passed to the server loop. The
>
On Mon, Oct 08, 2018 at 03:15:44PM +, Matteo Croce wrote:
> On Mon, Oct 8, 2018 at 3:11 PM Guru Shetty wrote:
> >
> >
> >
> > On Sat, 6 Oct 2018 at 09:20, Matteo Croce wrote:
> >>
> >> In dpif_netlink_port_add__(), socksp could be NULL, because
> >> vport_socksp_to_pids() would allocate a
In dpif_netlink_port_add__(), socksp could be NULL, because
vport_socksp_to_pids() would allocate a new array and return a single
zero element.
Following vport_socksp_to_pids() removal, a NULL pointer can happen when
dpif_netlink_port_add__() is called and dpif->handlers is 0.
Restore the old
On Mon, Oct 8, 2018 at 3:11 PM Guru Shetty wrote:
>
>
>
> On Sat, 6 Oct 2018 at 09:20, Matteo Croce wrote:
>>
>> In dpif_netlink_port_add__(), socksp could be NULL, because
>> vport_socksp_to_pids() would allocate a new array and return a single
>> zero element.
>> Following
On Sat, 6 Oct 2018 at 09:20, Matteo Croce wrote:
> In dpif_netlink_port_add__(), socksp could be NULL, because
> vport_socksp_to_pids() would allocate a new array and return a single
> zero element.
> Following vport_socksp_to_pids() removal, a NULL pointer can happen when
>
On Sat, Oct 6, 2018 at 4:11 AM Mark Michelson wrote:
> When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse
> table formatting options. The problem is that this then removes the table
> formatting options from the array of options passed to the server loop. The
> server loop
On Sat, Oct 6, 2018 at 4:11 AM Mark Michelson wrote:
> Table formatting has a local static integer that is intended to insert
> line breaks between tables. This works exactly as intended, as long as
> each call to table_format() is done as a single unit within the run of a
> process.
>
> When
From: Bhargava Shastry
Accepts fixes suggested by 0-day robot.
Refactor miniflow tests out of flow_extract_target.c into
a new target called miniflow_target.c
The biggest motivation for this massive (7-10x) increase in fuzzing
speed. Prior to the refactoring, we were doing roughly 900
57 matches
Mail list logo
