Hi Eelco,
Please find comments inline
> -Original Message-
> From: Eelco Chaudron [mailto:echau...@redhat.com]
> Sent: Wednesday, October 24, 2018 1:41 PM
> To: Ophir Munk
> Cc: Thomas Monjalon ; ovs-dev@openvswitch.org;
> Asaf Penso ; Shahaf Shuler
>
> Subject: Re: [ovs-dev] [dpdk-howl
On 25 Oct 2018, at 11:02, Ophir Munk wrote:
Hi Eelco,
Please find comments inline
-Original Message-
From: Eelco Chaudron [mailto:echau...@redhat.com]
Sent: Wednesday, October 24, 2018 1:41 PM
To: Ophir Munk
Cc: Thomas Monjalon ; ovs-dev@openvswitch.org;
Asaf Penso ; Shahaf Shuler
Hi Billy,
The issue of br-flat1 getting deleted is fixed now with the key-value pair
of "datapath_types = netdev,system" in OVS neutron-openvswitch-agent.ini in
the compute node.
Earlier, we used the key-value pair as "datapath_type = netdev". Please
note the new key name we used is "datapath_typ
Hi Manojawa,
Comments below.
BR,
Billy
From: Manojawa Paritala [mailto:manojaw...@biarca.com]
Sent: Thursday, October 25, 2018 10:33 AM
To: O Mahony, Billy
Cc: ovs-disc...@openvswitch.org; ovs-dev@openvswitch.org; Subba Rao Kodavalla
; Song, Kee SangX ; Srinivasa Goda
; Kris Rajana
Subject:
From: Numan Siddique
When 'make check' is called by the mock rpm build (which disables networking),
the test "ovn-nbctl: LBs - daemon" fails when it runs the command
"ovn-nbctl lb-add lb0 30.0.0.1a 192.168.10.10:80,192.168.10.20:80". ovn-nbctl
extracts the vip by calling the socket util function
Hello Dear
Hello Dear,
My Name is Captain james moten, i hope all is well with you? I am a Captain
working as United Nations peace keeping troop in Iraq on war against
terrorism.
I have in my possession the sum of $5.200.000.00 millions
USD Which i made here in Iraq ,
I deposited this money
I'v used ftrace to see which paths we take in the kernel.
I remind you that the packet (in my scenario) looks like the following:
ETH | IP | UDP | VXLAN | L2 | VLAN | IP | TCP | payload
When 8021q is not loaded:
dev_gro_receive <-napi_gro_receive
inet_gro_receive <-dev_gro_receive
udp4_gro_receive
Thu, Oct 25, 2018 at 01:34:04PM CEST, michaels...@gmail.com wrote:
>I'v used ftrace to see which paths we take in the kernel.
>I remind you that the packet (in my scenario) looks like the following:
>ETH | IP | UDP | VXLAN | L2 | VLAN | IP | TCP | payload
>
>When 8021q is not loaded:
>dev_gro_recei
Hi Kevin,
Please find comments inline.
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Friday, October 12, 2018 4:51 PM
> To: Ophir Munk ; ovs-dev@openvswitch.org
> Cc: Asaf Penso ; Sugesh Chandran
> ; Ian Stokes ; Ben
> Pfaff ; Shahaf Shuler ; Thomas
> Monj
Hi Eelco,
Thanks for your comments, please see my response below.
On Fri, Oct 19, 2018 at 7:52 PM Eelco Chaudron wrote:
>
> On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote:
>
> > This is the first patch in the patch-set to support dynamic
> > rebalancing
> > of offloaded flows.
> >
Hi Eelco,
Thanks for your comments, please see my response below.
On Fri, Oct 19, 2018 at 7:52 PM Eelco Chaudron wrote:
>
> On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote:
>
> > This is the second patch in the patch-set to support dynamic
> > rebalancing
> > of offloaded flows.
> >
Hi Eelco,
Thanks for your review comments. Please see my response below.
On Fri, Oct 19, 2018 at 7:53 PM Eelco Chaudron wrote:
>
> On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote:
>
> This is the third patch in the patch-set to support dynamic rebalancing
> of offloaded flows.
>
> T
Hi Eelco,
On Mon, Oct 22, 2018 at 12:30 PM Simon Horman
wrote:
>
> Hi Eelco,
>
> Thanks for your review and sorry for missing it. I trust that Sriharsha will
> address it in follow-up patches.
>
>
> 2018/10/19 15:27 Eelco Chaudron :
>>
>> Hi Simon,
>>
>> You might have missed my general comments
This commit fixes netdev_dpdk_get_features() by initializing a bitmap
that represents current features to zero and accounting for non defined
link speed values in the OpenFlow spec.
The current approach for retrieving netdev dpdk features uses a
pointer allocated in the stack without being initial
Report the link speed of the device in netdev_dpdk_get_status()
function.
Link speed is already reported as part of the netdev_get_features()
function. However only link speeds defined in the OpenFlow specs are
supported so speeds such as 25 Gbps etc. are not shown. The link
speed for the device i
On 10/11/2018 11:39 AM, Federico Iezzi wrote:
So, any news on the other link speeds likeĀ 25, 50, and 100Gbps?
Hi Federico,
I've sent out a patch series to help address this based on the previous
discussion.
https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353292.html
https://mail
1. Enable compilation and linkage with dpdk 18.08.0
The following dpdk commits which were introduced after dpdk 17.11.x
require OVS updates to accommodate to the dpdk changes.
- ce17edde ("ethdev: introduce Rx queue offloads API")
- ab3ce1e0 ("ethdev: remove old offload API")
- c06ddf96 ("meter: ad
Before this commit setting scatter offload was based on checking
net_nfp device.
Since DPDK 17.11 more PMD drivers are reporting offload
capabilities. Therefore this commit removes the specific check
against net_nfp device and replaces it with a generic check of
device capabilities before setting t
On Thu, Oct 25, 2018 at 07:32:27PM +0530, Sriharsha Basavapatna via dev wrote:
> > Removed by accident?
> There was ^L char here; I deleted it.
Don't do that. The coding style talks about the use of page breaks in code:
Within a file, non-static functions should come first, in the order
Partial offload support was added to OVS DPDK in OVS 2.10. As such
remove the limitation that OVS DPDK does not support HWOL from the
DPDK install documentation.
Signed-off-by: Ian Stokes
---
Documentation/intro/install/dpdk.rst | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/in
On Tue, Oct 23, 2018 at 06:58:57PM -0700, Zak Whittington wrote:
> Backported OFPT14_REQUESTFORWARD to OF1.0-1.3 as a Nicira
> extension.
>
> VMware-BZ: 2136594
> Signed-off-by: Zak Whittington
Thanks for the revision. It looks good! I have only a few comments.
First, the new test checks for
On Wed, Oct 24, 2018 at 03:56:00PM -0700, Zak Whittington wrote:
> When force-reload-kmod is used, it shows an error when reinstalling
> tlvs during "Restoring saved flows" step:
> OFPT_ERROR (xid=0x4): NXTTMFC_ALREADY_MAPPED
>
> This is caused by a race condition between the restore script,
> whi
When force-reload-kmod is used, it shows an error when reinstalling
tlvs during "Restoring saved flows" step:
OFPT_ERROR (xid=0x4): NXTTMFC_ALREADY_MAPPED
This is caused by a race condition between the restore script,
which calls ofctl, and the connected controllers both adding back
the same TLVs.
Backported OFPT14_REQUESTFORWARD to OF1.0-1.3 as a Nicira
extension. Includes ofp-print tests for multiple OF
verions and multiple payload types, as well as more
comprehensive end-to-end tests using OF1.0 and OF1.3.
VMware-BZ: 2136594
Signed-off-by: Zak Whittington
---
include/openvswitch/ofp-mo
Functions like scan_u8, return 0 when they failed to scan the expected
values. Function scan_geneve failed to check this situation. This leads
to using of uninitialized value of opt_len_mask. This patch fixes it
and further inspects and fixes all the problematic places where
the return values of sc
Sorry there is a compiling warning. I will fix it and submit v2.
On Thu, Oct 25, 2018 at 12:38 PM Yifeng Sun wrote:
> Functions like scan_u8, return 0 when they failed to scan the expected
> values. Function scan_geneve failed to check this situation. This leads
> to using of uninitialized value
In the filed of ver_flags_ttl_len of struct nshhdr, there are only 6
bits that are used to indicate header's total length in 4-byte words.
Therefore, the max value for total is 252 (63x4), instead of 256 used
in present code base. This patch fixes it.
Reported-at: https://bugs.chromium.org/p/oss-f
When parse_ofp_flow_mod_str returns error, `fm` is incomplete and pointers
in it may be null, e.g. fm.match.flow. In this case, passing it to
ofctl_parse_flows__ may cause pointer errors because ofctl_parse_flows__
expects a valid input of type struct ofputil_flow_mod.
Reported-at: https://bugs.ch
Dear d...@openvswitch.org___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
As a part of proposal for distributed virtual routing
for VLAN networks through OVN, this series has code changes
for Layer 2.
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=s
As a part of proposal for distributed virtual routing
for VLAN networks through OVN, this series has code changes
for Layer 2.
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=s
As a part of proposal for distributed virtual routing
for VLAN networks through OVN, this series has code changes
for Layer 2.
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=s
Functions like scan_u8, return 0 when they failed to scan the expected
values. Function scan_geneve failed to check this situation. This leads
to using of uninitialized value of opt_len_mask. This patch fixes it
and further inspects and fixes all the problematic places where
the return values of sc
On Thu, Oct 25, 2018 at 12:56:09PM -0700, Zak Whittington wrote:
> Backported OFPT14_REQUESTFORWARD to OF1.0-1.3 as a Nicira
> extension. Includes ofp-print tests for multiple OF
> verions and multiple payload types, as well as more
> comprehensive end-to-end tests using OF1.0 and OF1.3.
>
> VMwar
On Thu, Oct 25, 2018 at 11:09:09AM -0700, Zak Whittington wrote:
> When force-reload-kmod is used, it shows an error when reinstalling
> tlvs during "Restoring saved flows" step:
> OFPT_ERROR (xid=0x4): NXTTMFC_ALREADY_MAPPED
>
> This is caused by a race condition between the restore script,
> whi
35 matches
Mail list logo