[ovs-dev] [PATCH] ovsdb: Clarify that a server that leaves a cluster may never rejoin.

2018-10-29 Thread Ben Pfaff
This wasn't clear from the documentation. Reported-by; Paul Greenberg Signed-off-by: Ben Pfaff --- Documentation/ref/ovsdb.7.rst | 3 +++ ovsdb/ovsdb-server.1.in | 3 +++ 2 files changed, 6 insertions(+) diff --git a/Documentation/ref/ovsdb.7.rst b/Documentation/ref/ovsdb.7.rst index 39d

Re: [ovs-dev] [PATCH] manpages: Include ovs.tmac in most man roots.

2018-10-29 Thread Ben Pfaff
On Mon, Oct 29, 2018 at 05:46:33PM +0300, Ilya Maximets wrote: > This allows to not redefine common macroses in every single > file and allowes using things like .EX without warying about > compatibility. > manpages.mk updated automatically. > > Files that are already complete pages (i.e. has no *

[ovs-dev] [PATCH 6/6] ofproto: Don't always treat passive controllers as "equal".

2018-10-29 Thread Ben Pfaff
If a passive controller chooses to configure itself as a slave controller, I don't know a reason why it should be considered "equal" for some purposes. Signed-off-by: Ben Pfaff --- ofproto/ofproto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto

[ovs-dev] [PATCH 5/6] vswitchd: Allow user to configure controllers as "primary" or "service".

2018-10-29 Thread Ben Pfaff
Normally it makes sense for an active connection to be primary and a passive connection to be a service connection, but I've run into a corner case where it is better for a passive connection to be a primary connection. This specific case is for use with OFtest, which expects to be a primary contr

[ovs-dev] [PATCH 4/6] connmgr: Make treatment of active and passive connections more uniform.

2018-10-29 Thread Ben Pfaff
Until now, connmgr has handled active and passive OpenFlow connections in quite different ways. Any active connection, whether it was currently connected or not, was always maintained as an ofconn. Whenever such a connection (re)connected, its settings were cleared. On the other hand, passive co

[ovs-dev] [PATCH 3/6] connmgr: Improve interface for setting controllers.

2018-10-29 Thread Ben Pfaff
Using an shash instead of an array simplifies the code for both the caller and the callee. Putting the set of allowed OpenFlow versions into the ofproto_controller data structure also simplifies the overall function interface slightly. Signed-off-by: Ben Pfaff --- ofproto/connmgr.c | 51 ++

[ovs-dev] [PATCH 1/6] connmgr: Modernize coding style.

2018-10-29 Thread Ben Pfaff
This moves declarations closer to first use and merges them with initialization when possible, moves "for" loop variable declarations into the "for" statements where possible, and otherwise makes this code look like it was written a little more recently than it was. Signed-off-by: Ben Pfaff ---

[ovs-dev] [PATCH 2/6] rconn: New function rconn_is_reliable().

2018-10-29 Thread Ben Pfaff
This will have its first user in an upcoming commit. Signed-off-by: Ben Pfaff --- include/openvswitch/rconn.h | 1 + lib/rconn.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/openvswitch/rconn.h b/include/openvswitch/rconn.h index 5dc988af1dda..fd60a6ce1dea

[ovs-dev] Bequest notice

2018-10-29 Thread Admin dept
Good day beneficiary, I wish to bring to your notice on behalf of the trustee and executor to late Mrs. Auriel Yvonne Mitchely testament. The deceased before her death made you a beneficiary in her WILL codicil, been a wildly travelled woman she must have been in contact with you in the past,

Re: [ovs-dev] Problems on controller set up

2018-10-29 Thread Ben Pfaff
On Mon, Oct 29, 2018 at 06:35:06PM +0100, Hugo Alfonso Zúñiga Calvo wrote: > I am a new developer for openvswitch, I am currently trying to use the > experimenter messages in order to try out an extension of the protocol for > my master thesis. The switch I am using runs openvswitch, therefore I ha

[ovs-dev] Problems on controller set up

2018-10-29 Thread Hugo Alfonso Zúñiga Calvo
Hi, I am a new developer for openvswitch, I am currently trying to use the experimenter messages in order to try out an extension of the protocol for my master thesis. The switch I am using runs openvswitch, therefore I have already extended the openvswitch to add my custom experimenter messages.

[ovs-dev] [PATCH] tests: Simplify and improve the daemon tests.

2018-10-29 Thread Ben Pfaff
The daemon tests used files a lot when shell variables were easier to use and easier to understand. This commit changes that. The tests created empty databases that aren't really needed anymore. This commit changes them to use the ovsdb-server --no-db option instead. The tests had a lot of comm

[ovs-dev] [PATCH] manpages: Include ovs.tmac in most man roots.

2018-10-29 Thread Ilya Maximets
This allows to not redefine common macroses in every single file and allowes using things like .EX without warying about compatibility. manpages.mk updated automatically. Files that are already complete pages (i.e. has no *.in sources) wasn't touched, because this will require additional file mani

[ovs-dev] [PATCH 9/9] dpif-netdev.at: Add basic test for partial HW offloading.

2018-10-29 Thread Ilya Maximets
Simple test for basic partial HWOL functionality. Signed-off-by: Ilya Maximets --- tests/dpif-netdev.at | 73 1 file changed, 73 insertions(+) diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at index 6915d43ba..dd47f8874 100644 --- a/tests/dpif

[ovs-dev] [PATCH 8/9] netdev-dummy: Add flow offloading related logs.

2018-10-29 Thread Ilya Maximets
Add debug logging for partial HWOL for dummy interfaces for the future using in tests. Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 66 +++--- 1 file changed, 63 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c i

[ovs-dev] [PATCH 7/9] netdev-dummy: Set flow mark for offloaded flows.

2018-10-29 Thread Ilya Maximets
Match packets received on dummy interfaces with offloaded flows and set up corresponding marks in dp-packet. Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/lib/netdev-dummy.c b/lib

[ovs-dev] [PATCH 6/9] netdev-dummy: Implement dummy put/del flow offload API.

2018-10-29 Thread Ilya Maximets
Basic partial HWOL API for dummy interfaces. Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 106 +++-- 1 file changed, 103 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 23817d121..7163ab47c 100644 --- a/li

[ovs-dev] [PATCH 5/9] dp-packet: Copy flow mark on packet clone.

2018-10-29 Thread Ilya Maximets
Dummy interfaces clones dp-packet while 'receive' appctl processing. In general, we should do this anyway to avoid any possible issues in the future with real interfaces. Signed-off-by: Ilya Maximets --- lib/dp-packet.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/dp-packet.c b/li

[ovs-dev] [PATCH 4/9] dp-packet: Add flow_mark support for non-DPDK case.

2018-10-29 Thread Ilya Maximets
Additionally, new API call 'dp_packet_set_flow_mark' is needed for packet clone. Mostly for dummy HWOL implementation. Signed-off-by: Ilya Maximets --- lib/dp-packet.h | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h i

[ovs-dev] [PATCH 3/9] dp-packet: Refactor offloading API.

2018-10-29 Thread Ilya Maximets
1. No reason to have mbuf related APIs in a generic code. 2. Not only RSS/checksums should be invalidated in case of tunnel decapsulation or sending to 'ring' ports. In order to fix two above issues, new function 'dp_packet_offload_invalidate' introduced. In order to clean up/unify the code and

[ovs-dev] [PATCH 2/9] dp-packet: Constantify offloading APIs.

2018-10-29 Thread Ilya Maximets
Getters should have const arguments. Signed-off-by: Ilya Maximets --- lib/dp-packet.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 5b4c9c7a3..0c4c8c853 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h

[ovs-dev] [PATCH 1/9] dpif-netdev: Reduce log level for not found mark id.

2018-10-29 Thread Ilya Maximets
It's a normal case for 'find' function, especially because this happens for every first packet of flow that was not offloaded yet. Should not warn about this. Dropped to DBG to avoid log trashing in case of big number of new flows. CC: Yuanhan Liu Fixes: 241bad15d99a ("dpif-netdev: associate flow

[ovs-dev] [PATCH 0/9] dpif-netdev: Partial HWOL fixes/refactoring/unit-tests.

2018-10-29 Thread Ilya Maximets
Few more fixes + dummy implementation to enable unit testing of this feature. Two more patch-sets with fixes: * https://patchwork.ozlabs.org/project/openvswitch/list/?series=71449 * https://patchwork.ozlabs.org/project/openvswitch/list/?series=71748 Ilya Maximets (9): dpif-netde

[ovs-dev] [PATCH] dpif-netlink: Don't destroy and recreate port if it exists

2018-10-29 Thread Jianbo Liu
In commit 7521e0cf9e ('ofproto-dpif: Let the dpif report when a port is a duplicate'), the checking of port existence before adding was removed, and it's up to the dpif to check if port exists and add only if needed. But the port can't be added to datapath if already exists. Then it will be destro