Re: [ovs-dev] [PATCH V2 1/1] netdev-tc-offloads: Support IPv6 hlimit rewrite

2018-12-28 Thread Simon Horman
On Wed, Dec 26, 2018 at 09:36:22AM +0200, Eli Britstein wrote: > Add support for IPv6 hlimit field. > > Signed-off-by: Eli Britstein > Reviewed-by: Paul Blakey Thanks, this patch looks good to me. I am verifying that it passes travic-ci and plan to apply this patch if that passes. https://tra

Re: [ovs-dev] [PATCH V2 1/1] netdev-tc-offloads: Do not set 0 port attribute to TC tunnel

2018-12-28 Thread Simon Horman
On Wed, Dec 26, 2018 at 09:34:35AM +0200, Eli Britstein wrote: > For non UDP tunnels as GRE there is no UDP port, i.e initialized to 0. > > Do not set the port attribute in such case. > > Signed-off-by: Eli Britstein > Reviewed-by: Paul Blakey Thanks, this patch looks good to me. I am verifyi

Re: [ovs-dev] [PATCH v3] OVN: add mac address only support to IPAM/MACAM

2018-12-28 Thread Ben Pfaff
On Fri, Dec 28, 2018 at 06:18:04PM +0100, Lorenzo Bianconi wrote: > Add the capability to assign just L2 address to IPAM/MACAM since > in the current implementation either subnet or ipv6_prefix are mandatory > to enable IPAM > > Tested-by: Yossi Segev > Acked-by: Mark Michelson > Signed-off-by:

Re: [ovs-dev] [PATCH v3] OVN: add mac address only support to IPAM/MACAM

2018-12-28 Thread Ben Pfaff
On Fri, Dec 28, 2018 at 06:18:04PM +0100, Lorenzo Bianconi wrote: > Add the capability to assign just L2 address to IPAM/MACAM since > in the current implementation either subnet or ipv6_prefix are mandatory > to enable IPAM > > Tested-by: Yossi Segev > Acked-by: Mark Michelson > Signed-off-by:

Re: [ovs-dev] [PATCH v3] OVN: add static IP support to IPAM

2018-12-28 Thread Ben Pfaff
On Fri, Dec 28, 2018 at 06:38:47PM +0100, Lorenzo Bianconi wrote: > Add the capability to IPAM/MACAM framework to specify a static ip address > and get the L2 one allocated dynamically using the following syntax: > > $ovn-nbctl lsp-set-addresses "dynamic " > > The static ip address needs to belo

Re: [ovs-dev] OVN: add static IP support to IPAM

2018-12-28 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 OVN: add static IP support to IPAM The cop

Re: [ovs-dev] OVS seems to not release memory on ARP bursts

2018-12-28 Thread Ben Pfaff
On Fri, Dec 28, 2018 at 07:30:52AM +, Ani Sinha wrote: > We are performing an experiment based on our observed behavior on some of our > systems. We are using a python packet generator called scapy to generate arp > broadcast packet bursts with random MACs. What we are observing is that > w

[ovs-dev] [PATCH v3] OVN: add static IP support to IPAM

2018-12-28 Thread Lorenzo Bianconi
Add the capability to IPAM/MACAM framework to specify a static ip address and get the L2 one allocated dynamically using the following syntax: $ovn-nbctl lsp-set-addresses "dynamic " The static ip address needs to belong to the subnet configured for the logical switch Signed-off-by: Lorenzo Bia

[ovs-dev] [PATCH v3] OVN: add mac address only support to IPAM/MACAM

2018-12-28 Thread Lorenzo Bianconi
Add the capability to assign just L2 address to IPAM/MACAM since in the current implementation either subnet or ipv6_prefix are mandatory to enable IPAM Tested-by: Yossi Segev Acked-by: Mark Michelson Signed-off-by: Lorenzo Bianconi --- Changes since v2: - add a NEWS item Changes since v1: - fi

Re: [ovs-dev] [PATCH] doc: Add missing ':doc:' role

2018-12-28 Thread Ben Pfaff
On Fri, Dec 28, 2018 at 01:46:43PM +, Stephen Finucane wrote: > This was rendering in italics instead of cross-referencing as intended. > > Signed-off-by: Stephen Finucane Thanks! Applied to master. ___ dev mailing list d...@openvswitch.org https:

Re: [ovs-dev] conntrack: Check all addresses for ephemeral ports.

2018-12-28 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Dec 20, 2018 at 01:22:18PM -0500, Aaron Conole wrote: >> Kevin Traynor writes: >> >> > On 12/19/2018 08:23 AM, Darrell Ball wrote: >> >> On Tue, Dec 18, 2018 at 6:57 PM 0-day Robot wrote: >> >> >> >>> Bleep bloop. Greetings Darrell Ball, I am a robot and I have tr

Re: [ovs-dev] [PATCH] datapath-windows: Fix race condition when deleting internal ports

2018-12-28 Thread Alin Gabriel Serdean
> On 27 Dec 2018, at 20:29, Anand Kumar wrote: > > Acked-by: Anand Kumar mailto:kumaran...@vmware.com>> > Thanks both. Applied on master and branch-2.10. Alin. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listin

[ovs-dev] [PATCH] doc: Add missing ':doc:' role

2018-12-28 Thread Stephen Finucane
This was rendering in italics instead of cross-referencing as intended. Signed-off-by: Stephen Finucane --- Documentation/topics/dpdk/bridge.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/topics/dpdk/bridge.rst b/Documentation/topics/dpdk/bridge.rst index

[ovs-dev] hi

2018-12-28 Thread Leonie
Please can we talk? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] odp-util: Fix a bug in parse_odp_push_nsh_action

2018-12-28 Thread Jan Scheurich
Hi Ben and Yfeng, Looking at the current code on master I believe it is correct except that I wrongly used ofpbuf_push_zeros() where it should have been ofpbuf_put_zeros() to append the padding zeroes to the end. The ofp_buf should never be relocated through padding as it is allocated with the