[ovs-dev] mailto:20190125202328.gu1...@ovn.org

2019-01-25 Thread Phee Rujiphan
___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/3] revert port duplicate checking optimization

2019-01-25 Thread Ben Pfaff
On Thu, Jan 24, 2019 at 12:30:08PM -0200, Flavio Leitner wrote: > On Wed, Jan 23, 2019 at 12:13:25PM -0800, Ben Pfaff wrote: > > I'm not so happy about reverting without having the followup ready. How > > close are we to having the followup? Basically we've got two problems > > here. Without the

Re: [ovs-dev] [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros

2019-01-25 Thread Pravin Shelar
On Thu, Jan 24, 2019 at 1:47 AM Eli Britstein wrote: > > Declare ovs key structures using macros to enable retrieving fields > information, with no functional change. > I am not sure why is this done. Can you explain what are u trying to solve here? > Signed-off-by: Eli Britstein > Reviewed-by:

Re: [ovs-dev] [PATCH] treewide: Get rid of // comments, even inside comments.

2019-01-25 Thread Ben Pfaff
On Thu, Jan 24, 2019 at 05:00:11PM +0300, Ilya Maximets wrote: > On 23.01.2019 23:09, Ben Pfaff wrote: > > Just a style fix. > > > > With this patch, the following reports no hits: > > > > git ls-files | grep '\.[ch]$' | grep -vE 'datapath|sflow' | xargs grep -n > > // | grep -vE "http|s/|'|\""

Re: [ovs-dev] [PATCH] flow: fix udp checksum

2019-01-25 Thread Ben Pfaff
On Fri, Jan 25, 2019 at 07:08:33PM +0800, Li RongQing wrote: > As per RFC 768, if the calculated UDP checksum is 0, it should be > instead set as 0x in the frame. A value of 0 in the checksum > field indicates to the receiver that no checksum was calculated > and hence it should not verify the

Re: [ovs-dev] [PATCH v1 1/1] hash: Implement hash for aarch64 using CRC32c intrinsics.

2019-01-25 Thread Ben Pfaff
On Fri, Jan 25, 2019 at 11:28:01AM +, Yanqin Wei (Arm Technology China) wrote: > This commit adds lib/hash-aarch64.h to implement hash for aarch64. > It is based on aarch64 built-in CRC32c intrinsics, which accelerates > hash function for datapath performance. > > test: > 1. "test-hash" case

Re: [ovs-dev] skiplist code

2019-01-25 Thread Ben Pfaff
Thanks a lot for the detailed explanation! I borrowed it and sent a patch that removes the member: https://patchwork.ozlabs.org/patch/1031285/ On Fri, Jan 25, 2019 at 07:00:02PM +, Rodriguez Betancourt, Esteban wrote: > Hello, > In this case you are right, the "height" member is not

[ovs-dev] [PATCH] skiplist: Remove 'height' from skiplist_node.

2019-01-25 Thread Ben Pfaff
This member was write-only: it was initialized and never used later on. Thanks to Esteban Rodriguez Betancourt for the following additional rationale: In this case you are right, the "height" member is not only not used, it is in fact not required, and can be safely removed, without

[ovs-dev] [PATCH v5] Monitor Database table to manage lifecycle of IDL client.

2019-01-25 Thread Ted Elhourani
The Python IDL implementation supports ovsdb cluster connections. This patch is a follow up to commit 31e434fc98, it adds the option of connecting to the leader (the default) in the Raft-based cluster. It mimics the exisiting C IDL support for clusters introduced in commit 1b1d2e6daa. The _Server

Re: [ovs-dev] [PATCH] ovs-macros.at: Better hide 'exec -a' checking.

2019-01-25 Thread Ben Pfaff
On Fri, Jan 25, 2019 at 04:21:22PM +0300, Ilya Maximets wrote: > There is some issue with parsing of redirection options > on some shells. For example: > > $ (exec -a name true) 2>&1 >/dev/null || echo "failed" > sh: 10: exec: -a: not found > failed > > $ (exec -a name true) >/dev/null 2>

[ovs-dev] suspicious skiplist code

2019-01-25 Thread Rodriguez Betancourt, Esteban
Hello, In this case you are right, the "height" member is not only not used, it is in fact not required, and can be safely removed, without causing security issues. The code can't read past the end of the 'forward' array because the skiplist "level" member, that specifies the maximum height of th

Re: [ovs-dev] [PATCH] dpdk: Limit DPDK memory usage.

2019-01-25 Thread Ben Pfaff
On Fri, Jan 25, 2019 at 04:08:10PM +0300, Ilya Maximets wrote: > On 23.01.2019 15:40, Aaron Conole wrote: > > Ilya Maximets writes: > > > >> Aaron, what do you think about supporting tags like 'Based-on' in ovsrobot > >> ? > >> For example, patchew in QEMU parses 'Based-on: ' tags. > >> Maybe we

[ovs-dev] ¿Cómo prevenir la morosidad?

2019-01-25 Thread Recuperación de cartera vencida
Cursos escenciales - Webinar Interactivo – Jueves 21 de Febrero Recuperación de cartera vencida Este webinar interactivo está diseñado para brindar a las empresas estrategias y técnicas para desarrollar mejores procedimientos de recuperación de cartera dentro del marco legar pertinente y en una

[ovs-dev] Principales tipos de Auditoría Interna.

2019-01-25 Thread Cómo Detectar Fraudes
Cursos escenciales - Webinar Interactivo – Miércoles 20 de Febrero Guía de Auditoría y Control Interno para Detectar Fraudes Nuestro webinar funciona como una guía para que el participante revise los conceptos clave del Control Interno y la Auditoría para la prevención de escenarios que conllev

Re: [ovs-dev] [PATCH] acinclude: Also use LIBS from dpkg pkg-config

2019-01-25 Thread Aaron Conole
Luca Boccassi writes: > On Fri, 2019-01-25 at 16:39 +, Luca Boccassi wrote: >> On Fri, 2019-01-25 at 11:28 -0500, Aaron Conole wrote: >> > Christian Ehrhardt writes: >> > >> > > DPDK 18.11 builds using the more modern meson build system no >> > > more >> > > provide the -ldpdk linker script

Re: [ovs-dev] [PATCH] acinclude: Also use LIBS from dpkg pkg-config

2019-01-25 Thread Ben Pfaff
On Fri, Jan 25, 2019 at 04:39:15PM +, Luca Boccassi wrote: > On Fri, 2019-01-25 at 11:28 -0500, Aaron Conole wrote: > > Christian Ehrhardt writes: > > > > > DPDK 18.11 builds using the more modern meson build system no more > > > provide the -ldpdk linker script. Instead it is expected to use

Re: [ovs-dev] [PATCH] acinclude: Also use LIBS from dpkg pkg-config

2019-01-25 Thread Luca Boccassi
On Fri, 2019-01-25 at 16:39 +, Luca Boccassi wrote: > On Fri, 2019-01-25 at 11:28 -0500, Aaron Conole wrote: > > Christian Ehrhardt writes: > > > > > DPDK 18.11 builds using the more modern meson build system no > > > more > > > provide the -ldpdk linker script. Instead it is expected to use

Re: [ovs-dev] [PATCH] acinclude: Also use LIBS from dpkg pkg-config

2019-01-25 Thread Luca Boccassi
On Fri, 2019-01-25 at 11:28 -0500, Aaron Conole wrote: > Christian Ehrhardt writes: > > > DPDK 18.11 builds using the more modern meson build system no more > > provide the -ldpdk linker script. Instead it is expected to use > > pkgconfig for linker options as well. > > > > This change will set

Re: [ovs-dev] [PATCH] acinclude: Also use LIBS from dpkg pkg-config

2019-01-25 Thread Aaron Conole
Christian Ehrhardt writes: > DPDK 18.11 builds using the more modern meson build system no more > provide the -ldpdk linker script. Instead it is expected to use > pkgconfig for linker options as well. > > This change will set DPDK_LIB from pkg-config (if pkg-config was > available) and since tha

[ovs-dev] [PATCH] ovs-macros.at: Better hide 'exec -a' checking.

2019-01-25 Thread Ilya Maximets
There is some issue with parsing of redirection options on some shells. For example: $ (exec -a name true) 2>&1 >/dev/null || echo "failed" sh: 10: exec: -a: not found failed $ (exec -a name true) >/dev/null 2>&1 || echo "failed" failed So, the order of redirections matters for some re

Re: [ovs-dev] [PATCH] dpdk: Limit DPDK memory usage.

2019-01-25 Thread Ilya Maximets
On 23.01.2019 15:40, Aaron Conole wrote: > Ilya Maximets writes: > >> Aaron, what do you think about supporting tags like 'Based-on' in ovsrobot ? >> For example, patchew in QEMU parses 'Based-on: ' tags. >> Maybe we can use patchwork ids or something similar. > > I think there's a way to do it

Re: [ovs-dev] hash: Implement hash for aarch64 using CRC32c intrinsics.

2019-01-25 Thread 0-day Robot
Bleep bloop. Greetings Yanqin Wei (Arm Technology China), I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: corrupt patch at line 186 Repository lacks necessary blobs to fall back

[ovs-dev] [PATCH v1 1/1] hash: Implement hash for aarch64 using CRC32c intrinsics.

2019-01-25 Thread Yanqin Wei (Arm Technology China)
This commit adds lib/hash-aarch64.h to implement hash for aarch64. It is based on aarch64 built-in CRC32c intrinsics, which accelerates hash function for datapath performance. test: 1. "test-hash" case passed in aarch64 platform. 2. OVS-DPDK datapth performance test was run(NIC to NIC). Test

[ovs-dev] [PATCH] flow: fix udp checksum

2019-01-25 Thread Li RongQing
As per RFC 768, if the calculated UDP checksum is 0, it should be instead set as 0x in the frame. A value of 0 in the checksum field indicates to the receiver that no checksum was calculated and hence it should not verify the checksum. Signed-off-by: Li RongQing --- lib/flow.c | 3 +++ 1 fil

[ovs-dev] MES SALUTATIONS

2019-01-25 Thread Aline BELLAT
Bonjour Excusez moi de cette manière de vous contacter, je viens d'apercevoir votre profil et je me suis dis que vous êtes la personne qu'il me faut. Je suis Madame Aline BELLAT de nationalité française, hospitalisé en Europe pour raison de santé. Je souffre d'une tumeur au cerveau et le résultat

Re: [ovs-dev] [ovs-dev, v4] Monitor Database table to manage lifecycle of IDL client.

2019-01-25 Thread Ilya Maximets
Still some failures. See inline. Best regards, Ilya Maximets. On 25.01.2019 4:51, Ted Elhourani wrote: > The Python IDL implementation supports ovsdb cluster connections. > This patch is a follow up to commit 31e434fc98, it adds the option of > connecting to the leader (the default) in the Raft-b