On Fri, Jan 25, 2019 at 5:53 PM Aaron Conole wrote:
>
> Luca Boccassi writes:
>
> > On Fri, 2019-01-25 at 16:39 +, Luca Boccassi wrote:
> >> On Fri, 2019-01-25 at 11:28 -0500, Aaron Conole wrote:
> >> > Christian Ehrhardt writes:
> >> >
> >> > > DPDK 18.11 builds using the more modern meson
On Mon, Jan 28, 2019 at 04:31:40PM -0800, Han Zhou wrote:
> From: Han Zhou
>
> Signed-off-by: Han Zhou
> ---
> ovsdb/raft.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ovsdb/raft.c b/ovsdb/raft.c
> index 7538815..68b527c 100644
> --- a/ovsdb/raft.c
> +++ b/ovsdb/raft.c
> @@
I don't know off the top of my head. I'd recommend running "git blame" on the
tip of Linus's tree and figuring out which patches are necessary to add
support. My recollection is that they mostly went in as a single patch, so it
should be pretty easy to find the appropriate patches.
--Justin
The distribution version of OS of mime is CentOS Linux release 7.5.1804
(Core),and the kernel version is 3.10.0-862.14.4.el7.x86_64. I plan to merge
the meters patch to the 3.10.0-862 kernel of CentOS7.5.
Where is the function patch address? Do you have some suggestions？
Regards,
yunxiang
yep, I want to backport meter support for an older kernel. But I need to know
which patch of the support for meters. So ,I hope you could give me the
address of this patch.Regards,
yunxiang
At 2019-01-29 09:32:31, "Justin Pettit" wrote:
>I'm afraid that I don't understand the
I'm afraid that I don't understand the question. Are you asking how you'd
backport meter support for an older kernel? If so, you'd need to talk to the
Centos/Red Hat maintainers.
--Justin
> On Jan 28, 2019, at 5:29 PM, taoyunupt wrote:
>
> The distribution version of OS of mime is CentOS
From: Han Zhou
Signed-off-by: Han Zhou
---
ovsdb/raft.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index 7538815..68b527c 100644
--- a/ovsdb/raft.c
+++ b/ovsdb/raft.c
@@ -1453,7 +1453,6 @@ raft_waiter_complete_rpc(struct raft *raft, const union
raft_rpc
On 23.01.2019 14:03, Kees Cook wrote:
> This adds a new plugin "stackinit" that attempts to perform unconditional
> initialization of all stack variables
Hello Kees! Hello everyone!
I was curious about the performance impact of the initialization of all stack
variables. So I did a very brief
On 1/22/2019 1:22 PM, Ilya Maximets wrote:
No need to allocate memory and use 'strcat' direcly.
'dynamic-string' could do this for us.
> Signed-off-by: Ilya Maximets
---
lib/dpdk.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
Thanks for this Ilya, I've pushed this
On 1/22/2019 1:22 PM, Ilya Maximets wrote:
No need to implement dynamic vector to store arguments.
'svec' perfectly covers all the needed functionality.
Thanks for this Ilya, testing this this the last few days and seems in
working order, I see Aaron has also acked this, I just have one
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 conntrack: Exclude l2 padding in
On Sat, Jan 26, 2019 at 2:59 AM David Marchand
wrote:
> Hello Darrell,
>
> On Wed, Jan 23, 2019 at 1:14 AM Darrell Ball via dev <
> ovs-dev@openvswitch.org> wrote:
>
>> I would like to wait for David to return, so please hold off for now.
>>
>> On 1/22/19, 3:58 PM,
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 conntrack: Exclude l2 padding in
I sent a V3 since an unrelated change was also included in this patch.
Darrell
On Mon, Jan 28, 2019 at 10:41 AM Darrell Ball wrote:
>
>
> On Mon, Jan 28, 2019 at 10:05 AM Darrell Ball wrote:
>
>> 'conn_key_extract()' in OVS is including L2 (Ethernet) pad bytes
>>
>
> Above 'in OVS' was meant
I'd have to look at the history, but the feature wouldn't have been added to
OVN unless it was supported by OVS. Currently, we expect OVN to work with the
same version number of OVS. (Although, I expect you could use a newer version
of OVS and an older OVN.) We plan to break that requirement
The new api will be used in a subsequent patch.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 7b85dd9..087f36a 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -353,9
'conn_key_extract()' in userspace conntrack is including L2
(Ethernet) pad bytes for both L3 and L4 sizes. One problem is
any packet with non-zero L2 padding can incorrectly fail L4
checksum validation.
This patch fixes conn_key_extract() by ignoring L2 pad bytes.
Fixes: a489b16854b5
On Mon, Jan 28, 2019 at 10:05 AM Darrell Ball wrote:
> 'conn_key_extract()' in OVS is including L2 (Ethernet) pad bytes
>
Above 'in OVS' was meant to be 'in userspace conntrack' - will fix later
if there are objections.
> for both L3 and L4 sizes. One problem is any packet with non-zero
> L2
Thanks for the patch
I sent an alternative as part of a 2 patch series
https://patchwork.ozlabs.org/project/openvswitch/list/?series=88620
Darrell
On Mon, Jan 28, 2019 at 12:50 AM Vishal Deep Ajmera <
vishal.deep.ajm...@ericsson.com> wrote:
> Userspace conntrack implementation in OVS is
I resent this patch with a missing co-author added.
Thanks Darrell
On Mon, Jan 28, 2019 at 10:05 AM Darrell Ball wrote:
> 'conn_key_extract()' in OVS is including L2 (Ethernet) pad bytes
> for both L3 and L4 sizes. One problem is any packet with non-zero
> L2 padding can incorrectly fail L4
'conn_key_extract()' in OVS is including L2 (Ethernet) pad bytes
for both L3 and L4 sizes. One problem is any packet with non-zero
L2 padding can incorrectly fail L4 checksum validation.
This patch fixes conn_key_extract() by ignoring L2 pad bytes.
Fixes: a489b16854b5 ("conntrack: New userspace
The new api will be used in a subsequent patch.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 7b85dd9..087f36a 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -353,9
'conn_key_extract()' in OVS is including L2 (Ethernet) pad bytes
for both L3 and L4 sizes. One problem is any packet with non-zero
L2 padding can incorrectly fail L4 checksum validation.
This patch fixes conn_key_extract() by ignoring L2 pad bytes.
Fixes: a489b16854b5 ("conntrack: New userspace
The new api will be used in a subsequent patch.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 7b85dd9..087f36a 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -353,9
On 25.01.2019 23:22, Ben Pfaff wrote:
> This member was write-only: it was initialized and never used later on.
>
> Thanks to Esteban Rodriguez Betancourt for the
> following additional rationale:
>
> In this case you are right, the "height" member is not only not
> used, it is in fact
> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff
> Trimis: Wednesday, January 23, 2019 5:33 PM
> Către: Alin Gabriel Serdean
> Cc: d...@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet
buffering'
> > -Mesaj original-
> > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Anand Kumar
> > Trimis: Friday, January 11, 2019 2:45 AM
> > Către: d...@openvswitch.org
> > Subiect: [ovs-dev] [PATCH] datapath-windows: Add support for
> > 'OVS_KEY_ATTR_ENCAP' key
Add setting of ipv4 dscp and ecn fields in tc offload using pedit.
Signed-off-by: Pieter Jansen van Vuuren
Signed-off-by: Louis Peens
Reviewed-by: Simon Horman
---
lib/netdev-tc-offloads.c | 6 +-
lib/tc.c | 5 +
lib/tc.h | 1 +
3 files changed, 11
Extend ovs-tc translation by allowing non-byte-aligned fields
for set actions. Use new boundary shifts and add set ipv6 traffic
class action offload via pedit.
Signed-off-by: Pieter Jansen van Vuuren
Signed-off-by: Louis Peens
Reviewed-by: Simon Horman
---
lib/netdev-tc-offloads.c | 4 +++
pedit allows setting entire words with an optional mask and OVS
makes use of such masks to allow setting fields that do not span
entire words.
The struct tc_pedit_key structure, which is part of the kernel
ABI, uses host byte order fields to store the mask and value for
a pedit action, however,
pedit allows setting entire words with an optional mask and OVS
makes use of such masks to allow setting fields that do not span
entire words. One mask for leading bytes that should not be
updated and another mask for trailing bytes that should not be
updated. The masks are created using bit
Hi all,
This set fixes and subsequently extends the ovs-tc pedit interface
to allow setting ipv4 dscp and ecn fields as well as ipv6 traffic
class in tc via pedit. Patch 1 introduces a new sparse header which
helps work around the big endian issues in the tc_pedit_key structure.
Patch 2 fixes the
Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#560 FILE:
Currently OVS supports all ARP protocol fields as OXM match fields to
implement the relevant ARP procedures for IPv4. This includes support
for matching copying and setting ARP fields. In IPv6 ARP has been
replaced by ICMPv6 neighbor discovery (ND) procedures, neighbor
advertisement and neighbor
This patch adds support for match and set ICMPv6
"reserved" and "nd options type" fields.
v1->v2: Fixed compiler and sparse warnings.
v2->v3: Updated NEWS, simplified miniflow_extract for ICMPv6,
updated usage for tcp_flags and igmpgroup_ipv4.
v3->v4: Added parsing test in odp.at. Rebased to
Hello,justin
Forgive me! I have another question. As OVN use meters to
implement QoS and meters was added from ovs2.10, how the ovn(<2.10) support
QoS?
Regards,
Yunxiang
At 2019-01-28 15:43:24, "Justin Pettit" wrote:
>Sorry, I was thinking of another system that used
Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#33 FILE:
Userspace conntrack implementation in OVS is including L2 (Ethernet) pad bytes
as well for L4 checksum validation. This is a bug and any packet with non-zero
L2 padding bytes will be treated as invalid packet by conntrack due to checksum
failures.
This patch fixes the conntrack implementation by
38 matches
Mail list logo
