[ovs-dev] [branch-2.9 1/2] conntrack: fix ftp ipv4 address substitution.

When replacing the ipv4 address in repl_ftp_v4_addr(), the remaining size was incorrectly calculated which could lead to the wrong replacement adjustment. This goes unnoticed most of the time, unless you choose carefully your initial and replacement addresses. Example fail address combination

[ovs-dev] [branch-2.9 2/2] conntrack: Fix max size for inet_ntop() call.

The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle the maximum possible V6 address size for v4 mapping case. Found by inspection. Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") Signed-off-by: Darrell Ball --- lib/conntrack.c | 8 +++- 1 file changed, 3

[ovs-dev] [branch-2.8 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

'conn_key_extract()' in userspace conntrack is including L2 (Ethernet) pad bytes for both L3 and L4 sizes. One problem is any packet with non-zero L2 padding can incorrectly fail L4 checksum validation. This patch fixes conn_key_extract() by ignoring L2 pad bytes. Fixes: a489b16854b5

[ovs-dev] [branch-2.8 1/2] dp-packet: Add 'dp_packet_l3_size()'.

The new api will be used in a subsequent patch. Signed-off-by: Darrell Ball --- lib/dp-packet.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 980ef78..ea39eeb 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On Thu, Feb 14, 2019, 2:58 AM Gregory Rose wrote: > Norman, > > I couldn't find your original email to reply to so I just copied in your > patch below. My comments are preceeded > with ">>>". > > There's some changes I'd like to see and Lorenzo had some good review > comments as well. Thanks

[ovs-dev] [branch-2.7 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

'conn_key_extract()' in userspace conntrack is including L2 (Ethernet) pad bytes for both L3 and L4 sizes. One problem is any packet with non-zero L2 padding can incorrectly fail L4 checksum validation. This patch fixes conn_key_extract() by ignoring L2 pad bytes. Fixes: a489b16854b5

[ovs-dev] [branch-2.7 1/2] dp-packet: Add 'dp_packet_l3_size()'.

The new api will be used in a subsequent patch. Signed-off-by: Darrell Ball --- lib/dp-packet.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index cf7d247..b993d7e 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@

[ovs-dev] [branch-2.6 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

'conn_key_extract()' in userspace conntrack is including L2 (Ethernet) pad bytes for both L3 and L4 sizes. One problem is any packet with non-zero L2 padding can incorrectly fail L4 checksum validation. This patch fixes conn_key_extract() by ignoring L2 pad bytes. Fixes: a489b16854b5

[ovs-dev] [branch-2.6 1/2] dp-packet: Add 'dp_packet_l3_size()'.

The new api will be used in a subsequent patch. Signed-off-by: Darrell Ball --- lib/dp-packet.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 7c1e637..7d5438c 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@

[ovs-dev] Plan de vida y carrera

Cursos TOP - Webinar Interactivo – Miércoles 06 de Marzo Planes de carrera y sucesión El no disponer de un estudio de planes de carrera del personal puede suponer un factor de desmotivación de los trabajadores/as, que ven limitada su capacidad de ascenso y mejora en las condiciones de

[ovs-dev] [patch v13 8/8] Userspace datapath: Add fragmentation handling.

Fragmentation handling is added for supporting conntrack. Both v4 and v6 are supported. After discussion with several people, I decided to not store configuration state in the database to be more consistent with the kernel in future, similarity with other conntrack configuration which will not be

[ovs-dev] [patch v13 7/8] dp-packet: Add 'do_not_steal' packet batch flag.

This is needed in a subsequent patch and may otherwise be useful. Signed-off-by: Darrell Ball --- lib/dp-packet.h | 2 ++ lib/dpif-netdev.c | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 31c26e5..5b13329 100644 --- a/lib/dp-packet.h +++

[ovs-dev] [patch v13 6/8] dp-packet: Add 'dp_packet_batch_is_full()' api.

This new api is used in a subsequent patch and may otherwise be useful. Signed-off-by: Darrell Ball --- lib/dp-packet.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 26cfcb9..31c26e5 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -817,6

[ovs-dev] [patch v13 5/8] ovs-atomic: Add 64 bit apis.

Signed-off-by: Darrell Ball --- lib/ovs-atomic.h | 36 1 file changed, 36 insertions(+) diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h index 21e230e..11fa192 100644 --- a/lib/ovs-atomic.h +++ b/lib/ovs-atomic.h @@ -479,6 +479,42 @@

[ovs-dev] [patch v13 4/8] conntrack: Reword conntrack_execute() description.

Use 'must' instead of 'should'. Suggested-by: Justin Pettit Signed-off-by: Darrell Ball --- lib/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index de75c67..a044a69 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1298,7

[ovs-dev] [patch v13 3/8] tests: Add missed local stack checks.

Acked-by: Justin Pettit Signed-off-by: Darrell Ball --- tests/system-traffic.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index e34f7a4..de40734 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2981,6 +2981,7 @@

[ovs-dev] [patch v13 2/8] flow: Enhance parse_ipv6_ext_hdrs.

Acked-by: Justin Pettit Signed-off-by: Darrell Ball --- lib/conntrack.c | 4 ++-- lib/flow.c | 44 ++-- lib/flow.h | 3 ++- 3 files changed, 38 insertions(+), 13 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index

[ovs-dev] [patch v13 1/8] dp-packet: Add const qualifiers for checksum apis.

Acked-by: Justin Pettit Signed-off-by: Darrell Ball --- lib/dp-packet.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index c297a8f..26cfcb9 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -522,28 +522,28 @@

[ovs-dev] [patch v13 0/8] Userspace datapath: Add fragmentation support.

Fragmentation support for userspace datapath conntrack is added; both v4 and v6 are supported. Fragmentation handling is enabled by default and a command is supplied to disable it. Other commands allow setting the maximum number of fragments to be tracked, the minimum fragment size and

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

Norman, I couldn't find your original email to reply to so I just copied in your patch below.  My comments are preceeded with ">>>". There's some changes I'd like to see and Lorenzo had some good review comments as well.  Thanks for your work on this! - Greg diff --git

Re: [ovs-dev] [PATCH v6 1/1] acinclude: Also use LIBS from dpkg pkg-config

On 2/13/2019 2:26 PM, Stokes, Ian wrote: On Tue, Feb 12, 2019 at 11:47 PM Ben Pfaff wrote: On Tue, Feb 12, 2019 at 07:29:58AM +0100, Christian Ehrhardt wrote: DPDK 18.11 builds using the more modern meson build system no more provide the -ldpdk linker script. Instead it is expected to use

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On 2/13/2019 11:03 AM, Ben Pfaff wrote: On Wed, Feb 13, 2019 at 10:53:01AM -0800, Gregory Rose wrote: On 2/12/2019 1:15 PM, Gregory Rose wrote: On 2/11/2019 6:27 PM, Ben Pfaff wrote: Greg, I recommend that you take a look at this one. My apologies but I haven't been feeling well the last

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On Wed, Feb 13, 2019 at 10:53:01AM -0800, Gregory Rose wrote: > > On 2/12/2019 1:15 PM, Gregory Rose wrote: > > > > On 2/11/2019 6:27 PM, Ben Pfaff wrote: > > > Greg, I recommend that you take a look at this one. > > > > My apologies but I haven't been feeling well the last few days. I'll > >

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

On 2/12/2019 1:15 PM, Gregory Rose wrote: On 2/11/2019 6:27 PM, Ben Pfaff wrote: Greg, I recommend that you take a look at this one. My apologies but I haven't been feeling well the last few days. I'll have a look at this one. Thanks, I can't seem to find the actual patch - I went and

Re: [ovs-dev] [PATCH] faq: Update OVS/DPDK version table for OVS 2.11.

On 2/13/2019 4:27 PM, Kevin Traynor wrote: Indicate that OVS 2.11 uses DPDK 18.11. Signed-off-by: Kevin Traynor Thanks Kevin, pushed to master and 2.11 Ian ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] netdev-dpdk: Flow validation refactoring.

On Mon, Nov 12, 2018 at 12:28:39PM +0300, Ilya Maximets wrote: > * Dropped 'is_all_zero' function, which is equal to 'is_all_zeros' > from util.h . > * util.h added to includes. Includes re-sorted within their blocks. > (it's hard to figure out where to put new one if there is no order.) >

Re: [ovs-dev] [RFC] OVS robot discussion - check API integration

13/02/2019 17:56, Aaron Conole: > Ilya Maximets writes: > > And we, actually, already have special ovs-build mail-list. It could > > be used if you'll decide to choose DPDK way of working with patchwork. > > It looks intriguing. I like the idea that anyone could then contribute > 'check

Re: [ovs-dev] [RFC v3 2/5] Add a new OVS action check_pkt_larger

On Wed, Feb 13, 2019 at 10:53:53PM +0530, Numan Siddique wrote: > On Tue, Feb 12, 2019 at 8:33 AM Ben Pfaff wrote: > > > The OpenFlow syntax looks really weird. I don't understand it at all. > > > > By OpenFlow syntax you mean the way this action is being used ? > > i.e

Re: [ovs-dev] [RFC v3 2/5] Add a new OVS action check_pkt_larger

Thanks Ben for providing the review comments. I will address all the comments. A couple of comments inline. Thanks Numan On Tue, Feb 12, 2019 at 8:33 AM Ben Pfaff wrote: > On Thu, Jan 10, 2019 at 11:30:33PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds

Re: [ovs-dev] [patch v4 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

I backported as far as 2.9. For 2.8, it didn't apply cleanly--please post backports. On Wed, Feb 13, 2019 at 06:09:03AM +, Nitin Katiyar wrote: > Hi, > We would like to get it backported till OVS 2.6 at least. > > Regards, > Nitin > > > -Original Message- > > From: Ben Pfaff

Re: [ovs-dev] [RFC] OVS robot discussion - check API integration

Ilya Maximets writes: > On 11.02.2019 18:24, Aaron Conole wrote: >> I'm following up on a discussion where we briefly talked about adding >> a 'check' to OVS patch series during the OVS Conference. 'Check' is >> what the patchwork project provides to show that certain tests have been >>

Re: [ovs-dev] HA: SNAT on OVN logical_router in userspace works for ICMP but not TCP or UDP

On Wed, Feb 13, 2019 at 7:25 AM Rostyslav Fridman < rostyslav_frid...@epam.com> wrote: > Okay, I have managed to make it work, however I do not know if this is how > it is supposed to work. > > > > Basically, I reduced OVN scheme from > > container – internal switch – (container subnet gateway)

Re: [ovs-dev] [PATCH] dpif-netdev: Fix unsafe accesses to pmd polling lists.

On Wed, Feb 13, 2019 at 01:40:04PM +0300, Ilya Maximets wrote: > On 13.02.2019 1:24, Ben Pfaff wrote: > > On Tue, Feb 12, 2019 at 10:40:30AM +0300, Ilya Maximets wrote: > >> On 11.02.2019 22:15, Aaron Conole wrote: > >>> Ilya Maximets writes: > >>> > All accesses to 'pmd->poll_list' should

Re: [ovs-dev] [PATCH v1] doc: Add "Representors" topic document

On 2/13/2019 8:14 AM, Ophir Munk wrote: -Original Message- -Original Message- From: Ian Stokes Sent: Tuesday, February 12, 2019 7:17 PM To: Ilya Maximets ; Ophir Munk ; ovs-dev@openvswitch.org Cc: Olga Shern ; Kevin Traynor ; Asaf Penso ; Thomas Monjalon Subject: Re: [PATCH

[ovs-dev] [PATCH] faq: Update OVS/DPDK version table for OVS 2.11.

Indicate that OVS 2.11 uses DPDK 18.11. Signed-off-by: Kevin Traynor --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 86f09e6e2..cd7254b76 100644 --- a/Documentation/faq/releases.rst +++

[ovs-dev] Patricia Rementería

Cursos esenciales - Webinar Interactivo – Miércoles 27 de Febrero Balanced Scorecard El Balanced Scorecard ayuda a lograr un balance integrado del avance, crecimiento, productividad y competitividad de una organización y que proporciona la información necesaria para definir la dirección que

[ovs-dev] HA: HA: SNAT on OVN logical_router in userspace works for ICMP but not TCP or UDP

Okay, I have managed to make it work, however I do not know if this is how it is supposed to work. Basically, I reduced OVN scheme from container – internal switch – (container subnet gateway) internal router – interconnect switch – external router (NAT IP address) – external switch to

Re: [ovs-dev] HA: SNAT on OVN logical_router in userspace works for ICMP but not TCP or UDP

On Wed, Feb 13, 2019 at 5:16 AM Rostyslav Fridman via dev < ovs-dev@openvswitch.org> wrote: > Hi Darrel, > > I've reduced the amount of traffic. Here is dump-flows for ICMP traffic: > ovs-appctl dpif/dump-flows br-int >

Re: [ovs-dev] [PATCH] conntrack: force packet length check in extract_l3_ipv4

On Wed, Feb 13, 2019 at 1:10 AM Li RongQing wrote: > Assure the packet size is larger than ip total length > > Signed-off-by: Li RongQing > --- > lib/conntrack.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/lib/conntrack.c b/lib/conntrack.c > index 5c43410ec..4a39327b3 100644 >

Re: [ovs-dev] [PATCH v6 1/1] acinclude: Also use LIBS from dpkg pkg-config

> On Tue, Feb 12, 2019 at 11:47 PM Ben Pfaff wrote: > > > > On Tue, Feb 12, 2019 at 07:29:58AM +0100, Christian Ehrhardt wrote: > > > DPDK 18.11 builds using the more modern meson build system no more > > > provide the -ldpdk linker script. Instead it is expected to use > > > pkgconfig for linker

[ovs-dev] HA: SNAT on OVN logical_router in userspace works for ICMP but not TCP or UDP

Hi Darrel, I've reduced the amount of traffic. Here is dump-flows for ICMP traffic: ovs-appctl dpif/dump-flows br-int ct_state(-new+est-rel-inv+trk),recirc_id(0x303b),in_port(8),packet_type(ns=0,id=0),eth(src=00:00:00:61:f0:c0,dst=00:25:90:e7:23:94),eth_type(0x0800),ipv4(frag=no), packets:6,

Re: [ovs-dev] [RFC] OVS robot discussion - check API integration

On 11.02.2019 18:24, Aaron Conole wrote: > I'm following up on a discussion where we briefly talked about adding > a 'check' to OVS patch series during the OVS Conference. 'Check' is > what the patchwork project provides to show that certain tests have been > performed. It is made up of a name,

[ovs-dev] [PATCH] LACP-Rx packets are not captured in ovs-tcpdump.

Mirroring received LACP packets to help in debugging LACP issues. Co-authored-by: Manohar Krishnappa Chidambaraswamy Signed-off-by: Manohar Krishnappa Chidambaraswamy Signed-off-by: Nitin Katiyar --- ofproto/ofproto-dpif-xlate.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [ovs-dev] [PATCH] dpif-netdev: Fix unsafe accesses to pmd polling lists.

On 13.02.2019 1:24, Ben Pfaff wrote: > On Tue, Feb 12, 2019 at 10:40:30AM +0300, Ilya Maximets wrote: >> On 11.02.2019 22:15, Aaron Conole wrote: >>> Ilya Maximets writes: >>> All accesses to 'pmd->poll_list' should be guarded by 'pmd->port_mutex'. Additionally fixed inappropriate usage

[ovs-dev] Dodatečné zdroje

Dobrý den! Pro rozvoj podnikání živnostníků je zpravidla bariérou nedostatek provozních zdrojů na nákup materiálu, zboží nebo surovin z důvodu např. nezaplacení faktur (nezaplacení od dodavatelů, prodloužená splatnost apod.). V této oblasti jsme již pomohli řadě firem, které mohly díky získání

[ovs-dev] [PATCH] conntrack: force packet length check in extract_l3_ipv4

Assure the packet size is larger than ip total length Signed-off-by: Li RongQing --- lib/conntrack.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/conntrack.c b/lib/conntrack.c index 5c43410ec..4a39327b3 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1525,6 +1525,10 @@

Re: [ovs-dev] [PATCH v1] doc: Add "Representors" topic document

> -Original Message- > > -Original Message- > > From: Ian Stokes > > Sent: Tuesday, February 12, 2019 7:17 PM > > To: Ilya Maximets ; Ophir Munk > > ; ovs-dev@openvswitch.org > > Cc: Olga Shern ; Kevin Traynor > > ; Asaf Penso ; Thomas > > Monjalon > > Subject: Re: [PATCH v1]