Re: [ovs-dev] [ovs-dev, v2] netdev-dpdk: dfc_process optimization by

2019-03-12 Thread Yanqin Wei (Arm Technology China)
Thanks for the comments. It will be fixed in the following patch v3. -Original Message- From: Ilya Maximets Sent: Tuesday, March 12, 2019 9:31 PM To: Yanqin Wei (Arm Technology China) ; d...@openvswitch.org Cc: nd ; Gavin Hu (Arm Technology China) Subject: Re: [ovs-dev,v2] netdev-dpdk:

[ovs-dev] [PATCH v3] dpif-netdev: dfc_process optimization by prefetching EMC entry.

2019-03-12 Thread Yanqin Wei
It is observed that the throughput of multi-flow is worse than single-flow in the EMC NIC to NIC cases. It is because CPU cache-miss increasing in EMC lookup. Each flow need load at least one EMC entry to CPU cache(several cache lines) and compare it with packet miniflow. This patch improve it by

Re: [ovs-dev] OVS mailing lists *sometimes* replace the From: address by the list address

2019-03-12 Thread Ben Pfaff
On Mon, Mar 11, 2019 at 12:13:23PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > Hi Linux Foundation folks, > > > > We're seeing a recurring problem on the ovs-dev mailing list where, for > > some people, mailman is replacing the poster's own email address in > > mailing list messages by

[ovs-dev] 分管单位dev

2019-03-12 Thread 佛狸祠下
<温建兆 有增值稅普通發票開 等.. 微信: s s po168 > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Fix nbl cleanup when memory allocation fails

2019-03-12 Thread Anand Kumar via dev
Acked-by: Anand Kumar Thanks, Anand Kumar On 3/8/19, 1:23 PM, "ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal via dev" wrote: StartNblIngressError should be called only when an NBL hasn't been modified. In this case the nbl context was initialized. Rely on existing

Re: [ovs-dev] [PATCH] faq: Update features supported on Hyper-V

2019-03-12 Thread Sairam Venugopal via dev
Acked-by: Sairam Venugopal On 3/11/19, 1:48 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar via dev" wrote: These features were added a while back, so updating the documentation. Signed-off-by: Anand Kumar --- Documentation/faq/releases.rst | 6

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-03-12 Thread Sairam Venugopal via dev
Acked-by: Sairam Venugopal On 2/27/19, 6:10 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: When using a vport we need to guard its usage with the dispatch lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/User.c | 16

Re: [ovs-dev] [PATCH] datapath-windows: Add annotations to find vport functions

2019-03-12 Thread Sairam Venugopal via dev
Acked-by: Sairam Venugopal On 2/27/19, 9:34 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: Add annotations to find vport functions to check if the dispatch lock is held. Signed-off-by: Alin Gabriel Serdean ---

[ovs-dev] Flujo de efectivo

2019-03-12 Thread Dinero
Cursos de catalogo- Webinar Interactivo – Miércoles 20 de Marzo Herramientas de análisis financiero y administración de flujo de efectivo. Conocer los estados financieros y su aplicación en la empresa para obtener información de manera eficaz así como realizar planeaciones financieras para la

Re: [ovs-dev] [PATCH] manpages: Highlight --ct-next option.

2019-03-12 Thread Yi-Hung Wei
On Tue, Mar 12, 2019 at 5:53 AM Ilya Maximets wrote: > > This makes it look like other options. > > Signed-off-by: Ilya Maximets > --- Thanks for improving this manpage. Acked-by: Yi-Hung Wei ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] ovn-controller: Add a new thread in pinctrl module to handle packet-ins.

2019-03-12 Thread Han Zhou
On Tue, Mar 12, 2019 at 9:22 AM Numan Siddique wrote: > > > > On Tue, Mar 12, 2019 at 6:16 PM Mark Michelson wrote: >> >> On 3/11/19 6:11 PM, Han Zhou wrote: >> > On Mon, Mar 11, 2019 at 9:29 AM wrote: >> >> >> >> From: Numan Siddique >> >> >> >> Prior to this patch, ovn-controller was single

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-03-12 Thread Anand Kumar via dev
Acked-by: Anand Kumar Thanks, Anand Kumar On 2/27/19, 6:10 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: When using a vport we need to guard its usage with the dispatch lock. Signed-off-by: Alin Gabriel Serdean ---

Re: [ovs-dev] [PATCH] datapath-windows: Add annotations to find vport functions

2019-03-12 Thread Anand Kumar via dev
Acked-by: Anand Kumar Thanks, Anand Kumar On 2/27/19, 9:34 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: Add annotations to find vport functions to check if the dispatch lock is held. Signed-off-by: Alin Gabriel Serdean ---

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Ilya Maximets
On 12.03.2019 19:18, Ophir Munk wrote: > >>> >>> Not sure if I understand your point correctly, but isn't it expected >>> that if flow is offloaded than all the packets through the flow had flow >> mark? > > Not always. For fully HW offloaded traffic - packets will not be marked. > It is planned

[ovs-dev] [PATCH v2 1/2] ovn pinctrl: Pass 'struct rconn *swconn' to all the functions which use it

2019-03-12 Thread nusiddiq
From: Numan Siddique In pinctrl.c, many functions use 'swconn' variable which is declared as global static. This patch passes 'swconn' as a variable to functions. This will help in an upcoming patch which makes processing packet-ins in a separate pthread. Suggested-by: Mark Michelson

[ovs-dev] [PATCH v2 0/2] ovn-controller: Add a new thread in pinctrl module to process packet-ins

2019-03-12 Thread nusiddiq
From: Numan Siddique This series attempts to add a new thread in pinctrl module. This thread will handle the packet-ins. v1 -> v2 -- * Added a new patch p1 to the series suggessted by Mark. * Addressed the review comments from Han and Mark. Numan Siddique (2): ovn pinctrl: Pass

Re: [ovs-dev] [PATCH] ovn-controller: Add a new thread in pinctrl module to handle packet-ins.

2019-03-12 Thread Numan Siddique
On Tue, Mar 12, 2019 at 6:16 PM Mark Michelson wrote: > On 3/11/19 6:11 PM, Han Zhou wrote: > > On Mon, Mar 11, 2019 at 9:29 AM wrote: > >> > >> From: Numan Siddique > >> > >> Prior to this patch, ovn-controller was single threaded and everytime > the > >> poll_block() at the end of the main

Re: [ovs-dev] [PATCH] netdev-linux: Remove ingress qdisc before trying to add shared block

2019-03-12 Thread Ilya Maximets
> On Mon, Mar 11, 2019 at 03:24:47PM +, John Hurley wrote: >> On Mon, Mar 11, 2019 at 12:47 PM Roi Dayan wrote: >> > >> > Adding shared ingress block with ingress qdisc already exists results >> > in a failure. So remove the ingress qdisc first. >> > Also while at it log the slave name. >> >

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Ophir Munk
> > > > Not sure if I understand your point correctly, but isn't it expected > > that if flow is offloaded than all the packets through the flow had flow > mark? Not always. For fully HW offloaded traffic - packets will not be marked. It is planned to have another HW offload counter (which is

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Ilya Maximets
On 12.03.2019 18:51, Roni Bar Yanai wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Tuesday, March 12, 2019 5:25 PM >> To: Roni Bar Yanai ; Ophir Munk >> ; ovs-dev@openvswitch.org >> Cc: Asaf Penso ; Ian Stokes ; >> Shahaf Shuler ; Olga Shern >> ; Kevin Traynor >>

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Roni Bar Yanai
> -Original Message- > From: Ilya Maximets > Sent: Tuesday, March 12, 2019 5:25 PM > To: Roni Bar Yanai ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Asaf Penso ; Ian Stokes ; > Shahaf Shuler ; Olga Shern > ; Kevin Traynor > Subject: Re: [PATCH v1] dpif: Add marked packets stats > >

[ovs-dev] Request for your valuable inputs

2019-03-12 Thread rahulmeco
I've invited you to fill out the following form: A brief survey of open source software developers To fill it out, visit: https://docs.google.com/forms/d/e/1FAIpQLSdthSFUnx8ERlfbRzFGtXdGu0Hdou0nYgHw7DKwGzuXqh0_xA/viewform?vc=0c=0w=1usp=mail_form_link Hi, I am a PhD Research Scholar at

[ovs-dev] [PATCH] lib: added check to prevent int overflow

2019-03-12 Thread Toms Atteka
If enough large input is given ofpact_finish will fail. Check was added and error message returned. Basic manual testing performed. Reported-by: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12972 Signed-off-by: Toms Atteka --- lib/learn.c | 5 + 1 file changed, 5 insertions(+)

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Ilya Maximets
On 12.03.2019 17:53, Roni Bar Yanai wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Tuesday, March 12, 2019 11:11 AM >> To: Ophir Munk ; ovs-dev@openvswitch.org >> Cc: Asaf Penso ; Ian Stokes ; >> Shahaf Shuler ; Olga Shern >> ; Kevin Traynor ; Roni Bar >> Yanai >>

[ovs-dev] Cierre de Inscripciones

2019-03-12 Thread Power Point
Cursos esenciales - Webinar Interactivo – Viernes 22 de Marzo Cómo presentar proyectos y resultados a nivel profesional Presentar un proyecto a nivel profesional utilizando las herramientas adecuadas y teniendo una planeación óptima. Partimos desde la elaboración y los tiempos, hasta la

Re: [ovs-dev] [PATCH] netdev-linux: Remove ingress qdisc before trying to add shared block

2019-03-12 Thread Simon Horman
On Mon, Mar 11, 2019 at 03:24:47PM +, John Hurley wrote: > On Mon, Mar 11, 2019 at 12:47 PM Roi Dayan wrote: > > > > Adding shared ingress block with ingress qdisc already exists results > > in a failure. So remove the ingress qdisc first. > > Also while at it log the slave name. > > > >

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Remove ingress qdisc on tc init flow api

2019-03-12 Thread Simon Horman
On Mon, Mar 11, 2019 at 03:25:09PM +, John Hurley wrote: > On Mon, Mar 11, 2019 at 2:34 PM Roi Dayan wrote: > > > > It could be a port added to ovs bridge already has ingress qdisc > > which will make the block probe fail. > > The probes should start clean and ingress is being added later > >

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Roni Bar Yanai
> -Original Message- > From: Ilya Maximets > Sent: Tuesday, March 12, 2019 11:11 AM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Asaf Penso ; Ian Stokes ; > Shahaf Shuler ; Olga Shern > ; Kevin Traynor ; Roni Bar > Yanai > Subject: Re: [PATCH v1] dpif: Add marked packets stats >

Re: [ovs-dev] [ovs-dev, v2] netdev-dpdk: dfc_process optimization by

2019-03-12 Thread Ilya Maximets
Hi. Thanks for working on this. Not a full review, just a few notes about formatting. 1. Looks like your subject line was accidentally cropped. 2. This change is local to generic parts of 'dpif-netdev', so, the "area" in a subject line should be 'dpif-netdev'. There is nothing DPDK specific

Re: [ovs-dev] [ovs-dev,v9] Improved Packet Drop Statistics in OVS

2019-03-12 Thread Ilya Maximets
Hi. Have you missed my "inline" comments to v8: https://mail.openvswitch.org/pipermail/ovs-dev/2019-February/356153.html ? Best regards, Ilya Maximets. On 27.02.2019 12:22, Anju Thomas wrote: > Currently OVS maintains explicit packet drop/error counters only on port > level. Packets that are

[ovs-dev] [PATCH] manpages: Highlight --ct-next option.

2019-03-12 Thread Ilya Maximets
This makes it look like other options. Signed-off-by: Ilya Maximets --- ofproto/ofproto-unixctl.man | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ofproto/ofproto-unixctl.man b/ofproto/ofproto-unixctl.man index 2db4fe633..925752343 100644 ---

Re: [ovs-dev] [PATCH] ovn-controller: Add a new thread in pinctrl module to handle packet-ins.

2019-03-12 Thread Mark Michelson
On 3/11/19 6:11 PM, Han Zhou wrote: On Mon, Mar 11, 2019 at 9:29 AM wrote: From: Numan Siddique Prior to this patch, ovn-controller was single threaded and everytime the poll_block() at the end of the main while() loop wakes up, it processes the whole SB DB and translates the logical flows

Re: [ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Ilya Maximets
On 12.03.2019 11:41, Ophir Munk wrote: > This commit adds marked packets statistics. Following commit [1], > received packets can be marked with a mark id which is associated > with the flow on which the packets were recieved. This commits counts > the marked packets per flow and displays the

[ovs-dev] [PATCH v1] dpif: Add marked packets stats

2019-03-12 Thread Ophir Munk
This commit adds marked packets statistics. Following commit [1], received packets can be marked with a mark id which is associated with the flow on which the packets were recieved. This commits counts the marked packets per flow and displays the result when executing datapath dump-flow command