Re: [ovs-dev] [PATCH] ovn-controller: Fix busy loop when sb disconnected.

2019-04-03 Thread Numan Siddique
On Wed, Apr 3, 2019 at 10:05 AM Han Zhou wrote: > Thanks Numan for the review. Please see my response below. > > On Tue, Apr 2, 2019 at 3:59 AM Numan Siddique wrote: > > > > > > > > On Mon, Apr 1, 2019 at 1:15 AM Han Zhou wrote: > >> > >> From: Han Zhou > >> > >> In the main loop, if the SB DB

Re: [ovs-dev] [PATCH OVS 2/4] ovs-tc: allow offloading of ingress mirr TC actions to datapath

2019-04-03 Thread John Hurley
On Wed, Apr 3, 2019 at 7:19 AM Roi Dayan wrote: > > > > On 02/04/2019 20:14, John Hurley wrote: > > On Tue, Apr 2, 2019 at 4:05 PM Roi Dayan wrote: > >> > >> > >> > >> On 02/04/2019 12:27, John Hurley wrote: > >>> The TC datapath only permits the offload of mirr actions if they are > >>> egress.

[ovs-dev] [PATCH] compiler: Fix compilation when using VStudio 2015/2017

2019-04-03 Thread Alin Gabriel Serdean
This is somewhat a regression of: https://github.com/openvswitch/ovs/commit/27f141d44d95b4cabfd7eac47ace8d1201668b2c The main issue using `offsetof` from via the C compiler from MSVC 2015/2017 has issues and is buggy: https://bit.ly/2UvWwti Until it is fixed, we define our own definition of `off

[ovs-dev] [PATCH] windows, tests: Allow tests to run on MSYS2

2019-04-03 Thread Alin Gabriel Serdean
Signed-off-by: Alin Gabriel Serdean --- tests/atlocal.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/atlocal.in b/tests/atlocal.in index 5eff0a0aa..50c2a48a4 100644 --- a/tests/atlocal.in +++ b/tests/atlocal.in @@ -100,7 +100,7 @@ esac # Check for platform. case

Re: [ovs-dev] [PATCH] compiler: Disable BUILD_MESSAGE() when processing with sparse.

2019-04-03 Thread Alin Serdean
On 28 Mar 2019, at 01:11, Ben Pfaff mailto:b...@ovn.org>> wrote: sparse doesn't support _Pragma(message(x)), even though GCC does, so HAVE_PRAGMA_MESSAGE is deceptive in that case and causes pointless errors. Signed-off-by: Ben Pfaff mailto:b...@ovn.org>> --- lib/compiler.h | 4 ++— Acked-by: A

Re: [ovs-dev] [PATCH v2] datapath-windows: Address memory allocation issues for OVS_BUFFER_CONTEXT

2019-04-03 Thread Alin Gabriel Serdean
Applied on master! > On 25 Mar 2019, at 19:29, aserd...@ovn.org wrote: > > -Original Message- > From: ovs-dev-boun...@openvswitch.org On > Behalf Of Anand Kumar via dev > Sent: Thursday, March 21, 2019 1:55 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v2] datapath-windows: A

Re: [ovs-dev] [PATCH v4] checkpatch: Normalize exit code for Windows

2019-04-03 Thread Alin Gabriel Serdean
Applied on master! > On 19 Mar 2019, at 00:43, Alin Gabriel Serdean wrote: > > Using python `sys.exit(-1)` on Windows produces mixed results. > Let's take the following results from different shells: > CMD >> python -c "import sys; sys.exit(-1)" & echo %errorlevel% > 1 > MSYS > $ python -c "impo

Re: [ovs-dev] [PATCH] datapath-windows: Add guards around IpHelper adapter binding calls

2019-04-03 Thread Alin Serdean
Applied on master! > On 25 Mar 2019, at 19:26, Alin Serdean > wrote: > > -Original Message- > From: ovs-dev-boun...@openvswitch.org On > Behalf Of Sairam Venugopal via dev > Sent: Thursday, March 14, 2019 12:37 AM > To: ovs-dev@openvswitch.org > Subject: [ovs-dev] [PATCH] datapath-wi

[ovs-dev] Recursos Humanos

2019-04-03 Thread Call Center - Operación óptima
Cursos TOP - Webinar Interactivo – Jueves 16 de Mayo Operación Óptima de un Call Center La operación de un Call center requiere de disciplina, pero sobre todo de astucia e inteligencia. Y es que supervisar o gestionar un Call center o Contact center requiere del conocimiento y la habilidad par

[ovs-dev] [PATCH] datapath: Revert "datapath: Fix template leak in error cases."

2019-04-03 Thread Yifeng Sun
From: Flavio Leitner Upstream commit: commit 7f6d6558ae44bc193eb28df3617c364d3bb6df39 Author: Flavio Leitner Date: Fri Sep 28 14:55:34 2018 -0300 Revert "openvswitch: Fix template leak in error cases." This reverts commit 90c7afc. When the commit was merged, the code

Re: [ovs-dev] datapath: Revert "datapath: Fix template leak in error cases."

2019-04-03 Thread 0-day Robot
Bleep bloop. Greetings Yifeng Sun, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Flavio Leitner needs to sign off. WARNING: Unexpected sign-offs from developers wh

[ovs-dev] [PATCH v2 1/2] ovn-controller: Fix busy loop when sb disconnected.

2019-04-03 Thread Han Zhou
From: Han Zhou In the main loop, if the SB DB is disconnected when there is a pending transaction, there can be busy loop causing 100% CPU of ovn-controller, until SB DB is connected again. The root cause is that when a transaction is pending, ovsdb_idl_loop_run() will return NULL for ovnsb_idl_

[ovs-dev] [PATCH v2 2/2] chassis.c: Return chassis record whenever available in chassis_run().

2019-04-03 Thread Han Zhou
From: Han Zhou The ovn-controller main loop relies on the return value of chassis_run(). When ovnsb_idl_txn is NULL (i.e. there is a pending transaction for SB), chasssis_run() returns NULL, which blocks functions to be executed in the main loop unnecessarily. This patch updates chassis_run() so

[ovs-dev] [PATCH v2] datapath-windows: Add Win10Analyze target

2019-04-03 Thread Alin Gabriel Serdean
This patch adds a new target called `Win10Analyze` to the driver solution. It enables us to trigger static analysis over the Win10 target. Since the location of the ruleset of drivers is somewhat random starting from 1803: https://www.osr.com/blog/2018/05/21/wdk-1803-ca/ Commit the ruleset insid

Re: [ovs-dev] [PATCH v2 1/2] ovn-controller: Fix busy loop when sb disconnected.

2019-04-03 Thread Numan Siddique
On Wed, Apr 3, 2019 at 10:37 PM Han Zhou wrote: > From: Han Zhou > > In the main loop, if the SB DB is disconnected when there is a pending > transaction, there can be busy loop causing 100% CPU of ovn-controller, > until SB DB is connected again. > > The root cause is that when a transaction is

Re: [ovs-dev] [PATCH v2 2/2] chassis.c: Return chassis record whenever available in chassis_run().

2019-04-03 Thread Numan Siddique
On Wed, Apr 3, 2019 at 10:38 PM Han Zhou wrote: > From: Han Zhou > > The ovn-controller main loop relies on the return value of chassis_run(). > When ovnsb_idl_txn is NULL (i.e. there is a pending transaction for SB), > chasssis_run() returns NULL, which blocks functions to be executed in > the

Re: [ovs-dev] [ovs-dev, v2, 1/2] ovn-controller: Fix busy loop when sb disconnected.

2019-04-03 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #97 FILE: ovn/controller/ovn-controlle

Re: [ovs-dev] [PATCH] datapath: Revert "datapath: Fix template leak in error cases."

2019-04-03 Thread Flavio Leitner via dev
On Wed, Apr 03, 2019 at 09:49:13AM -0700, Yifeng Sun wrote: > From: Flavio Leitner > > Upstream commit: > commit 7f6d6558ae44bc193eb28df3617c364d3bb6df39 > Author: Flavio Leitner > Date: Fri Sep 28 14:55:34 2018 -0300 > > Revert "openvswitch: Fix template leak in error cases."

Re: [ovs-dev] [PATCH] faq: Explain why select groups don't sort out packets evenly.

2019-04-03 Thread Alin Serdean
On 8 Mar 2019, at 03:47, Ben Pfaff mailto:b...@ovn.org>> wrote: This keeps coming up. Signed-off-by: Ben Pfaff mailto:b...@ovn.org>> — Acked-by: Alin Gabriel Serdean mailto:aserd...@ovn.org>> ___ dev mailing list d...@openvswitch.org https://mail.o

[ovs-dev] [PATCH v4] Policy-based Routing(PBR) in OVN

2019-04-03 Thread Mary Manohar
PBR provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the logical-router. Reroute policies are needed for service-insertion and service-chaining. Currently, policies are stateless. Mary Manohar (1): Policy

[ovs-dev] [PATCH v4] Policy-based routing (PBR) in OVN.

2019-04-03 Thread Mary Manohar
PBR provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the logical-router. Reroute policies are needed for service-insertion and service-chaining. Currently, policies are stateless. To achieve this, a new tab

[ovs-dev] [PATCH v3 1/2] ovn-controller: Fix busy loop when sb disconnected.

2019-04-03 Thread Han Zhou
From: Han Zhou In the main loop, if the SB DB is disconnected when there is a pending transaction, there can be busy loop causing 100% CPU of ovn-controller, until SB DB is connected again. The root cause is that when a transaction is pending, ovsdb_idl_loop_run() will return NULL for ovnsb_idl_

[ovs-dev] [PATCH v3 2/2] chassis.c: Return chassis record whenever available in chassis_run().

2019-04-03 Thread Han Zhou
From: Han Zhou The ovn-controller main loop relies on the return value of chassis_run(). When ovnsb_idl_txn is NULL (i.e. there is a pending transaction for SB), chasssis_run() returns NULL, which blocks functions to be executed in the main loop unnecessarily. This patch updates chassis_run() so

Re: [ovs-dev] [ovs-dev,v4] Policy-based routing (PBR) in OVN.

2019-04-03 Thread 0-day Robot
Bleep bloop. Greetings Mary Manohar, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #369 FILE: ovn/utilities/ovn-nbctl.c:649: lr-p