[ovs-dev] [PATCH v2 2/2] netdev-linux: Don't remove ingress when not configured

2019-04-08 Thread Tonghao Zhang
In some case, we may not use the openvswitch tc to limit the ingress police rate. And before we add the port to openvswitch bridge, we may set the ingress policer, so don't remove the ingress when we not configured it in openvswitch. Signed-off-by: Tonghao Zhang --- lib/netdev-linux.c | 21 +

[ovs-dev] [PATCH v2 1/2] netdev-linux: Add coverage counters for netdev_set_policing when ingress tc-offload

2019-04-08 Thread Tonghao Zhang
When enable tc-offload, we should add coverage counters for netdev_set_policing. Fixes: e7f6ba220e10 ("lib/tc: add ingress ratelimiting support for tc-offload") Cc: Pieter Jansen van Vuuren Signed-off-by: Tonghao Zhang --- lib/netdev-linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

Re: [ovs-dev] [PATCH] netdev-linux: Don't remove ingress when not configured

2019-04-08 Thread Tonghao Zhang
On Tue, Apr 9, 2019 at 4:21 AM Ben Pfaff wrote: > > On Fri, Apr 05, 2019 at 12:53:39AM -0400, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > In some case, we may not use the openvswitch tc to limit the ingress > > police rate. And before we add the port to openvswitch bridge, we

Re: [ovs-dev] [PATCH v5] ovsdb raft: Sync commit index to followers without delay.

2019-04-08 Thread Han Zhou
On Wed, Mar 27, 2019 at 4:10 PM Han Zhou wrote: > > On Mon, Mar 25, 2019 at 4:24 PM Han Zhou wrote: > > > > On Mon, Mar 25, 2019 at 2:00 PM Ben Pfaff wrote: > > > > > > On Sat, Mar 23, 2019 at 09:44:26AM -0700, Han Zhou wrote: > > > > From: Han Zhou > > > > > > > > When update is requested from

[ovs-dev] OVSDB client library for C?

2019-04-08 Thread Duane Butler
Hello, I am interested in using OVSDB as a general purpose database (not necessarily with openvswitch), and would like to develop my own client to talk to ovsdb-server. The OvS website (http://docs.openvswitch.org/en/latest/ref/ovsdb.7/) makes this statement: The OVSDB protocol specification

Re: [ovs-dev] [PATCH] netdev-linux: Don't remove ingress when not configured

2019-04-08 Thread Ben Pfaff
On Fri, Apr 05, 2019 at 12:53:39AM -0400, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > In some case, we may not use the openvswitch tc to limit the ingress > police rate. And before we add the port to openvswitch bridge, we may > set the ingress policer, so don't remove the ingress w

Re: [ovs-dev] [PATCH] bond/mirror: fix duplicate output when mix bond and mirror

2019-04-08 Thread Ben Pfaff
On Fri, Apr 05, 2019 at 01:26:29PM +, ? ? wrote: > When we configured bond that use recirc and configure mirror, we > observed that mirror destination is duplicated output. This is > because bond's frozen_state is not updated to reflect the mirror > already composed the output, and when the co

Re: [ovs-dev] [PATCH] windows, tests: Allow tests to run on MSYS2

2019-04-08 Thread Ben Pfaff
On Wed, Apr 03, 2019 at 03:03:34PM +0300, Alin Gabriel Serdean wrote: > Signed-off-by: Alin Gabriel Serdean Looks good to me. Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/5] compiler: Disable BUILD_MESSAGE() when processing with sparse.

2019-04-08 Thread Ben Pfaff
On Mon, Apr 08, 2019 at 11:22:02AM -0700, Ben Pfaff wrote: > sparse doesn't support _Pragma(message(x)), even though GCC does, so > HAVE_PRAGMA_MESSAGE is deceptive in that case and causes pointless errors. > > Signed-off-by: Ben Pfaff Alin separately reviewed this one, and I've applied it, so y

Re: [ovs-dev] [PATCH] compiler: Disable BUILD_MESSAGE() when processing with sparse.

2019-04-08 Thread Ben Pfaff
On Wed, Apr 03, 2019 at 12:11:05PM +, Alin Serdean wrote: > > > On 28 Mar 2019, at 01:11, Ben Pfaff mailto:b...@ovn.org>> wrote: > > sparse doesn't support _Pragma(message(x)), even though GCC does, so > HAVE_PRAGMA_MESSAGE is deceptive in that case and causes pointless errors. > > Signed-o

Re: [ovs-dev] Question about mega / micro-flow co-existence

2019-04-08 Thread Ben Pfaff
On Fri, Apr 05, 2019 at 07:21:50PM +, Deval, Manasi wrote: > I have a few small questions about OvS and how it has evolved since > the NSDI paper > (http://www.openvswitch.org/support/papers/nsdi2015.pdf) > The paper discusses how the reactive method of flow addition was not > scalable, hence

[ovs-dev] Potencial herramienta para los negocios

2019-04-08 Thread Whatsapp
Cursos TOP - Webinar Interactivo – Viernes 03 de Mayo ¿Cómo vender por whatsapp ? Las ventas se logran el 90% con una estrategia comunicacional y el 10% con tecnología. En nuestro webinar podrás conocer todo lo que debes saber sobre WhatsApp, esta poderosa herramienta que todos utilizamos de m

[ovs-dev] [PATCH 5/5] odp-util: Add FLOW_WC_SEQ assertions.

2019-04-08 Thread Ben Pfaff
The assertions make it easier to find all the places that need to be updated when adding protocol support. Signed-off-by: Ben Pfaff --- lib/odp-util.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/odp-util.c b/lib/odp-util.c index 6e545b80ba6c..f60536c1d9dc 100644 --- a/lib

[ovs-dev] [PATCH 3/5] meta-flow: Add comment.

2019-04-08 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/meta-flow.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 1724e46e1b97..e3274b97f335 100644 --- a/lib/meta-flow.c +++ b/lib/meta-flow.c @@ -2287,6 +2287,12 @@ mf_set(const struct mf_field *mf, *err_str =

[ovs-dev] [PATCH 4/5] flow: Add FLOW_WC_SEQ assertions and improve comments.

2019-04-08 Thread Ben Pfaff
The assertions make it easier to find all the places that need to be updated when adding protocol support. Signed-off-by: Ben Pfaff --- lib/flow.c | 64 -- lib/odp-util.c | 15 ++-- 2 files changed, 49 insertions(+), 30 deletions(-) di

[ovs-dev] [PATCH 2/5] extract-ofp-fields: Improve error message.

2019-04-08 Thread Ben Pfaff
Without this change, it's not obvious what needs to be edited. Signed-off-by: Ben Pfaff --- build-aux/extract-ofp-fields | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build-aux/extract-ofp-fields b/build-aux/extract-ofp-fields index e159a1df66e2..7a4e8e170171 100755 ---

[ovs-dev] [PATCH 1/5] compiler: Disable BUILD_MESSAGE() when processing with sparse.

2019-04-08 Thread Ben Pfaff
sparse doesn't support _Pragma(message(x)), even though GCC does, so HAVE_PRAGMA_MESSAGE is deceptive in that case and causes pointless errors. Signed-off-by: Ben Pfaff --- lib/compiler.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/compiler.h b/lib/compiler.h inde

[ovs-dev] Harvard / taller de negociación.

2019-04-08 Thread Negociación estratégica y estrategias de negociación.
innova Taller de negociación al estilo HARVARD - para gerentes y directores - Cursos TOP - Webinar Interactivo – martes 07 de Mayo kpis En este webinar verás cómo se centra el eje de la negociación en estimular los intereses propios por encima de otros factores o estrategias cola

Re: [ovs-dev] Questions about rcu_postpone's wrong use in classifier.c

2019-04-08 Thread Ilya Maximets
On 02.04.2019 14:28, fuzhantao wrote: > > +d...@openvswitch.org 'ovs-disc...@openvswitch.org' > > Hi Ilya & Ben > Thanks for your reply and suggestion. The following is my patch to fix > this bug(refer to Ilya's double postponing method). > It is useful via our fault-injection test. Co

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-08 Thread David Marchand
Hello Ilya, On Mon, Apr 8, 2019 at 10:27 AM Ilya Maximets wrote: > On 04.04.2019 22:49, David Marchand wrote: > > We tried to lower the number of rebalances but we don't have a > > satisfying solution at the moment, so this patch rebalances on each > > update. > > Hi. > > Triggering the reconfig

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Fix probe tc block support

2019-04-08 Thread John Hurley
On Mon, Apr 8, 2019 at 1:43 PM Roi Dayan wrote: > > From: Raed Salem > > Current implementation will try to create an qdisk of type ingress with > block id 1 to check for kernel ingress block support, this check is > insufficient as old kernels without ingress block support will > successfully cr

Re: [ovs-dev] [PATCH OVS v2 4/4] ovs-tc: offload datapath rules matching on internal ports

2019-04-08 Thread John Hurley
On Mon, Apr 8, 2019 at 11:49 AM Roi Dayan wrote: > > > > On 08/04/2019 13:38, Roi Dayan wrote: > > > > > > On 04/04/2019 19:05, John Hurley wrote: > >> Rules applied to OvS internal ports are not represented in TC datapaths. > >> However, it is possible to support rules matching on internal ports

[ovs-dev] [PATCH] netdev-tc-offloads: Fix probe tc block support

2019-04-08 Thread Roi Dayan
From: Raed Salem Current implementation will try to create an qdisk of type ingress with block id 1 to check for kernel ingress block support, this check is insufficient as old kernels without ingress block support will successfully create an ingress qdisc, ignoring the ingress block. Fix by try

Re: [ovs-dev] [PATCH OVS v2 4/4] ovs-tc: offload datapath rules matching on internal ports

2019-04-08 Thread Roi Dayan
On 08/04/2019 13:38, Roi Dayan wrote: > > > On 04/04/2019 19:05, John Hurley wrote: >> Rules applied to OvS internal ports are not represented in TC datapaths. >> However, it is possible to support rules matching on internal ports in TC. >> The start_xmit ndo of OvS internal ports directs pack

Re: [ovs-dev] [PATCH OVS v2 4/4] ovs-tc: offload datapath rules matching on internal ports

2019-04-08 Thread Roi Dayan
On 04/04/2019 19:05, John Hurley wrote: > Rules applied to OvS internal ports are not represented in TC datapaths. > However, it is possible to support rules matching on internal ports in TC. > The start_xmit ndo of OvS internal ports directs packets back into the OvS > kernel datapath where the

Re: [ovs-dev] [PATCH OVS v2 3/4] ovs-tc: allow offloading TC rules to egress qdiscs

2019-04-08 Thread Roi Dayan
On 04/04/2019 19:05, John Hurley wrote: > Offloading rules to a TC datapath only allows the creating of ingress hook > qdiscs and the application of filters to these. However, there may be > certain situations where an egress qdisc is more applicable (e.g. when > offloading to TC rules applied t

Re: [ovs-dev] [PATCH OVS v2 2/4] ovs-tc: allow offloading of ingress mirred TC actions to datapath

2019-04-08 Thread Roi Dayan
On 04/04/2019 19:05, John Hurley wrote: > The TC datapath only permits the offload of mirred actions if they are > egress. To offload TC actions that output to OvS internal ports, ingress > mirred actions are required. At the TC layer, an ingress mirred action > passes the packet back into the n

Re: [ovs-dev] [PATCH OVS v2 1/4] compat: add compatibility headers for tc skbedit action

2019-04-08 Thread Roi Dayan
On 04/04/2019 19:05, John Hurley wrote: > OvS includes compat code for several TC actions including vlan, mirred and > tunnel key. Add support for using skbedit actions when compiling > user-space code against older kernel headers. > > Signed-off-by: John Hurley > --- > acinclude.m4

Re: [ovs-dev] [ovs-dev, 0/6] Accelerate peer port forwarding by bypassing DP processing

2019-04-08 Thread Ilya Maximets
On 02.04.2019 17:57, Eli Britstein wrote: > Current HW offloading solutions use embedded switches to offload OVS DP > rules while using SRIOV pass-through interfaces to the guest VMs. This > architecture requires the VM guests to install vendor specific drivers > and is challenging for live-migrati

Re: [ovs-dev] openvswitch crash on i386

2019-04-08 Thread Juerg Haefliger
On Tue, 19 Mar 2019 11:45:44 -0700 Gregory Rose wrote: > On 3/14/2019 6:59 PM, Ben Pfaff wrote: > > On Thu, Mar 14, 2019 at 03:53:12PM -0700, Gregory Rose wrote: > >> A further update on this bug. > >> > >> A reliable indicator that the bug is going to occur imminently is when this > >> junk ap

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-08 Thread Ilya Maximets
On 04.04.2019 22:49, David Marchand wrote: > We currently poll all available queues based on the max queue count > exchanged with the vhost peer and rely on the vhost library in DPDK to > check the vring status beneath. > This can lead to some overhead when we have a lot of unused queues. > This si

Re: [ovs-dev] [PATCH v3] OVN: Add support for Transport Zones

2019-04-08 Thread Daniel Alvarez Sanchez
Tested-by: Daniel Alvarez On Thu, Mar 28, 2019 at 11:37 AM wrote: > > From: Lucas Alvares Gomes > > This patch is adding support for Transport Zones. Transport zones (a.k.a > TZs) is way to enable users of OVN to separate Chassis into different > logical groups that will form tunnels only betwe

Re: [ovs-dev] [PATCH v1] netdev-vport: Check DPDK_NETDEV for offloaded API.

2019-04-08 Thread Ilya Maximets
On 02.04.2019 12:18, Ophir Munk wrote: > vport offloaded functions should have a different implementation for > linux based OVS versus dpdk based OVS. Currently there is only support > for linux based offloaded API. The code in the file named netdev-vport.c > checks 'ifdef __linux__' to select the