[ovs-dev] Imprimi a bajo costo

2019-04-30 Thread Estudio Grafico Flores
--- Postales Clásicas Papel 350 gramos. Full Color frente y dorso. Laminado brillo frente opcional. Tiempo de producción 10 a 12 días. $2700.                 Cantidad 1000 u. Etiquetas Ropa Clásicas   Cantidad 1000 u.

Re: [ovs-dev] [PATCH] oss-fuzz: fixed wrong lib path

2019-04-30 Thread Ben Pfaff
On Tue, Apr 30, 2019 at 04:57:45AM -0700, Toms Atteka wrote: > the logical-fields.h file was moved. Path has been updated > accordingly. This broke oss-fuzz buils. > > Signed-off-by: Toms Atteka Thanks, applied to master. ___ dev mailing list

[ovs-dev] [PATCH 10/10] OpenFlow: Enable OpenFlow 1.5 by default.

2019-04-30 Thread Ben Pfaff
Open vSwitch now supports all OpenFlow 1.5 required features, so enable it by default. Signed-off-by: Ben Pfaff --- Documentation/faq/openflow.rst| 27 +-- .../group-selection-method-property.txt | 16 +-- NEWS

[ovs-dev] [PATCH 09/10] ofp-actions: Support OF1.5 meter action.

2019-04-30 Thread Ben Pfaff
OpenFlow 1.5 changed "meter" from an instruction to an action. This commit supports it properly. Signed-off-by: Ben Pfaff --- Documentation/topics/openflow.rst | 6 -- NEWS | 1 + include/openvswitch/ofp-actions.h | 4 +- lib/ofp-actions.c |

[ovs-dev] [PATCH 08/10] tests: Add negative tests for action and instruction parsing.

2019-04-30 Thread Ben Pfaff
This adds a negative test for almost all of the error messages that parsing an action or instruction can produce. This commit removes now-redundant tests from multipath.at. Signed-off-by: Ben Pfaff --- tests/multipath.at | 30 --- tests/ofp-actions.at | 209

[ovs-dev] [PATCH 06/10] ofp-actions: Improve a few error messages.

2019-04-30 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/multipath.c | 4 ++-- lib/ofp-actions.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/multipath.c b/lib/multipath.c index 43a3d8f30466..6896f94a1e2b 100644 --- a/lib/multipath.c +++ b/lib/multipath.c @@ -1,5 +1,5 @@ /* - *

[ovs-dev] [PATCH 07/10] ovs-ofctl: New testing command "parse-group".

2019-04-30 Thread Ben Pfaff
This will be used in an upcoming test. Signed-off-by: Ben Pfaff --- lib/ofp-group.c | 5 - utilities/ovs-ofctl.c | 41 - 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/lib/ofp-group.c b/lib/ofp-group.c index

[ovs-dev] [PATCH 04/10] ofp-actions: Improve error messages for verification failures in parsing.

2019-04-30 Thread Ben Pfaff
Verification can fail for a variety of reasons but the code here always reported "Incorrect instruction ordering". Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 90 - tests/classifier.at | 6 +-- 2 files changed, 59 insertions(+), 37

[ovs-dev] [PATCH 03/10] ofp-actions: Enforce minimum length for packet truncation during parsing.

2019-04-30 Thread Ben Pfaff
Otherwise, specifying something like output(port=1,max_len=5) would parse OK and then cause a failure when it was received by the switch. Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index

[ovs-dev] [PATCH 02/10] ofp-actions: Make decap action format output match parsed input.

2019-04-30 Thread Ben Pfaff
The action expects 'type' as a parameter name so it should use 'type' when it formats actions too. Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index 182277da85cb..c2cef769e839 100644 ---

[ovs-dev] [PATCH 01/10] ofp-actions: Make encap action really require OF1.3+.

2019-04-30 Thread Ben Pfaff
This action is only supported in OpenFlow 1.3 and later, but the parser from text allowed it in earlier versions, which could cause confusion, e.g.: $ ovs-ofctl parse-flow 'actions=encap(ethernet())' usable protocols: any chosen protocol: OpenFlow10-table_id

[ovs-dev] [PATCH] rhel: fix logrotate group when dpdk is enabled

2019-04-30 Thread Jaime Caamaño Ruiz
Otherwise logrotate will fail to generate the rotated log files. Signed-off-by: Jaime Caamaño Ruiz --- rhel/openvswitch-fedora.spec.in | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-30 Thread William Tu
Thanks Ben and Eelco On Tue, Apr 30, 2019 at 9:18 AM Eelco Chaudron wrote: > > > On 30 Apr 2019, at 18:10, Ben Pfaff wrote: > > > On 25.04.2019 2:47, William Tu wrote: > >> +#define unlikely OVS_UNLIKELY > >> +#define likely OVS_LIKELY > >> +#define barrier() __asm__ __volatile__("": :

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-30 Thread Eelco Chaudron
On 30 Apr 2019, at 18:10, Ben Pfaff wrote: > On 25.04.2019 2:47, William Tu wrote: >> +#define unlikely OVS_UNLIKELY >> +#define likely OVS_LIKELY >> +#define barrier() __asm__ __volatile__("": : :"memory") >> +#define smp_rmb() barrier() >> +#define smp_wmb() barrier() > > Does any of this

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-30 Thread Ben Pfaff
On 25.04.2019 2:47, William Tu wrote: > +#define unlikely OVS_UNLIKELY > +#define likely OVS_LIKELY > +#define barrier() __asm__ __volatile__("": : :"memory") > +#define smp_rmb() barrier() > +#define smp_wmb() barrier() Does any of this mean we're cutting and pasting Linux kernel code into OVS

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-30 Thread Ilya Maximets
One more thing. On 25.04.2019 2:47, William Tu wrote: > +#define unlikely OVS_UNLIKELY > +#define likely OVS_LIKELY > +#define barrier() __asm__ __volatile__("": : :"memory") > +#define smp_rmb() barrier() > +#define smp_wmb() barrier() You may probably use something like this: #include

Re: [ovs-dev] [RFC 0/2] Split up netdev offloading to separate module.

2019-04-30 Thread Ben Pfaff
On Tue, Apr 30, 2019 at 02:30:45PM +0300, Ilya Maximets wrote: > On 29.04.2019 19:32, Ben Pfaff wrote: > > On Wed, Apr 24, 2019 at 09:07:17AM -0700, Ben Pfaff wrote: > >> On Wed, Apr 24, 2019 at 05:07:16PM +0300, Ilya Maximets wrote: > >>> This is the further work about splitting up netdev

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-30 Thread Ilya Maximets
On 27.04.2019 16:28, William Tu wrote: > >  if WIN32 > >  lib_libopenvswitch_la_SOURCES += \ > > diff --git a/lib/dp-packet.c b/lib/dp-packet.c > > index 0976a35e758b..a61552f72988 100644 > > --- a/lib/dp-packet.c > > +++ b/lib/dp-packet.c > > @@ -22,6 +22,9 @@ > > 

[ovs-dev] conference session recordings - video with slides

2019-04-30 Thread Jesse Eric Tanner
Hello,I just wanted to follow-up on my last email to you regarding our on-site conference session recording and distance education technology services. We video record your sessions (or live stream), create an online library of content, and provide this service anywhere your conference is held.

[ovs-dev] [RFC 5/5] dpif-netdev: Catch reloads faster.

2019-04-30 Thread David Marchand
Looking at the reload flag only every 1024 loops can be a long time under load, since we might be handling 32 packets per iteration, which means 32k packets. Look at the flag every loop, no major performance impact seen. Signed-off-by: David Marchand --- lib/dpif-netdev.c | 10 +- 1

[ovs-dev] [RFC 3/5] dpif-netdev: Do not sleep when swapping queues.

2019-04-30 Thread David Marchand
When swapping queues from a pmd thread to another (q0 polled by pmd0/q1 polled by pmd1 -> q1 polled by pmd0/q0 polled by pmd1), the current "Step 5" puts both pmds to sleep waiting for the control thread to wake them up later. Prefer to make them spin in such a case to avoid sleeping an

[ovs-dev] [RFC 4/5] dpif-netdev: Only reload static tx qid when needed.

2019-04-30 Thread David Marchand
pmd->static_tx_qid is allocated under a mutex by the different pmd threads. Unconditionally reallocating it will make those pmd threads sleep when contention occurs. During "normal" reloads like for rebalancing queues between pmd threads, this can make pmd threads waste time on this. Reallocating

[ovs-dev] [RFC 2/5] dpif-netdev: Trigger parallel pmd reloads.

2019-04-30 Thread David Marchand
pmd reloads are currently serialised in each steps calling reload_affected_pmds. Any pmd processing packets, waiting on a mutex etc... will make other pmd threads wait for a delay that can be undeterministic when syscalls adds up. Switch to a little busy loop on the control thread using an atomic

[ovs-dev] [RFC 1/5] dpif-netdev: Convert exit latch to flag.

2019-04-30 Thread David Marchand
No need for a latch here since we don't have to wait. A simple boolean flag is enough. Fixes: e4cfed38b159 ("dpif-netdev: Add poll-mode-device thread.") Signed-off-by: David Marchand --- lib/dpif-netdev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [RFC 0/5] Quicker pmd threads reloads

2019-04-30 Thread David Marchand
We have been testing the rebalance code in different situations while having traffic going through OVS. Those tests have shown that part of the observed packets losses is due to some time wasted in signaling/waiting for the pmd threads to reload their polling configurations. This RFC series is an

[ovs-dev] [PATCH] oss-fuzz: fixed wrong lib path

2019-04-30 Thread Toms Atteka
the logical-fields.h file was moved. Path has been updated accordingly. This broke oss-fuzz buils. Signed-off-by: Toms Atteka --- tests/oss-fuzz/expr_parse_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/oss-fuzz/expr_parse_target.c

Re: [ovs-dev] [PATCH net-next v3 0/4] openvswitch: load and reference the NAT helper

2019-04-30 Thread Pablo Neira Ayuso
On Wed, Apr 17, 2019 at 11:46:13AM -0300, Flavio Leitner wrote: > The request_module() is quite expensive and triggers the > usermode helper in userspace. Instead, load only if the > module is not present and keep module references to avoid > problems. > > The first patch standardize the module

Re: [ovs-dev] [RFC 0/2] Split up netdev offloading to separate module.

2019-04-30 Thread Ilya Maximets
On 29.04.2019 19:32, Ben Pfaff wrote: > On Wed, Apr 24, 2019 at 09:07:17AM -0700, Ben Pfaff wrote: >> On Wed, Apr 24, 2019 at 05:07:16PM +0300, Ilya Maximets wrote: >>> This is the further work about splitting up netdev offloading >>> from the generic netdev related code and making different >>>

Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign vport netdev functions.

2019-04-30 Thread Roni Bar Yanai
Aaron, please see inline. >-Original Message- >From: ovs-dev-boun...@openvswitch.org >On Behalf Of Aaron Conole >Sent: Monday, April 29, 2019 4:44 PM >To: Ilya Maximets >Cc: ovs-dev@openvswitch.org; Thomas Monjalon >Subject: Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign

Re: [ovs-dev] [PATCH] ovs-tcpdump: Fix E117 over-indented.

2019-04-30 Thread Ilya Maximets
On 29.04.2019 17:13, Aaron Conole wrote: > Ilya Maximets writes: > >> utilities/ovs-tcpdump.in:376:9: E117 over-indented >> make[2]: *** [flake8-check] Error 1 >> >> CC: Liu Chang >> Fixes: 2eeadf73d931 ("ovs-tcpdump: Improve error message when tcpdump is not >> available.") >>