Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#627 FILE: ovn/utilities/ovn-nbctl.c:575:
Background:
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
This Series:
Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan
backed distributed logical
This series is about enhancing the logical router functionality in OVN to work
with vlan backed logical switches.
Intial proposal was discused here:
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
Background:
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
This Series:
Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan
backed distributed logical router.
This
Hi Numan,
Thanks for trying out the patch.
Please find my comments inline.
Regards,
Ankur
From: Numan Siddique
Sent: Friday, May 10, 2019 5:44 AM
To: Ankur Sharma
Cc: ovs-dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v7 2/2] OVN: Enable N-S Traffic, Vlan backed DVR
On Thu, May 9, 2019
Hi Numan,
Glad to see your comments.
I have handled all the comments in the code, v8 will have the same.
Regarding your comments on backward compatibility:
“
Hi Ankur,
For most part the patch looks fine to me. Please see some additional comments.
I still have few questions about the type added
Hi Han,
Thanks for review.
Yup, looks like it, although I did not try the scenario myself, but yes entry
are not getting removed once added,
hence, new mac bindings will not be added after some time (as existing count
reaches 1000).
Regards,
Ankur
From: Han Zhou
Sent: Friday, May 10, 2019
On Fri, May 10, 2019 at 2:46 PM Ankur Sharma
wrote:
>
> ISSUE:
> a. As soon as entries get added to put_mac_bindings in pinctrl.c,
>ovn-controller CPU consumption reached 100%.
>
> b. This happens because in wait_put_mac_bindings,
>if !hmap_is_empty(_mac_bindings) succeeds and
>calls
On Fri, 10 May 2019 at 14:47, Guru Shetty wrote:
>>>
>>>
>>> > +# daemons. Another "restart" (outside the package postinst script) is
>>> > +# needed to actually run new daemons.
>>> > +if [ -e "%{_tmppath}/ovs-upgrade-from-sysv" ]; then
>>> t seems that if rpm package that was built
This fixes two bugs. First, & has a special meaning in the replacement
text for a sed "s" command, so this escapes it. Second, this code
misprocessed bold or underlined &<>: >^H> would become ^H which
would display as in most browers.
Finally, this improves the HTML output so that bold ABC
ISSUE:
a. As soon as entries get added to put_mac_bindings in pinctrl.c,
ovn-controller CPU consumption reached 100%.
b. This happens because in wait_put_mac_bindings,
if !hmap_is_empty(_mac_bindings) succeeds and
calls poll_immediat_wake().
ovn-controller.log:
>
>
>> > +# daemons. Another "restart" (outside the package postinst script)
>> is
>> > +# needed to actually run new daemons.
>> > +if [ -e "%{_tmppath}/ovs-upgrade-from-sysv" ]; then
>> t seems that if rpm package that was built from rhel spec file was
>> removed (without upgrade)
Oops, nice catch, thanks, I will fix in later patch.
Yifeng
On Fri, May 10, 2019 at 1:53 PM Darrell Ball wrote:
>
> Looks a little odd: 'HAVE_NF_CONNTRACK_L3PROATO_H'
>
> You may want a follow up patch:
> s/HAVE_NF_CONNTRACK_L3PROATO_H/HAVE_NF_CONNTRACK_L3PROTO_H
>
>
>
> On 5/10/19, 12:31 PM,
On Thu, 9 May 2019 at 17:37, Ansis Atteka wrote:
> On Fri, 3 May 2019 at 11:19, Gurucharan Shetty wrote:
> >
> > Currently we have rhel/openvswitch.spec.in that provides
> > sysv scripts. The fedora package provides systemd scripts.
> > If one upgrades openvswitch package from sysv to systemd,
Looks a little odd: 'HAVE_NF_CONNTRACK_L3PROATO_H'
You may want a follow up patch:
s/HAVE_NF_CONNTRACK_L3PROATO_H/HAVE_NF_CONNTRACK_L3PROTO_H
On 5/10/19, 12:31 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yifeng
Sun"
wrote:
Upstream kernel commit a0ae2562 ("netfilter: conntrack:
Bleep bloop. Greetings Yifeng Sun, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 datapath: Handle removal of
Thanks Ben. I will pay attention for future patches.
Yifeng
On Fri, May 10, 2019 at 1:18 PM Ben Pfaff wrote:
>
> Please add tags to each patch, because they need to be there when the
> patches are applied.
>
> I took care of that myself, and I also reordered the tags a little
> (Signed-off-by
Please add tags to each patch, because they need to be there when the
patches are applied.
I took care of that myself, and I also reordered the tags a little
(Signed-off-by should be last) and applied this series to master.
Thanks, everyone!
On Fri, May 10, 2019 at 12:53:08PM -0700, Yifeng Sun
On 5/10/2019 12:53 PM, Yifeng Sun wrote:
Thanks Greg, I've put your tags in the cover letter.
Yifeng
Now I see them. Thanks!
On Fri, May 10, 2019 at 12:47 PM Gregory Rose wrote:
My tags are missing.
For the series:
Tested-by: Greg Rose
Reviewed-by: Greg Rose
On 5/10/2019 12:30 PM,
Thanks Greg, I've put your tags in the cover letter.
Yifeng
On Fri, May 10, 2019 at 12:47 PM Gregory Rose wrote:
>
> My tags are missing.
>
> For the series:
>
> Tested-by: Greg Rose
> Reviewed-by: Greg Rose
>
> On 5/10/2019 12:30 PM, Yifeng Sun wrote:
> > This series of patches enabled OVS to
My tags are missing.
For the series:
Tested-by: Greg Rose
Reviewed-by: Greg Rose
On 5/10/2019 12:30 PM, Yifeng Sun wrote:
This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.
Tests shows that this series of patches passed check-kmod tests or
didn't introduce new failed
Please use v3, v2 was messed up, sorry.
Thanks,
Yifeng
On Fri, May 10, 2019 at 11:31 AM Ben Pfaff wrote:
>
> Please do in this case. It simplifies my workflow.
>
> On Fri, May 10, 2019 at 11:28:16AM -0700, Yifeng Sun wrote:
> > Hi Ben,
> >
> > All the patches in this series got acked. Do I
This patch updated acinclude.m4 so that OVS can be compiled on 4.19.x
and 4.20.x kernels.
This patch also updated travis files so that latest kernel versions
are used during travis test builds.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
.travis.yml | 18 ++
NEWS
From: Gao Feng
Upstream commit:
commit 440534d3c56be04abfb26850ee882d19d223557a
Author: Gao Feng
Date: Mon Jul 9 18:06:33 2018 +0800
netfilter: Remove useless param helper of nf_ct_helper_ext_add
The param helper of nf_ct_helper_ext_add is useless now, then remove
it
From: Florian Westphal
Upstream commit:
commit 60e3be94e6a1c5162a0763c9aafb5190b2b1fdce
Author: Florian Westphal
Date: Mon Jun 25 17:55:32 2018 +0200
openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
These versions deal with the l3proto/l4proto details internally.
This patch fixes the compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
datapath/linux/compat/include/net/netfilter/nf_conntrack_count.h | 4 ++--
datapath/linux/compat/nf_conncount.c | 6 +-
2 files changed, 7
From: Florian Westphal
Upstream commit:
commit 70b095c84326640eeacfd69a411db8fc36e8ab1a
Author: Florian Westphal
Date: Sat Jul 14 01:14:01 2018 +0200
ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module
IPV6=m
DEFRAG_IPV6=m
CONNTRACK=y yields:
From: Florian Westphal
Upstream Commit:
commit 93e66024b0249cec81e91328c55a754efd3192e0
Author: Florian Westphal
Date: Wed Sep 12 15:19:07 2018 +0200
netfilter: conntrack: pass nf_hook_state to packet and error handlers
nf_hook_state contains all the hook
Upstream kernel commit a0ae2562 ("netfilter: conntrack: remove l3proto
abstraction") removed header file net/netfilter/nf_conntrack_l3proto.h.
This patch detects it and fixes compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
acinclude.m4
This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.
Tests shows that this series of patches passed check-kmod tests or
didn't introduce new failed check-kmod tests for the following
kernel versions:
3.10.0-957.12.1.el7.x86_64 (rhel)
4.4.0-31-generic (ubuntu 14.04)
From: Florian Westphal
Upstream commit:
commit 60e3be94e6a1c5162a0763c9aafb5190b2b1fdce
Author: Florian Westphal
Date: Mon Jun 25 17:55:32 2018 +0200
openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
These versions deal with the l3proto/l4proto details internally.
This patch fixes the compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
datapath/linux/compat/include/net/netfilter/nf_conntrack_count.h | 4 ++--
datapath/linux/compat/nf_conncount.c | 6 +-
2 files changed, 7
Upstream kernel commit a0ae2562 ("netfilter: conntrack: remove l3proto
abstraction") removed header file net/netfilter/nf_conntrack_l3proto.h.
This patch detects it and fixes compilation errors of OVS on 4.19+ kernels.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
acinclude.m4
This patch updated acinclude.m4 so that OVS can be compiled on 4.19.x
and 4.20.x kernels.
This patch also updated travis files so that latest kernel versions
are used during travis test builds.
Signed-off-by: Yifeng Sun
Acked-by: Yi-Hung Wei
---
.travis.yml | 18 ++
NEWS
From: Florian Westphal
Upstream Commit:
commit 93e66024b0249cec81e91328c55a754efd3192e0
Author: Florian Westphal
Date: Wed Sep 12 15:19:07 2018 +0200
netfilter: conntrack: pass nf_hook_state to packet and error handlers
nf_hook_state contains all the hook
From: Gao Feng
Upstream commit:
commit 440534d3c56be04abfb26850ee882d19d223557a
Author: Gao Feng
Date: Mon Jul 9 18:06:33 2018 +0800
netfilter: Remove useless param helper of nf_ct_helper_ext_add
The param helper of nf_ct_helper_ext_add is useless now, then remove
it
From: Florian Westphal
Upstream commit:
commit 70b095c84326640eeacfd69a411db8fc36e8ab1a
Author: Florian Westphal
Date: Sat Jul 14 01:14:01 2018 +0200
ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module
IPV6=m
DEFRAG_IPV6=m
CONNTRACK=y yields:
This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.
Tests shows that this series of patches passed check-kmod tests or
didn't introduce new failed check-kmod tests for the following
kernel versions:
3.10.0-957.12.1.el7.x86_64 (rhel)
4.4.0-31-generic (ubuntu 14.04)
Hi Ben,
All the patches in this series got acked. Do I need to send v2 for
those patches that were acked in v1?
Thanks,
Yifeng
On Wed, May 8, 2019 at 4:36 PM Yifeng Sun wrote:
>
> Sure, I will submit new versions after testing is done.
> Thanks,
> Yifeng
>
> On Wed, May 8, 2019 at 4:05 PM Ben
Please do in this case. It simplifies my workflow.
On Fri, May 10, 2019 at 11:28:16AM -0700, Yifeng Sun wrote:
> Hi Ben,
>
> All the patches in this series got acked. Do I need to send v2 for
> those patches that were acked in v1?
>
> Thanks,
> Yifeng
>
> On Wed, May 8, 2019 at 4:36 PM Yifeng
Aaron Conole writes:
> Flavio Leitner writes:
>
>> On Thu, Apr 18, 2019 at 01:46:22PM -0600, Alex Williamson wrote:
>>> On Thu, 18 Apr 2019 15:50:43 -0300
>>> Flavio Leitner wrote:
>>>
>>> > On Thu, Apr 18, 2019 at 12:06:57PM -0600, Alex Williamson wrote:
>>> > > On Thu, 18 Apr 2019 13:56:23
On Thu, May 9, 2019 at 10:56 AM Yifeng Sun wrote:
>
> From: Gao Feng
>
> Upstream commit:
> commit 440534d3c56be04abfb26850ee882d19d223557a
> Author: Gao Feng
> Date: Mon Jul 9 18:06:33 2018 +0800
>
> netfilter: Remove useless param helper of nf_ct_helper_ext_add
>
> The
On Thu, May 9, 2019 at 10:55 AM Yifeng Sun wrote:
>
> From: Florian Westphal
>
> Upstream commit:
> commit 60e3be94e6a1c5162a0763c9aafb5190b2b1fdce
> Author: Florian Westphal
> Date: Mon Jun 25 17:55:32 2018 +0200
>
> openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
>
>
On Wed, May 8, 2019 at 5:00 PM Yifeng Sun wrote:
>
> From: Florian Westphal
>
> Upstream commit:
> commit 70b095c84326640eeacfd69a411db8fc36e8ab1a
> Author: Florian Westphal
> Date: Sat Jul 14 01:14:01 2018 +0200
>
> ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module
>
>
On Wed, May 8, 2019 at 4:59 PM Yifeng Sun wrote:
>
> From: Florian Westphal
>
> Upstream Commit:
> commit 93e66024b0249cec81e91328c55a754efd3192e0
> Author: Florian Westphal
> Date: Wed Sep 12 15:19:07 2018 +0200
>
> netfilter: conntrack: pass nf_hook_state to packet and error
>
>
> Hi,
> usually a package on Fedora/RHEL7+ is never enabled by default, unless
> it's necessary to enable it for a really good reason.
>
I would like to put an argument on why this a good reason in this case.
When I did a grep on 2 large repositories at VMware that use openvswitch
RPMs,
On Fri, 3 May 2019 00:05:34 -0700
Gurucharan Shetty wrote:
> We currently have rhel/openvswitch.spec.in that automatically
> enables openvswitch service when the package is installed using
> chkconfig.
>
> But fedora rpm may not enable openvswitch service automatically.
> The macro currently
diffusion
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, May 10, 2019 at 02:37:33PM +0530, Numan Siddique wrote:
> On Thu, May 2, 2019 at 11:28 PM Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> >
>
> Acked-by: Numan Siddique
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
On Fri, May 10, 2019 at 02:33:29PM +0530, Numan Siddique wrote:
> On Wed, May 1, 2019 at 5:23 AM Ben Pfaff wrote:
>
> > Reported-by: William Konitzer
> > Signed-off-by: Ben Pfaff
> >
>
> Acked-by: Numan Siddique
Thanks, applied to master.
___
dev
Not a big deal.
On Fri, May 10, 2019 at 05:57:01AM -0700, Cpp Code wrote:
> Ok, missed that
>
> On Thu, May 9, 2019 at 1:59 PM Ben Pfaff wrote:
>
> > On Thu, May 09, 2019 at 06:29:59AM -0700, Toms Atteka wrote:
> > > This fixes stack overflow issues for odp_actions_from_string.
> > > Added
Ok, missed that
On Thu, May 9, 2019 at 1:59 PM Ben Pfaff wrote:
> On Thu, May 09, 2019 at 06:29:59AM -0700, Toms Atteka wrote:
> > This fixes stack overflow issues for odp_actions_from_string.
> > Added wrapper functions for recursion limitation.
> >
> > Basic manual testing was performed.
> >
On Thu, May 9, 2019 at 4:29 AM Ankur Sharma
wrote:
> Background:
> [1]
> https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
> [2]
> https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
>
> This Series:
> Layer 2, Layer 3 E-W and
On Thu, May 9, 2019 at 4:28 AM Ankur Sharma
wrote:
> Background:
> [1]
> https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
> [2]
> https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
>
> This Series:
> Layer 3 E-W and Layer 3 N-S
On Wed, May 1, 2019 at 5:23 AM Ben Pfaff wrote:
> Reported-by: William Konitzer
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> vswitchd/ovs-vswitchd.8.in | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/vswitchd/ovs-vswitchd.8.in
On Thu, May 2, 2019 at 11:28 PM Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
>
Acked-by: Numan Siddique
> ---
> v1->v2: Add paragraph about liveness.
>
> lib/ovs-actions.xml | 53 +
> 1 file changed, 49 insertions(+), 4 deletions(-)
>
> diff
On Thu, May 9, 2019 at 1:40 PM Dumitru Ceara wrote:
> The chassis_lookup_by_name function now calls
> sbrec_chassis_index_set_name instead of sbrec_chassis_set_name. Due to
> the use of the wrong API memory was leaked every time a chassis was
> looked up by name. This was mostly visible when
57 matches
Mail list logo
