Re: [ovs-dev] [PATCHv9] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-27 Thread William Tu
On Sun, May 26, 2019 at 10:35 PM Yanqin Wei (Arm Technology China) wrote: > > Hi William, > > I think the main objective of this patch is to introduce AF_XDP socket for > OVS userspace datapath. This is an alternative to DPDK PMD library. Is it > possible to continue using other DPDK

[ovs-dev] [PATCH v2] dpif-netdev: Fix unsafe access to pmd polling lists.

2019-05-27 Thread Ilya Maximets
All accesses to 'pmd->poll_list' should be guarded by 'pmd->port_mutex'. Additionally fixed inappropriate usage of 'HMAP_FOR_EACH_SAFE' (hmap doesn't change in a loop) and dropped not needed local variable 'proc_cycles'. CC: Nitin Katiyar Fixes: 5bf84282482a ("Adding support for PMD auto load

[ovs-dev] [PATCH v2] dpif-netdev: Forwarding optimization for direct output flows.

2019-05-27 Thread Ilya Maximets
There are some cases where users want to have simple forwarding or drop rules for all packets received from particular port, i.e : "in_port=1,actions=2" "in_port=1,actions=IN_PORT" "in_port=1,actions=drop" There are also cases where complex OF flows could be simplified down to simple

Re: [ovs-dev] [PATCH] dpif-netdev: Forwarding optimization for direct output flows.

2019-05-27 Thread Ilya Maximets
On 24.05.2019 19:20, Ben Pfaff wrote: > On Fri, May 24, 2019 at 03:18:50PM +0300, Ilya Maximets wrote: >> There are some cases where users want to have simple forwarding or drop >> rules for all packets received from particular port, i.e : >> >> "in_port=1,actions=2" >>

Re: [ovs-dev] [PATCH v3] ovn-controller: Fix parsing of OVN tunnel IDs

2019-05-27 Thread Numan Siddique
On Mon, May 27, 2019, 4:01 PM Dumitru Ceara wrote: > On Mon, May 27, 2019 at 11:57 AM 0-day Robot wrote: > > > > Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out > your patch. > > Thanks for your contribution. > > > > I encountered some error that I wasn't expecting.

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-27 Thread Roni Bar Yanai
Ilya thanks for the answer. Seems we have a different point of view. "You contradict yourself. "not part of the switch" vs "OF switch with great performance". It's not the OF switch anymore if you're hiding ports from OF and users." I don't think I contradict myself. VF and Vhost "ports"

Re: [ovs-dev] [PATCH v3] ovn-controller: Fix parsing of OVN tunnel IDs

2019-05-27 Thread Dumitru Ceara
On Mon, May 27, 2019 at 11:57 AM 0-day Robot wrote: > > Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > fatal: sha1 information is

Re: [ovs-dev] [PATCH] OVN: do not distribute traffic for local FIP

2019-05-27 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (ovn/northd/ovn-northd.c). Repository lacks

Re: [ovs-dev] [PATCH v3] ovn-controller: Fix parsing of OVN tunnel IDs

2019-05-27 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (ovn/controller/bfd.c). Repository lacks necessary

[ovs-dev] [PATCH] OVN: do not distribute traffic for local FIP

2019-05-27 Thread Lorenzo Bianconi
Do not send traffic for local FIP through the overlay tunnels but manage it in the local hypervisor Signed-off-by: Lorenzo Bianconi --- ovn/northd/ovn-northd.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index

Re: [ovs-dev] [PATCH] Add support for DHCP option 15 - domain name

2019-05-27 Thread Maciej Jozefczyk
Hello! >> What's the full story? I found that option not used in code. It was only used in parser tests, but with the same flag number - 15 as domain_name. https://tools.ietf.org/html/rfc2132 As per RFC I decided to rename it in tests and add its support to the code. Should I add some note to

[ovs-dev] [PATCH v3] ovn-controller: Fix parsing of OVN tunnel IDs

2019-05-27 Thread Dumitru Ceara
Encap tunnel-ids are of the form: . In physical_run we were checking if a tunnel-id corresponds to the local chassis-id by searching if the chassis-id string is included in the tunnel-id (strstr). This can break quite easily, for example, if the local chassis-id is a substring of a remote

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-27 Thread Ilya Maximets
On 24.05.2019 23:51, Roni Bar Yanai wrote: > Hi Ilya, > (S > > See inline. > >> -Original Message- >> From: Ilya Maximets >> Sent: Friday, May 24, 2019 3:21 PM >> To: Simon Horman ; Roni Bar Yanai >> >> Cc: ovs-dev@openvswitch.org; Ian Stokes ; Kevin Traynor >> ; Oz Shlomo ; Eli

Re: [ovs-dev] [PATCH v3] ovn: Add a new logical switch port type - 'virtual'

2019-05-27 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (include/ovn/actions.h). Repository lacks

Re: [ovs-dev] [PATCH] ovn: Add a new logical switch port type - 'virtual'

2019-05-27 Thread Numan Siddique
On Sun, May 26, 2019 at 12:59 PM Numan Siddique wrote: > > > On Sat, May 25, 2019 at 2:29 AM Ben Pfaff wrote: > >> This commit adds new columns virtual_ip and virtual_parents in the >> Logical_Switch_Port table, which are used for the new 'virtual' port >> type. Most of the time, if a

[ovs-dev] [PATCH v3] ovn: Add a new logical switch port type - 'virtual'

2019-05-27 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a