[ovs-dev] Fix for hashing fragmented UDP packets

2019-05-30 Thread Van Bemmel, Jeroen (Nokia - US)
Hello all, Back in 2015 I submitted some code to improve ECMP hashing algorithms used in OVS, see https://mail.openvswitch.org/pipermail/ovs-dev/2015-July/300748.html We have now found an issue with the hashing of fragmented UDP packets: The first packet contains the UDP ports, but the rest of

Re: [ovs-dev] [PATCH v2]conntrack: ignore port for ICMP/ICMPv6 NAT.

2019-05-30 Thread 0-day Robot
Bleep bloop. Greetings solomon, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

Re: [ovs-dev] [PATCH]ovs:conntrack: ignore port for icmp/icmpv6 protocol

2019-05-30 Thread solomon
Thank you very much for your suggestions and testcases. I sent a v2 patch,ref to https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359385.html Darrell Ball wrote: > Thanks Solomon; fix looks good. > > Can you: > > 1/ Change subject to: > > "conntrack: ignore port for ICMP/ICMPv6

[ovs-dev] [PATCH v2]conntrack: ignore port for ICMP/ICMPv6 NAT.

2019-05-30 Thread solomon
ICMP/ICMPv6 fails, if the src/dst port is set in a common NAT rule. like this: actions=ct(nat(dst=172.16.1.100:5000),commit,table=40) Fixes: 4cd0481c9e8b ("conntrack: Fix wasted work for ICMP NAT.") CC: Darrell Ball Signed-off-by: solomon Signed-off-by: Darrell Ball --- lib/conntrack.c

[ovs-dev] [PATCH] Remove ESX references.

2019-05-30 Thread Justin Pettit
Signed-off-by: Justin Pettit --- configure.ac | 1 - lib/automake.mk | 6 -- lib/dpif.h| 6 +++--- m4/openvswitch.m4 | 10 -- 4 files changed, 3 insertions(+), 20 deletions(-) diff --git a/configure.ac b/configure.ac index 2dbe9a9178e3..a9f0a06dc140 100644 ---

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: add af_xdp support.

2019-05-30 Thread William Tu
Hi Ilya, Thanks for the comments. On Thu, May 30, 2019 at 12:47 AM Ilya Maximets wrote: > > On 29.05.2019 20:57, William Tu wrote: > > On Wed, May 29, 2019 at 10:51 AM William Tu wrote: > >> > > Thanks for the logs. It looks like a bug in DPDK. > Does rte_eal_hotplug_remove() works without

[ovs-dev] Product Inquiry

2019-05-30 Thread Maria Wilson
Hello, Can you quote the best price of the items listed on our attached purchase order, As the order are urgently needed and so let me know if you can deliver it before the end of next month. Awaiting your prompt reply Best regards Gerhard J. Kahmann Purchasing Dept

Re: [ovs-dev] [patch v1] tests: Include ovn-macros for system testsuites.

2019-05-30 Thread Gregory Rose
On 5/25/2019 1:49 PM, Darrell Ball wrote: ovn-macros are needed to run the OVN system tests. Signed-off-by: Darrell Ball --- tests/system-kmod-testsuite.at | 1 + tests/system-userspace-testsuite.at | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/system-kmod-testsuite.at

Re: [ovs-dev] [PATCH] netdev-dpdk: ensure that qid is valid before using it

2019-05-30 Thread Ilya Maximets
On 30.05.2019 11:05, Li RongQing wrote: > otherwise it maybe lead to out of bound access in tx_q > > Signed-off-by: Li RongQing > --- > lib/netdev-dpdk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index

Re: [ovs-dev] [PATCHv10] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-30 Thread Ilya Maximets
On 28.05.2019 22:01, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to DPDK but cooperate

Re: [ovs-dev] [PATCH]ovs:conntrack: ignore port for icmp/icmpv6 protocol

2019-05-30 Thread Darrell Ball
Thanks Solomon; fix looks good. Can you: 1/ Change subject to: "conntrack: ignore port for ICMP/ICMPv6 NAT." 2/ Change commit message body to: ICMP/ICMPv6 fails, if the src/dst port is set in a common NAT rule. like this: actions=ct(nat(dst=172.16.1.100:5000),commit,table=40) Fixes:

[ovs-dev] [patch v2] conntrack: Add option to enable TCP liberal mode.

2019-05-30 Thread Darrell Ball
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359188.html Signed-off-by: Darrell Ball --- v2: Remove presently redundant check. NEWS| 1 + lib/conntrack-private.h | 6 ++- lib/conntrack-tcp.c | 20 +++ lib/conntrack.c | 15 ++

[ovs-dev] [PATCH] ossfuzz: Fix expr target build failure

2019-05-30 Thread bshastry
From: Bhargava Shastry Google oss-fuzz reported a build failure for the OVN expression parser. Upon investigation, it turned out that the expr_parse_target fuzzer was not being run by Google due to the said failure. The root cause of the build failure turned out to be a change in the

Re: [ovs-dev] Offer

2019-05-30 Thread Christopher . Mulvey
Donation to you, contact julieleach...@gmail.com [https://www.winchester.ac.uk/media/content-assets/corporate-imagery/Email-signature.png] Our privacy policy is

Re: [ovs-dev] [PATCH]ovs:conntrack: ignore port for icmp/icmpv6 protocol

2019-05-30 Thread 0-day Robot
Bleep bloop. Greetings solomon, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Darrell Ball needs to sign off. WARNING: Unexpected sign-offs from developers who are

[ovs-dev] Réseaux sociaux : conseils pour de nouveaux acheteurs

2019-05-30 Thread Guide du Social Selling
social media ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH]ovs:conntrack: ignore port for icmp/icmpv6 protocol

2019-05-30 Thread solomon
conntrack will not work for icmp/icmpv6 protocol, if the src/dst port is set in nat. like this: actions=ct(nat(dst=172.16.1.100:5000),commit,table=40) This patch fix this. This bug is introduced by commit 4cd0481c9e. commit 4cd0481c9e8b30bca5c0394f4e94ae126bde4908 Author: Darrell Ball Date:

[ovs-dev] [PATCH] netdev-dpdk: ensure that qid is valid before using it

2019-05-30 Thread Li RongQing
otherwise it maybe lead to out of bound access in tx_q Signed-off-by: Li RongQing --- lib/netdev-dpdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index c06f46931..e6cdcd454 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: add af_xdp support.

2019-05-30 Thread Ilya Maximets
On 29.05.2019 20:57, William Tu wrote: > On Wed, May 29, 2019 at 10:51 AM William Tu wrote: >> >> Hi Ilya, >> >> Thanks for your feedback. >> >> On Wed, May 29, 2019 at 6:15 AM Ilya Maximets wrote: >>> >>> On 28.05.2019 23:12, William Tu wrote: The patch adds support for using DPDK's AF_XDP

Re: [ovs-dev] [PATCH] netdev-dpdk: Print the reason of device detaching failure.

2019-05-30 Thread Stokes, Ian
> Useful for debugging. > > Signed-off-by: Ilya Maximets > --- > lib/netdev-dpdk.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index cc15df65c..4856c56aa 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@

[ovs-dev] [PATCH] netdev-dpdk: Print the reason of device detaching failure.

2019-05-30 Thread Ilya Maximets
Useful for debugging. Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index cc15df65c..4856c56aa 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1394,8 +1394,11 @@

[ovs-dev] Mejora o realiza FOTOS profesionales de tus PRODUCTOS

2019-05-30 Thread Estudio Lux
( http://www.fotoestudiolux.com.ar )   ¿ Esta pensando en mejorar o realizar FOTOS de sus PRODUCTOS, SERVICIOS y/o INSTITUCIONALES ?     Realizamos producciones fotograficas en Estudio o en su domicilio para su uso en Catalogos, Folletos, Paginas Web, Gigantografias, etc .

[ovs-dev] [patch v1] conntrack: Add option to enable TCP liberal mode.

2019-05-30 Thread Darrell Ball
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359188.html Signed-off-by: Darrell Ball --- NEWS| 1 + lib/conntrack-private.h | 6 ++- lib/conntrack-tcp.c | 30 ++- lib/conntrack.c | 15 ++ lib/conntrack.h | 2 +