[ovs-dev] Request for soft freeze exceptions for the below OVN patches.

2019-07-08 Thread Numan Siddique
Hi, It would be great if the below OVN patches are considered during the soft freeze window - ovn: Add a new logical switch port type - 'virtual' - https://patchwork.ozlabs.org/patch/1128402/ - ovn-northd: Add the option to pause and resume - https://patchwork.ozlabs.org/patch/1129510/ Thanks

Re: [ovs-dev] [PATCH v2] ovn-northd: Add the option to pause and resume

2019-07-08 Thread Numan Siddique
On Mon, Jul 8, 2019 at 11:22 PM Mark Michelson wrote: > Hi Numan, > > The code changes all look good, but there are a few problems with the > documentation. I've noted them down below. > > Oops. Lots of typos and mistakes. Thanks for the review. I corrected them and submitted v3. Thanks Numan

[ovs-dev] [PATCH v3] ovn-northd: Add the option to pause and resume

2019-07-08 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and use

Re: [ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-08 Thread Gregory Rose
On 7/8/2019 4:18 PM, Gregory Rose wrote: On 7/8/2019 4:08 PM, David Miller wrote: From: Taehee Yoo Date: Sat,  6 Jul 2019 01:08:09 +0900 When a vport is deleted, the maximum headroom size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be

Re: [ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-08 Thread Gregory Rose
On 7/8/2019 4:08 PM, David Miller wrote: From: Taehee Yoo Date: Sat, 6 Jul 2019 01:08:09 +0900 When a vport is deleted, the maximum headroom size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be set. But, if the new headroom size is equal

Re: [ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-08 Thread David Miller
From: Taehee Yoo Date: Sat, 6 Jul 2019 01:08:09 +0900 > When a vport is deleted, the maximum headroom size would be changed. > If the vport which has the largest headroom is deleted, > the new max_headroom would be set. > But, if the new headroom size is equal to the old headroom size, > updatin

Re: [ovs-dev] [PATCH net-next] net: openvswitch: use netif_ovs_is_port() instead of opencode

2019-07-08 Thread David Miller
From: Taehee Yoo Date: Sat, 6 Jul 2019 01:05:46 +0900 > Use netif_ovs_is_port() function instead of open code. > This patch doesn't change logic. > > Signed-off-by: Taehee Yoo Applied. ___ dev mailing list d...@openvswitch.org https://mail.openvswit

Re: [ovs-dev] [PATCH v4 0/3] vhost tx retry updates

2019-07-08 Thread Kevin Traynor
On 08/07/2019 13:45, Ian Stokes wrote: > On 7/2/2019 1:32 AM, Kevin Traynor wrote: >> v4: >> - 1/2 New patch: Move vhost tx retries doc to a seperate section (David) >> >> - 2/3 >> -- Changed tx_retries to be a custom stat for vhost (Ilya) >> -- Added back in MIN() that was dropped in v2, as in ret

Re: [ovs-dev] [PATCH] ofproto: Preserve ofport number for failed ofport across restarts

2019-07-08 Thread Ben Pfaff
On Thu, Jun 13, 2019 at 08:28:02AM +, Vishal Deep Ajmera wrote: > > > > > This patch fixes both the above issue by retaining the ofport number till > > ofport > > entry exists in the OVSDB. > > > > Warm Regards, > > Vishal Ajmera > > Hi Ben, > > Did you get a chance to review this patch ?

Re: [ovs-dev] [patch v5] conntrack: Optimize recirculations.

2019-07-08 Thread Ben Pfaff
On Sun, Jun 09, 2019 at 07:32:03AM -0700, Darrell Ball wrote: > Cache the 'conn' context and use it when it is valid. The cached 'conn' > context will get reset if it is not expected to be valid; a negative test > is added to check this. > > Signed-off-by: Darrell Ball > --- > > v5: Check for a

Re: [ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-08 Thread William Tu
On Mon, Jul 8, 2019 at 1:50 PM William Tu wrote: > > Hi Ilya, > > Thanks for all the feedback! > > On Fri, Jul 5, 2019 at 8:32 AM Ilya Maximets wrote: > > > > On 01.07.2019 19:08, William Tu wrote: > > > The patch introduces experimental AF_XDP support for OVS netdev. > > > AF_XDP, the Address Fa

Re: [ovs-dev] [PATCH v3] OVN: run local logical flows first in S_ROUTER_OUT_SNAT table

2019-07-08 Thread Ben Pfaff
On Sat, Jul 06, 2019 at 12:45:00PM +0200, Lorenzo Bianconi wrote: > Run local logical flows first if the gw router port is scheduled > on the local chassis in order to properly manage snat traffic > > Tested-by: Eran Kuris > Acked-by: Numan Siddique > Signed-off-by: Lorenzo Bianconi > --- > Cha

Re: [ovs-dev] [PATCH v2] rhel: Fixed a bug for checking the correct major version and revision.

2019-07-08 Thread Ben Pfaff
On Mon, Jul 08, 2019 at 09:51:29AM -0700, Ashish Varma wrote: > Fixed a bug where checking for major version 3.10 and major revision not > equal to 327 or 693 or 957 should have gone to the default else at the end. > In the current code, the default else condition will not get executed > for kernel

Re: [ovs-dev] [PATCH v2 0/3] ovn-controller: Fix and refactor chassis ovn-sbdb record init

2019-07-08 Thread Ben Pfaff
On Mon, Jul 08, 2019 at 12:06:45PM +0200, Dumitru Ceara wrote: > The chassis_run code didn't take into account the scenario when the > system-id was changed in the Open_vSwitch table. Due to this the code > was trying to insert a new Chassis record in the OVN_Southbound DB with > the same Encaps as

Re: [ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-08 Thread William Tu
On Fri, Jul 5, 2019 at 10:48 AM Ilya Maximets wrote: > > Few more comments inline. > > On 01.07.2019 19:08, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type built upon the

Re: [ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-08 Thread William Tu
Hi Ilya, Thanks for all the feedback! On Fri, Jul 5, 2019 at 8:32 AM Ilya Maximets wrote: > > On 01.07.2019 19:08, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type built

[ovs-dev] Evolution de carrière

2019-07-08 Thread Les étapes clefs
Les Guides Du Digital Guide Bilan de competences Vous souhaitez faire le point sur vos competences pour envisager une evolution de carriere ? Vous lancer dans ce processus de reflexion personnelle et professionnelle demande une certaine preparation. Notre guide de 22 pages vous eclaire sur toutes

Re: [ovs-dev] [PATCH v3] OVN: run local logical flows first in S_ROUTER_OUT_SNAT table

2019-07-08 Thread Mark Michelson
Acked-by: Mark Michelson On 7/6/19 6:45 AM, Lorenzo Bianconi wrote: Run local logical flows first if the gw router port is scheduled on the local chassis in order to properly manage snat traffic Tested-by: Eran Kuris Acked-by: Numan Siddique Signed-off-by: Lorenzo Bianconi --- Changes since

Re: [ovs-dev] [PATCH v2] ovn-northd: Add the option to pause and resume

2019-07-08 Thread Mark Michelson
Hi Numan, The code changes all look good, but there are a few problems with the documentation. I've noted them down below. On 7/8/19 11:41 AM, nusid...@redhat.com wrote: From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-n

[ovs-dev] [PATCH v2] rhel: Fixed a bug for checking the correct major version and revision.

2019-07-08 Thread Ashish Varma
Fixed a bug where checking for major version 3.10 and major revision not equal to 327 or 693 or 957 should have gone to the default else at the end. In the current code, the default else condition will not get executed for kernel with major version 3.10 and major revision not equal to 327/693/957 r

[ovs-dev] [PATCH v2] ovn-northd: Add the option to pause and resume

2019-07-08 Thread nusiddiq
From: Numan Siddique This patch adds 3 unixctl socket comments - pause, resume and is-paused. Usage: ovs-appctl -t ovn-northd pause/resume/is-paused This feature will be useful if the CMS wants to - deploy OVN DB servers in active/passive mode and - run ovn-northd on all these nodes and use

[ovs-dev] "soft freeze" now in effect for master branch

2019-07-08 Thread Ben Pfaff
Hi. As described in Documentation/internals/release-process.rst, we are in a "soft freeze" of the master branch: During the freeze, we ask committers to refrain from applying patches that add new features unless those patches were already being publicly discussed and reviewed before the

Re: [ovs-dev] [PATCH v3 2/5] dpif-netdev: Trigger parallel pmd reloads.

2019-07-08 Thread Ilya Maximets
On 08.07.2019 17:55, Ilya Maximets wrote: > On 04.07.2019 14:59, David Marchand wrote: >> pmd reloads are currently serialised in each steps calling >> reload_affected_pmds. >> Any pmd processing packets, waiting on a mutex etc... will make other >> pmd threads wait for a delay that can be undeterm

Re: [ovs-dev] [PATCH v3 2/5] dpif-netdev: Trigger parallel pmd reloads.

2019-07-08 Thread Ilya Maximets
On 04.07.2019 14:59, David Marchand wrote: > pmd reloads are currently serialised in each steps calling > reload_affected_pmds. > Any pmd processing packets, waiting on a mutex etc... will make other > pmd threads wait for a delay that can be undeterministic when syscalls > adds up. > > Switch to

Re: [ovs-dev] [PATCH] netdev-dpdk: Add a statistic on vhost tx contention.

2019-07-08 Thread Ilya Maximets
On 07.07.2019 19:13, David Marchand wrote: > Add a statistic to help diagnose contention on the vhost txqs. > This is usually seen as dropped packets on the physical ports for rates > that are usually handled fine by OVS. > > Signed-off-by: David Marchand > --- > This patch applies on top of Kevi

Re: [ovs-dev] [PATCH] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

2019-07-08 Thread Flavio Leitner via dev
On Tue, Jul 02, 2019 at 08:50:16PM -0400, Vasu Dasari wrote: > Hi Flavio, > > I am trying to emulate the test case scenario you mentioned earlier, where > in we need to clean you neighbor cache when an external interface goes > down. To study that, I wrote a small script based off of test case > s

Re: [ovs-dev] [PATCH v2] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-07-08 Thread Ilya Maximets
On 25.06.2019 12:28, Vishal Deep Ajmera wrote: > Problem: > > In OVS-DPDK, flows with output over a bond interface of type "balance-tcp" > (using a hash on TCP/UDP 5-tuple) get translated by the ofproto layer into > "HASH" and "RECIRC" datapath actions. After recirculation, the packet is >

Re: [ovs-dev] [PATCH v4 0/3] vhost tx retry updates

2019-07-08 Thread Ian Stokes
On 7/2/2019 1:32 AM, Kevin Traynor wrote: v4: - 1/2 New patch: Move vhost tx retries doc to a seperate section (David) - 2/3 -- Changed tx_retries to be a custom stat for vhost (Ilya) -- Added back in MIN() that was dropped in v2, as in retesting I saw it is needed when the retry limit is re

Re: [ovs-dev] [PATCH] netdev-dpdk: Add a statistic on vhost tx contention.

2019-07-08 Thread David Marchand
On Mon, Jul 8, 2019 at 1:41 PM Eelco Chaudron wrote: > > > On 7 Jul 2019, at 18:13, David Marchand wrote: > > > Add a statistic to help diagnose contention on the vhost txqs. > > This is usually seen as dropped packets on the physical ports for > > rates > > that are usually handled fine by OVS.

Re: [ovs-dev] [PATCH] netdev-dpdk: Add a statistic on vhost tx contention.

2019-07-08 Thread Eelco Chaudron
On 7 Jul 2019, at 18:13, David Marchand wrote: Add a statistic to help diagnose contention on the vhost txqs. This is usually seen as dropped packets on the physical ports for rates that are usually handled fine by OVS. Signed-off-by: David Marchand --- This patch applies on top of Kevin "

Re: [ovs-dev] [PATCH 0/3] ovn-controller: Fix and refactor chassis ovn-sbdb record init

2019-07-08 Thread Dumitru Ceara
On Fri, Jul 5, 2019 at 11:46 PM Ben Pfaff wrote: > > On Wed, Jun 12, 2019 at 12:37:57PM +0200, Dumitru Ceara wrote: > > The chassis_run code didn't take into account the scenario when the > > system-id was changed in the Open_vSwitch table. Due to this the code > > was trying to insert a new Chass

[ovs-dev] [PATCH v2 3/3] ovn-controller: Update stale chassis entry at init

2019-07-08 Thread Dumitru Ceara
The first time ovn-controller initializes the Chassis entry (shortly after start up) we first look if there is a stale Chassis record in the OVN_Southbound DB by checking if any of the old Encap entries associated to the Chassis record match the new tunnel configuration. If found it means that ovn-

[ovs-dev] [PATCH v2 2/3] ovn-controller: Refactor chassis.c to abstract the string parsing

2019-07-08 Thread Dumitru Ceara
Abstract out the chassis config string processing and use library data structures (e.g., sset). Rename the get_chassis_id function in ovn-controller.c to get_ovs_chassis_id to avoid confusion with the newly added chassis_get_id function from chassis.c which returns the last successfully configured

[ovs-dev] [PATCH v2 1/3] ovn-controller: Fix chassis ovn-sbdb record init

2019-07-08 Thread Dumitru Ceara
The chassis_run code didn't take into account the scenario when the system-id was changed in the Open_vSwitch table. Due to this the code was trying to insert a new Chassis record in the OVN_Southbound DB with the same Encaps as the previous Chassis record. The transaction used to insert the new re

[ovs-dev] [PATCH v2 0/3] ovn-controller: Fix and refactor chassis ovn-sbdb record init

2019-07-08 Thread Dumitru Ceara
The chassis_run code didn't take into account the scenario when the system-id was changed in the Open_vSwitch table. Due to this the code was trying to insert a new Chassis record in the OVN_Southbound DB with the same Encaps as the previous Chassis record. The transaction used to insert the new re

Re: [ovs-dev] [PATCH v3 0/5] Quicker pmd threads reloads

2019-07-08 Thread Eelco Chaudron
Reviewed the patchset, and the changes look fine to me. Ack for the series… Acked-by: Eelco Chaudron On 4 Jul 2019, at 13:59, David Marchand wrote: We have been testing the rebalance code in different situations while having traffic going through OVS. Those tests have shown that part of the