[ovs-dev] 答复: 答复: 答复: [ovs-discuss] How can I delete flows which match a given cookie value?

2019-07-18 Thread 杨燚
Cookie is enough, I just think two field matches can avoid false del-flows. -邮件原件- 发件人: Ben Pfaff [mailto:b...@ovn.org] 发送时间: 2019年7月18日 11:34 收件人: Yi Yang (杨燚)-云服务集团 抄送: ovs-disc...@openvswitch.org; ovs-dev@openvswitch.org 主题: Re: 答复: 答复: [ovs-discuss] How can I delete flows which match

Re: [ovs-dev] [PATCH v7] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread Numan Siddique
On Thu, Jul 18, 2019 at 2:47 AM Guru Shetty wrote: > > > On Tue, 16 Jul 2019 at 17:48, wrote: > >> From: Numan Siddique >> >> This new type is added for the following reasons: >> >> - When a load balancer is created in an OpenStack deployment with >> Octavia >> service, it creates a logic

[ovs-dev] [PATCH v8] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a servi

Re: [ovs-dev] [PATCH v8] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Co-author Ben Pfaff needs to sign off. WARNING: Line is 236 characters long (recommen

Re: [ovs-dev] [PATCHv16 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-18 Thread Ilya Maximets
On 17.07.2019 21:52, William Tu wrote: > On Wed, Jul 17, 2019 at 9:56 AM Ben Pfaff wrote: >> >> On Fri, Jul 12, 2019 at 04:50:56PM -0700, William Tu wrote: >>> The patch introduces experimental AF_XDP support for OVS netdev. >>> AF_XDP, the Address Family of the eXpress Data Path, is a new Linux s

Re: [ovs-dev] [PATCH v12 0/5] dpcls func ptrs & optimizations

2019-07-18 Thread Ilya Maximets
On 17.07.2019 19:33, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Wednesday, July 17, 2019 5:26 PM >> To: Van Haaren, Harry ; d...@openvswitch.org >> Cc: echau...@redhat.com; malvika.gu...@arm.com; Stokes, Ian >> >> Subject:

Re: [ovs-dev] [PATCH v13 4/5] dpif-netdev: Refactor generic implementation

2019-07-18 Thread Ilya Maximets
On 17.07.2019 21:21, Harry van Haaren wrote: > This commit refactors the generic implementation. The > goal of this refactor is to simplify the code to enable > "specialization" of the functions at compile time. > > Given compile-time optimizations, the compiler is able > to unroll loops, and crea

Re: [ovs-dev] [PATCH v2] doc: Remove experimental tag for SMC cache.

2019-07-18 Thread Ilya Maximets
On 17.07.2019 23:25, Ian Stokes wrote: > On 7/17/2019 12:38 PM, Yipeng Wang wrote: >> SMC cache was introduced in 2.10 with experimental tag. >> SMC cache is a layer of software cache located after EMC >> cache. The purpose is to improve the performance of use >> cases that many flows missing the E

Re: [ovs-dev] [PATCHv16 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-18 Thread Ilya Maximets
On 17.07.2019 19:22, Ben Pfaff wrote: > On Wed, Jul 17, 2019 at 06:41:48PM +0300, Ilya Maximets wrote: >> This patch-set has a long history and the latest versions are in a good >> shape. >> netdev-afxdp works stable for me over the virtual interfaces and passes all >> the >> system tests that it

Re: [ovs-dev] [PATCH v13 4/5] dpif-netdev: Refactor generic implementation

2019-07-18 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Thursday, July 18, 2019 12:34 PM > To: Van Haaren, Harry ; d...@openvswitch.org > Cc: echau...@redhat.com; malvika.gu...@arm.com; Stokes, Ian > > Subject: Re: [PATCH v13 4/5] dpif-netdev: Refactor generic im

Re: [ovs-dev] [PATCH v13 4/5] dpif-netdev: Refactor generic implementation

2019-07-18 Thread Ilya Maximets
On 18.07.2019 15:32, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Thursday, July 18, 2019 12:34 PM >> To: Van Haaren, Harry ; d...@openvswitch.org >> Cc: echau...@redhat.com; malvika.gu...@arm.com; Stokes, Ian >> >> Subject:

Re: [ovs-dev] [PATCH v2] doc: Remove experimental tag for SMC cache.

2019-07-18 Thread Ian Stokes
On 7/18/2019 12:56 PM, Ilya Maximets wrote: On 17.07.2019 23:25, Ian Stokes wrote: On 7/17/2019 12:38 PM, Yipeng Wang wrote: SMC cache was introduced in 2.10 with experimental tag. SMC cache is a layer of software cache located after EMC cache. The purpose is to improve the performance of use c

[ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-18 Thread Harry van Haaren
Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on the ML since then. I'm aware of the soft-freeze for 2.12, I feel this patchset has had enough reviews/versions/testing to be merged in 2.12. Thanks Ilya for input and sugge

[ovs-dev] [PATCH v14 1/5] dpif-netdev: Implement function pointers/subtable

2019-07-18 Thread Harry van Haaren
This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van Haaren Tested-by: Malvika Gupta --- v11: - Rebased to latest master - Added spac

[ovs-dev] [PATCH v14 2/5] dpif-netdev: Move dpcls lookup structures to .h

2019-07-18 Thread Harry van Haaren
This commit moves some data-structures to be available in the dpif-netdev-private.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c Signed-off-by: Harry van Haaren Tested-by: Malvi

[ovs-dev] [PATCH v14 3/5] dpif-netdev: Split out generic lookup function

2019-07-18 Thread Harry van Haaren
This commit splits the generic hash-lookup-verify function to its own file, for cleaner seperation between optimized versions. Signed-off-by: Harry van Haaren Tested-by: Malvika Gupta --- v12: - Fix indentation around "keep sparse happy" comment (Ilya) v11: - Rebase fixups from previous patch

[ovs-dev] [PATCH v14 5/5] dpif-netdev: Add specialized generic scalar functions

2019-07-18 Thread Harry van Haaren
This commit adds a number of specialized functions, that handle common miniflow fingerprints. This enables compiler optimization, resulting in higher performance. Below a quick description of how this optimization actually works; "Specialized functions" are "instances" of the generic implementatio

[ovs-dev] [PATCH v14 4/5] dpif-netdev: Refactor generic implementation

2019-07-18 Thread Harry van Haaren
This commit refactors the generic implementation. The goal of this refactor is to simplify the code to enable "specialization" of the functions at compile time. Given compile-time optimizations, the compiler is able to unroll loops, and create optimized code sequences due to compile time knowledge

Re: [ovs-dev] [PATCH] system-traffic.at: Make nsh test more robust.

2019-07-18 Thread Ilya Maximets
On 18.07.2019 0:21, William Tu wrote: > The patch adds '-n' to tcpdump to avoid address coverting. Since '-U' is > used to output to stdout, simply use 'cat' to search result. > Use OVS_WAIT_UNTIL instead of sleep ,and also remove/add some newlines. Thanks for working on this! There are few more i

Re: [ovs-dev] [PATCH v14 2/5] dpif-netdev: Move dpcls lookup structures to .h

2019-07-18 Thread 0-day Robot
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #129 FILE: lib/dpif-netdev-private.h:91: #d

Re: [ovs-dev] [PATCH v14 5/5] dpif-netdev: Add specialized generic scalar functions

2019-07-18 Thread 0-day Robot
Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 dpif-netdev: Add specialized generic scala

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-18 Thread Ian Stokes
On 7/18/2019 2:03 PM, Harry van Haaren wrote: Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on the ML since then. I'm aware of the soft-freeze for 2.12, I feel this patchset has had enough reviews/versions/testing to be

[ovs-dev] [PATCH v9] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a servi

Re: [ovs-dev] [PATCH] ovsdb-idl: Mark row "parsed" in ovsdb_idl_txn_write__

2019-07-18 Thread Ben Pfaff
On Wed, Jul 17, 2019 at 09:05:04PM +0200, Dumitru Ceara wrote: > Once a column is set in a row using ovsdb_idl_txn_write__ we also mark > the row "parsed". Otherwise the memory allocated by > sbrec__parse_() will never be freed. After marking the row > "parsed", the ovsdb_idl_txn_disassemble functi

Re: [ovs-dev] [PATCH v9] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Co-author Ben Pfaff needs to sign off. WARNING: Line is 236 characters long (recommen

Re: [ovs-dev] [PATCHv17 1/2] ovs-thread: Add pthread spin lock support.

2019-07-18 Thread Ilya Maximets
On 17.07.2019 23:23, William Tu wrote: > The patch adds the basic spin lock functions: > ovs_spin_{lock, try_lock, unlock, init, destroy}. > OSX does not support pthread spin lock, so make it > linux only. The last sentence seems redundant now and could be removed. The patch looks good to me. One

Re: [ovs-dev] [PATCHv17 1/2] ovs-thread: Add pthread spin lock support.

2019-07-18 Thread William Tu
On Thu, Jul 18, 2019 at 9:38 AM Ilya Maximets wrote: > > On 17.07.2019 23:23, William Tu wrote: > > The patch adds the basic spin lock functions: > > ovs_spin_{lock, try_lock, unlock, init, destroy}. > > OSX does not support pthread spin lock, so make it > > linux only. > > The last sentence seems

Re: [ovs-dev] [PATCH] ovsdb-idl: Mark row "parsed" in ovsdb_idl_txn_write__

2019-07-18 Thread Damijan Skvarc
Hmm, the problem of "parsed" flag is that it identifies "all" columns of certain row have been parsed, however there are CLI tools which modify only individual colums by calling ovsdb_idl_txn_write_() function. In this case and in case parsed flag would be set in ovsdb_idl_txn_write() function then

Re: [ovs-dev] Update on DDlog port of ovn-northd

2019-07-18 Thread Mark Michelson
Hi, just wanted to send a follow-up and a test result. I got everything up and running (yay!). So I set up a server and ran a sandbox test using ovn with traditional C-based ovn-northd and then ran the same test using ovn with DDlog-based ovn-northd. The test script can be found here: https:

Re: [ovs-dev] [PATCHv17 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-18 Thread Ilya Maximets
On 17.07.2019 23:23, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to DPDK but cooperate be

Re: [ovs-dev] [PATCH v9] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread Guru Shetty
On Thu, 18 Jul 2019 at 07:58, wrote: > From: Numan Siddique > > This new type is added for the following reasons: > > - When a load balancer is created in an OpenStack deployment with Octavia > service, it creates a logical port 'VIP' for the virtual ip. > > - This logical port is not bo

Re: [ovs-dev] [PATCHv17 1/2] ovs-thread: Add pthread spin lock support.

2019-07-18 Thread Ben Pfaff
On Wed, Jul 17, 2019 at 01:23:33PM -0700, William Tu wrote: > --- a/include/openvswitch/thread.h > +++ b/include/openvswitch/thread.h > @@ -17,6 +17,8 @@ > #ifndef OPENVSWITCH_THREAD_H > #define OPENVSWITCH_THREAD_H 1 > > +#include That shouldn't be there. Every .c file should already have #

Re: [ovs-dev] [PATCHv17 1/2] ovs-thread: Add pthread spin lock support.

2019-07-18 Thread Ben Pfaff
On Thu, Jul 18, 2019 at 07:38:03PM +0300, Ilya Maximets wrote: > On 17.07.2019 23:23, William Tu wrote: > > The patch adds the basic spin lock functions: > > ovs_spin_{lock, try_lock, unlock, init, destroy}. > > OSX does not support pthread spin lock, so make it > > linux only. > > The last senten

Re: [ovs-dev] [PATCH] ovsdb-idl: Mark row "parsed" in ovsdb_idl_txn_write__

2019-07-18 Thread Ben Pfaff
I guess I missed it. Will you please point it out to me, for example in the list archive? On Thu, Jul 18, 2019 at 06:58:34PM +0200, Damijan Skvarc wrote: > Hmm, the problem of "parsed" flag is that it identifies "all" columns of > certain row have been parsed, however there are CLI tools which mo

Re: [ovs-dev] [PATCH] ovsdb-idl: Mark row "parsed" in ovsdb_idl_txn_write__

2019-07-18 Thread Ben Pfaff
On Thu, Jul 18, 2019 at 08:52:13AM -0700, Ben Pfaff wrote: > On Wed, Jul 17, 2019 at 09:05:04PM +0200, Dumitru Ceara wrote: > > Once a column is set in a row using ovsdb_idl_txn_write__ we also mark > > the row "parsed". Otherwise the memory allocated by > > sbrec__parse_() will never be freed. Aft

Re: [ovs-dev] [PATCHv17 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-18 Thread Ben Pfaff
On Wed, Jul 17, 2019 at 01:23:34PM -0700, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to

Re: [ovs-dev] [PATCHv17 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-18 Thread William Tu
On Thu, Jul 18, 2019 at 10:19 AM Ilya Maximets wrote: > > On 17.07.2019 23:23, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type built upon the eBPF and XDP technology. It

Re: [ovs-dev] [PATCHv17 1/2] ovs-thread: Add pthread spin lock support.

2019-07-18 Thread William Tu
On Thu, Jul 18, 2019 at 11:08 AM Ben Pfaff wrote: > > On Thu, Jul 18, 2019 at 07:38:03PM +0300, Ilya Maximets wrote: > > On 17.07.2019 23:23, William Tu wrote: > > > The patch adds the basic spin lock functions: > > > ovs_spin_{lock, try_lock, unlock, init, destroy}. > > > OSX does not support pth

Re: [ovs-dev] [PATCH v9] ovn: Add a new logical switch port type - 'virtual'

2019-07-18 Thread Numan Siddique
On Thu, Jul 18, 2019 at 11:20 PM Guru Shetty wrote: > > > On Thu, 18 Jul 2019 at 07:58, wrote: > >> From: Numan Siddique >> >> This new type is added for the following reasons: >> >> - When a load balancer is created in an OpenStack deployment with >> Octavia >> service, it creates a logi

[ovs-dev] [PATCH v2] userspace: Enable non-bridge port as tunnel endpoint.

2019-07-18 Thread Yifeng Sun
For userspace datapath, currently only the bridge itself, the LOCAL port, can be the tunnel endpoint to encap/decap tunnel packets. This patch enables non-bridge port as tunnel endpoint. One use case is for users to create a bridge and a vtep port as tap, and configure underlay IP at vtep port as

[ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-18 Thread William Tu
The patch introduces experimental AF_XDP support for OVS netdev. AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket type built upon the eBPF and XDP technology. It is aims to have comparable performance to DPDK but cooperate better with existing kernel's networking stack.

Re: [ovs-dev] Update on DDlog port of ovn-northd

2019-07-18 Thread Mark Michelson
I've now performed tests where I measured the wall clock time of each iteration through the test. I've created a plot of the C vs. the DDlog ovn-northd here: https://i.imgur.com/bIsbeMN.png This confirms for me that the DDlog implementation does a better job of staying consistent in its execut

[ovs-dev] Лучшие психологические тренинги и медитации в одной коллекции. 13_05_2019 02_03 198707

2019-07-18 Thread Роман Колунов via dev
ЛУЧШИЕ ПСИХОЛОГИЧЕСКИЕ ТРЕНИНГИ И МЕДИТАЦИИ Вы включаете и слышите прекрасную музыку, звуки живой природы и спокойный голос, обращенный к вам. Постепенно вы погружаетесь в состояние приятного душевного и физического комфорта. И незаметно для вас в вашем подсознании начинается внутренняя работа.

Re: [ovs-dev] [PATCH RFC v2 0/8] Introduce connection tracking tc offload

2019-07-18 Thread Marcelo Ricardo Leitner
On Thu, Jul 04, 2019 at 05:28:19PM +0300, Paul Blakey wrote: > Hi, > > The following patches add connection tracking offload to tc. > > We plan on offloading the datapath rules to netdev one to one to tc rules. > We'll be using upcoming act_ct tc module which is currently under review in > netde

[ovs-dev] Jeg har dårlige nyheter for deg.

2019-07-18 Thread Anonymous
Jeg hilser deg! Jeg har dårlige nyheter for deg. 27/04/2019 - På denne dagen hacket jeg operativsystemet ditt og fikk full tilgang til kontoen din. Hvordan det var: I programvaren til ruteren som du var tilkoblet den dagen, var det et sikkerhetsproblem. Jeg hakkede først denne ruteren og plasse

[ovs-dev] [PATCH] datapath: Print friendly error message when conntrack fails to init

2019-07-18 Thread Yifeng Sun
On 4.14 kernels, if kernel isn't configured with CONFIG_NF_CONNTRACK_IPV4 and CONFIG_NF_CONNTRACK_IPV6, openvswitch module will fail to load. The error message is "openvswitch: failed to init nf_conncount -91". This patch prints helpful error message for this case. Signed-off-by: Yifeng Sun ---

Re: [ovs-dev] [PATCH] ovsdb-idl: Mark row "parsed" in ovsdb_idl_txn_write__

2019-07-18 Thread Damijan Skvarc
https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360285.htmlhttps://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360285.html On Thu, 18 Jul 2019, 20:12 Ben Pfaff, wrote: > I guess I missed it. Will you please point it out to me, for example in > the list archive? > > On Thu, Jul 18,

[ovs-dev] [PATCH] ofproto-dpif: Fix for recirc issue with mpls traffic with dp_hash

2019-07-18 Thread Surya Rudra via dev
Fix infinite recirculation loop for MPLS packets sent to dp_hash-based select group Issue: When a MPLS encapsulated packet is received, the MPLS header is removed, a recirculation id assigned and then recirculated into the pipeline. If the flow rules require the packet to be then sent over DP-HAS

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

2019-07-18 Thread Ian Stokes
On 7/18/2019 3:30 PM, Ian Stokes wrote: On 7/18/2019 2:03 PM, Harry van Haaren wrote: Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on the ML since then. I'm aware of the soft-freeze for 2.12, I feel this patchset has h