> Comments for v2 wasn't addressed and still valid:
> https://protect2.fireeye.com/url?k=c85828c4-94d1f2d4-c858685f-
> 0cc47ad93e2a-
> cd974aa1a210bc2b=1=https%3A%2F%2Fmail.openvswitch.org%2Fpiperma
> il%2Fovs-dev%2F2019-July%2F360452.html
Patch-set v5 set for review. It now includes
syzbot found the following crash on:
HEAD commit:1e78030e Merge tag 'mmc-v5.3-rc1' of git://git.kernel.org/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=148d3d1a60
kernel config: https://syzkaller.appspot.com/x/.config?x=30cef20daf3e9977
Hi Numan,
Thanks a lot for the review. Please find my comments inline.
V4 will accommodate changes for review comments.
Regards,
Ankur
From: Numan Siddique
Sent: Thursday, August 8, 2019 12:13 AM
To: Ankur Sharma
Cc: ovs-dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3 3/4 ovn] OVN: Vlan
On Wed, Aug 07, 2019 at 01:32:40PM -0700, Pravin Shelar wrote:
> On Tue, Aug 6, 2019 at 5:00 AM Hillf Danton wrote:
> >
> >
> > On Tue, 06 Aug 2019 01:58:05 -0700
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
>
> ...
> > > BUG: memory leak
> > > unreferenced object
On Thu, Aug 8, 2019 at 8:23 AM Ilya Maximets wrote:
>
> On 08.08.2019 16:27, Eelco Chaudron wrote:
> > If for some reason the last element in the batch was already pushed on
> > the stack, none of the elements where pushed. This was leading to
> > buffer starvation.
> >
> > Signed-off-by: Eelco
When using dynamic address assignment for logical switches, OVN reserves
the first address in the subnet for the attached router port to use.
In commit 488d153ee87841c042af05bc0eb8b5481aaa98cf, the IPAM code was
modified to add assigned router port addresses to IPAM. The use case for
this was
On Thu, Aug 8, 2019 at 1:00 PM 0-day Robot wrote:
>
> Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out
your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> fatal: sha1 information is
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: sha1 information is lacking or useless (northd/ovn-northd.c).
Repository lacks necessary
When using dynamic address assignment for logical switches, OVN reserves
the first address in the subnet for the attached router port to use.
In commit 488d153ee87841c042af05bc0eb8b5481aaa98cf, the IPAM code was
modified to add assigned router port addresses to IPAM. The use case for
this was
On Thu, Aug 8, 2019 at 10:48 PM Han Zhou wrote:
>
>
> On Thu, Aug 8, 2019 at 5:58 AM wrote:
> >
> > From: Numan Siddique
> >
> > This was left out during the OVS/OVN split.
> >
> > We still need to handle the below in the automake files
> > - OVN northbound/southbound E-R diagram
> > - OVN
On Thu, Aug 8, 2019 at 5:58 AM wrote:
>
> From: Numan Siddique
>
> This was left out during the OVS/OVN split.
>
> We still need to handle the below in the automake files
> - OVN northbound/southbound E-R diagram
> - OVN northbound/southbound schema documentation
> - ovn-architecture manpage
Thanks. I merged this into branch-2.12.
--Justin
> On Aug 6, 2019, at 4:04 AM, nusid...@redhat.com wrote:
>
> From: Damijan Skvarc
>
> Memory leak happens because of redundand memory allocation for array
> of single pointer. Issue was solved by removing this redundand allocation
> and using
Thanks. I merged this into branch-2.12.
--Justin
> On Aug 5, 2019, at 11:54 PM, nusid...@redhat.com wrote:
>
> From: Numan Siddique
>
> The commit [1] encoded the vport key using uint32_t and the test case
> "action parsing" is failing for s380 arch.
>
> This patch fixes this issue by
Thanks. I added a reference to the OVN repo commit and merged this into
branch-2.12.
--Justin
> On Aug 6, 2019, at 7:35 AM, Lorenzo Bianconi
> wrote:
>
> If no protcol is specified defining a load balancing rule TCP is
> selected as default but ovn-nbctl lb-list reports 'tcp/udp' in this
>
Thanks. I added a reference to the OVN repo commit and merged this into
branch-2.12.
--Justin
> On Aug 8, 2019, at 1:25 AM, Damijan Skvarc wrote:
>
> Within this function actions & match dynamic strings are used as helper
> variables for adding entries into logical flow table. Variables are
Thanks. I added a reference to the OVN repo commit and merged this into
branch-2.12.
--Justin
> On Aug 5, 2019, at 9:10 AM, Han Zhou wrote:
>
> From: Han Zhou
>
> From: Han Zhou
>
> When using unixctl command inject-packet, it always respond with
> failure "server not ready", although
Thanks. I added a reference to the OVN repo commit and merged this into
branch-2.12.
--Justin
> On Aug 5, 2019, at 8:50 AM, Han Zhou wrote:
>
> From: Dumitru Ceara
>
> When trying to incrementally process changes even if there are in-flight
> messages we were incorrectly setting the
Thanks. I added a reference to the OVN repo commit and merged this into
branch-2.12.
--Justin
> On Aug 5, 2019, at 8:50 AM, Han Zhou wrote:
>
> From: Han Zhou
>
> When there are in-flight flow-installations pending to ovs-vswitchd,
> current incremental processing logic prioritizes new
Thanks. I added a reference to the OVN repo commit and merged this into
branch-2.12.
--Justin
> On Aug 5, 2019, at 8:52 AM, Daniel Alvarez wrote:
>
> Prior to this patch, when a LRP has only IPv6 addresses, ovn-northd
> will crash (SIGSEV) because the current code injects a flow to
> emit
Thanks. I merged this into branch-2.12.
--Justin
> On Jul 31, 2019, at 11:31 PM, nusid...@redhat.com wrote:
>
> From: Numan Siddique
>
> This patch adds 3 unixctl socket comments - pause, resume and is-paused.
>
> Usage: ovs-appctl -t ovn-northd pause/resume/is-paused
>
> This feature
Thanks. I merged this into branch-2.12.
--Justin
> On Jul 29, 2019, at 10:08 PM, nusid...@redhat.com wrote:
>
> From: Numan Siddique
>
> Before the commit [1], ovn-controller would always recreate its
> chassis row if deleted externally. After this commit, it no longer
> recreates it. This
On 08.08.2019 17:53, Eelco Chaudron wrote:
>
>
> On 8 Aug 2019, at 14:09, Ilya Maximets wrote:
>
>> On 08.08.2019 14:42, Eelco Chaudron wrote:
>>>
>>>
>>> On 19 Jul 2019, at 16:54, Ilya Maximets wrote:
>>>
On 18.07.2019 23:11, William Tu wrote:
> The patch introduces experimental
On 08.08.2019 16:27, Eelco Chaudron wrote:
> If for some reason the last element in the batch was already pushed on
> the stack, none of the elements where pushed. This was leading to
> buffer starvation.
>
> Signed-off-by: Eelco Chaudron
Thanks! Applied to master and branch-2.12.
Best
On 8 Aug 2019, at 14:09, Ilya Maximets wrote:
On 08.08.2019 14:42, Eelco Chaudron wrote:
On 19 Jul 2019, at 16:54, Ilya Maximets wrote:
On 18.07.2019 23:11, William Tu wrote:
The patch introduces experimental AF_XDP support for OVS netdev.
AF_XDP, the Address Family of the eXpress Data
If for some reason the last element in the batch was already pushed on
the stack, none of the elements where pushed. This was leading to
buffer starvation.
Signed-off-by: Eelco Chaudron
---
lib/netdev-afxdp.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
From: Numan Siddique
This was left out during the OVS/OVN split.
We still need to handle the below in the automake files
- OVN northbound/southbound E-R diagram
- OVN northbound/southbound schema documentation
- ovn-architecture manpage generation.
The above requires some amount of work
On 08.08.2019 14:42, Eelco Chaudron wrote:
>
>
> On 19 Jul 2019, at 16:54, Ilya Maximets wrote:
>
>> On 18.07.2019 23:11, William Tu wrote:
>>> The patch introduces experimental AF_XDP support for OVS netdev.
>>> AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket
>>>
On 19 Jul 2019, at 16:54, Ilya Maximets wrote:
On 18.07.2019 23:11, William Tu wrote:
The patch introduces experimental AF_XDP support for OVS netdev.
AF_XDP, the Address Family of the eXpress Data Path, is a new Linux
socket
type built upon the eBPF and XDP technology. It is aims to have
Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#219 FILE:
On Mon, Aug 5, 2019 at 11:12 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Fix conntrack checks in the following tests in tests/system-ovn.at:
> - ovn -- DNAT and SNAT on distributed router - N/S
> - ovn -- DNAT and SNAT on distributed router - E/W
>
> Fixes: a6ee09882283 ("OVN: run
v4->v5:
Support for stats per hash bucket.
Support for dynamic load balancing.
Rebased to OVS Master.
v3->v4:
Addressed Ilya Maximets comments.
https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360452.html
v2->v3:
Rebased to OVS master.
Fixed git merge issue.
v1->v2:
Updated
Problem:
In OVS-DPDK, flows with output over a bond interface of type “balance-tcp”
(using a hash on TCP/UDP 5-tuple) get translated by the ofproto layer into
"HASH" and "RECIRC" datapath actions. After recirculation, the packet is
forwarded to the bond member port based on 8-bits of the
Within this function actions & match dynamic strings are used as helper
variables for adding entries into logical flow table. Variables are
used several times in order to optimize number of memory allocations,
however at the end memory was forgotten to be deallocated.
Signed-off-by: Damijan
On Wed, Aug 7, 2019 at 3:50 PM Numan Siddique wrote:
>
>
> On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc
> wrote:
>
>> Within this function actions & match dynamic strings are used as helper
>> variables for adding entries into logical flow table. Variables are
>> used several times in order to
On Fri, Aug 2, 2019 at 5:24 AM Ankur Sharma
wrote:
> Background:
> With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added
> support for E-W workflow for vlan backed DVRs.
>
> This series enables N-S workflow for vlan backed DVRs.
>
> Key difference between E-W and N-S traffic flow is that
ХИМИЯ
Увлекательная видеоколлекция для детей.
Наука о превращениях, но без использования волшебной палочки! Убедиться в этом
помогут профессор Дмитрий Иванович и его верный помощник Аргентум, он же Гоша.
В основе многих выпусков передач лежат ответы на вопросы из писем
любознательных зрителей.
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#141 FILE:
From: Numan Siddique
With this patch we have to configure OVN to refer to external OVS source/build
directory instead of the ovs subtree.
The new configuration options added are:
* --with-ovs-source=/path/to/ovs/source/dir
* --with-ovs-build=/path/to/ovs/build/dir
Before configuring OVN,
38 matches
Mail list logo