Re: [ovs-dev] [PATCH ovn] Add support for using OVN specific rundirs

2019-08-12 Thread Numan Siddique
On Mon, Aug 12, 2019 at 2:59 PM Dumitru Ceara wrote: > On Fri, Aug 9, 2019 at 8:24 PM wrote: > > > > From: Numan Siddique > > > > Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). > > The commit [1] changed the package name from openvswitch to ovn, but > > it didn't take int

Re: [ovs-dev] [PATCH] Do RCU synchronization at fixed interval in PMD main loop.

2019-08-12 Thread Nitin Katiyar
Hi A gentle reminder. Please review and provide the feedback. Regards, Nitin > -Original Message- > From: Nitin Katiyar > Sent: Wednesday, August 07, 2019 7:52 PM > To: ovs-dev@openvswitch.org > Cc: Nitin Katiyar ; Anju Thomas > > Subject: [PATCH] Do RCU synchronization at fixed interval

Re: [ovs-dev] [PATCH v3 2/9] ovs-vsctl: Add conntrack zone commands.

2019-08-12 Thread Darrell Ball
Thanks for the patch Thanks for the fixups; mostly minor comments inline. On Mon, Aug 12, 2019 at 5:53 PM Yi-Hung Wei wrote: > From: William Tu > > The patch adds commands creating/deleting/listing conntrack zone > timeout policies: > $ ovs-vsctl {add,del,list}-zone-tp dp zone=zone_id ... >

Re: [ovs-dev] [PATCH v3 1/9] ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.

2019-08-12 Thread Darrell Ball
Thanks for the patch On Mon, Aug 12, 2019 at 5:52 PM Yi-Hung Wei wrote: > From: Justin Pettit > > Signed-off-by: Justin Pettit > Signed-off-by: Yi-Hung Wei > Co-authored-by: Yi-Hung Wei > --- > vswitchd/vswitch.ovsschema | 51 - > vswitchd/vswitch.xml | 275 >

Re: [ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-12 Thread Darrell Ball
Thanks for the patch Not a full review; I just did a quick run of the test using a more recent kernel version dball@ubuntu:~/ovs$ uname -r 5.0.0-23-generic dball@ubuntu:~/ovs$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 18.04.3 LTS Release: 18.04 Codena

Re: [ovs-dev] OVN: Guest VLAN Tagging proposal

2019-08-12 Thread Ankur Sharma
Hi, Gentle reminder. Regards, Ankur From: Ankur Sharma Sent: Tuesday, August 6, 2019 3:33 PM To: ovs-dev@openvswitch.org Subject: OVN: Guest VLAN Tagging proposal Hi, PROBLEM STATEMENT: === OVN does not provide support for guest vlan tagging, i.

Re: [ovs-dev] [PATCH v3 0/9] Support zone-based conntrack timeout policy

2019-08-12 Thread Darrell Ball
Thanks for the patches On Mon, Aug 12, 2019 at 5:51 PM Yi-Hung Wei wrote: > This patch series enables zone-based conntrack timeout policy support in > OVS. > Timeout policy is a set of timeout attributes that can be associated with a > connection when it is committed. Then, the connection track

Re: [ovs-dev] [PATCH v2 9/9] system-traffic: Add zone-based conntrack timeout policy test

2019-08-12 Thread Darrell Ball
On Mon, Aug 12, 2019 at 5:15 PM Yi-Hung Wei wrote: > On Sun, Aug 11, 2019 at 12:30 PM Darrell Ball wrote: > > > > I did some further testing and ran into another issue; in this case, > one, I did not expect. > > > > I added an additional sending of packets at the end of the test after > this che

Re: [ovs-dev] [PATCH v2 9/9] system-traffic: Add zone-based conntrack timeout policy test

2019-08-12 Thread Darrell Ball
On Mon, Aug 12, 2019 at 5:22 PM Yi-Hung Wei wrote: > On Sun, Aug 11, 2019 at 12:30 PM Darrell Ball wrote: > > > > I did some further testing and ran into another issue; in this case, > one, I did not expect. > > > > I added an additional sending of packets at the end of the test after > this che

[ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-12 Thread Yi-Hung Wei
This patch derives the timeout policy based on ct zone from the internal data structure that we maintain on dpif layer. It also adds a system traffic test to verify the zone-based conntrack timeout feature. The test uses ovs-vsctl commands to configure the customized ICMP and UDP timeout on zone

[ovs-dev] [PATCH v3 8/9] datapath: Add support for conntrack timeout policy

2019-08-12 Thread Yi-Hung Wei
This patch adds support for specifying a timeout policy for a connection in connection tracking system in kernel datapath. The timeout policy will be attached to a connection when the connection is committed to conntrack. This patch introduces a new odp field OVS_CT_ATTR_TIMEOUT in the ct action t

[ovs-dev] [PATCH v3 7/9] datapath: compat: Backport nf_conntrack_timeout support

2019-08-12 Thread Yi-Hung Wei
This patch brings in nf_ct_timeout_put() and nf_ct_set_timeout() when it is not available in the kernel. Three symbols are created in acinclude.m4. * HAVE_NF_CT_SET_TIMEOUT is used to determine if upstream net-next commit 717700d183d65 ("netfilter: Export nf_ct_{set,destroy}_timeout()") is availa

[ovs-dev] [PATCH v3 6/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-12 Thread Yi-Hung Wei
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains the zone-based configuration in the vswitchd. Whenever there is a database change, vswitchd will read the datapath, CT_Zone, and CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the database configuration in

[ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-12 Thread Yi-Hung Wei
This patch first defines the dpif interface for a datapath to support adding, deleting, getting and dumping conntrack timeout policy. The timeout policy is identified by a 4 bytes unsigned integer in datapath, and it currently support timeout for TCP, UDP, and ICMP protocols. Moreover, this patch

[ovs-dev] [PATCH v3 5/9] simap: Add utility function to help compare two simaps.

2019-08-12 Thread Yi-Hung Wei
From: Ben Pfaff Signed-off-by: Ben Pfaff --- lib/simap.c | 15 ++- lib/simap.h | 1 + 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/simap.c b/lib/simap.c index d634f8ed9eea..f404ece67703 100644 --- a/lib/simap.c +++ b/lib/simap.c @@ -1,5 +1,5 @@ /* - * Copyrig

[ovs-dev] [PATCH v3 2/9] ovs-vsctl: Add conntrack zone commands.

2019-08-12 Thread Yi-Hung Wei
From: William Tu The patch adds commands creating/deleting/listing conntrack zone timeout policies: $ ovs-vsctl {add,del,list}-zone-tp dp zone=zone_id ... Signed-off-by: William Tu --- tests/ovs-vsctl.at | 34 - utilities/ovs-vsctl.8.in | 26 +++ utilities/ovs-vsctl.c

[ovs-dev] [PATCH v3 3/9] ct-dpif: Export ct_dpif_format_ipproto()

2019-08-12 Thread Yi-Hung Wei
This function will be useful for following patches. Signed-off-by: Yi-Hung Wei Acked-by: Justin Pettit --- lib/ct-dpif.c | 3 +-- lib/ct-dpif.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c index 5d8a75d3a63f..6ea7feb0ee35 100644 --- a/lib/c

[ovs-dev] [PATCH v3 0/9] Support zone-based conntrack timeout policy

2019-08-12 Thread Yi-Hung Wei
This patch series enables zone-based conntrack timeout policy support in OVS. Timeout policy is a set of timeout attributes that can be associated with a connection when it is committed. Then, the connection tracking system will expire a connection based on its connection state. For example, one

[ovs-dev] [PATCH v3 1/9] ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.

2019-08-12 Thread Yi-Hung Wei
From: Justin Pettit Signed-off-by: Justin Pettit Signed-off-by: Yi-Hung Wei Co-authored-by: Yi-Hung Wei --- vswitchd/vswitch.ovsschema | 51 - vswitchd/vswitch.xml | 275 + 2 files changed, 277 insertions(+), 49 deletions(-) diff --g

Re: [ovs-dev] [PATCH v2 9/9] system-traffic: Add zone-based conntrack timeout policy test

2019-08-12 Thread Yi-Hung Wei
On Sun, Aug 11, 2019 at 12:30 PM Darrell Ball wrote: > > I did some further testing and ran into another issue; in this case, one, I > did not expect. > > I added an additional sending of packets at the end of the test after this > check: > > AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT

Re: [ovs-dev] [PATCH v2 9/9] system-traffic: Add zone-based conntrack timeout policy test

2019-08-12 Thread Yi-Hung Wei
On Sun, Aug 11, 2019 at 12:30 PM Darrell Ball wrote: > > I did some further testing and ran into another issue; in this case, one, I > did not expect. > > I added an additional sending of packets at the end of the test after this > check: > > AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT

[ovs-dev] [PATCH v1] doc: Added OVS Nicira Extension document

2019-08-12 Thread Ashish Varma
OVS supports Nicira Extensions as various vendor messages or as vendor types in stats or multipart messages. Added a document to describe the Nicira extension as currently supported by OVS. Signed-off-by: Ashish Varma --- Documentation/automake.mk | 1 + Documen

[ovs-dev] [PATCH] utilities: Improve ovs-dpctl-top flow parsing

2019-08-12 Thread Jaime Caamaño Ruiz
* check that expected bytes and packets stats are correctly read from every flow. * check that the expected elements are read for every field type aggregation. Signed-off-by: Jaime Caamaño Ruiz --- utilities/ovs-dpctl-top.in | 23 --- 1 file changed, 12 insertions(+), 11

[ovs-dev] New Request for Quotation

2019-08-12 Thread Andrew Collins
Sir/Madam Attached for your reference is details of our bulk order. View and give us your best offer which must include delivery and payment terms. Regards [1] Links: -- [1] https://www.mediafire.com/file/2pf48p3s3vjzf92/NEW_QUOTATION_3456.7z/file _

[ovs-dev] New Request for Quotation

2019-08-12 Thread Andrew Collins
Sir/Madam Attached for your reference is details of our bulk order. View and give us your best offer which must include delivery and payment terms. Regards [1] Links: -- [1] https://www.mediafire.com/file/2pf48p3s3vjzf92/NEW_QUOTATION_3456.7z/file _

[ovs-dev] New Request for Quotation

2019-08-12 Thread Andrew Collins
Sir/Madam Attached for your reference is details of our bulk order. View and give us your best offer which must include delivery and payment terms. Regards [1] Links: -- [1] https://www.mediafire.com/file/2pf48p3s3vjzf92/NEW_QUOTATION_3456.7z/file _

Re: [ovs-dev] [PATCH v12] Improved Packet Drop Statistics in OVS

2019-08-12 Thread Eelco Chaudron
Hi Anju, See comments inline… //Eelco On 25 Jul 2019, at 14:16, Anju Thomas wrote: Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in ta

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Add IGMP Relay support

2019-08-12 Thread Dumitru Ceara
On Fri, Aug 9, 2019 at 10:11 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > > It looks good to me. I do have one question down below. Thanks for the review! I sent a v3 addressing your question: https://patchwork.ozlabs.org/patch/1145688/ > > On 8/9/19 5:54 AM, Dumitru Ceara wrote: > >

[ovs-dev] [PATCH ovn v3] ovn-northd: Add IGMP Relay support

2019-08-12 Thread Dumitru Ceara
Add a new configuration option 'mcast_relay' to the Logical_Router:options in the OVN Northbound database. If a router is configured with 'mcast_relay' enabled then ovn-northd will install Logical_Flows to allow IP multicast traffic to be routed between Logical_Switches. The logical router will ag

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix for recirc issue with mpls traffic with dp_hash

2019-08-12 Thread Rudra Surya Bhaskara Rao via dev
Hi All, Please consider this as second gentle reminder. Could you please review this fix and provide your valuable suggestions and comments. Thanks & Regards, Surya. -Original Message- From: Rudra Surya Bhaskara Rao Sent: 31 July 2019 10:41 AM To: 'ovs-dev@openvswitch.org' Subject:

Re: [ovs-dev] [PATCH ovn] Add support for using OVN specific rundirs

2019-08-12 Thread Dumitru Ceara
On Fri, Aug 9, 2019 at 8:24 PM wrote: > > From: Numan Siddique > > Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). > The commit [1] changed the package name from openvswitch to ovn, but > it didn't take into the account the effects of it. When "make install" > is run ovn-ctl

Re: [ovs-dev] [PATCH] checkpatch: Fix regexp for if, while, etc inside macros.

2019-08-12 Thread Ilya Maximets
On 09.08.2019 17:04, Aaron Conole wrote: > Ilya Maximets writes: > >> This allows to use a one-character expression inside the 'if' >> statement and multiple spaces before the line continuation character. >> >> Fixes false positive in case like this: >> >> #define MACRO(ARG) \ >> if (