Re: [ovs-dev] [PATCH v1 ovn] OVN: Replace chassis mac with router port mac on destination chassis

2019-08-27 Thread Numan Siddique
On Tue, Aug 27, 2019 at 7:20 AM Ankur Sharma wrote: > Hi Numan, > > Thanks a lot for the feedback. > > Sure, I can define the range for physical flows. > > However, just wanted to call out that as I understand, conjunction id has > to be unique only across a table, > > i.e IDs can overlap across

[ovs-dev] Why are iperf3 udp packets out of order in OVS DPDK case?

2019-08-27 Thread 杨�D
Hi, all I’m doing experiments with OVS and OVS DPDK, only one bridge is there, ports and flows are same for OVS and OVS DPDK, in OVS case, everything works well, but in OVS DPDK case, iperf udp performance data are very poor, udp packets are out of order, I have limited MTU and send buffer by �

Re: [ovs-dev] [patch v1] conntrack: Fix ICMPV4 error data L4 length check.

2019-08-27 Thread Vishal Deep Ajmera
Hi Darrell, Thanks for the patch. When I applied the patch to latest master, I see that we take care of length check (< 8) only for ICMPv6 and not for ICMPv4. We need to do it for ICMPv4 as well. Also, we are already using 'related' to skip or not to skip length check. * If 'related' is NULL,

Re: [ovs-dev] Why are iperf3 udp packets out of order in OVS DPDK case?

2019-08-27 Thread Stokes, Ian
On 8/27/2019 9:35 AM, Yi Yang (杨燚)-云服务集团 wrote: Hi, all I’m doing experiments with OVS and OVS DPDK, only one bridge is there, ports and flows are same for OVS and OVS DPDK, in OVS case, everything works well, but in OVS DPDK case, iperf udp performance data are very poor, udp packets are

Re: [ovs-dev] [PATCH v5] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-08-27 Thread Vishal Deep Ajmera
> > Hi Vishal, > > I quickly tested your patch on two servers with 2 ixgbe cards each linked via > a > juniper switch with LACP. > With testpmd using a single core the switching rate raised from ~2.0 Mpps to > ~2.4+ Mpps, so I read at least a +20% gain. > > Please add an example command on how

Re: [ovs-dev] [PATCH v5] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-08-27 Thread Vishal Deep Ajmera
Thanks Ilya for comments. I will address them in the next patch-set. Warm Regards, Vishal Ajmera ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] Make pid_exists() more robust against empty pid argument

2019-08-27 Thread Ilya Maximets
On 14.08.2019 18:47, Michele Baldessari wrote: > In some of our destructive testing of ovn-dbs inside containers managed > by pacemaker we reached a situation where /var/run/openvswitch had > empty .pid files. The current code does not deal well with them > and pidfile_is_running() returns true in

Re: [ovs-dev] [PATCH] packets: Fix using outdated RSS hash after MPLS decapsulation.

2019-08-27 Thread Nitin Katiyar
Hi, Gentle reminder. Please provide your feedback. Regards, Nitin > -Original Message- > From: Nitin Katiyar > Sent: Saturday, August 17, 2019 12:25 AM > To: ovs-dev@openvswitch.org > Cc: Nitin Katiyar > Subject: [PATCH] packets: Fix using outdated RSS hash after MPLS > decapsulation. >

Re: [ovs-dev] [PATCH] packets: Fix using outdated RSS hash after MPLS decapsulation.

2019-08-27 Thread Ilya Maximets
Hi. Since this is not a first version of a patch, the subject prefix should be [PATCH v2]. For the next version, please, use [PATCH v3]. This way it's much easier to recognize/track patches in a list or mailbox. Hint: It's generally speeds up review process if relevant people are in CC list

[ovs-dev] Cómo realizar una DNC efectiva

2019-08-27 Thread Russel Cohuo
Me da mucho gusto saludarte. Es, para mí, un placer poder invitarte a nuestro Curso en Línea "¿Cómo realizar una DNC efectiva?", que se estará llevando a cabo el día Jueves 05 de Septiembre con un horario de 10:00 a 14:00 hrs. (hora del centro de México) Objetivos Específicos: - Comprenderá q

[ovs-dev] [PATCH ovn 0/2] add empty_lb controller_event for logical router pipeline

2019-08-27 Thread Lorenzo Bianconi
Introduce empty load balancer controller_event support to logical router pipeline. Update northd documentation. Lorenzo Bianconi (2): northd: introduce build_empty_lb_event_flow routine northd: add empty_lb controller_event for logical router northd/ovn-northd.8.xml | 12 ++ northd/ovn-n

[ovs-dev] [PATCH ovn 1/2] northd: introduce build_empty_lb_event_flow routine

2019-08-27 Thread Lorenzo Bianconi
Introduce build_empty_lb_event_flow routine and remove open code Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 63 ++--- 1 file changed, 37 insertions(+), 26 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index ca128c996..

[ovs-dev] [PATCH ovn 2/2] northd: add empty_lb controller_event for logical router

2019-08-27 Thread Lorenzo Bianconi
Add empty load balancer controller_event support to logical router pipeline. Update northd documentation even for logical switch pipeline Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.8.xml | 12 + northd/ovn-northd.c | 19 +- tests/ovn.at| 57

Re: [ovs-dev] [PATCH] ovs-lib: Add timeout at ovs-check-dead-ifs.

2019-08-27 Thread Guru Shetty
On Fri, 23 Aug 2019 at 11:29, William Tu wrote: > At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read > an entry in /proc//fd/ but hangs forever. The pid is > a qemu-system-x86_64 process and we suspect it's an issue related to > qemu, not ovs. As a result, force-reload-kmod han

Re: [ovs-dev] [PATCH] ovs-lib: Add timeout at ovs-check-dead-ifs.

2019-08-27 Thread William Tu
On Tue, Aug 27, 2019 at 10:21 AM Guru Shetty wrote: > > > > On Fri, 23 Aug 2019 at 11:29, William Tu wrote: >> >> At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read >> an entry in /proc//fd/ but hangs forever. The pid is >> a qemu-system-x86_64 process and we suspect it's an iss

Re: [ovs-dev] [PATCH] Docs: Add DPDK AF_XDP PMD use case.

2019-08-27 Thread Stokes, Ian
On 8/22/2019 3:43 PM, William Tu wrote: On Thu, Aug 22, 2019 at 1:33 AM David Marchand wrote: On Thu, Aug 22, 2019 at 10:30 AM Stokes, Ian wrote: On 8/22/2019 7:00 AM, David Marchand wrote: On Thu, Aug 22, 2019 at 12:49 AM William Tu wrote: Add command lines for using DPDK's AF_XDP P

[ovs-dev] [PATCHv2] ovs-lib: Add timeout at ovs-check-dead-ifs.

2019-08-27 Thread William Tu
At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read an entry in /proc//fd/ but hangs forever. The pid is a qemu-system-x86_64 process and we suspect it's an issue related to qemu, not ovs. As a result, force-reload-kmod hangs and OVS bridge never gets restarted. This patch adds a

Re: [ovs-dev] [PATCHv2] ovs-lib: Add timeout at ovs-check-dead-ifs.

2019-08-27 Thread Guru Shetty
On Tue, 27 Aug 2019 at 11:10, William Tu wrote: > At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read > an entry in /proc//fd/ but hangs forever. The pid is > a qemu-system-x86_64 process and we suspect it's an issue related to > qemu, not ovs. As a result, force-reload-kmod han

[ovs-dev] [PATCH] flow: Reduce metadata connection state branches in miniflow_extract

2019-08-27 Thread Malvika Gupta
This patch merges two separate if-else branches for metadata connection state into one if-else branch to improve performance. It gives an average performance improvement of ~3% on arm platforms and ~4.5% on x86 platforms. Signed-off-by: Malvika Gupta Reviewed-by: Yanqin Wei Reviewed-by: Gavin Hu

Re: [ovs-dev] [patch v1] conntrack: Fix ICMPV4 error data L4 length check.

2019-08-27 Thread Darrell Ball
On Tue, Aug 27, 2019 at 2:02 AM Vishal Deep Ajmera < vishal.deep.ajm...@ericsson.com> wrote: > Hi Darrell, > > Thanks for the patch. When I applied the patch to latest master, > I see that we take care of length check (< 8) only for ICMPv6 and > not for ICMPv4. That is interesting i just tried a

[ovs-dev] [PATCH] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-27 Thread Greg Rose
A Centos 7.5 kernel with an unencountered set of minor build numbers caused an upgrade bug. Adding the case for the rhel 7.5 kmod management script fixes the problem. Signed-off-by: Greg Rose --- rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh | 5 + 1 file changed, 5 insertions(+) d

Re: [ovs-dev] [PATCH] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-27 Thread Guru Shetty
On Tue, 27 Aug 2019 at 14:06, Greg Rose wrote: > A Centos 7.5 kernel with an unencountered set of minor build numbers > caused an upgrade bug. Adding the case for the rhel 7.5 kmod management > script fixes the problem. > > Signed-off-by: Greg Rose > --- > rhel/usr_share_openvswitch_scripts_ov

Re: [ovs-dev] [PATCH] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-27 Thread Yifeng Sun
Reviewed-by: Yifeng Sun On Tue, Aug 27, 2019 at 2:06 PM Greg Rose wrote: > > A Centos 7.5 kernel with an unencountered set of minor build numbers > caused an upgrade bug. Adding the case for the rhel 7.5 kmod management > script fixes the problem. > > Signed-off-by: Greg Rose > --- > rhel/usr

Re: [ovs-dev] [PATCH v2] userspace: Enable non-bridge port as tunnel endpoint.

2019-08-27 Thread Yifeng Sun
Hi Ben, Could you please take a look at this patch if you have time? Thanks. Yifeng On Thu, Jul 18, 2019 at 1:07 PM Yifeng Sun wrote: > > For userspace datapath, currently only the bridge itself, the LOCAL port, > can be the tunnel endpoint to encap/decap tunnel packets. This patch > enables non

[ovs-dev] [patch v2] conntrack: Fix ICMPv4 error data L4 length check.

2019-08-27 Thread Darrell Ball
The ICMPv4 error data L4 length check was found to be too strict for TCP, expecting a minimum of 20 rather than 8 bytes. This worked by hapenstance for other inner protocols. The approach is to explicitly handle the ICMPv4 error data L4 length check and to do this for all supported inner protocol

[ovs-dev] [PATCH v7 0/3 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-27 Thread Ankur Sharma
Problem Description: Redirection to chassisredirect ports happens only via tunnel encapsulation. As a result, same cannot be leveraged upon for vlan backed environments. This series addresses the issue by allowing redirection to happen without encapsulation. Design: === a. High level design

[ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be res

[ovs-dev] [PATCH v7 2/3 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-27 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be res

[ovs-dev] [PATCH v7 3/3 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-27 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be res

Re: [ovs-dev] [PATCH v6 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Ankur Sharma
Hi Numan, Thanks a lot for the feedback. Just sent out V7 with following changes. a. Replace “vlan” with “bridged”. b. Remove dependency of datum_to_smap. Appreciate your inputs. Regards, Ankur From: Numan Siddique Sent: Saturday, August 24, 2019 11:53 AM To: Ankur Sharma Cc: ovs-dev@openvsw

Re: [ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Numan Siddique
On Wed, Aug 28, 2019, 6:34 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that >

[ovs-dev] [PATCH v8 0/3 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-27 Thread Ankur Sharma
Problem Description: Redirection to chassisredirect ports happens only via tunnel encapsulation. As a result, same cannot be leveraged upon for vlan backed environments. This series addresses the issue by allowing redirection to happen without encapsulation. Design: === a. High level design

[ovs-dev] [PATCH v8 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be res

[ovs-dev] [PATCH v8 2/3 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-27 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be res

[ovs-dev] [PATCH v8 3/3 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-27 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be res

Re: [ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Ankur Sharma
Gosh, bad miss, just now sent out a V8. Regards, Ankur From: Numan Siddique Sent: Tuesday, August 27, 2019 6:39 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option On Wed, Aug 28, 2019, 6:34 AM Ankur Sharma

Re: [ovs-dev] [PATCH v6 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-27 Thread Ankur Sharma
Hi Numan, Sent out V7/8 with changes in ovn-northd.8.xml. You have raised a very good point regarding ARP resolution and in this aspect patch differs from overlay redirection because of following reasons: SENDER SIDE: a. Since, there is no encapsulation, hence generated ARP request

Re: [ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #249 FILE: utilities/ovn-nbctl.c:670: lrp-set-

Re: [ovs-dev] [PATCH v8 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #212 FILE: utilities/ovn-nbctl.c:670: lrp-set-

[ovs-dev] 答复: Why are iperf3 udp packets out of order in OVS DPDK case?

2019-08-27 Thread 杨�D
Ian, here is my configuration, sorry I can't show flow details because it is confidential. By the way, iperf3 tcp is ok and performance is good enough, I'm really confused, udp was ok but tcp were not ok in my VM environment before, it broke my sense :-), I can avoid out of order issue if I control