Re: [ovs-dev] [PATCH v2 python3 6/6] Require Python 3 and remove support for Python 2.

Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ben Pfaff needs to sign off. WARNING: Line is 89 characters long (recommended limit

[ovs-dev] [PATCH v2 python3 4/6] Recommend Sphinx from Python 3 in documentation and packaging.

Signed-off-by: Ben Pfaff --- .travis.yml | 2 +- Documentation/intro/install/documentation.rst | 6 +++--- Documentation/intro/install/rhel.rst | 2 +- rhel/openvswitch-fedora.spec.in | 2 +- rhel/openvswitch.spec.in |

[ovs-dev] [PATCH v2 python3 5/6] xenserver: Make Python files parse in Python 3 also.

I don't actually have any idea whether XenServer has moved forward to Python 3 these days, but these files are still OK in Python 2.x as well. The rest of the Python files in OVS seem to already be OK in Python 3. Signed-off-by: Ben Pfaff --- ...xensource_libexec_InterfaceReconfigureBridge.py |

[ovs-dev] [PATCH v2 python3 3/6] Documentation: Work with sphinx-build for Python 3 also.

There's nothing in OVS specific to Sphinx for Python 2, but the compile-time check only looked for a binary named "sphinx-build", which is typically provided only for Python 2. With Python 3, the binary is typically called "sphinx-build-3". With this commit, either name is accepted. Signed-off-b

[ovs-dev] [PATCH v2 python3 2/6] travis: Dump config.log if make fails.

This is sometimes useful for debugging. Signed-off-by: Ben Pfaff --- .travis/linux-build.sh | 2 +- .travis/osx-build.sh | 8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh index 661d5e89ed70..89496e2a275b 100755 --- a/.t

[ovs-dev] [PATCH v2 python3 0/6] Remove Python 2 support

Python 2 will reach end-of-life at the beginning of 2020, in only a few months. This series removes support for Python 2 from OVS and requires Python 3. v1->v2: - Fixed build problems found by travis. - Added a couple of commits at the beginning to make travis failures more debuggable. - Fix te

[ovs-dev] [PATCH v2 python3 1/6] travis: Obtain testsuite logs from the correct directory.

These days Automake uses _build/sub for its distcheck builds, not plain _build. (I don't know whether that is a change from previous versions.) Signed-off-by: Ben Pfaff --- .travis/linux-build.sh | 2 +- .travis/osx-build.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH] fatal-signal: Catch SIGSEGV and print backtrace.

On Wed, Sep 18, 2019 at 01:16:37PM -0700, William Tu wrote: > Thanks for the feedback. > > On Wed, Sep 18, 2019 at 11:30 AM Ben Pfaff wrote: > > > > On Tue, Sep 17, 2019 at 04:13:24PM -0700, William Tu wrote: > > > The patch catches the SIGSEGV signal and prints the backtrace > > > using libunwin

Re: [ovs-dev] 13-09-2019 RESULTS.

Microsoft UK Regional Office Waverley Gate 2-4 Waterloo Place Edinburgh EH1 3EG United Kingdom. Dear ovs-...@mail.linuxfoundation.org Congratulation to you as we bring to your notice the results of the Microsoft 2019 Product Award Draws held on Friday 13th September 2019. We are happy to inform

Re: [ovs-dev] 13-09-2019 RESULTS.

Microsoft UK Regional Office Waverley Gate 2-4 Waterloo Place Edinburgh EH1 3EG United Kingdom. Dear ovs-dev@openvswitch.org Congratulation to you as we bring to your notice the results of the Microsoft 2019 Product Award Draws held on Friday 13th September 2019. We are happy to inform you that

Re: [ovs-dev] 13-09-2019 RESULTS.

Microsoft UK Regional Office Waverley Gate 2-4 Waterloo Place Edinburgh EH1 3EG United Kingdom. Dear d...@openvswitch.org Congratulation to you as we bring to your notice the results of the Microsoft 2019 Product Award Draws held on Friday 13th September 2019. We are happy to inform you that yo

[ovs-dev] Fabrica de Bolsas de Friselina. Precio de fabrica

( http://www.starpack.com.ar/ )   Estimado Cliente, Envio Precios de Promocion de Septiembre para la Reposicon de tus Bolsas Ecologicas de Friselina y Friselina Laminada , Como bien saben Confeccionamos nuestras Bolsas Con Friselina de Calidad Premiun para que tu negocio se destaque del resto

Re: [ovs-dev] [PATCH] fatal-signal: Catch SIGSEGV and print backtrace.

Thanks for the feedback. On Wed, Sep 18, 2019 at 11:30 AM Ben Pfaff wrote: > > On Tue, Sep 17, 2019 at 04:13:24PM -0700, William Tu wrote: > > The patch catches the SIGSEGV signal and prints the backtrace > > using libunwind, hopefully makes it easier to debug. > > > > Signed-off-by: William Tu

Re: [ovs-dev] [PATCH python3 4/4] Require Python 3 and remove support for Python 2.

Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ben Pfaff needs to sign off. WARNING: Line is 89 characters long (recommended limit

Re: [ovs-dev] [PATCH python3 2/4] Recommend Sphinx from Python 3 in documentation and packaging.

Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ben Pfaff needs to sign off. Lines checked: 95, Warnings: 0, Errors: 1 Please chec

Re: [ovs-dev] [PATCH] ovs-bugtool: Add ip -s -s to get_device_stats.out.

On Mon, Sep 16, 2019 at 09:31:36AM -0700, Gregory Rose wrote: > > On 9/12/2019 10:07 AM, William Tu wrote: > > The patch adds 'ip -s -s' to file get_device_stats.out to collect > > device statistics. When debugging tunnel related issues, the command > > shows much more detailed counters, ex: frame

Re: [ovs-dev] [PATCH 1/1] stream_ssl: fix important memory leak in ssl_connect() function

On Mon, Sep 16, 2019 at 04:44:11PM -0700, William Tu wrote: > On Mon, Sep 16, 2019 at 12:20 AM Damijan Skvarc > wrote: > > > > Hi William and thanks for your review. > > I agree with your proposed changes. > > Is there still some action expected from me? > > > > thanks, Damijan > > No, thanks fo

Re: [ovs-dev] [PATCH] fatal-signal: Catch SIGSEGV and print backtrace.

On Tue, Sep 17, 2019 at 04:13:24PM -0700, William Tu wrote: > The patch catches the SIGSEGV signal and prints the backtrace > using libunwind, hopefully makes it easier to debug. > > Signed-off-by: William Tu I guess my experience is that this sort of thing is sometimes useful but ultimately cau

[ovs-dev] [PATCH python3 3/4] xenserver: Make Python files parse in Python 3 also.

I don't actually have any idea whether XenServer has moved forward to Python 3 these days, but these files are still OK in Python 2.x as well. The rest of the Python files in OVS seem to already be OK in Python 3. Signed-off-by: Ben Pfaff --- ...xensource_libexec_InterfaceReconfigureBridge.py |

[ovs-dev] [PATCH python3 2/4] Recommend Sphinx from Python 3 in documentation and packaging.

--- .travis.yml | 2 +- Documentation/intro/install/documentation.rst | 6 +++--- Documentation/intro/install/rhel.rst | 2 +- rhel/openvswitch-fedora.spec.in | 2 +- rhel/openvswitch.spec.in | 2 +- 5 files changed, 7 i

[ovs-dev] [PATCH python3 1/4] Documentation: Work with sphinx-build for Python 3 also.

There's nothing in OVS specific to Sphinx for Python 2, but the compile-time check only looked for a binary named "sphinx-build", which is typically provided only for Python 2. With Python 3, the binary is typically called "sphinx-build-3". With this commit, either name is accepted. Signed-off-b

[ovs-dev] [PATCH python3 0/4] Remove Python 2 support

Python 2 will reach end-of-life at the beginning of 2020, in only a few months. This series removes support for Python 2 from OVS and requires Python 3. This is currently building on Travis: https://travis-ci.org/blp/ovs-reviews/builds/586655314 Ben Pfaff (4): Documentation: Work with sphinx-b

Re: [ovs-dev] [PATCH 2/2] db-ctl-base: Give better error messages for ambiguous abbreviations.

THank you for the reviews. I applied these to master. On Wed, Sep 18, 2019 at 10:36:53AM -0700, Yifeng Sun wrote: > LGTM, thanks. > > Reviewed-by: Yifeng Sun > > On Wed, Sep 18, 2019 at 9:32 AM Ben Pfaff wrote: > > > > Tables and columns may be abbreviated to unique prefixes, but until now >

Re: [ovs-dev] [PATCH 2/2] db-ctl-base: Give better error messages for ambiguous abbreviations.

LGTM, thanks. Reviewed-by: Yifeng Sun On Wed, Sep 18, 2019 at 9:32 AM Ben Pfaff wrote: > > Tables and columns may be abbreviated to unique prefixes, but until now > the error messages have just said there's more than one match. This commit > makes the error messages list the possibilities. > >

Re: [ovs-dev] [PATCH 1/2] sset: New function sset_join().

LGTM, thanks. Reviewed-by: Yifeng Sun On Wed, Sep 18, 2019 at 9:31 AM Ben Pfaff wrote: > > This will acquire its first user in an upcoming commit. > > This function follows the pattern set by svec_join(). > > Signed-off-by: Ben Pfaff > --- > lib/sset.c | 31 +++ >

Re: [ovs-dev] Supply Chain Management

Did you get a chance to review my previous email? Please let me know if you did like to review few sample records from your target audience. Look forward to hearing back Regards, Laura From: Laura Mendez Sent: 06 September, 2019 1:47 PM To: 'd...@openvswitch.org' Subject: Supply Chain Manageme

[ovs-dev] [PATCH 2/2] db-ctl-base: Give better error messages for ambiguous abbreviations.

Tables and columns may be abbreviated to unique prefixes, but until now the error messages have just said there's more than one match. This commit makes the error messages list the possibilities. Signed-off-by: Ben Pfaff --- lib/db-ctl-base.c | 58 +-

[ovs-dev] [PATCH 1/2] sset: New function sset_join().

This will acquire its first user in an upcoming commit. This function follows the pattern set by svec_join(). Signed-off-by: Ben Pfaff --- lib/sset.c | 31 +++ lib/sset.h | 3 +++ 2 files changed, 34 insertions(+) diff --git a/lib/sset.c b/lib/sset.c index 3deb1f9d

Re: [ovs-dev] [PATCH v1 ovn] ovn-ctl: Support passing ssl certs for northd

Thanks, I pushed this to master. On 9/17/19 7:43 PM, Han Zhou wrote: On Mon, Sep 16, 2019 at 3:12 PM wrote: From: Aliasgar Ginwala When using ssl mode for ovn nb/sb active-standby/cluster db service models, northd can use ssl mode too. e.g. one can pass --ovn-northd-ssl-key, --ovn-northd

Re: [ovs-dev] [PATCHv4] netdev-afxdp: Add need_wakeup supprt.

On 17 Sep 2019, at 20:36, William Tu wrote: > The patch adds support for using need_wakeup flag in AF_XDP rings. > A new option, use_need_wakeup, is added. When this option is used, > it means that OVS has to explicitly wake up the kernel RX, using poll() > syscall and wake up TX, using sendto(

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

On Wed, Sep 18, 2019 at 9:30 AM Dumitru Ceara wrote: > > On Tue, Sep 17, 2019 at 6:49 PM Han Zhou wrote: > > > > > > > > On Tue, Sep 17, 2019 at 5:21 AM Mark Michelson wrote: > > > > > > On 9/16/19 12:04 PM, Han Zhou wrote: > > > > > > > > > > > > On Mon, Sep 16, 2019 at 4:15 AM Dumitru Ceara >

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

On Tue, Sep 17, 2019 at 6:49 PM Han Zhou wrote: > > > > On Tue, Sep 17, 2019 at 5:21 AM Mark Michelson wrote: > > > > On 9/16/19 12:04 PM, Han Zhou wrote: > > > > > > > > > On Mon, Sep 16, 2019 at 4:15 AM Dumitru Ceara > > > wrote: > > > > > > > > On Sat, Sep 14, 2019