QVO LEGIS - FORMAÇÃO E CONSULTADORIA
Formação certificada
Inspeção Máquinas e Equipamentos de Trabalho - Dec. lei 50/2005
Formação Obrigatória
DURAÇÃO 07 Horas - 1 dia
HORÁRIO 9H Recepção dos participantes, início às 9H30 e fim às 17H30
Local/Data: LISBOA - 23 de SETEMBRO 2019
Hi,
Addressed comments given in patch v8. Kindly review patch v9.
Changes since patch v8 :
Rebased my changes on top of Ilya's patch " Reuse vhost function for dpdk
ETH custom stats". Patch set 1/2.
Addressed comments given in patch v8.
Thanks & Regards,
Sriram.
-Original Message-
From: Martin Zhang
When parse tnl_push, if IPv4 is used,
we forget to fill the ipv4 checksum fields.
In the patch:
csum has been used as a variable,
so we neeed rename it to udp_csum.
Signed-off-by: Martin Zhang
Signed-off-by: Dujie
---
lib/odp-util.c | 9 ++---
1 file changed, 6
This may be needed in some special cases, such as to support some hardware
offload implementations. Note that disabling TCP sequence number
verification is not an optimization in itself, but supporting some
hardware offload implementations may offer better performance. TCP
sequence number
Thanks Ben
I just noticed I sent another version here
https://patchwork.ozlabs.org/patch/1153283/
but there were a couple of issues that deserve a resend.
It might need a rebase as well
Darrell
On Tue, Sep 24, 2019 at 3:18 PM Ben Pfaff wrote:
> On Wed, Jun 12, 2019 at 12:44:18PM -0700,
On Wed, Jun 12, 2019 at 12:44:18PM -0700, Darrell Ball wrote:
> On Wed, Jun 12, 2019 at 10:58 AM Ben Pfaff wrote:
>
> > On Wed, Jun 12, 2019 at 10:31:17AM -0700, Darrell Ball wrote:
> > > On Wed, Jun 12, 2019 at 10:09 AM Ben Pfaff wrote:
> > >
> > > > On Wed, Jun 12, 2019 at 08:46:06AM -0700,
On Fri, Aug 30, 2019 at 09:13:19AM -0700, Darrell Ball wrote:
> The datatype 'pad' in the function 'reverse_nat_packet()' was incorrectly
> declared as 'char' instead of 'uint8_t'. This can affect reverse natting
> of icmpX packets with padding > 127 bytes. At the same time, add some
> comments
Done!
On Tue, Sep 24, 2019 at 02:56:40PM -0700, Darrell Ball wrote:
> Thanks Ben
>
> Would you mind applying to 2.12 as well.
>
> Darrell
>
> On Tue, Sep 24, 2019 at 2:34 PM Ben Pfaff wrote:
>
> > On Mon, Sep 23, 2019 at 04:44:33PM -0700, Darrell Ball wrote:
> > > Valgrind reported that
Thanks Ben
Would you mind applying to 2.12 as well.
Darrell
On Tue, Sep 24, 2019 at 2:34 PM Ben Pfaff wrote:
> On Mon, Sep 23, 2019 at 04:44:33PM -0700, Darrell Ball wrote:
> > Valgrind reported that 'pkt->md.ct_orig_tuple.ipv4.ipv4_proto' is
> > uninitialized in 'check_orig_tuple()', if
On Sat, Sep 14, 2019 at 08:17:28PM -0300, Flavio Leitner via dev wrote:
> Python3 complains if a dict key is changed during the
> iteration.
>
> Use list() to create a copy of it.
Thanks! Applied to master.
___
dev mailing list
d...@openvswitch.org
On Mon, Sep 23, 2019 at 04:44:33PM -0700, Darrell Ball wrote:
> Valgrind reported that 'pkt->md.ct_orig_tuple.ipv4.ipv4_proto' is
> uninitialized in 'check_orig_tuple()', if 'ct_state' is zero. Although
> this is true, the check is superceded, as even if it succeeds the check
> for natted packets
On Tue, Sep 24, 2019 at 01:26:42AM +0800, martinbj2...@gmail.com wrote:
> From: Martin Zhang
>
> When parse tnl_push, if IPv4 is used,
> we forget to fill the ipv4 version and ip header length fields.
>
> so there is a wrong ip header in the header of "struct
>
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 98 characters long (recommended limit is 79)
#990 FILE:
From: Numan Siddique
OVN has the actions - put_arp and put_nd to learn the mac bindings from the
ARP/ND packets. These actions update the Southbound MAC_Binding table.
These actions translates to controller actions. Whenever pinctrl thread
receives such packets, it wakes up the main
Thanks Han for the reviews.
Please see below for some comments.
Thanks
Numan
On Wed, Sep 18, 2019 at 4:56 AM Han Zhou wrote:
>
> On Mon, Sep 16, 2019 at 10:17 AM wrote:
> >
> > From: Numan Siddique
> >
> > OVN has the actions - put_arp and put_nd to learn the mac bindings from
> the
> >
On Tue, Sep 24, 2019 at 03:41:22PM +0200, Damijan Skvarc wrote:
> Signed-off-by: Damijan Skvarc
Thanks. I applied this to master.
There's another memory leak here (in the run()) call, but it's even less
worth fixing than this one.
___
dev mailing
Add set_queue() action for qos capable localnet port in
S_SWITCH_OUT_PORT_SEC_L2 stage of logical swith pipeline
Introduce build_lswitch_{input,outpur}_port_sec and refactor
lswitch_port_security code in order to remove duplicated code
Signed-off-by: Lorenzo Bianconi
---
northd/ovn-northd.8.xml
Refactor allocate_chassis_queueid and free_chassis_queueid in order
to get an unused queue_id even for localnet ports and add the
the possibility to define localnet as qos capable port
Acked-by: Dumitru Ceara
Signed-off-by: Lorenzo Bianconi
---
northd/ovn-northd.c | 45
Introduce add_localnet_egress_interface_mappings routine in order to collect as
egress interfaces all ovs bridge interfaces marked with ovn-egress-iface
in the external_ids column of ovs interface table.
ovn-egress-iface is used to indicate to which localnet ports QoS egress
shaping has to be
OVN applies logical switch QoS settings to egress interfaces. It
currently works by analyzing each br-int interface to see what the remote-ip
is on it, and then adding qdiscs to the tunnel-egress-iface associated
with this br-int interface.
This doesn't work as well when working with VLAN
Hi.
Thanks for a new version.
Comments inline.
Best regards, Ilya Maximets.
On 17.09.2019 21:36, William Tu wrote:
The patch adds support for using need_wakeup flag in AF_XDP rings.
A new option, use_need_wakeup, is added. When this option is used,
it means that OVS has to explicitly wake up
Hi
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 17.09.2019 11:50, Vishal Deep Ajmera wrote:> Problem:
In OVS-DPDK, flows with output over a bond interface of type “balance-tcp”
(using a hash on TCP/UDP 5-tuple) get translated by the ofproto layer into
"HASH" and "RECIRC" datapath actions. After recirculation, the packet is
Signed-off-by: Damijan Skvarc
---
utilities/ovs-ofctl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 06289d2..b2350e0 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -590,6 +590,8 @@ open_vconn__(const char *name,
On 23.09.2019 23:55, Ben Pfaff wrote:
On Mon, Sep 23, 2019 at 04:59:11PM +0100, Kevin Traynor wrote:
Indicate that OVS 2.12 uses DPDK 18.11.2.
Signed-off-by: Kevin Traynor
---
Can also be backported to branch-2.12.
Thanks!
Done.
Thanks, Kevin and Ben for taking care of this!
Best
On 12 Sep 2019, at 12:24, Ilya Maximets wrote:
On 12.09.2019 13:19, Ilya Maximets wrote:
On 12.09.2019 13:07, Eelco Chaudron wrote:
On 12 Sep 2019, at 10:39, Ilya Maximets wrote:
On 11.09.2019 16:20, Eelco Chaudron wrote:
Currently, OVS does not register and therefore not handle the
On cloud topology with hardware offload, when SR-IOV is used there is an
architecture limitation to configure the VF from the host. The port representor
is attached to OVS, while the VF is usually configured in pass through to the
VM. In such topology the MAC address of the VF is configured by the
On Mon, Sep 23, 2019 at 5:09 PM Lorenzo Bianconi
wrote:
>
> Refactor allocate_chassis_queueid and free_chassis_queueid in order
> to get an unused queue_id even for localnet ports and add the
> the possibility to define localnet as qos capable port
>
> Signed-off-by: Lorenzo Bianconi
Looks good
On Mon, Sep 23, 2019 at 5:09 PM Lorenzo Bianconi
wrote:
>
> Add set_queue() action for qos capable localnet port in
> S_SWITCH_OUT_PORT_SEC_L2 stage of logical swith pipeline
> Introduce build_lswitch_port_sec and refactor lswitch_port_security code
> in order to remove duplicated code
>
>
On Mon, Sep 23, 2019 at 5:09 PM Lorenzo Bianconi
wrote:
>
> Introduce add_localnet_egress_interface_mappings routine in order to collect
> as
> egress interfaces all ovs bridge interfaces marked with ovn-egress-iface
> in the external_ids column of ovs interface table.
> ovn-egress-iface is used
On Tue, Sep 24, 2019 at 2:09 AM Russell Bryant wrote:
> Sorry.
>
>
No worries :)
Thanks for the review. I applied this patch to master.
Numan
> Acked-by: Russell Bryant
>
> > On Sep 23, 2019, at 4:20 PM, nusid...@redhat.com wrote:
> >
> > From: Numan Siddique
> >
> > Below compilation
Add the following new configuration options to the
Logical_Switch_Port:options column in the OVN Northbound database:
- mcast_flood: if set to 'true' all incoming IP multicast traffic
(except IP multicast reports) entering the switch will also be
flooded on the logical switch port.
-
On Tue, Sep 24, 2019 at 1:39 AM Ben Pfaff wrote:
>
> Sorry about that. Applied, thanks!
Thanks!
>
> On Mon, Sep 16, 2019 at 12:24:24PM +0200, Dumitru Ceara wrote:
> > Hi,
> >
> > Just a reminder, Mark has acked this change a while ago but it didn't
> > get pushed yet.
> >
> > Thanks,
> >
From: Martin Zhang
When parse tnl_push, if IPv4 is used,
we forget to fill the ipv4 version and ip header length fields.
so there is a wrong ip header in the header of "struct ovs_action_push_tnl",
which will caused wrong packdet sent by dpcl.
test command:
ovs-appctl
Hi Ben & Ilya,
The provided changes were internally tested and works fine.
Can we consider these changes for now and can be later enhanced as suggested
by Ilya.
Best Regards,
Anil Kumar.
-Original Message-
From: Anil Kumar Koli
Sent: Friday, 13 September, 2019 08:20 AM
To: 'Ben Pfaff'
35 matches
Mail list logo
