[ovs-dev] [PATCH] netdev-offload: replace netdev_hmap_mutex to netdev_hmap_rwlock

2019-10-09 Thread wenxu
From: wenxu All the kmap lookup operations netdev_ports_flow_del, netdev_ports_get netdev_ifindex_to_odp_port should protected by rdlock without affect each other in the handlers and revalidators Signed-off-by: wenxu --- lib/netdev-offload.c | 58 +--

Re: [ovs-dev] [PATCH ovn v4] Document process for compatibility between OVS and OVN.

2019-10-09 Thread Numan Siddique
On Wed, Oct 9, 2019 at 2:42 AM Mark Michelson wrote: > This document serves to provide an explanation for how OVN will remain > compatible with OVS. It provides instructions for OVN contributors for > how to maintain compatibility even across older versions of OVS when > possible. > > It also cre

[ovs-dev] [PATCH] ofproto: Fix for frequent invalidation of mega flows for push actions

2019-10-09 Thread Vishal Deep Ajmera via dev
When a packet is processed by the slow path and the matching OpenFlow rule has actions like push_mpls/set_field and push_vlan/set_field, the ofproto layer un-wildcards the MPLS and VLAN match fields in the megaflow entry that it plans to install. However, when the megaflow entry is actually install

[ovs-dev] Apply For Financial investment at a lower rate 2%

2019-10-09 Thread Nadia Artha Dewi
-- Hello, We are private lenders based in UK. Do you need a loan (credit) as soon as possible. Are you in search of money to solve your personal needs or finance your business venture, then get Your desired loan today! Consult us at Sunrise Funding Ltd. * We offer personal loan & huge capital lo

[ovs-dev] [PATCH] appveyor: Update OpenSSL link and python3 to path

2019-10-09 Thread Alin Gabriel Serdean
This patch fixes the appveyor build by adding the python version 3 to path as per: https://www.appveyor.com/docs/windows-images-software/#python We also create a hardlink for python3 in the same directory to ease up scripts which checks for its existence. This patch also bumps the OpenSSL version

Re: [ovs-dev] [PATCH 2/2] backtrace: Fix 32-bit libunwind build.

2019-10-09 Thread Alin Serdean
On 8 Oct 2019, at 20:51, Ben Pfaff mailto:b...@ovn.org>> wrote: On Tue, Oct 08, 2019 at 06:33:10PM +0200, Ilya Maximets wrote: On 08.10.2019 18:13, William Tu wrote: On Mon, Oct 07, 2019 at 07:10:26PM +0200, Ilya Maximets wrote: On 07.10.2019 18:11, Ilya Maximets wrote: On 07.10.2019 18:07, Wil

[ovs-dev] [PATCH] netdev-afxdp: Fix umem creation failure due to uninitialized config.

2019-10-09 Thread Ilya Maximets
Later version of 'struct xsk_umem_config' contains additional field 'flags'. OVS doesn't use that field passing uninitialized stack memory to the 'xsk_umem__create()' call that could fail with 'Invalid argument' if 'flags' are non-zero or, even worse, create umem with unexpected properties. We ne

[ovs-dev] [PATCH] netdev-afxdp: Update memory locking limits unconditionally.

2019-10-09 Thread Ilya Maximets
Any type of AF_XDP socket in all modes implies creation of BPF map of type BPF_MAP_TYPE_XSKMAP. This leads to BPF_MAP_CREATE syscall and subsequently 'xsk_map_alloc()' function that will charge required memory from the memlock limit and fail with EPERM if we're trying to allocate more. On my syst

[ovs-dev] [PATCH] tests: Allow valgrind check for afxdp testsuite.

2019-10-09 Thread Ilya Maximets
New 'make' target 'check-afxdp-valgrind'. Signed-off-by: Ilya Maximets --- tests/automake.mk | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/automake.mk b/tests/automake.mk index 9dd07a2d9..4bf8f00d5 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -282,6 +282,12 @@ chec

[ovs-dev] Lieber Geliebter in Christus,

2019-10-09 Thread aa zz via dev
Lieber Geliebter in Christus, ICH BRINGE KALVARISCHE GRÜSSE Ich bin Frau Angelica Louise aus Kap Verde, ich bin mit Herrn Teo J Louise verheiratet, ich und mein verstorbener Ehemann waren vor dem Tod meines Ehemanns in der Nachlassverwaltung und auch in einem staatlichen Nachlassbauunternehmen.

[ovs-dev] Lieber Geliebter in Christus,

2019-10-09 Thread aa zz via dev
Lieber Geliebter in Christus, ICH BRINGE KALVARISCHE GRÜSSE Ich bin Frau Angelica Louise aus Kap Verde, ich bin mit Herrn Teo J Louise verheiratet, ich und mein verstorbener Ehemann waren vor dem Tod meines Ehemanns in der Nachlassverwaltung und auch in einem staatlichen Nachlassbauunternehmen.

Re: [ovs-dev] [PATCH] appveyor: Update OpenSSL link and python3 to path

2019-10-09 Thread 0-day Robot
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 93 characters long (recommended limit is 79) #29 FILE: appveyor.yml:8:

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Add static IP multicast flood configuration

2019-10-09 Thread Mark Michelson
I've merged this to master. On 9/24/19 4:02 AM, Dumitru Ceara wrote: Add the following new configuration options to the Logical_Switch_Port:options column in the OVN Northbound database: - mcast_flood: if set to 'true' all incoming IP multicast traffic (except IP multicast reports) entering

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Add static IP multicast flood configuration

2019-10-09 Thread Dumitru Ceara
On Wed, Oct 9, 2019 at 5:01 PM Mark Michelson wrote: > > I've merged this to master. Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] appveyor: Update OpenSSL link and python3 to path

2019-10-09 Thread Ben Pfaff
On Wed, Oct 09, 2019 at 05:10:08PM +0300, Alin Gabriel Serdean wrote: > This patch fixes the appveyor build by adding the python version 3 to path > as per: > https://www.appveyor.com/docs/windows-images-software/#python > > We also create a hardlink for python3 in the same directory to ease up sc

Re: [ovs-dev] [PATCH] upcall: Configure datapath max-unkeep-op through ovs-vsctl.

2019-10-09 Thread Ben Pfaff
On Wed, Oct 09, 2019 at 02:50:39PM +0800, wenxu wrote: > > On 10/9/2019 1:33 AM, Ben Pfaff wrote: > > On Tue, Oct 08, 2019 at 03:01:44PM +0800, wenxu wrote: > >> Thx.  I  found the root cause of the bad performance  delete tc flower > >> rule in revalidator threads. > >> > >> All the block is for

Re: [ovs-dev] [PATCH] flow: Fix using pointer to member of packed struct icmp6_hdr.

2019-10-09 Thread Ilya Maximets
On 08.10.2019 18:55, William Tu wrote: On Tue, Oct 01, 2019 at 08:04:00PM +0300, Ilya Maximets wrote: OVS has no structure definition for ICMPv6 header with additional data. More precisely, it has, but this structure named as 'icmp6_error_header' and only suitable to store error related extended

[ovs-dev] [PATCH] debian: Update list of copyright holders.

2019-10-09 Thread Ben Pfaff
The list of copyright holders was incomplete and out of date. This updates it based on a "grep" for copyright notices, which I reviewed by hand. CC: 942...@bugs.debian.org Reported-by: Chris Lamb Reported-at: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942056 Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH] netdev-offload: replace netdev_hmap_mutex to netdev_hmap_rwlock

2019-10-09 Thread Ben Pfaff
On Wed, Oct 09, 2019 at 03:01:00PM +0800, we...@ucloud.cn wrote: > From: wenxu > > All the kmap lookup operations netdev_ports_flow_del, netdev_ports_get > netdev_ifindex_to_odp_port should protected by rdlock without > affect each other in the handlers and revalidators > > Signed-off-by: wenxu

Re: [ovs-dev] [PATCH 1/1] ovsdb-client: fix memory leak while executing database backup

2019-10-09 Thread Ben Pfaff
On Wed, Oct 09, 2019 at 08:34:24AM +0200, Damijan Skvarc wrote: > valgrind detects this leak while running functional test "ovsdb-client backup > and restore" Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.

Re: [ovs-dev] [PATCH lib: v2] Avoid clobbered variable warning on ppc64le.

2019-10-09 Thread Ben Pfaff
On Tue, Oct 08, 2019 at 12:40:19PM -0700, David Wilder wrote: > Since commit e2ed6fbeb1, Ci on ppc64le with Ubuntu 16.04.6 LTS throws > this error: > > lib/fatal-signal.c: In function 'send_backtrace_to_monitor': > lib/fatal-signal.c:168:9: error: variable 'dep' might be clobbered by > 'longjmp' o

Re: [ovs-dev] [PATCH] flow: Fix using pointer to member of packed struct icmp6_hdr.

2019-10-09 Thread Ben Pfaff
On Wed, Oct 09, 2019 at 06:54:29PM +0200, Ilya Maximets wrote: > On 08.10.2019 18:55, William Tu wrote: > > On Tue, Oct 01, 2019 at 08:04:00PM +0300, Ilya Maximets wrote: > > > OVS has no structure definition for ICMPv6 header with additional > > > data. More precisely, it has, but this structure n

Re: [ovs-dev] [PATCH] tests: Allow valgrind check for afxdp testsuite.

2019-10-09 Thread Ben Pfaff
On Wed, Oct 09, 2019 at 04:36:49PM +0200, Ilya Maximets wrote: > New 'make' target 'check-afxdp-valgrind'. > > Signed-off-by: Ilya Maximets Makes sense to me. I did not test it. Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://m

Re: [ovs-dev] [PATCH] ofproto: Fix for frequent invalidation of mega flows for push actions

2019-10-09 Thread Ben Pfaff
On Wed, Oct 09, 2019 at 02:06:30PM +0530, Vishal Deep Ajmera via dev wrote: > When a packet is processed by the slow path and the matching OpenFlow > rule has actions like push_mpls/set_field and push_vlan/set_field, the > ofproto layer un-wildcards the MPLS and VLAN match fields in the megaflow >

Re: [ovs-dev] [PATCH 0/1] Encap & Decap actions for MPLS Packet Type

2019-10-09 Thread Ben Pfaff
On Tue, Oct 08, 2019 at 08:13:16AM +0530, Martin Varghese wrote: > The existing PUSH MPLS & POP MPLS actions inserts & removes MPLS header > between ethernet header and the IP header. Though this behaviour is fine > for L3 VPN where an IP packet is encapsulated inside a MPLS tunnel, it does > not s

[ovs-dev] [PATCH 0/5] Backport upstream Linux kernel patches

2019-10-09 Thread Greg Rose
Pull in upstream kernel patches not related to conntrack and add compatibility layer code where needed. The upstream conntrack related patches will come later from Yi-Hung. Passes Travis: https://travis-ci.org/gvrose8192/ovs-experimental/builds/595755449 Passes check-kmod with no regressions on

[ovs-dev] [PATCH 1/5] datapath: hide clang frame-overflow warnings

2019-10-09 Thread Greg Rose
From: Arnd Bergmann Upstream commit: commit 260637903f47f20c5918bb5c1eea52b2a28ea863 Author: Arnd Bergmann Date: Mon Jul 22 17:00:01 2019 +0200 ovs: datapath: hide clang frame-overflow warnings Some functions in the datapath code are factored out so that each one has

[ovs-dev] [PATCH 2/5] datapath: change type of UPCALL_PID attribute to NLA_UNSPEC

2019-10-09 Thread Greg Rose
From: Li RongQing Upstream commit: commit ea8564c865299815095bebeb4b25bef474218e4c Author: Li RongQing Date: Tue Sep 24 19:11:52 2019 +0800 openvswitch: change type of UPCALL_PID attribute to NLA_UNSPEC userspace openvswitch patch "(dpif-linux: Implement the API funct

[ovs-dev] [PATCH 3/5] compat: remove the incorrect mtu limit for erspan

2019-10-09 Thread Greg Rose
From: Haishuang Yan Upstream commit: commit 0e141f757b2c78c983df893e9993313e2dc21e38 Author: Haishuang Yan Date: Fri Sep 27 14:58:20 2019 +0800 erspan: remove the incorrect mtu limit for erspan erspan driver calls ether_setup(), after commit 61e84623ace3 ("net: centra

[ovs-dev] [PATCH 4/5] datapath: rename flow_stats to sw_flow_stats

2019-10-09 Thread Greg Rose
From: Pablo Neira Ayuso Upstream commit: commit aef833c58d321f09ae4ce4467723542842ba9faf Author: Pablo Neira Ayuso Date: Fri Jul 19 18:20:13 2019 +0200 net: openvswitch: rename flow_stats to sw_flow_stats There is a flow_stats structure defined in include/net/flow_offload

[ovs-dev] [PATCH 5/5] datapath: compat: drop bridge nf reset from nf_reset

2019-10-09 Thread Greg Rose
Upstream commmit: commit 895b5c9f206eb7d25dc1360a8ccfc5958895eb89 Author: Florian Westphal Date: Sun Sep 29 20:54:03 2019 +0200 netfilter: drop bridge nf reset from nf_reset commit 174e23810cd31 ("sk_buff: drop all skb extensions on free and skb scrubbing") made napi

[ovs-dev] [PATCH] Fix "the the" typo in two places.

2019-10-09 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- Documentation/topics/testing.rst | 2 +- acinclude.m4 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst index 6c93826fbc40..31433c591744 100644 --- a/Documenta

Re: [ovs-dev] [PATCH 1/5] datapath: hide clang frame-overflow warnings

2019-10-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Arnd Bergmann needs to sign off. WARNING: Unexpected sign-offs from developers who a

Re: [ovs-dev] [PATCH 2/5] datapath: change type of UPCALL_PID attribute to NLA_UNSPEC

2019-10-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Li RongQing needs to sign off. WARNING: Unexpected sign-offs from developers who are

Re: [ovs-dev] [PATCH 3/5] compat: remove the incorrect mtu limit for erspan

2019-10-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Haishuang Yan needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH 4/5] datapath: rename flow_stats to sw_flow_stats

2019-10-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Pablo Neira Ayuso needs to sign off. WARNING: Unexpected sign-offs from developers w

Re: [ovs-dev] [PATCH] Fix "the the" typo in two places.

2019-10-09 Thread Gregory Rose
On 10/9/2019 2:30 PM, Ben Pfaff wrote: Signed-off-by: Ben Pfaff --- Documentation/topics/testing.rst | 2 +- acinclude.m4 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst index 6c9

Re: [ovs-dev] [PATCH] Fix "the the" typo in two places.

2019-10-09 Thread Ben Pfaff
On Wed, Oct 09, 2019 at 03:40:55PM -0700, Gregory Rose wrote: > > On 10/9/2019 2:30 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > Documentation/topics/testing.rst | 2 +- > > acinclude.m4 | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > >

Re: [ovs-dev] [PATCH] tests: Allow valgrind check for afxdp testsuite.

2019-10-09 Thread William Tu
On Wed, Oct 09, 2019 at 11:20:00AM -0700, Ben Pfaff wrote: > On Wed, Oct 09, 2019 at 04:36:49PM +0200, Ilya Maximets wrote: > > New 'make' target 'check-afxdp-valgrind'. > > > > Signed-off-by: Ilya Maximets > > Makes sense to me. I did not test it. > > Acked-by: Ben Pfaff Thanks, I tested th

[ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-10-09 Thread amginwal
From: Aliasgar Ginwala Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for ovn-nbctl and ovn-sbctl respectively where user can set any single supported option. e.g export OVN_NBCTL_OPTIONS=--no-leader-only. Above env var OVN_NBCTL_OPTIONS have no effect if user runs command as ovn-n

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-09 Thread aginwala
Thanks Ben and Han. As suggested, I used env vars OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS and sent the new patch @ https://patchwork.ozlabs.org/patch/1174211/. PTAL. On Fri, Oct 4, 2019 at 10:39 AM Ben Pfaff wrote: > OK. > > I've made the points that I consider relevant. I'll let the rest of th

Re: [ovs-dev] [PATCH] appveyor: Update OpenSSL link and python3 to path

2019-10-09 Thread William Tu
On Wed, Oct 09, 2019 at 09:44:14AM -0700, Ben Pfaff wrote: > On Wed, Oct 09, 2019 at 05:10:08PM +0300, Alin Gabriel Serdean wrote: > > This patch fixes the appveyor build by adding the python version 3 to path > > as per: > > https://www.appveyor.com/docs/windows-images-software/#python > > > > We

Re: [ovs-dev] [PATCH 0/1] Encap & Decap actions for MPLS Packet Type

2019-10-09 Thread Martin Varghese
On Wed, Oct 09, 2019 at 11:31:44AM -0700, Ben Pfaff wrote: > On Tue, Oct 08, 2019 at 08:13:16AM +0530, Martin Varghese wrote: > > The existing PUSH MPLS & POP MPLS actions inserts & removes MPLS header > > between ethernet header and the IP header. Though this behaviour is fine > > for L3 VPN where

[ovs-dev] [PATCH ovn v1] utilities: add ovn-sim

2019-10-09 Thread Flavio Fernandes
Adding a wrapper to ovs-sim called ovn-sim, which re-introduces the primitives for OVN in the simulator that were lost as part of the ovn-org/ovn split. Also resurrected the man page used to document ovn-sim usage. Lastly, there were some leftover ovs-sim references that were not proper. This pat

Re: [ovs-dev] [PATCH ovn v1] utilities: add ovn-sim

2019-10-09 Thread 0-day Robot
Bleep bloop. Greetings Flavio Fernandes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #160 FILE: Documentation/ref/

Re: [ovs-dev] [PATCH] ofproto: Fix for frequent invalidation of mega flows for push actions

2019-10-09 Thread Vishal Deep Ajmera via dev
> Thanks, applied to master. Thanks Ben. Warm Regards, Vishal Ajmera ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev