Re: [ovs-dev] [PATCH V1] Add offload packets statistics

2019-10-15 Thread zhaozhanxu
Thanks for your advise, I modified the parameters form 'uint64_t packet_count' and 'uint64_t byte_count' to 'struct pkts_stats'. New commit: https://mail.openvswitch.org/pipermail/ovs-dev/2019-October/363518.html At 2019-10-15 03:15:55, "Ben Pfaff" wrote: >On Fri, Oct 11, 2019 at 11:46:29AM +0

[ovs-dev] [PATCH] AUTHORS: Add Alessandro Pilotti.

2019-10-15 Thread Alin Gabriel Serdean
Signed-off-by: Alin Gabriel Serdean --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index 443bb0ba2..480611a1f 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -34,6 +34,7 @@ Name Email Aaron Conole ac

[ovs-dev] [dpdk-latest PATCH] netdev-dpdk: add custom vhost statistics to count IRQs

2019-10-15 Thread Eelco Chaudron
When the dpdk vhost library executes an eventfd_write() call, i.e. waking up the guest, a new callback will be called. This patch adds the callback to count the number of interrupts sent to the VM to track the number of times interrupts where generated. This might be of interest to find out syste

Re: [ovs-dev] [PATCHv3] netdev-linux: Detect numa node id.

2019-10-15 Thread Eelco Chaudron
See some comment below… On 2 Oct 2019, at 22:26, William Tu wrote: The patch detects the numa node id from the name of the netdev, by reading the '/sys/class/net//device/numa_node'. If not available, ex: virtual device, or any error happens, return numa id 0. Currently only the afxdp netdev ty

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Track vhost tx contention.

2019-10-15 Thread Eelco Chaudron
On 13 Oct 2019, at 17:55, David Marchand wrote: Add a coverage counter to help diagnose contention on the vhost txqs. This is seen as dropped packets on the physical ports for rates that are usually handled fine by OVS. Document how to further debug this contention with perf. Signed-off-by:

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Track vhost tx contention.

2019-10-15 Thread Ilya Maximets
On 14.10.2019 20:04, Aaron Conole wrote: David Marchand writes: Add a coverage counter to help diagnose contention on the vhost txqs. This is seen as dropped packets on the physical ports for rates that are usually handled fine by OVS. Document how to further debug this contention with perf.

Re: [ovs-dev] [PATCH v2 1/2] sparse: Get rid of obsolete rte_flow header.

2019-10-15 Thread Stokes, Ian
On 10/3/2019 7:15 PM, David Marchand wrote: On Thu, Oct 3, 2019 at 8:12 PM David Marchand wrote: This header had been copied to cope with issues on the dpdk side. Now that the problems have been fixed [1], let's drop this file as it is now out of sync with dpdk. 1: https://git.dpdk.org/dpd

Re: [ovs-dev] [PATCH v2 2/2] travis: Switch to dpdk master branch.

2019-10-15 Thread Stokes, Ian
On 10/3/2019 7:11 PM, David Marchand wrote: Make this branch point to current dpdk master branch so that we can track API breakage. Signed-off-by: David Marchand --- Changelog since v1: - since building DPDK is controlled by either setting DPDK or DPDK_SHARED variables, we can set DPDK_VE

Re: [ovs-dev] [PATCH v2 2/2] travis: Switch to dpdk master branch.

2019-10-15 Thread Ilya Maximets
On 15.10.2019 14:59, Stokes, Ian wrote: On 10/3/2019 7:11 PM, David Marchand wrote: Make this branch point to current dpdk master branch so that we can track API breakage. Signed-off-by: David Marchand --- Changelog since v1: - since building DPDK is controlled by either setting DPDK or DPDK

Re: [ovs-dev] [PATCH v2 1/2] sparse: Get rid of obsolete rte_flow header.

2019-10-15 Thread Ilya Maximets
On 10/3/2019 7:15 PM, David Marchand wrote: On Thu, Oct 3, 2019 at 8:12 PM David Marchand wrote: This header had been copied to cope with issues on the dpdk side. Now that the problems have been fixed [1], let's drop this file as it is now out of sync with dpdk. 1: https://git.dpdk.org/dpdk/

Re: [ovs-dev] [PATCH] Documentation: Convert multiple manpages to ReST.

2019-10-15 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Oct 10, 2019 at 07:58:02PM -0400, 0-day Robot wrote: >> WARNING: New doc ovs-appctl.8.rst not listed in Documentation/automake.mk >> WARNING: New doc ovs-ctl.8.rst not listed in Documentation/automake.mk >> WARNING: New doc ovs-l3ping.8.rst not listed in Documentation/

Re: [ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-15 Thread Kevin Traynor
On 21/09/2019 03:40, Sriram Vatala wrote: > From: Ilya Maximets > > This is yet another refactoring for upcoming detailed drop stats. > It allowes to use single function for all the software calculated > statistics in netdev-dpdk for both vhost and ETH ports. > > UINT64_MAX used as a marker for

Re: [ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-15 Thread Kevin Traynor
With corrected email for Ilya. On 15/10/2019 14:33, Kevin Traynor wrote: > On 21/09/2019 03:40, Sriram Vatala wrote: >> From: Ilya Maximets >> >> This is yet another refactoring for upcoming detailed drop stats. >> It allowes to use single function for all the software calculated >> statistics in

Re: [ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-15 Thread Ilya Maximets
On 15.10.2019 15:35, Kevin Traynor wrote: With corrected email for Ilya. On 15/10/2019 14:33, Kevin Traynor wrote: On 21/09/2019 03:40, Sriram Vatala wrote: From: Ilya Maximets This is yet another refactoring for upcoming detailed drop stats. It allowes to use single function for all the sof

Re: [ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-15 Thread Kevin Traynor
On 15/10/2019 14:43, Ilya Maximets wrote: > On 15.10.2019 15:35, Kevin Traynor wrote: >> With corrected email for Ilya. >> >> On 15/10/2019 14:33, Kevin Traynor wrote: >>> On 21/09/2019 03:40, Sriram Vatala wrote: From: Ilya Maximets This is yet another refactoring for upcoming deta

Re: [ovs-dev] [PATCH v2 2/2] travis: Switch to dpdk master branch.

2019-10-15 Thread Stokes, Ian
On 10/15/2019 2:04 PM, Ilya Maximets wrote: On 15.10.2019 14:59, Stokes, Ian wrote: On 10/3/2019 7:11 PM, David Marchand wrote: Make this branch point to current dpdk master branch so that we can track API breakage. Signed-off-by: David Marchand --- Changelog since v1: - since building DP

Re: [ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-15 Thread Sriram Vatala via dev
-Original Message- From: Kevin Traynor Sent: 15 October 2019 19:21 To: Ilya Maximets ; Sriram Vatala ; ovs-dev@openvswitch.org Subject: Re: [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats. On 15/10/2019 14:43, Ilya Maximets wrote: > On 15.10.2019 15:35, Kevin

Re: [ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-15 Thread Ilya Maximets
On 15.10.2019 17:32, Sriram Vatala wrote: -Original Message- From: Kevin Traynor Sent: 15 October 2019 19:21 To: Ilya Maximets ; Sriram Vatala ; ovs-dev@openvswitch.org Subject: Re: [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats. On 15/10/2019 14:43, Ilya Max

Re: [ovs-dev] [PATCH v9 1/2] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

2019-10-15 Thread Kevin Traynor
On 15/10/2019 16:42, Ilya Maximets wrote: > On 15.10.2019 17:32, Sriram Vatala wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: 15 October 2019 19:21 >> To: Ilya Maximets ; Sriram Vatala >> ; ovs-dev@openvswitch.org >> Subject: Re: [PATCH v9 1/2] netdev-dpdk: Reuse vhost functi

[ovs-dev] [PATCH] tests: Get rid of timeout options for control utilities.

2019-10-15 Thread Ilya Maximets
'OVS_CTL_TIMEOUT' environment variable is exported in tests/atlocal.in and controls timeouts for all OVS utilities in testsuite. There should be no manual tweaks for each single command. This helps with running tests under valgrind where commands could take really long time as you only need to ch

Re: [ovs-dev] [PATCH] tests: Get rid of timeout options for control utilities.

2019-10-15 Thread Yifeng Sun
Looks good to me, thanks. Reviewed-by: Yifeng Sun On Tue, Oct 15, 2019 at 9:11 AM Ilya Maximets wrote: > > 'OVS_CTL_TIMEOUT' environment variable is exported in tests/atlocal.in > and controls timeouts for all OVS utilities in testsuite. > > There should be no manual tweaks for each single comm

Re: [ovs-dev] [PATCH 00/11] Backport upstream conntrack related patches

2019-10-15 Thread Ben Pfaff
On Mon, Oct 14, 2019 at 10:37:40AM -0700, Yi-Hung Wei wrote: > This series backports conntrack related patches from upstream kernel. > It has been tested on > * Ubuntu 14.04, 16.04, and 18.04. > * RHEL 7.4-7.6. > * 5.0 kernel. Yi-Hung, I think that you've received acks on all of these.

Re: [ovs-dev] [PATCH] tests: Get rid of timeout options for control utilities.

2019-10-15 Thread Ben Pfaff
On Tue, Oct 15, 2019 at 06:10:35PM +0200, Ilya Maximets wrote: > 'OVS_CTL_TIMEOUT' environment variable is exported in tests/atlocal.in > and controls timeouts for all OVS utilities in testsuite. > > There should be no manual tweaks for each single command. > > This helps with running tests under

Re: [ovs-dev] [PATCH] AUTHORS: Add Alessandro Pilotti.

2019-10-15 Thread Ben Pfaff
On Tue, Oct 15, 2019 at 01:15:02PM +0300, Alin Gabriel Serdean wrote: > Signed-off-by: Alin Gabriel Serdean Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1] ovs container build.sh requires python3

2019-10-15 Thread Ben Pfaff
Done. Does it make sense for this to be in both repos? On Mon, Oct 14, 2019 at 07:48:14PM -0700, aginwala wrote: > Hi Ben: > > Can you also push this to OVS master? Got it merged in ovn repo already. > > On Fri, Oct 11, 2019 at 2:06 PM wrote: > > > From: Aliasgar Ginwala > > > > building ovn

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-10-15 Thread Ben Pfaff
On Mon, Oct 14, 2019 at 07:45:11PM -0700, aginwala wrote: > On Mon, Oct 14, 2019 at 4:38 PM Ben Pfaff wrote: > > > On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote: > > > On Wed, Oct 09, 2019 at 04:56:40PM -0700, amgin...@gmail.com wrote: > > > > From: Aliasgar Ginwala > > > > > > > > A

[ovs-dev] [PATCH v2 00/12] Backport upstream conntrack related patches

2019-10-15 Thread Yi-Hung Wei
This series backports conntrack related patches from upstream kernel. It has been tested on * Ubuntu 14.04, 16.04, and 18.04. * RHEL 7.4-7.6. * 5.0 kernel. Travis test: https://travis-ci.org/YiHungWei/ovs/builds/596361660 v1->v2: - Fix commit message in one patch as noted by Yife

[ovs-dev] [PATCH v2 01/12] datapath: Fix linking without CONFIG_NF_CONNTRACK_LABELS

2019-10-15 Thread Yi-Hung Wei
From: Arnd Bergmann upstream commit: commit a277d516de5f498c91d91189717ef7e01102ad27 Author: Arnd Bergmann Date: Fri Nov 2 16:36:55 2018 +0100 openvswitch: fix linking without CONFIG_NF_CONNTRACK_LABELS When CONFIG_CC_OPTIMIZE_FOR_DEBUGGING is enabled, the compiler fails to optim

[ovs-dev] [PATCH v2 02/12] datapath: Replace nf_ct_invert_tuplepr() with nf_ct_invert_tuple()

2019-10-15 Thread Yi-Hung Wei
After upstream net-next commit 303e0c558959 ("netfilter: conntrack: avoid unneeded nf_conntrack_l4proto lookups") nf_ct_invert_tuplepr() is no longer available in the kernel. Ideally, we should be in sync with upstream kernel by calling nf_ct_invert_tuple() directly in conntrack.c. However, nf_ct

[ovs-dev] [PATCH v2 03/12] datapath: Detect upstream nf_nat change

2019-10-15 Thread Yi-Hung Wei
The following two upstream commits merge nf_nat_ipv4 and nf_nat_ipv6 into nf_nat core, and move some header files around. To handle these modifications, this patch detects the upstream changes, uses the header files and config symbols properly. Ideally, we should replace CONFIG_NF_NAT_IPV4 and CO

[ovs-dev] [PATCH v2 04/12] datapath: add seqadj extension when NAT is used.

2019-10-15 Thread Yi-Hung Wei
From: Flavio Leitner upstream patch: commit fa7e428c6b7ed3281610511a2b2ec716d9894be8 Author: Flavio Leitner Date: Mon Mar 25 15:58:31 2019 -0300 openvswitch: add seqadj extension when NAT is used. When the conntrack is initialized, there is no helper attached yet so the nat info

[ovs-dev] [PATCH v2 05/12] datapath: Handle NF_NAT_NEEDED replacement

2019-10-15 Thread Yi-Hung Wei
Starting from the following upstream commit, NF_NAT_NEEDED is replaced by IS_ENABLED(CONFIG_NF_NAT) in the upstream kernel. This patch makes some changes so that our in tree ovs kernel module is compatible to both old and new kernels. Upstream commit: commit 4806e975729f99c7908d1688a143f1e16d464e6

[ovs-dev] [PATCH v2 07/12] datapath: genetlink: optionally validate strictly/dumps

2019-10-15 Thread Yi-Hung Wei
This patch backports the following upstream commit within the openvswitch kernel module with some checks so that it also works in the older kernel. Upstream commit: commit ef6243acb4782df587a4d7d6c310fa5b5d82684b Author: Johannes Berg Date: Fri Apr 26 14:07:31 2019 +0200 genetlink: optiona

[ovs-dev] [PATCH v2 06/12] datapath: Use nla_nest_start_noflag()

2019-10-15 Thread Yi-Hung Wei
This patch backports the openvswitch changes and update the compat layer for the following upstream patch. commit ae0be8de9a53cda3505865c11826d8ff0640237c Author: Michal Kubecek Date: Fri Apr 26 11:13:06 2019 +0200 netlink: make nla_nest_start() add NLA_F_NESTED flag Even if the NLA_F

[ovs-dev] [PATCH v2 08/12] datapath: Load and reference the NAT helper.

2019-10-15 Thread Yi-Hung Wei
This commit backports the following upstream commit, and two functions in nf_conntrack_helper.h. Upstream commit: commit fec9c271b8f1bde1086be5aa415cdb586e0dc800 Author: Flavio Leitner Date: Wed Apr 17 11:46:17 2019 -0300 openvswitch: load and reference the NAT helper. This improves t

[ovs-dev] [PATCH v2 10/12] datapath: Replace removed NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT)

2019-10-15 Thread Yi-Hung Wei
Backports the following upstream commit with some backward compatibility change. commit f319ca6557c10a711facc4dd60197470796d3ec1 Author: Geert Uytterhoeven Date: Wed May 8 08:52:32 2019 +0200 openvswitch: Replace removed NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT) Commit 4806e975729f

[ovs-dev] [PATCH v2 09/12] datapath: Check for null pointer return from nla_nest_start_noflag

2019-10-15 Thread Yi-Hung Wei
From: Colin Ian King upstream commit: commit ca96534630e2edfd73121c487c957b17eca3b7d7 Author: Colin Ian King Date: Wed May 1 14:41:58 2019 +0100 openvswitch: check for null pointer return from nla_nest_start_noflag The call to nla_nest_start_noflag can return null in the unlikely

[ovs-dev] [PATCH v2 11/12] datapath: Fix log message in ovs conntrack

2019-10-15 Thread Yi-Hung Wei
Upstream commit: commit 12c6bc38f99bb168b7f16bdb5e855a51a23ee9ec Author: Yi-Hung Wei Date: Wed Aug 21 17:16:10 2019 -0700 openvswitch: Fix log message in ovs conntrack Fixes: 06bd2bdf19d2 ("openvswitch: Add timeout support to ct action") Signed-off-by: Yi-Hung Wei Signed-off-b

[ovs-dev] [PATCH v2 12/12] datapath: Allow attaching helper in later commit

2019-10-15 Thread Yi-Hung Wei
Upstream commit: commit 248d45f1e1934f7849fbdc35ef1e57151cf063eb Author: Yi-Hung Wei Date: Fri Oct 4 09:26:44 2019 -0700 openvswitch: Allow attaching helper in later commit This patch allows to attach conntrack helper to a confirmed conntrack entry. Currently, we can only attach a

Re: [ovs-dev] [PATCH 00/11] Backport upstream conntrack related patches

2019-10-15 Thread Yi-Hung Wei
On Tue, Oct 15, 2019 at 10:18 AM Ben Pfaff wrote: > > On Mon, Oct 14, 2019 at 10:37:40AM -0700, Yi-Hung Wei wrote: > > This series backports conntrack related patches from upstream kernel. > > It has been tested on > > * Ubuntu 14.04, 16.04, and 18.04. > > * RHEL 7.4-7.6. > > * 5.0 ker

Re: [ovs-dev] [PATCH v2 01/12] datapath: Fix linking without CONFIG_NF_CONNTRACK_LABELS

2019-10-15 Thread Yifeng Sun
LGTM. Reviewed-by: Yifeng Sun On Tue, Oct 15, 2019 at 10:40 AM Yi-Hung Wei wrote: > > From: Arnd Bergmann > > upstream commit: > commit a277d516de5f498c91d91189717ef7e01102ad27 > Author: Arnd Bergmann > Date: Fri Nov 2 16:36:55 2018 +0100 > > openvswitch: fix linking without CONFIG_NF_C

Re: [ovs-dev] [PATCH v1] ovs container build.sh requires python3

2019-10-15 Thread Ginwala, Aliasgar via dev
Thanks Ben: Yes ovs container build script is for ovs and similar for ovn; as user just using ovs in containers don't need to clone/use ovn stuff and vice versa. Regards, Aliasgar From: Ben Pfaff Sent: Tuesday, October 15, 2019 9:17 AM To: aginwala Cc: aginwal

Re: [ovs-dev] [PATCH v2 01/12] datapath: Fix linking without CONFIG_NF_CONNTRACK_LABELS

2019-10-15 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Arnd Bergmann needs to sign off. WARNING: Unexpected sign-offs from developers wh

Re: [ovs-dev] [PATCH 1/5] datapath: hide clang frame-overflow warnings

2019-10-15 Thread Yi-Hung Wei
On Wed, Oct 9, 2019 at 2:23 PM Greg Rose wrote: > > From: Arnd Bergmann > > Upstream commit: > commit 260637903f47f20c5918bb5c1eea52b2a28ea863 > Author: Arnd Bergmann > Date: Mon Jul 22 17:00:01 2019 +0200 > > ovs: datapath: hide clang frame-overflow warnings > > Some funct

Re: [ovs-dev] [PATCH 2/5] datapath: change type of UPCALL_PID attribute to NLA_UNSPEC

2019-10-15 Thread Yi-Hung Wei
On Wed, Oct 9, 2019 at 2:24 PM Greg Rose wrote: > > From: Li RongQing > > Upstream commit: > commit ea8564c865299815095bebeb4b25bef474218e4c > Author: Li RongQing > Date: Tue Sep 24 19:11:52 2019 +0800 > > openvswitch: change type of UPCALL_PID attribute to NLA_UNSPEC > > u

Re: [ovs-dev] [PATCH 3/5] compat: remove the incorrect mtu limit for erspan

2019-10-15 Thread Yi-Hung Wei
On Wed, Oct 9, 2019 at 2:25 PM Greg Rose wrote: > > From: Haishuang Yan > > Upstream commit: > commit 0e141f757b2c78c983df893e9993313e2dc21e38 > Author: Haishuang Yan > Date: Fri Sep 27 14:58:20 2019 +0800 > > erspan: remove the incorrect mtu limit for erspan > > erspan dri

Re: [ovs-dev] [PATCH v2 04/12] datapath: add seqadj extension when NAT is used.

2019-10-15 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Flavio Leitner needs to sign off. WARNING: Unexpected sign-offs from developers w

Re: [ovs-dev] [PATCH v2 05/12] datapath: Handle NF_NAT_NEEDED replacement

2019-10-15 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Florian Westphal needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH v2 06/12] datapath: Use nla_nest_start_noflag()

2019-10-15 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Michal Kubecek needs to sign off. WARNING: Unexpected sign-offs from developers w

Re: [ovs-dev] [PATCH v2 07/12] datapath: genetlink: optionally validate strictly/dumps

2019-10-15 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Johannes Berg needs to sign off. WARNING: Unexpected sign-offs from developers wh

Re: [ovs-dev] [PATCH 4/5] datapath: rename flow_stats to sw_flow_stats

2019-10-15 Thread Yi-Hung Wei
On Wed, Oct 9, 2019 at 2:25 PM Greg Rose wrote: > > From: Pablo Neira Ayuso > > Upstream commit: > commit aef833c58d321f09ae4ce4467723542842ba9faf > Author: Pablo Neira Ayuso > Date: Fri Jul 19 18:20:13 2019 +0200 > > net: openvswitch: rename flow_stats to sw_flow_stats > >

Re: [ovs-dev] [PATCH 5/5] datapath: compat: drop bridge nf reset from nf_reset

2019-10-15 Thread Yi-Hung Wei
On Wed, Oct 9, 2019 at 2:25 PM Greg Rose wrote: > > Upstream commmit: > commit 895b5c9f206eb7d25dc1360a8ccfc5958895eb89 > Author: Florian Westphal > Date: Sun Sep 29 20:54:03 2019 +0200 > > netfilter: drop bridge nf reset from nf_reset > > commit 174e23810cd31 > ("sk_buf

Re: [ovs-dev] [PATCH v2 08/12] datapath: Load and reference the NAT helper.

2019-10-15 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Flavio Leitner needs to sign off. WARNING: Unexpected sign-offs from developers w

Re: [ovs-dev] [PATCH v2 09/12] datapath: Check for null pointer return from nla_nest_start_noflag

2019-10-15 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Colin Ian King needs to sign off. WARNING: Unexpected sign-offs from developers w

Re: [ovs-dev] [PATCH v2 10/12] datapath: Replace removed NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT)

2019-10-15 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Geert Uytterhoeven needs to sign off. WARNING: Unexpected sign-offs from develope

Re: [ovs-dev] [PATCH 5/5] datapath: compat: drop bridge nf reset from nf_reset

2019-10-15 Thread Gregory Rose
On 10/15/2019 11:23 AM, Yi-Hung Wei wrote: On Wed, Oct 9, 2019 at 2:25 PM Greg Rose wrote: Upstream commmit: commit 895b5c9f206eb7d25dc1360a8ccfc5958895eb89 Author: Florian Westphal Date: Sun Sep 29 20:54:03 2019 +0200 netfilter: drop bridge nf reset from nf_reset

[ovs-dev] [PATCH] ovsdb-server: Allow replication from older schema version servers.

2019-10-15 Thread nusiddiq
From: Numan Siddique Presently, replication is not allowed if there is a schema version mismatch between the schema returned by the active ovsdb-server and the local db schema. This is causing failures in OVN DB HA deployments during uprades. In the case of OpenStack tripleo deployment with OVN

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Gregory Rose
On 10/11/2019 2:49 PM, Yifeng Sun wrote: This patch provides essential fixes for OVS to support RHEL7.7's new kernel. make rpm-fedora-kmod \ RPMBUILD_OPT='-D "kversion 3.10.0-1062.1.2.el7.x86_64"' Signed-off-by: Yifeng Sun Hi Yifeng, I'm trying to test this patch on a RHEL 7.7 system but i

Re: [ovs-dev] [PATCH] AUTHORS: Add Alessandro Pilotti.

2019-10-15 Thread Alin Gabriel Serdean
> On 15 Oct 2019, at 19:14, Ben Pfaff wrote: > > On Tue, Oct 15, 2019 at 01:15:02PM +0300, Alin Gabriel Serdean wrote: >> Signed-off-by: Alin Gabriel Serdean > > Acked-by: Ben Pfaff Thanks! Applied on master. ___ dev mailing list d...@openvswitch

Re: [ovs-dev] [PATCH net-next v3 00/10] optimize openvswitch flow looking up

2019-10-15 Thread Gregory Rose
On 10/11/2019 7:00 AM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang This series patch optimize openvswitch for performance or simplify codes. Patch 1, 2, 4: Port Pravin B Shelar patches to linux upstream with little changes. Patch 5, 6, 7: Optimize the flow looking up and simplify the

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Expose datapath capability to ovsdb.

2019-10-15 Thread Gregory Rose
On 10/4/2019 3:32 PM, William Tu wrote: The patch adds support for fetching the datapath's capabilities from the result of 'check_support()', and write the supported capability to a new database column, called 'capabilities' under Datapath table. To see how it works, run: # ovs-vsctl -- add-

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Ben Pfaff
On Tue, Oct 15, 2019 at 12:28:21PM -0700, Gregory Rose wrote: > > On 10/11/2019 2:49 PM, Yifeng Sun wrote: > > This patch provides essential fixes for OVS to support > > RHEL7.7's new kernel. > > > > make rpm-fedora-kmod \ > > RPMBUILD_OPT='-D "kversion 3.10.0-1062.1.2.el7.x86_64"' > > > > Signe

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Yifeng Sun
Hi Greg, Please try the following: # yum install scl-utils scl-utils-build # yum install rh-python36 # scl enable rh-python36 bash # pip install sphinx Thanks, Yifeng On Tue, Oct 15, 2019 at 12:28 PM Gregory Rose wrote: > > > On 10/11/2019 2:49 PM, Yifeng Sun wrote: > > This patch provides ess

[ovs-dev] [PATCH] configure: Properly handle case where libunwind.h is not available.

2019-10-15 Thread Yi-Hung Wei
It is possible that user install libunwind but not libunwind-devel, and it will run into a compilation error. So check the existence of the header file instead of the library. Fixes: e2ed6fbeb18c ("fatal-signal: Catch SIGSEGV and print backtrace.") Signed-off-by: Yi-Hung Wei --- m4/openvswitch.

Re: [ovs-dev] [PATCH] ovsdb-server: Allow replication from older schema version servers.

2019-10-15 Thread Ben Pfaff
On Wed, Oct 16, 2019 at 12:20:48AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Presently, replication is not allowed if there is a schema version mismatch > between > the schema returned by the active ovsdb-server and the local db schema. This > is > causing failures in OVN DB

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Gregory Rose
On 10/15/2019 10:57 AM, Ben Pfaff wrote: On Tue, Oct 15, 2019 at 12:28:21PM -0700, Gregory Rose wrote: On 10/11/2019 2:49 PM, Yifeng Sun wrote: This patch provides essential fixes for OVS to support RHEL7.7's new kernel. make rpm-fedora-kmod \ RPMBUILD_OPT='-D "kversion 3.10.0-1062.1.2.el7.x8

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Gregory Rose
On 10/15/2019 2:27 PM, Yifeng Sun wrote: Hi Greg, Please try the following: # yum install scl-utils scl-utils-build # yum install rh-python36 Hi Yifeng, I tried this step but no luck. [root@localhost ~]# yum install rh-python36 -y Loaded plugins: product-id, search-disabled-repos, subscrip

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Yifeng Sun
Hi Greg, I added this repo: subscription-manager repos --enable rhel-server-rhscl-7-rpms Thanks, Yifeng On Tue, Oct 15, 2019 at 2:58 PM Gregory Rose wrote: > > > On 10/15/2019 2:27 PM, Yifeng Sun wrote: > > Hi Greg, > > > > Please try the following: > > > > # yum install scl-utils scl-utils-bu

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Ben Pfaff
On Tue, Oct 15, 2019 at 02:54:05PM -0700, Gregory Rose wrote: > > On 10/15/2019 10:57 AM, Ben Pfaff wrote: > > It's easy to figure out how to get a particular file on Fedora or RHEL, > > using "dnf provides": > > > > $ dnf provides /usr/bin/sphinx-build-3 > > python3-sphinx-1:1.8.4-1.fc

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Gregory Rose
On 10/15/2019 11:42 AM, Ben Pfaff wrote: On Tue, Oct 15, 2019 at 02:54:05PM -0700, Gregory Rose wrote: On 10/15/2019 10:57 AM, Ben Pfaff wrote: It's easy to figure out how to get a particular file on Fedora or RHEL, using "dnf provides": $ dnf provides /usr/bin/sphinx-build-3 pyth

Re: [ovs-dev] [PATCH] configure: Properly handle case where libunwind.h is not available.

2019-10-15 Thread Ben Pfaff
On Tue, Oct 15, 2019 at 02:30:48PM -0700, Yi-Hung Wei wrote: > It is possible that user install libunwind but not libunwind-devel, > and it will run into a compilation error. So check the existence > of the header file instead of the library. > > Fixes: e2ed6fbeb18c ("fatal-signal: Catch SIGSEGV

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

2019-10-15 Thread Gregory Rose
On 10/15/2019 3:02 PM, Yifeng Sun wrote: Hi Greg, I added this repo: subscription-manager repos --enable rhel-server-rhscl-7-rpms I had to install the epel-release package as well and that is fixed now. Thanks! Thanks, Yifeng On Tue, Oct 15, 2019 at 2:58 PM Gregory Rose wrote: On 1

Re: [ovs-dev] [PATCH] configure: Properly handle case where libunwind.h is not available.

2019-10-15 Thread Yi-Hung Wei
On Tue, Oct 15, 2019 at 3:25 PM Ben Pfaff wrote: > > On Tue, Oct 15, 2019 at 02:30:48PM -0700, Yi-Hung Wei wrote: > > It is possible that user install libunwind but not libunwind-devel, > > and it will run into a compilation error. So check the existence > > of the header file instead of the libr

[ovs-dev] [PATCH v1] command-line.c: Support parsing ctl options via env variable

2019-10-15 Thread amginwal
From: Aliasgar Ginwala Signed-off-by: Aliasgar Ginwala --- lib/command-line.c | 50 ++ lib/command-line.h | 3 +++ 2 files changed, 53 insertions(+) diff --git a/lib/command-line.c b/lib/command-line.c index 9e000bd28..64a84efa8 100644 --- a/lib/com

[ovs-dev] [PATCH v2 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-10-15 Thread amginwal
From: Aliasgar Ginwala Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for ovn-nbctl and ovn-sbctl respectively where user can set supported ovn-nb/sbctl options using environment variable. e.g. OVN_SBCTL_OPTIONS="--db=unix:sb1.ovsdb --no-leader-only" Signed-off-by: Aliasgar Ginwal

Re: [ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-10-15 Thread aginwala
On Tue, Oct 15, 2019 at 10:38 AM Ben Pfaff wrote: > On Mon, Oct 14, 2019 at 07:45:11PM -0700, aginwala wrote: > > On Mon, Oct 14, 2019 at 4:38 PM Ben Pfaff wrote: > > > > > On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote: > > > > On Wed, Oct 09, 2019 at 04:56:40PM -0700, amgin...@gmail