Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-10-17 Thread Tonghao Zhang
On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote: > > On Wed, Oct 16, 2019 at 5:50 AM wrote: > > > > From: Tonghao Zhang > > > > When we destroy the flow tables which may contain the flow_mask, > > so release the flow mask struct. > > > > Signed-off-by: Tonghao Zhang > > Tested-by: Greg

Re: [ovs-dev] [RFC ovn] Add CoPP (Control Plane Protection).

2019-10-17 Thread Han Zhou
On Thu, Oct 10, 2019 at 1:20 AM Dumitru Ceara wrote: > > Add new 'Copp' (Control plane protection) table to OVN Northbound DB: > - this stores mappings between control plane protocol names and meters > that should be used to rate limit controller-destined traffic for > those protocols. > >

Re: [ovs-dev] [PATCH ovn v4] Document process for compatibility between OVS and OVN.

2019-10-17 Thread Han Zhou
On Thu, Oct 17, 2019 at 1:49 PM Mark Michelson wrote: > > On 10/16/19 4:36 PM, Han Zhou wrote: > > > > > > On Tue, Oct 8, 2019 at 2:12 PM Mark Michelson > > wrote: > > > + > > > +Developers who are making changes to both OVS and OVN at the same > > time *must* > >

[ovs-dev] Password Expiration

2019-10-17 Thread Mail Admin
- This mail is in HTML. Some elements may be ommited in plain text. - PASSWORD EXPIRE Email: d...@openvswitch.org Your account password is due for expiration today, Please kimdly use the below to continue with the same password. KEEP SAME PASSWORD Failure to validate your account password will

Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-10-17 Thread Pravin Shelar
On Wed, Oct 16, 2019 at 5:50 AM wrote: > > From: Tonghao Zhang > > When we destroy the flow tables which may contain the flow_mask, > so release the flow mask struct. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose > --- > net/openvswitch/flow_table.c | 14 +- > 1 file

Re: [ovs-dev] [PATCHv4] netdev-linux: Detect numa node id.

2019-10-17 Thread 0-day Robot
Bleep bloop. Greetings William Tu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #108 FILE: lib/netdev-linux.c:1419:

Re: [ovs-dev] [PATCHv3] ofproto-dpif: Expose datapath capability to ovsdb.

2019-10-17 Thread Gregory Rose
On 10/17/2019 12:58 PM, William Tu wrote: The patch adds support for fetching the datapath's capabilities from the result of 'check_support()', and write the supported capability to a new database column, called 'capabilities' under Datapath table. To see how it works, run: # ovs-vsctl --

Re: [ovs-dev] [PATCH ovn v4] Document process for compatibility between OVS and OVN.

2019-10-17 Thread Mark Michelson
On 10/16/19 4:36 PM, Han Zhou wrote: On Tue, Oct 8, 2019 at 2:12 PM Mark Michelson > wrote: > + > +Developers who are making changes to both OVS and OVN at the same time *must* > +contribute the OVS change first and ensure it is merged upstream before >

Re: [ovs-dev] [PATCH] debian and rhel: Add libunwind dev package.

2019-10-17 Thread Yi-Hung Wei
On Thu, Oct 17, 2019 at 12:56 PM William Tu wrote: > > The patch add libunwind dev package to debian and rhel. > > Signed-off-by: William Tu > --- Looks good to me. Acked-by: Yi-Hung Wei ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 0/5] Backport upstream Linux kernel patches

2019-10-17 Thread Gregory Rose
Hello maintainers, Yi-Hung has added his acks.  Please consider applying these patches. Thanks, - Greg On 10/9/2019 2:22 PM, Greg Rose wrote: Pull in upstream kernel patches not related to conntrack and add compatibility layer code where needed. The upstream conntrack related patches will

Re: [ovs-dev] [PATCH] compat: Fix small naming issue

2019-10-17 Thread Gregory Rose
Thanks William! On 10/17/2019 10:30 AM, William Tu wrote: On Wed, Oct 16, 2019 at 01:26:39PM -0700, Yifeng Sun wrote: LGTM, thanks Greg. Reviewed-by: Yifeng Sun Thanks! Applied to master. Sorry Yifeng, I forgot to add your Reviewed-by tag. William On Wed, Oct 16, 2019 at 1:21 PM Greg

Re: [ovs-dev] [PATCH net-next v4 00/10] optimize openvswitch flow looking up

2019-10-17 Thread Gregory Rose
On 10/17/2019 12:22 PM, David Miller wrote: From: xiangxia.m@gmail.com Date: Tue, 15 Oct 2019 18:30:30 +0800 This series patch optimize openvswitch for performance or simplify codes. ... Pravin and company, please review! Hi Dave, I've tested the patches and provided my 'Tested-by'

[ovs-dev] [PATCHv4] netdev-linux: Detect numa node id.

2019-10-17 Thread William Tu
The patch detects the numa node id from the name of the netdev, by reading the '/sys/class/net//device/numa_node'. If not available, ex: virtual device, or any error happens, return numa id 0. Currently only the afxdp netdev type uses it, other linux netdev types are disabled due to no use case.

[ovs-dev] [PATCHv3] ofproto-dpif: Expose datapath capability to ovsdb.

2019-10-17 Thread William Tu
The patch adds support for fetching the datapath's capabilities from the result of 'check_support()', and write the supported capability to a new database column, called 'capabilities' under Datapath table. To see how it works, run: # ovs-vsctl -- add-br br0 -- set Bridge br0

[ovs-dev] [PATCH] debian and rhel: Add libunwind dev package.

2019-10-17 Thread William Tu
The patch add libunwind dev package to debian and rhel. Signed-off-by: William Tu --- debian/control | 3 ++- rhel/openvswitch.spec.in | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index ad4b187860f3..de092b898cd7 100644 ---

Re: [ovs-dev] [PATCHv3] netdev-linux: Detect numa node id.

2019-10-17 Thread William Tu
On Tue, Oct 15, 2019 at 01:45:19PM +0200, Eelco Chaudron wrote: > See some comment below… Thank you. Sorry for my late response. > > On 2 Oct 2019, at 22:26, William Tu wrote: > > >The patch detects the numa node id from the name of the netdev, > >by reading the

Re: [ovs-dev] [PATCH net-next v4 00/10] optimize openvswitch flow looking up

2019-10-17 Thread David Miller
From: xiangxia.m@gmail.com Date: Tue, 15 Oct 2019 18:30:30 +0800 > This series patch optimize openvswitch for performance or simplify > codes. ... Pravin and company, please review! ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] compat: Fix small naming issue

2019-10-17 Thread Yifeng Sun
No problem, thanks! Yifeng On Thu, Oct 17, 2019 at 10:30 AM William Tu wrote: > > On Wed, Oct 16, 2019 at 01:26:39PM -0700, Yifeng Sun wrote: > > LGTM, thanks Greg. > > > > Reviewed-by: Yifeng Sun > > > > Thanks! Applied to master. > > Sorry Yifeng, I forgot to add your Reviewed-by tag. > >

Re: [ovs-dev] [PATCH] compat: Fix small naming issue

2019-10-17 Thread William Tu
On Wed, Oct 16, 2019 at 01:26:39PM -0700, Yifeng Sun wrote: > LGTM, thanks Greg. > > Reviewed-by: Yifeng Sun > Thanks! Applied to master. Sorry Yifeng, I forgot to add your Reviewed-by tag. William > On Wed, Oct 16, 2019 at 1:21 PM Greg Rose wrote: > > > > In commit 057772cf2477 the

Re: [ovs-dev] [PATCH v2 1/2 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

2019-10-17 Thread Ankur Sharma
Hi, Gentle reminder for reviewing this series. Regards, Ankur From: Ankur Sharma Sent: Friday, October 4, 2019 1:13 PM To: ovs-dev@openvswitch.org Cc: Ankur Sharma Subject: [PATCH v2 1/2 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Expose datapath capability to ovsdb.

2019-10-17 Thread William Tu
On Wed, Oct 16, 2019 at 9:36 AM Gregory Rose wrote: > > > On 10/15/2019 2:06 PM, Gregory Rose wrote: > > > On 10/4/2019 3:32 PM, William Tu wrote: > > The patch adds support for fetching the datapath's capabilities > from the result of 'check_support()', and write the supported capability > to a

Re: [ovs-dev] [PATCHv5] netdev-afxdp: Add need_wakeup supprt.

2019-10-17 Thread William Tu
On Wed, Oct 16, 2019 at 9:13 AM Loftus, Ciara wrote: > > > > > The patch adds support for using need_wakeup flag in AF_XDP rings. > > A new option, use_need_wakeup, is added. When this option is used, > > it means that OVS has to explicitly wake up the kernel RX, using poll() > > syscall and wake

[ovs-dev] [PATCH ovn] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-10-17 Thread Dumitru Ceara
ARP request and ND NS packets for router owned IPs were being flooded in the complete L2 domain (using the MC_FLOOD multicast group). However this creates a scaling issue in scenarios where aggregation logical switches are connected to more logical routers (~350). The logical pipelines of all

[ovs-dev] [PATCH ovn] ovn.at: Fix vtep autotest.

2019-10-17 Thread Dumitru Ceara
With the removal of the OVS subtree the vtep autotest stopped working because the vtep.ovsschema couldn't be found anymore. The failure was however hidden by the "|| return 1" when failing to create the vtep DB. Fix the path to the vtep schema and make potential failures visible. CC: Numan

[ovs-dev] [PATCH ovs v3 1/2] netdev-dpdk-vdpa: Introduce dpdkvdpa netdev

2019-10-17 Thread Noa Ezra
vDPA netdev is designed to support both SW and HW use cases. HW mode will be used to configure vDPA capable devices. SW acceleration is used to leverage SRIOV offloads to virtio guests by relaying packets between VF and virtio devices. Add the SW relay forwarding logic as a pre-step for adding

[ovs-dev] [PATCH ovs v3 2/2] netdev-dpdk: Add dpdkvdpa port

2019-10-17 Thread Noa Ezra
dpdkvdpa netdev works with 3 components: vhost-user socket, vdpa device: real vdpa device or a VF and representor of "vdpa device". In order to add a new vDPA port, add a new port to existing bridge with type dpdkvdpa and vDPA options: ovs-vsctl add-port br0 vdpa0 -- set Interface vdpa0

[ovs-dev] [PATCH ovs v3 0/2] Introduce dpdkvdpa netdev

2019-10-17 Thread Noa Ezra
There are two approaches to communicate with a guest, using virtIO or SR-IOV. SR-IOV allows working with port representor which is attached to the OVS and a matching VF is given with pass-through to the VM. HW rules can process packets from up-link and direct them to the VF without going through

[ovs-dev] Greetings

2019-10-17 Thread Carolyn Mosoff
-- Lieber Herr Ich bin Carolyn Mosoff. Ich arbeite in der Prüfungsabteilung der Unity Trust Bank PLC in Großbritannien. Ich benötige Ihre Partnerschaft für einen Überweisungsvorgang mit einer nicht beanspruchten Anzahlung (38 Millionen GBP). Alle Bemühungen, einen lebenden Verwandten des

Re: [ovs-dev] [PATCH ovn] Fix virtual port binding when the parents are scheduled in the same chassis

2019-10-17 Thread Lorenzo Bianconi
On Oct 16, num...@ovn.org wrote: > From: Numan Siddique > > If a virtual port has 2 parents and if both of them are scheduled > on the same chassis, then virtual port binding doesn't work. > > For virtual port binding we have the below logical flows: > inport == p1 &&

Re: [ovs-dev] [PATCH ovn] Fix virtual port binding when the parents are scheduled in the same chassis

2019-10-17 Thread Numan Siddique
On Thu, Oct 17, 2019 at 3:09 PM Dumitru Ceara wrote: > On Wed, Oct 16, 2019 at 7:01 PM wrote: > > > > From: Numan Siddique > > > > If a virtual port has 2 parents and if both of them are scheduled > > on the same chassis, then virtual port binding doesn't work. > > > > For virtual port binding

Re: [ovs-dev] [PATCH ovn] Fix virtual port binding when the parents are scheduled in the same chassis

2019-10-17 Thread Dumitru Ceara
On Wed, Oct 16, 2019 at 7:01 PM wrote: > > From: Numan Siddique > > If a virtual port has 2 parents and if both of them are scheduled > on the same chassis, then virtual port binding doesn't work. > > For virtual port binding we have the below logical flows: > inport == p1 &&