On Tue, Oct 22, 2019 at 7:35 PM Tonghao Zhang wrote:
>
> On Tue, Oct 22, 2019 at 2:58 PM Pravin Shelar wrote:
> >
...
> > > >
> > Sure, I can review it, Can you send the patch inlined in mail?
> >
> > Thanks.
> diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
> index 5df5
Memory leak happens while converting existing database into new database
according to
the specified schema (ovsdb-client convert new-schema). Memory leak was detected
by valgrind while executing functional test "schema conversion online -
clustered"
==16202== 96 bytes in 6 blocks are definitely
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#43 FILE: ovsdb/file.c:238:
Ich bin * Azim Hashim Premji *, ein indisches Wirtschaftsmagazin, Investor und
Philanthrop. Ich bin Vorsitzender von Wipro Limited. Ich habe 25 Prozent meiner
persönlichen Vermögensanträge. Und ich habe auch versprochen, den Rest von 25%
im Jahr 2019 zu verschenken. Ich habe beschlossen, Ihnen
On Mon, Oct 21, 2019 at 07:01:38AM +, Roi Dayan wrote:
>
>
> On 2019-10-18 1:00 PM, Simon Horman wrote:
> > On Wed, Oct 16, 2019 at 11:53:52AM +, Roi Dayan wrote:
> >>
> >>
> >> On 2019-10-16 2:40 PM, Simon Horman wrote:
> >>> On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote:
> >
parse_tcp_flags() does not care about vlan tags in a packet thus
not able to parse them. As a result, if partial offloading is
enabled in userspace datapath vlan packets are not parsed, i.e.
has no initialized offsets. This causes OVS crash on any attempt
to access/modify packet header fields.
F
Mixing of RSS hash with recirculation depth is useful for flow lookup
because same packet after recirculation should match with different
datapath rule. Setting of the mixed value back to the packet is
completely unnecessary because recirculation depth is different on
each recirculation, i.e. we w
CC: Ben Pfaff
Fixes: 7be29a47576d ("ofproto-dpif: Remove tabs from output.")
Signed-off-by: Ilya Maximets
---
tests/system-userspace-packet-type-aware.at | 64 ++---
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/tests/system-userspace-packet-type-aware.at
b/tes
Even simpler solution to the problem.
Acked-by: Jan Scheurich
BR, Jan
> -Original Message-
> From: Ilya Maximets
> Sent: Thursday, 24 October, 2019 14:32
> To: ovs-dev@openvswitch.org
> Cc: Ian Stokes ; Kevin Traynor ;
> Jan Scheurich ; ychen103...@163.com; Ilya
> Maximets
> Subject: [
On Thu, Oct 24, 2019 at 02:41:48PM +0200, Ilya Maximets wrote:
> CC: Ben Pfaff
> Fixes: 7be29a47576d ("ofproto-dpif: Remove tabs from output.")
> Signed-off-by: Ilya Maximets
If you've run the test and this makes it pass:
Acked-by: Ben Pfaff
Also, thank you!
___
On Sun, Oct 20, 2019 at 5:52 PM Han Zhou wrote:
> diff --git a/Documentation/tutorials/ovn-interconnection.rst
b/Documentation/tutorials/ovn-interconnection.rst
...
> +
> +For each OVN deployment, start the ``ovn-ic`` daemon on central nodes ::
> +
> +$ ovn-ctl --ovninb-db= --ovnisb-db= \
> +
Ein guter und legitimer Kreditgeber Ich gebe Darlehen an diejenigen, die
Darlehen benötigen. Ich gebe Geschäftskredite, medizinische Kredite,
Bildungskredite, Privat- oder Investitionskredite, Hausmietkredite usw. zu 2%
Zinssatz aus
___
dev mailing li
From: Ilya Maximets
This is yet another refactoring for upcoming detailed drop stats.
It allowes to use single function for all the software calculated
statistics in netdev-dpdk for both vhost and ETH ports.
UINT64_MAX used as a marker for non-supported statistics in a
same way as it's done in b
OVS may be unable to transmit packets for multiple reasons on
the userspace datapath and today there is a single counter to
track packets dropped due to any of those reasons. This patch
adds custom software stats for the different reasons packets
may be dropped during tx/rx on the userspace datapat
From: Ilya Maximets
This is yet another refactoring for upcoming detailed drop stats.
It allowes to use single function for all the software calculated
statistics in netdev-dpdk for both vhost and ETH ports.
UINT64_MAX used as a marker for non-supported statistics in a
same way as it's done in b
Sometimes, analysing the drop statistics of the ports
will be helpful in debugging. This patch adds script
to collect all supported port stats which also includes
the drop counters in userspace datapath. The output of
this scirpt is included in the bugtool output.
Signed-off-by: Sriram Vatala
---
On Thu, Oct 24, 2019 at 09:20:49AM +0200, Damijan Skvarc wrote:
> Memory leak happens while converting existing database into new database
> according to
> the specified schema (ovsdb-client convert new-schema). Memory leak was
> detected
> by valgrind while executing functional test "schema conv
On Mon, Oct 21, 2019 at 12:42:02PM +0530, Surya Rudra via dev wrote:
> Issue:
> When LLDP is enabled on a port, a structure to hold LLDP related state
> is created and that structure has a reference to the port. The ofproto
> monitor thread accesses the LLDP structure to periodically send packets
>
On Thu, Oct 24, 2019 at 12:09:16PM +0200, Ilya Maximets wrote:
> parse_tcp_flags() does not care about vlan tags in a packet thus
> not able to parse them. As a result, if partial offloading is
> enabled in userspace datapath vlan packets are not parsed, i.e.
> has no initialized offsets. This ca
On Mon, Oct 21, 2019 at 07:34:36PM +0530, Gowrishankar Muthukrishnan wrote:
> It might be difficult to trace whether LACP PDU tx (as in
> response) was successful when the pdu was not transmitted by
> egress slave for various reasons (including resource contention
> within NIC) and only way to trac
On Mon, Oct 21, 2019 at 10:26:51PM +0530, num...@ovn.org wrote:
> From: Numan Siddique
>
> Presently, replication is not allowed if there is a schema version mismatch
> between
> the schema returned by the active ovsdb-server and the local db schema. This
> is
> causing failures in OVN DB HA de
On Fri, Oct 11, 2019 at 02:49:14PM -0700, Yifeng Sun wrote:
> This patch provides essential fixes for OVS to support
> RHEL7.7's new kernel.
>
> make rpm-fedora-kmod \
> RPMBUILD_OPT='-D "kversion 3.10.0-1062.1.2.el7.x86_64"'
>
> Signed-off-by: Yifeng Sun
Thanks, applied to master.
21 de Noviembre | Horario de 10:00 a 17:00 hrs. | (hora del centro de México)
- Mapeo de Procesos - Webinar en Vivo
Este taller está dirigido al personal de las áreas de calidad, procesos,
proyectos de mejora y profesionales dedicados a la documentación de procesos
en general y les permiti
On Tue, Oct 15, 2019 at 02:56:23PM +0800, zhaozhanxu wrote:
> Add argument '-m' for command ovs-appctl bridge/dump-flows
> to display the offloaded packets statistics.
Thanks for the updated patch.
Are n_offload_packets a subset of n_packets, or in addition to them? If
they are a subset, then n_
On Tue, Oct 15, 2019 at 06:52:34PM -0700, amgin...@gmail.com wrote:
> From: Aliasgar Ginwala
>
> Signed-off-by: Aliasgar Ginwala
I'm pretty sure this code doesn't work properly because it tries to
parse the same string twice with strtok_r(), which is going to truncate
it after the first option.
This log message was introduced in commit 5344f24ecb. It may be more
appropriate as a deubg message, but as a warning, it breaks this test suite.
Filtering it out of the logs gets these tests passing for me.
A sample of the messages encountered in a test run are:
2019-10-25T01:06:53.026Z|00010|c
Bleep bloop. Greetings Russell Bryant, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Russell Bryant needs to sign off.
Lines checked: 135, Warnings: 0, Errors: 1
On Fri, Oct 25, 2019, 6:56 AM Russell Bryant wrote:
> This log message was introduced in commit 5344f24ecb. It may be more
> appropriate as a deubg message, but as a warning, it breaks this test
> suite.
> Filtering it out of the logs gets these tests passing for me.
>
> A sample of the messages
On Fri, Oct 25, 2019, 7:59 AM Numan Siddique wrote:
>
>
> On Fri, Oct 25, 2019, 6:56 AM Russell Bryant wrote:
>
>> This log message was introduced in commit 5344f24ecb. It may be more
>> appropriate as a deubg message, but as a warning, it breaks this test
>> suite.
>> Filtering it out of the l
On Wed, Oct 23, 2019 at 12:41 PM Dumitru Ceara wrote:
> ARP request and ND NS packets for router owned IPs were being
> flooded in the complete L2 domain (using the MC_FLOOD multicast group).
> However this creates a scaling issue in scenarios where aggregation
> logical switches are connected to
On Wed, Oct 23, 2019 at 8:49 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Introduce the possibility to specify a RDNSS option to Router
> Advertisement packets. DNS IPv6 address can be specified using
> 'rdnss' tag in the ipv6_ra_configs column of logical router
> port table
>
> Ack
From: Aliasgar Ginwala
Signed-off-by: Aliasgar Ginwala
---
lib/command-line.c | 55 ++
lib/command-line.h | 3 +++
2 files changed, 58 insertions(+)
diff --git a/lib/command-line.c b/lib/command-line.c
index 9e000bd28..d13cca294 100644
--- a/lib/com
Thanks Ben for the review:
Yes you are right, current patch is buggy as using same string twice with
strtok_r() was always using first option instead of n options. Thanks for
pointing out about svec.[ch]. I sent v2
https://patchwork.ozlabs.org/patch/1183774/ to address the same. PTAL.
Ali
_
33 matches
Mail list logo
