Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-11-03 Thread Anil Kumar Koli via dev
Hi Ben, I have not tried it under OVS sandbox. I can test the patch on both OVS sandbox and my local testbed and update with the results. Thanks & Regards, Anil Kumar -Original Message- From: Ben Pfaff Sent: Friday, 1 November, 2019 11:12 PM To: Ilya Maximets Cc: Ilya Maximets ; Anil

Re: [ovs-dev] [PATCH net-next v6 00/10] optimize openvswitch flow looking up

2019-11-03 Thread David Miller
From: xiangxia.m@gmail.com Date: Fri, 1 Nov 2019 22:23:44 +0800 > This series patch optimize openvswitch for performance or simplify > codes. Series applied, thank you. ___ dev mailing list d...@openvswitch.org

[ovs-dev] Investment opportunity

2019-11-03 Thread Peter Wong
Greetings, Find the attached mail very confidential. reply for more details Thanks. Peter Wong This email was sent by the shareware version of Postman Professional. ___ dev mailing list

Re: [ovs-dev] [PATCH ovn v1] vagrant: Use python3 and newer linux distros

2019-11-03 Thread 0-day Robot
Bleep bloop. Greetings Flavio Fernandes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #86 FILE: Vagrantfile:35:

[ovs-dev] gso packet is failing with af_packet socket with packet_vnet_hdr

2019-11-03 Thread Ramana Reddy
Hi, I am wondering if anyone can help me with this. I am having trouble to send tso/gso packet with af_packet socket with packet_vnet_hdr (through virtio_net_hdr) over vxlan tunnel in OVS. What I observed that, the following function eventually hitting and is returning false (net/core/skbuff.c),

Re: [ovs-dev] [patch v1] faq: Fix meter action releases.

2019-11-03 Thread Ben Pfaff
On Sat, Nov 02, 2019 at 12:05:34PM -0700, Darrell Ball wrote: > At the same time disambiguate some feature descriptions. > 'Meters' is changed to 'Meter action' to clarify that the entry > describes the Openflow meter action rather than port based meters. > 'NAT' is changed to 'Conntrack NAT' to

[ovs-dev] [PATCH ovn v1] vagrant: Use python3 and newer linux distros

2019-11-03 Thread Flavio Fernandes
Stop usage of python2 as ovs+ovn no longer support it. Update vagrant boxes to the following revisions: - Debian: buster (from jessie) - Fedora: v31 (from v29) - Centos: 8 (from 7, kinda**) Centos 7 may still be used, but only if explicitly provided in command: 'vagrant up centos-7' Fedora-31's

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Prevent duplicating of traffic to a mirror port

2019-11-03 Thread Roi Dayan
On 2019-11-03 12:00 PM, 0-day Robot wrote: > Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > WARNING: Line is 83 characters

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Prevent duplicating of traffic to a mirror port

2019-11-03 Thread 0-day Robot
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #31 FILE:

[ovs-dev] [PATCH] ofproto-dpif-xlate: Prevent duplicating of traffic to a mirror port

2019-11-03 Thread Roi Dayan
From: Dmytro Linkin Currently ofproto design disallow duplicating output packet on forwarding and mirroring to/from same ovs port. Next scenario reveal lack of design: 1. Send ping between regular ovs ports (VFs, for ex.), stop it. 2. While rule still exist, make mirror for one of the ports.

Re: [ovs-dev] [PATCH] lib/tc: Fix flow dump for tunnel id equal zero

2019-11-03 Thread Roi Dayan
On 2019-11-02 1:27 PM, Simon Horman wrote: > On Fri, Nov 01, 2019 at 03:54:49PM +0100, Simon Horman wrote: >> On Wed, Oct 30, 2019 at 02:40:35PM +0200, Roi Dayan wrote: >>> From: Dmytro Linkin >>> >>> Tunnel id 0 is not printed unless tunnel flag FLOW_TNL_F_KEY is set. >>> Fix that by always

Re: [ovs-dev] [PATCH net-next v6 10/10] net: openvswitch: simplify the ovs_dp_cmd_new

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > use the specified functions to init resource. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose Acked-by: Pravin B Shelar ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH net-next v6 09/10] net: openvswitch: don't unlock mutex when changing the user_features fails

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > Unlocking of a not locked mutex is not allowed. > Other kernel thread may be in critical section while > we unlock it because of setting user_feature fail. > > Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain

Re: [ovs-dev] [PATCH net-next v6 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > When we destroy the flow tables which may contain the flow_mask, > so release the flow mask struct. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose > --- Acked-by: Pravin B Shelar

Re: [ovs-dev] [PATCH net-next v6 07/10] net: openvswitch: add likely in flow_lookup

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > The most case *index < ma->max, and flow-mask is not NULL. > We add un/likely for performance. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose > Acked-by: William Tu > --- Acked-by: Pravin B Shelar

Re: [ovs-dev] [PATCH net-next v6 05/10] net: openvswitch: optimize flow-mask looking up

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > The full looking up on flow table traverses all mask array. > If mask-array is too large, the number of invalid flow-mask > increase, performance will be drop. > > One bad case, for example: M means flow-mask is valid and NULL >

Re: [ovs-dev] [PATCH net-next v6 06/10] net: openvswitch: simplify the flow_hash

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > Simplify the code and remove the unnecessary BUILD_BUG_ON. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose > Acked-by: William Tu > --- Acked-by: Pravin B Shelar ___ dev

Re: [ovs-dev] [PATCH net-next v6 04/10] net: openvswitch: optimize flow mask cache hash collision

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > Port the codes to linux upstream and with little changes. > > Pravin B Shelar, says: > | In case hash collision on mask cache, OVS does extra flow > | lookup. Following patch avoid it. > > Link: >

Re: [ovs-dev] [PATCH net-next v6 03/10] net: openvswitch: shrink the mask array if necessary

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > When creating and inserting flow-mask, if there is no available > flow-mask, we realloc the mask array. When removing flow-mask, > if necessary, we shrink mask array. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose >

Re: [ovs-dev] [PATCH net-next v6 02/10] net: openvswitch: convert mask list in mask array

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > Port the codes to linux upstream and with little changes. > > Pravin B Shelar, says: > | mask caches index of mask in mask_list. On packet recv OVS > | need to traverse mask-list to get cached mask. Therefore array > | is better

Re: [ovs-dev] [PATCH net-next v6 01/10] net: openvswitch: add flow-mask cache for performance

2019-11-03 Thread Pravin Shelar
On Fri, Nov 1, 2019 at 7:24 AM wrote: > > From: Tonghao Zhang > > The idea of this optimization comes from a patch which > is committed in 2014, openvswitch community. The author > is Pravin B Shelar. In order to get high performance, I > implement it again. Later patches will use it. > > Pravin