On Tue, Dec 3, 2019 at 10:00 PM Ian Stokes wrote:
>
> This commit adds support for DPDK v19.11, it includes the following
> changes.
>
> 1. travis: Enable compilation and linkage with dpdk 19.11.0
>
> 2. sparse: Remove dpdk network headers copies.
>
> 3. dpdk: Migratee to new PDUMP API.
>
> 4.
Thank you
I will continue as your suggestion when have time
-RongQing
发件人: Darrell Ball [mailto:dlu...@gmail.com]
发送时间: 2019年11月30日 3:19
收件人: Li,Rongqing ; ovs dev
主题: Re: ipf question
-- Forwarded message -
From: Li,Rongqing mailto:lirongq...@baidu.com>>
Date: Thu, Nov 28,
> -邮件原件-
> 发件人: David Marchand [mailto:david.march...@redhat.com]
> 发送时间: 2019年12月3日 20:40
> 收件人: Ilya Maximets
> 抄送: ovs dev ; Ian Stokes ;
> Li,Rongqing
> 主题: Re: [RFC PATCH] netdev-dpdk: Narrow down txq critical section.
>
> On Tue, Dec 3, 2019 at 12:17 PM Ilya Maximets wrote:
> >
Hi,
Could you see if this patch fixes your problem?
https://patchwork.ozlabs.org/patch/1203951/
Thanks,
Han
On Mon, Dec 2, 2019 at 12:28 AM Han Zhou wrote:
> Sorry for the late reply. It was holiday here.
> I didn't see such problem when there is no compaction. Did you see this
> problem
Cluster doesn't work after all nodes restarted after DB compaction,
unless there is any transaction after DB compaction before the restart.
Error log is like:
raft|ERR|internal error: deferred vote_request message completed but not ready
to send because message index 9 is past last synced index
In test case "election timer change", before testing DB compact,
we had to insert some data. Otherwise, inserting data after DB
compact will cause busy loop as mentioned in the XXX comment.
The root cause of the busy loop is still not clear, but the test
itself didn't wait until the leader
On Tue, Dec 3, 2019 at 2:42 PM Ben Pfaff wrote:
>
> On Tue, Dec 03, 2019 at 01:44:08PM -0800, William Tu wrote:
> > Fix indentation and whitespace.
> >
> > Signed-off-by: William Tu
>
> Acked-by: Ben Pfaff
Thanks, applied to master.
___
dev mailing
On Tue, Dec 3, 2019 at 2:41 PM Ben Pfaff wrote:
>
> On Tue, Dec 03, 2019 at 01:44:07PM -0800, William Tu wrote:
> > Signed-off-by: William Tu
> > ---
> > AUTHORS.rst | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/AUTHORS.rst b/AUTHORS.rst
> > index 4823badfbd4b..5043aeb27126
On Tue, Dec 03, 2019 at 01:44:08PM -0800, William Tu wrote:
> Fix indentation and whitespace.
>
> Signed-off-by: William Tu
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Dec 03, 2019 at 01:44:07PM -0800, William Tu wrote:
> Signed-off-by: William Tu
> ---
> AUTHORS.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/AUTHORS.rst b/AUTHORS.rst
> index 4823badfbd4b..5043aeb27126 100644
> --- a/AUTHORS.rst
> +++ b/AUTHORS.rst
> @@ -421,6 +421,7 @@
On Tue, Dec 3, 2019 at 8:07 PM Ben Pfaff wrote:
>
> On Tue, Dec 03, 2019 at 10:56:54AM +0100, Dumitru Ceara wrote:
> > The commit that adds incremental processing for port-group changes
> > doesn't store logical flow references for port groups. If a port group
> > is updated (e.g., a port is
Fix indentation and whitespace.
Signed-off-by: William Tu
---
lib/match.c | 2 +-
lib/netdev-native-tnl.c | 4 ++--
lib/odp-util.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/match.c b/lib/match.c
index 052daee146f2..ae568280a2bb 100644
---
Signed-off-by: William Tu
---
AUTHORS.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/AUTHORS.rst b/AUTHORS.rst
index 4823badfbd4b..5043aeb27126 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -421,6 +421,7 @@ wenxu we...@ucloud.cn
wisd0me
The act_ct TC module shares a common conntrack and NAT infrastructure
exposed via netfilter. It's possible that a packet needs both SNAT and
DNAT manipulation, due to e.g. tuple collision. Netfilter can support
this because it runs through the NAT table twice - once on ingress and
again after
The openvswitch module shares a common conntrack and NAT infrastructure
exposed via netfilter. It's possible that a packet needs both SNAT and
DNAT manipulation, due to e.g. tuple collision. Netfilter can support
this because it runs through the NAT table twice - once on ingress and
again after
On 12/3/2019 8:59 PM, Ian Stokes wrote:
This commit adds support for DPDK v19.11, it includes the following
changes.
1. travis: Enable compilation and linkage with dpdk 19.11.0
2. sparse: Remove dpdk network headers copies.
3. dpdk: Migratee to new PDUMP API.
4. netdev-dpdk: Prefix
This commit adds support for DPDK v19.11, it includes the following
changes.
1. travis: Enable compilation and linkage with dpdk 19.11.0
2. sparse: Remove dpdk network headers copies.
3. dpdk: Migratee to new PDUMP API.
4. netdev-dpdk: Prefix network structures with rte_.
5. netdev-dpdk:
On Tue, Dec 03, 2019 at 05:26:51PM +0100, Ilya Maximets wrote:
> On 03.12.2019 14:12, Flavio Leitner wrote:
> > On Tue, Dec 03, 2019 at 01:15:23PM +0100, Ilya Maximets wrote:
> >> On 02.12.2019 14:44, Flavio Leitner wrote:
> >>> Abbreviated as TSO, TCP Segmentation Offload is a feature which
On Tue, Dec 03, 2019 at 04:11:21PM +0200, Roi Dayan wrote:
> From: Dmytro Linkin
>
> Currently ofproto design disallow duplicating output packet on forwarding
> and mirroring to/from same ovs port. Next scenario reveal lack of design:
> 1. Send ping between regular ovs ports (VFs, for ex.), stop
On Tue, Dec 03, 2019 at 10:56:54AM +0100, Dumitru Ceara wrote:
> The commit that adds incremental processing for port-group changes
> doesn't store logical flow references for port groups. If a port group
> is updated (e.g., a port is added) no logical flow recalculation will be
> performed.
>
>
On Tue, Dec 03, 2019 at 09:33:49AM +0100, Damijan Skvarc wrote:
> unit test is introduced which checks fail-mode related commands.
>
> Signed-off-by: Damijan Skvarc
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
On Tue, Dec 03, 2019 at 09:14:17AM -0800, Darrell Ball wrote:
> Signed-off-by: Darrell Ball
Thanks. I applied this to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Dec 3, 2019 at 5:18 AM Numan Siddique wrote:
>
> On Tue, Dec 3, 2019 at 5:38 AM Han Zhou wrote:
> >
> > On Mon, Dec 2, 2019 at 12:41 AM Numan Siddique wrote:
> > >
> > > On Mon, Dec 2, 2019 at 1:53 PM Han Zhou wrote:
> > > >
> > > > On Sun, Dec 1, 2019 at 11:59 PM Numan Siddique
Signed-off-by: Darrell Ball
---
v4: Add zone_limit_seq; /* Used to disambiguate zone limit counts. */
v3: recent merge conflict.
v2: Address review comment from Ben; one involves creating an
admit zone in the connection entry to track the zone used
for zone limit accounting when the
Pls ignore V3; sending V4.
On Mon, Dec 2, 2019 at 9:43 PM Darrell Ball wrote:
> Signed-off-by: Darrell Ball
> ---
>
> v3: recent merge conflict.
>
> v2: Address review comment from Ben; one involves creating an
> admit zone in the connection entry to track the zone used
> for zone
Hi Ben,
yes, will do.
On Mon, Dec 02, 2019 at 03:07:43PM -0800, Ben Pfaff wrote:
> Simon, would you mind taking a look at this too?
>
> On Mon, Oct 28, 2019 at 08:19:48PM +0800, zhaozhanxu wrote:
> > Add argument '-m' or '--more' for command ovs-appctl bridge/dump-flows
> > to display the
--
Dear Friend,
I pray and hope this mail finds you in good condition.
It's almost 3 years now that both of us communicated and is just that i lost
your contact details. So how are you doing over there in your country?.
Well, am happy to inform you that i have succeeded in getting the
On Tue, Dec 03, 2019 at 03:45:24PM +0200, Roi Dayan wrote:
> The following patchset introduces hardware offload of OVS connection
> tracking datapath rules.
>
> OVS uses ct() and recirc() (recirculation) actions and recirc_id()/ct_state()
> matches to support connection tracking.
>
> The
On 03.12.2019 14:12, Flavio Leitner wrote:
> On Tue, Dec 03, 2019 at 01:15:23PM +0100, Ilya Maximets wrote:
>> On 02.12.2019 14:44, Flavio Leitner wrote:
>>> Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
>>> the network stack to delegate the TCP segmentation to the NIC
Et si vous deveniez un professionnel
des Thrapies Alternatives ?
De plus en plus utilise, lHypnose Thrapeutique est
vraiment la nouvelle faon de soulager et rtablir
lharmonie des personnes en utilisant linconscient.
Quel que
On Tue, Dec 03, 2019 at 12:59:24PM +, Stokes, Ian wrote:
>
>
> On 12/3/2019 12:15 PM, Ilya Maximets wrote:
> > On 02.12.2019 14:44, Flavio Leitner wrote:
> > > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> > > the network stack to delegate the TCP segmentation to
On 03.12.2019 15:42, Malvika Gupta wrote:
> Hi Ilya,
>
> Please see the inline comments below. Thanks!
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Friday, November 29, 2019 12:30 AM
>> To: Yanqin Wei (Arm Technology China) ; Ilya
>> Maximets ; Malvika Gupta
>> ;
On Wed, Nov 20, 2019 at 9:07 PM Eli Britstein wrote:
>
> Signed-off-by: Eli Britstein
> Reviewed-by: Oz Shlomo
> ---
> NEWS | 2 +
> lib/netdev-offload-dpdk-flow.c | 87
> --
> 2 files changed, 85 insertions(+), 4 deletions(-)
On 03.12.2019 14:45, Roi Dayan wrote:
> From: Paul Blakey
>
> Each recirculation id will create a tc chain, and we translate
> the recirculation action to a tc goto chain action.
>
> We check for kernel support for this by probing OvS Datapath for the
> tc recirc id sharing feature. If
On Wed, Nov 20, 2019 at 9:05 PM Eli Britstein wrote:
>
> Add debug prints when creating and destroying rte flows.
>
> Signed-off-by: Eli Britstein
> Reviewed-by: Oz Shlomo
> ---
> lib/netdev-dpdk.c | 29 +++
> lib/netdev-offload-dpdk-flow.c| 168
>
On Wed, Nov 20, 2019 at 9:07 PM Eli Britstein wrote:
>
> Instead of statically allocated pattern items on the stack,dynamically
> allocate only the required items while parsing the required matches.
What are the benefits of dynamic allocation scheme? It is not clear
from the patch whether this
Hi Eli,
Thanks for this full-offload patch set. I have some comments inline.
Thanks,
-Harsha
On Wed, Nov 20, 2019 at 9:07 PM Eli Britstein wrote:
>
> Refactor the flow patterns and actions code to a new source files for
> better readability and towards adding more code to it.
>
>
Hi Ilya,
Please see the inline comments below. Thanks!
> -Original Message-
> From: Ilya Maximets
> Sent: Friday, November 29, 2019 12:30 AM
> To: Yanqin Wei (Arm Technology China) ; Ilya
> Maximets ; Malvika Gupta
> ; d...@openvswitch.org
> Cc: nd ; Honnappa Nagarahalli
>
> Subject:
From: Dmytro Linkin
Currently ofproto design disallow duplicating output packet on forwarding
and mirroring to/from same ovs port. Next scenario reveal lack of design:
1. Send ping between regular ovs ports (VFs, for ex.), stop it.
2. While rule still exist, make mirror for one of the ports.
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
build:
depbase=`echo lib/dpif-netlink-rtnl.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool
Bleep bloop. Greetings Roi Dayan, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Paul Blakey needs to sign off.
Lines checked: 745, Warnings: 0, Errors: 1
Please
On 2019-12-03 12:47 AM, Ben Pfaff wrote:
> On Sun, Nov 03, 2019 at 11:11:53AM +0200, Roi Dayan wrote:
>> From: Dmytro Linkin
>>
>> Currently ofproto design disallow duplicating output packet on forwarding
>> and mirroring to/from same ovs port. Next scenario reveal lack of design:
>> 1. Send
From: Paul Blakey
---
Changelog:
V2->V3:
Added missing match on ct_mark.
Signed-off-by: Paul Blakey
---
lib/dpif-netlink.c | 2 ++
lib/netdev-offload-tc.c | 66 +
lib/tc.c| 53 +++
From: Paul Blakey
Since OvS datapath gets packets already decapsulated from tunnel devices,
it doesn't explicitly decapsulate them. So in a recirculation setup,
the tunnel matching continues in the recirculation as the tunnel
metadata still exists on the SKB.
Tunnel key unset action unsets this
From: Paul Blakey
Update kernel UAPI to support conntrack matches, and the
tc actions ct and goto chain.
Signed-off-by: Paul Blakey
---
include/linux/automake.mk| 3 ++-
include/linux/pkt_cls.h | 46 +---
include/linux/tc_act/tc_ct.h | 41
From: Paul Blakey
Move all that is needed to identify a tc filter to a
new structure, tcf_id. This removes a lot of duplication
in accessing/creating tc filters.
---
Changelog:
V2->V1:
Renamed *tc_id* -> *tcf_id*
Renamed make_tc_id -> tc_make_tcf_id to be consistent with tc_make_*
From: Paul Blakey
This enables user features on the kernel datapath via the DP_CMD_SET
command, and also retrieves them to check for actual support and
not just an older kernel ignoring the requested features.
This will be used in next patch to enable recirc_id sharing with tc.
From: Paul Blakey
To be consistent with our tc-ufid mapping after flush, and to support tc
chains flushing in the next commit, implement flush operation via
deleting all the filters we actually added and delete their mappings.
This will also not delete the configured qos policing via matchall
From: Paul Blakey
Each recirculation id will create a tc chain, and we translate
the recirculation action to a tc goto chain action.
We check for kernel support for this by probing OvS Datapath for the
tc recirc id sharing feature. If supported, we can offload rules
that match on recirc_id, and
From: Paul Blakey
Zone and ct_state first.
Signed-off-by: Paul Blakey
---
lib/dpif-netlink.c | 2 +
lib/netdev-offload-tc.c | 136
lib/tc.c| 122 +++
lib/tc.h| 11
The following patchset introduces hardware offload of OVS connection
tracking datapath rules.
OVS uses ct() and recirc() (recirculation) actions and recirc_id()/ct_state()
matches to support connection tracking.
The datapath rules are in the form of:
From: Paul Blakey
---
Changelog:
V2->V3:
Ipv6 nat dump fix (missing unspec type in policy)
Renamed tc range struct to be consistent with NL ATTRIBUTES and ovs
V1->V2:
Missing ntohs/htons on nat port range.
Signed-off-by: Paul Blakey
---
lib/netdev-offload-tc.c | 104
From: Paul Blakey
Sets zone in match.
Signed-off-by: Paul Blakey
---
include/openvswitch/match.h | 2 ++
lib/match.c | 10 --
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/openvswitch/match.h b/include/openvswitch/match.h
index
On Tue, Dec 3, 2019 at 5:38 AM Han Zhou wrote:
>
> On Mon, Dec 2, 2019 at 12:41 AM Numan Siddique wrote:
> >
> > On Mon, Dec 2, 2019 at 1:53 PM Han Zhou wrote:
> > >
> > > On Sun, Dec 1, 2019 at 11:59 PM Numan Siddique wrote:
> > > >
> > > > On Mon, Dec 2, 2019 at 12:44 PM Han Zhou wrote:
> >
On 12/2/2019 4:25 PM, Ilya Maximets wrote:
> On 01.12.2019 9:29, Eli Britstein wrote:
>> On 11/30/2019 1:59 PM, Ilya Maximets wrote:
>>> On 24.11.2019 14:22, Eli Britstein wrote:
On 11/22/2019 6:19 PM, Ilya Maximets wrote:
> On 20.11.2019 16:28, Eli Britstein wrote:
>>
On Tue, Dec 03, 2019 at 01:15:23PM +0100, Ilya Maximets wrote:
> On 02.12.2019 14:44, Flavio Leitner wrote:
> > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> > the network stack to delegate the TCP segmentation to the NIC reducing
> > the per packet CPU overhead.
> >
>
On Tue, Dec 3, 2019 at 12:34 PM Ilya Maximets wrote:
>
> On 02.12.2019 17:03, David Marchand wrote:
> > Most DPDK components make the assumption that rte_lcore_id() returns
> > a valid lcore_id in [0..RTE_MAX_LCORE] range (with the exception of
> > the LCORE_ID_ANY special value).
>
> Do you
On 12/3/2019 12:15 PM, Ilya Maximets wrote:
On 02.12.2019 14:44, Flavio Leitner wrote:
Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
the network stack to delegate the TCP segmentation to the NIC reducing
the per packet CPU overhead.
A guest using vhost-user
On Tue, Dec 3, 2019 at 12:17 PM Ilya Maximets wrote:
>
> On 02.12.2019 17:24, David Marchand wrote:
> > tx_lock protects the NIC/vhost queue from concurrent access.
> > Move it closer to the parts it protects and let packets duplication (when
> > source is not DPDK) and the egress policer run out
On 02.12.2019 14:44, Flavio Leitner wrote:
> Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> the network stack to delegate the TCP segmentation to the NIC reducing
> the per packet CPU overhead.
>
> A guest using vhost-user interface with TSO enabled can send TCP packets
On 02.12.2019 17:03, David Marchand wrote:
> Most DPDK components make the assumption that rte_lcore_id() returns
> a valid lcore_id in [0..RTE_MAX_LCORE] range (with the exception of
> the LCORE_ID_ANY special value).
Do you think that makes a practical sense? In a real virtualization
On 02.12.2019 17:24, David Marchand wrote:
> tx_lock protects the NIC/vhost queue from concurrent access.
> Move it closer to the parts it protects and let packets duplication (when
> source is not DPDK) and the egress policer run out of it.
>
> Signed-off-by: David Marchand
> ---
> I caught
'linux_tc' flow API suitable only for tunneling vports with backing
linux interfaces. DPDK flow API is not suitable for such ports.
With this change we could drop vport restriction from dpif-netdev.
This is a prerequisite for enabling vport offloading in DPDK.
Signed-off-by: Ilya Maximets
---
Virtual interfaces like vports or dpdk vhost-user ports has no
proper ifindex, but could support some kind of offloading.
This is a prerequisite for tunneling vport offloading with DPDK
flow API.
Signed-off-by: Ilya Maximets
---
lib/netdev-offload.c | 17 ++---
1 file changed, 10
Storing of the dpif type of the owning datapath interface will allow
us to easily distinguish, for example, userspace tunneling ports from
the system ones. This is required in terms of HW offloading to avoid
offloading of userspace flows to kernel interfaces that doesn't belong
to userspace
There is no real difference between the 'class' and 'type' in the
context of common lookup operations inside netdev-offload module
because it only checks the value of pointers without using the
value itself. However, 'type' has some meaning and can be used by
offload provides on the
These patches are necessary to enable vxlan offloading for
userspace datapath via DPDK flow offloading API (not tested).
They allows to properly distinguish userspace tunnels from the
system tunnels on netdev level in order to choose appropriate
flow offloading API provider. Before these patches
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
The commit that adds incremental processing for port-group changes
doesn't store logical flow references for port groups. If a port group
is updated (e.g., a port is added) no logical flow recalculation will be
performed.
To fix this, when parsing the flow expression also store the referenced
On Tue, Dec 3, 2019 at 12:05 AM Han Zhou wrote:
>
>
>
> On Mon, Dec 2, 2019 at 2:38 PM Han Zhou wrote:
> >
> >
> >
> > On Mon, Dec 2, 2019 at 5:20 AM Dumitru Ceara wrote:
> > >
> > > The commit that adds incremental processing for port-group changes
> > > doesn't store logical flow references
unit test is introduced which checks fail-mode related commands.
Signed-off-by: Damijan Skvarc
---
tests/ovs-vsctl.at | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
index 18b9cd7..ff39e15 100644
--- a/tests/ovs-vsctl.at
Добрый день!
Компания RANBERG окажет вам поддержку во всех вопросах связанных с логистикой и
таможенным оформлением.
Наши уникальные возможности:
— Доставка грузов из Европы и Азии
— Таможенное оформление
— Импорт-Экспорт
— ВЭД сопровождение
— Сертификация и Страхование
Специальное предложение
On Wed, Nov 27, 2019 at 5:16 AM Dumitru Ceara wrote:
>
> The incremental processing engine might stop a run before the
> en_runtime_data node is processed. In such cases the ed_runtime_data
> fields might contain pointers to already deleted SB records. For
> example, if a port binding
On Tue, Dec 3, 2019 at 12:01 AM Han Zhou wrote:
>
>
>
> On Mon, Dec 2, 2019 at 10:03 AM Dumitru Ceara wrote:
> >
> > Incremental processing tries to minimize the number of times
> > ovn-controller has to fully reprocess the contents of the southbound
> > database. However, if a bug in the I-P
74 matches
Mail list logo
