Re: [ovs-dev] [PATCHv7] userspace: Add GTP-U support.

2020-01-17 Thread 0-day Robot
Bleep bloop. Greetings William Tu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: C99 style comment #816 FILE: lib/netdev-native-tnl.c:808: //*seqno =

[ovs-dev] [PATCHv7] userspace: Add GTP-U support.

2020-01-17 Thread William Tu
GTP, GPRS Tunneling Protocol, is a group of IP-based communications protocols used to carry general packet radio service (GPRS) within GSM, UMTS and LTE networks. GTP protocol has two parts: Signalling (GTP-Control, GTP-C) and User data (GTP-User, GTP-U). GTP-C is used for setting up GTP-U

Re: [ovs-dev] [PATCH v9 2/2] netdev-afxdp: NUMA-aware memory allocation for XSK related memory

2020-01-17 Thread Ilya Maximets
On 18.01.2020 00:19, William Tu wrote: > On Fri, Jan 17, 2020 at 2:58 PM Ilya Maximets wrote: >> >> On 04.01.2020 02:13, Yi-Hung Wei wrote: >>> Currently, the AF_XDP socket (XSK) related memory are allocated by main >>> thread in the main thread's NUMA domain. With the patch that detects >>>

Re: [ovs-dev] [PATCHv6] userspace: Add GTP-U support.

2020-01-17 Thread William Tu
On Fri, Jan 17, 2020 at 02:14:27PM -0800, Ben Pfaff wrote: > On Thu, Jan 16, 2020 at 11:45:20AM -0800, William Tu wrote: > > GTP, GPRS Tunneling Protocol, is a group of IP-based communications > > protocols used to carry general packet radio service (GPRS) within > > GSM, UMTS and LTE networks.

Re: [ovs-dev] [PATCH v9 2/2] netdev-afxdp: NUMA-aware memory allocation for XSK related memory

2020-01-17 Thread William Tu
On Fri, Jan 17, 2020 at 2:58 PM Ilya Maximets wrote: > > On 04.01.2020 02:13, Yi-Hung Wei wrote: > > Currently, the AF_XDP socket (XSK) related memory are allocated by main > > thread in the main thread's NUMA domain. With the patch that detects > > netdev-linux's NUMA node id, the PMD thread of

Re: [ovs-dev] [PATCH v5] userspace: Add TCP Segmentation Offload support

2020-01-17 Thread Ilya Maximets
On 18.01.2020 00:03, Stokes, Ian wrote: > Thanks all for review/testing, pushed to master. OK, thanks Ian. @Ben, even though this patch already merged, I'd ask you to take a look at the code in case you'll spot some issues especially in non-DPDK related parts. Thanks. Best regards, Ilya

Re: [ovs-dev] [PATCH v5] userspace: Add TCP Segmentation Offload support

2020-01-17 Thread Stokes, Ian
Thanks all for review/testing, pushed to master. Regards Ian -Original Message- From: dev On Behalf Of Stokes, Ian Sent: Friday, January 17, 2020 10:56 PM To: Flavio Leitner ; d...@openvswitch.org Cc: Ilya Maximets ; txfh2007 Subject: Re: [ovs-dev] [PATCH v5] userspace: Add TCP

Re: [ovs-dev] [PATCH v9 2/2] netdev-afxdp: NUMA-aware memory allocation for XSK related memory

2020-01-17 Thread Ilya Maximets
On 04.01.2020 02:13, Yi-Hung Wei wrote: > Currently, the AF_XDP socket (XSK) related memory are allocated by main > thread in the main thread's NUMA domain. With the patch that detects > netdev-linux's NUMA node id, the PMD thread of AF_XDP port will be run on > the AF_XDP netdev's NUMA domain.

Re: [ovs-dev] [PATCH v5] userspace: Add TCP Segmentation Offload support

2020-01-17 Thread Stokes, Ian
On 1/17/2020 9:54 PM, Stokes, Ian wrote: On 1/17/2020 9:47 PM, Flavio Leitner wrote: Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU overhead. A guest using vhostuser interface

[ovs-dev] Is this d...@openvswitch.org still active?

2020-01-17 Thread Nelson Corey
I have tried to email this your d...@openvswitch.org account severally but I got no response, Please get back to me at your earliest convenience if you receive this email. Sincerely, Nelson Corey ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 2/3] ovn-controller.c: Move the position of handling OVN-SB related settings.

2020-01-17 Thread Han Zhou
On Fri, Jan 17, 2020 at 5:14 AM Numan Siddique wrote: > > On Wed, Jan 15, 2020 at 5:34 PM Flavio Fernandes wrote: > > > > > > > > > On Jan 14, 2020, at 5:34 PM, Han Zhou wrote: > > > > > > On Tue, Jan 14, 2020 at 1:24 PM Mark Michelson wrote: > > >> > > >> The commit message doesn't make much

[ovs-dev] [PATCH] dpif: Fix leak and usage of uninitialized dp_extra_info.

2020-01-17 Thread Ilya Maximets
'dpif_probe_feature'/'revalidate' doesn't free the 'dp_extra_info' string. Also, all the implementations of dpif_flow_get() should initialize the value to avoid printing/freeing of random memory. 30 bytes in 1 blocks are definitely lost in loss record 323 of 889 at 0x483AD19: realloc

Re: [ovs-dev] [PATCHv6] userspace: Add GTP-U support.

2020-01-17 Thread Ben Pfaff
On Thu, Jan 16, 2020 at 11:45:20AM -0800, William Tu wrote: > GTP, GPRS Tunneling Protocol, is a group of IP-based communications > protocols used to carry general packet radio service (GPRS) within > GSM, UMTS and LTE networks. GTP protocol has two parts: Signalling > (GTP-Control, GTP-C) and

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Flavio Leitner
On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets wrote: > On 16.01.2020 18:00, Flavio Leitner wrote: [...] > > Signed-off-by: Flavio Leitner > > > I still didn't check computation of offsets and device configuration. > Few comments inline. > > In general, I'd like if Ben will take a

Re: [ovs-dev] [PATCH v5] userspace: Add TCP Segmentation Offload support

2020-01-17 Thread 0-day Robot
Bleep bloop. Greetings Flavio Leitner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #1901 FILE:

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread William Tu
On Fri, Jan 17, 2020 at 1:41 PM Stokes, Ian wrote: > > > > On 1/17/2020 9:37 PM, Flavio Leitner wrote: > > On Fri, Jan 17, 2020 at 12:37:56PM -0800, William Tu wrote: > >> On Fri, Jan 17, 2020 at 04:58:57PM -0300, Flavio Leitner wrote: > >>> On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets

Re: [ovs-dev] [PATCH ovn 1/4] ovn-controller: A new action "select".

2020-01-17 Thread Han Zhou
On Fri, Jan 17, 2020 at 4:38 AM Numan Siddique wrote: > > On Tue, Jan 7, 2020 at 8:00 AM Han Zhou wrote: > > > > Support a new logical flow action "select", which can be used to > > implement features such as ECMP. The action uses OpenFlow group > > action to select an integer (uint16_t) from a

Re: [ovs-dev] [PATCH v5] userspace: Add TCP Segmentation Offload support

2020-01-17 Thread Stokes, Ian
On 1/17/2020 9:47 PM, Flavio Leitner wrote: Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU overhead. A guest using vhostuser interface with TSO enabled can send TCP packets much

[ovs-dev] [PATCH v5] userspace: Add TCP Segmentation Offload support

2020-01-17 Thread Flavio Leitner
Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU overhead. A guest using vhostuser interface with TSO enabled can send TCP packets much bigger than the MTU, which saves CPU cycles

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Stokes, Ian
On 1/17/2020 9:37 PM, Flavio Leitner wrote: On Fri, Jan 17, 2020 at 12:37:56PM -0800, William Tu wrote: On Fri, Jan 17, 2020 at 04:58:57PM -0300, Flavio Leitner wrote: On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets wrote: On 16.01.2020 18:00, Flavio Leitner wrote: > [...] diff

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Flavio Leitner
On Fri, Jan 17, 2020 at 12:37:56PM -0800, William Tu wrote: > On Fri, Jan 17, 2020 at 04:58:57PM -0300, Flavio Leitner wrote: > > On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets wrote: > > > On 16.01.2020 18:00, Flavio Leitner wrote: > [...] > > > > diff --git a/lib/userspace-tso.c

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread William Tu
On Fri, Jan 17, 2020 at 04:58:57PM -0300, Flavio Leitner wrote: > On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets wrote: > > On 16.01.2020 18:00, Flavio Leitner wrote: > > > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables > > > the network stack to delegate the TCP

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Flavio Leitner
On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets wrote: > On 16.01.2020 18:00, Flavio Leitner wrote: > > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables > > the network stack to delegate the TCP segmentation to the NIC reducing > > the per packet CPU overhead. > > >

Re: [ovs-dev] [PATCH] Typo fix: vswtich -> vswitch.

2020-01-17 Thread Ben Pfaff
On Fri, Jan 17, 2020 at 04:58:32PM +0530, Numan Siddique wrote: > On Fri, Jan 17, 2020 at 5:52 AM Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > Acked-by: Numan Siddique Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

[ovs-dev] SERVICE DE PRÊT

2020-01-17 Thread Andrea lese
Salut à vous Vous êtes rejeté par la banque et vous désirez avoir un prêt pour répondre à vos besoins, pas de problème, quelle que soit votre situation financière. Je vous offre les prêts hypothécaires, prêts commerciaux, les prêts internationaux, les prêts personnels et de prêts exclusive Prêts

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Stokes, Ian
On 1/17/2020 5:58 PM, Ilya Maximets wrote: On 16.01.2020 18:00, Flavio Leitner wrote: Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU overhead. A guest using vhostuser interface

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Ilya Maximets
On 16.01.2020 18:00, Flavio Leitner wrote: > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables > the network stack to delegate the TCP segmentation to the NIC reducing > the per packet CPU overhead. > > A guest using vhostuser interface with TSO enabled can send TCP packets

Re: [ovs-dev] [PATCH v4 2/3] vhost: Disable multi-segmented buffers

2020-01-17 Thread Stokes, Ian
On 1/17/2020 5:48 PM, Stokes, Ian wrote: On 1/17/2020 4:24 PM, Ilya Maximets wrote: On 16.01.2020 18:00, Flavio Leitner wrote: There is no support for multi-segmented buffers, so flag that to vhost library. Signed-off-by: Flavio Leitner ---   lib/netdev-dpdk.c | 6 ++   1 file

Re: [ovs-dev] [PATCH v4 2/3] vhost: Disable multi-segmented buffers

2020-01-17 Thread Stokes, Ian
On 1/17/2020 4:24 PM, Ilya Maximets wrote: On 16.01.2020 18:00, Flavio Leitner wrote: There is no support for multi-segmented buffers, so flag that to vhost library. Signed-off-by: Flavio Leitner --- lib/netdev-dpdk.c | 6 ++ 1 file changed, 6 insertions(+) Suggesting to rename

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Stokes, Ian
On 1/17/2020 4:10 PM, Ilya Maximets wrote: On 17.01.2020 15:23, Stokes, Ian wrote: On 1/16/2020 5:00 PM, Flavio Leitner wrote: Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU

Re: [ovs-dev] [PATCH v4 2/3] vhost: Disable multi-segmented buffers

2020-01-17 Thread Ilya Maximets
On 16.01.2020 18:00, Flavio Leitner wrote: > There is no support for multi-segmented buffers, so flag > that to vhost library. > > Signed-off-by: Flavio Leitner > --- > lib/netdev-dpdk.c | 6 ++ > 1 file changed, 6 insertions(+) > Suggesting to rename this patch to: 'netdev-dpdk: Disable

Re: [ovs-dev] [PATCH v4 1/3] dp-packet: preserve headroom when cloning a pkt batch

2020-01-17 Thread Ilya Maximets
On 16.01.2020 18:00, Flavio Leitner wrote: > The headroom is useful if the packet needs to insert additional > header, so preserve the original headroom when cloning the batch. > > Signed-off-by: Flavio Leitner > --- > lib/dp-packet.h | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Ilya Maximets
On 17.01.2020 15:23, Stokes, Ian wrote: > > > On 1/16/2020 5:00 PM, Flavio Leitner wrote: >> Abbreviated as TSO, TCP Segmentation Offload is a feature which enables >> the network stack to delegate the TCP segmentation to the NIC reducing >> the per packet CPU overhead. >> >> A guest using

Re: [ovs-dev] [v5] dpif-netdev: Modified ovs-appctl dpctl/dump-flows command

2020-01-17 Thread Stokes, Ian
On 1/17/2020 11:46 AM, Finn, Emma wrote: Re-sending to patchwork -Original Message- From: Finn, Emma Sent: Friday 17 January 2020 10:11 To: d...@openvswitch.com Cc: i.maxim...@ovn.org; Stokes, Ian ; Finn, Emma Subject: [v5] dpif-netdev: Modified ovs-appctl dpctl/dump-flows command

[ovs-dev] [PATCH ovn] ovn-northd: Set stage-hint for all applicable flows.

2020-01-17 Thread Dumitru Ceara
Until now the 'stage-hint' external-id was set only for logical flows installed for ACLs. In order to simplify troubleshooting, extend the approach and apply whenever possible. Set stage-hint for logical flows generated by the following NB tables too: - Logical_Switch_Port - Logical_Router_Port -

Re: [ovs-dev] [PATCH] Fix links to ovs-advanced tutorial

2020-01-17 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (Documentation/tutorials/ovn-sandbox.rst).

Re: [ovs-dev] [PATCH] Fix links to ovs-advanced tutorial

2020-01-17 Thread Numan Siddique
On Fri, Jan 17, 2020 at 7:50 PM wrote: > > From: Lars Kellogg-Stedman > > This fixes the broken link in the README to the ovs-advanced tutorial. > This also adds a hyperlink to Documentation/tutorials/ovn-sandbox.rst > where the tutorial is referenced. > > Closes #7 Thanks for the PR Lars. I

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-17 Thread Stokes, Ian
On 1/16/2020 5:00 PM, Flavio Leitner wrote: Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU overhead. A guest using vhostuser interface with TSO enabled can send TCP packets much

[ovs-dev] [PATCH] Fix links to ovs-advanced tutorial

2020-01-17 Thread numans
From: Lars Kellogg-Stedman This fixes the broken link in the README to the ovs-advanced tutorial. This also adds a hyperlink to Documentation/tutorials/ovn-sandbox.rst where the tutorial is referenced. Closes #7 Signed-off-by: Lars Kellogg-Stedman --- Documentation/tutorials/ovn-sandbox.rst

Re: [ovs-dev] [PATCH 2/3] ovn-controller.c: Move the position of handling OVN-SB related settings.

2020-01-17 Thread Numan Siddique
On Wed, Jan 15, 2020 at 5:34 PM Flavio Fernandes wrote: > > > > > On Jan 14, 2020, at 5:34 PM, Han Zhou wrote: > > > > On Tue, Jan 14, 2020 at 1:24 PM Mark Michelson wrote: > >> > >> The commit message doesn't make much sense to me. The external-ids are > >> set outside of ovn-controller, so

Re: [ovs-dev] [PATCH 1/3] ovn-controller.c: Fix possible NULL pointer dereference.

2020-01-17 Thread Numan Siddique
On Wed, Jan 15, 2020 at 3:51 AM Han Zhou wrote: > > Hi Mark, > > Thanks for the review! > In fact, if cfg was NULL, this function would never have a chance to set > probe interval, because before setting the interval it would have already > crashed, at this line: > int interval =

Re: [ovs-dev] [PATCH ovn 1/4] ovn-controller: A new action "select".

2020-01-17 Thread Numan Siddique
On Tue, Jan 7, 2020 at 8:00 AM Han Zhou wrote: > > Support a new logical flow action "select", which can be used to > implement features such as ECMP. The action uses OpenFlow group > action to select an integer (uint16_t) from a list of integers, > and assign it to specified field, e.g.: >

Re: [ovs-dev] [v5] dpif-netdev: Modified ovs-appctl dpctl/dump-flows command

2020-01-17 Thread Finn, Emma
Re-sending to patchwork > -Original Message- > From: Finn, Emma > Sent: Friday 17 January 2020 10:11 > To: d...@openvswitch.com > Cc: i.maxim...@ovn.org; Stokes, Ian ; Finn, Emma > > Subject: [v5] dpif-netdev: Modified ovs-appctl dpctl/dump-flows command > > Modified ovs-appctl

Re: [ovs-dev] [PATCH] Typo fix: vswtich -> vswitch.

2020-01-17 Thread Numan Siddique
On Fri, Jan 17, 2020 at 5:52 AM Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Numan Siddique Numan > --- > NEWS | 2 +- > tests/ofproto-dpif.at | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index

Re: [ovs-dev] [PATCH 1/1] NEWS: Fix location of output actions to be under DPDK

2020-01-17 Thread Ilya Maximets
On 17.01.2020 09:26, Eli Britstein wrote: > In the cited commit, the output actions NEWS was mistekenly under OVSDB > instead of DPDK. Fix it. > > Fixes: 3c7330ebf036 ("netdev-offload-dpdk: Support offload of output action.") > Signed-off-by: Eli Britstein Thanks! Applied to master. Best

Re: [ovs-dev] [PATCH v4 0/3] Add support for TSO with DPDK

2020-01-17 Thread Loftus, Ciara
> -Original Message- > From: Flavio Leitner > Sent: Thursday 16 January 2020 17:01 > To: d...@openvswitch.org > Cc: Stokes, Ian ; Loftus, Ciara > ; Ilya Maximets ; > yangy...@inspur.com; txfh2007 ; Flavio Leitner > > Subject: [PATCH v4 0/3] Add support for TSO with DPDK > >

Re: [ovs-dev] [PATCH] Grant Access Privilege of Named Pipe to Creator

2020-01-17 Thread 0-day Robot
Bleep bloop. Greetings Ning Wu via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: corrupt patch at line 13 Repository lacks necessary blobs to fall back on 3-way merge.

[ovs-dev] [PATCH] Grant Access Privilege of Named Pipe to Creator

2020-01-17 Thread Ning Wu via dev
Current implementation of ovs on windows only allows LocalSystem and Administrators to access the named pipe created with API of ovs. Thus any service that needs to invoke the API to create named pipe has to run as System account to interactive with ovs. It causes the system more vulnerable if one

[ovs-dev] [PATCH 1/1] NEWS: Fix location of output actions to be under DPDK

2020-01-17 Thread Eli Britstein
In the cited commit, the output actions NEWS was mistekenly under OVSDB instead of DPDK. Fix it. Fixes: 3c7330ebf036 ("netdev-offload-dpdk: Support offload of output action.") Signed-off-by: Eli Britstein --- NEWS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS