[ovs-dev] [PATCH] openvswitch: Distribute switch variables for initialization

2020-02-19 Thread Kees Cook
Variables declared in a switch statement before any case statements cannot be automatically initialized with compiler instrumentation (as they are not part of any execution flow). With GCC's proposed automatic stack variable initialization feature, this triggers a warning (and they don't get initia

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-19 Thread Han Zhou
On Wed, Feb 19, 2020 at 2:11 AM Numan Siddique wrote: > > On Wed, Feb 19, 2020 at 1:16 PM Han Zhou wrote: > > > > On Tue, Feb 18, 2020 at 11:56 AM Numan Siddique wrote: > > > > > > On Tue, Feb 18, 2020 at 11:50 PM Han Zhou wrote: > > > > > > > > On Tue, Feb 18, 2020 at 9:27 AM Numan Siddique w

Re: [ovs-dev] [PATCH ovn] ovn-controller.c: Avoid adding neighbour flows for non-local datapaths.

2020-02-19 Thread Han Zhou
On Wed, Feb 19, 2020 at 4:50 AM Dumitru Ceara wrote: > > On 2/19/20 12:32 AM, Han Zhou wrote: > > This is usefule when external_ids:ovn-monitor-all is set to true. > > > > Signed-off-by: Han Zhou > > Hi Han, > > Looks good to me. > > Acked-by: Dumitru Ceara > > I also tested this (together with

Re: [ovs-dev] [PATCH v2 3/4] Add file descriptor persistence where possible

2020-02-19 Thread Anton Ivanov
On 19/02/2020 14:20, Dumitru Ceara wrote: On 2/18/20 7:12 AM, Anton Ivanov wrote: On 17/02/2020 14:48, Dumitru Ceara wrote: On 2/14/20 6:54 PM, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov 1. Adds "persistent" behaviour where feasible (streams and signals). These are waited

Re: [ovs-dev] [PATCH ovn v1] northd: Allow /64 after ipv6_prefix

2020-02-19 Thread 0-day Robot
Bleep bloop. Greetings Russell Bryant, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #41 FILE: northd/ovn-northd.c:6

[ovs-dev] FBI HEAD OFFICE WASHINGTON.

2020-02-19 Thread WASHINGTON.
FBI HEAD OFFICE WASHINGTON. Address : 935 Pennsylvania Ave NW, Washington, DC 20535, United States. Hello. FBI refused to approve your payment for this reason. You have not Affidavit of claim from court and for this reason no bank in the world will accept to pay you money until you provide

[ovs-dev] [PATCH ovn v1] northd: Allow /64 after ipv6_prefix

2020-02-19 Thread Russell Bryant
We recently hit a bug in ovn-kubernetes, where I accidentally added /64 at the end of ipv6_prefix, to match the format we used for the subnet option for IPv4. This was not allowed. This patch update ovn-northd to take the ipv6_prefix either with or without a trailing "/64". It still enforces a /

Re: [ovs-dev] 答复: [PATCH v3] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-02-19 Thread William Tu
Hi Yi, Thanks for making travis test passed on this patch. William On Tue, Feb 18, 2020 at 10:11 PM Yi Yang (杨燚)-云服务集团 wrote: > > Hi, William > > I pushed fix patch into my github repo, travis showed all the builds passed, > https://travis-ci.org/yyang13/ovs (my ovs repo: > https://github.com

[ovs-dev] [PATCH ovn] [RFC] Add chassis liveness monitoring mechanism

2020-02-19 Thread lmartins
From: Lucas Alvares Gomes NOTE: SENDING THIS PATCH AS A RFC TO SEE WHAT OTHERS MIGHT THINK ABOUT THE IDEA PRIOR TO WRITTING TESTS TO IT. CMSes integrating with OVN often uses the nb_cfg mechanism as a way to check the health status of the ovn-controller process but, the current implementation is

Re: [ovs-dev] [PATCH v2 3/4] Add file descriptor persistence where possible

2020-02-19 Thread Dumitru Ceara
On 2/18/20 7:12 AM, Anton Ivanov wrote: > > > On 17/02/2020 14:48, Dumitru Ceara wrote: >> On 2/14/20 6:54 PM, anton.iva...@cambridgegreys.com wrote: >>> From: Anton Ivanov >>> >>> 1. Adds "persistent" behaviour where feasible (streams and signals). >>> These are waited upon in the same thread w

Re: [ovs-dev] votre espace sera suspendu

2020-02-19 Thread FR--Crédit mutuel--
  Madame, Monsieur, Vous devez vous connecter à votre compte de crédit mutuel dès que possible et accepter les nouvelles conditions pour confirmer et / ou mettre à jour vos données personnelles. Avec cette étape, nous pouvons nous assurer que votre adresse électronique et votre numéro de

[ovs-dev] 答复: 答复: OVS performance issue: why small udp packet pps performance between VMs is highly related with number of ovs ports and number of VMs?

2020-02-19 Thread 杨燚
Hi, Flavio and Ilya After I checked it further, I'm very sure it isn't led by bandwidth limit, the issue is still there after I totally removed bandwidth limit (tc qdisc show can confirm this). The issue becomes more seriously when we started more VMs in a subnet, we did see the actions which

Re: [ovs-dev] [PATCH ovn] ovn-controller.c: Avoid adding neighbour flows for non-local datapaths.

2020-02-19 Thread Dumitru Ceara
On 2/19/20 12:32 AM, Han Zhou wrote: > This is usefule when external_ids:ovn-monitor-all is set to true. > > Signed-off-by: Han Zhou Hi Han, Looks good to me. Acked-by: Dumitru Ceara I also tested this (together with your previous patch) on a scaled setup with 150 ovn-fake-multinode nodes an

Re: [ovs-dev] [PATCH ovn] ovn-controller: Avoid creating patch port for non-local datapaths.

2020-02-19 Thread Dumitru Ceara
On 2/18/20 11:26 PM, Han Zhou wrote: > When external-ids:ovn-monitor-all is set to true, patch ports for > non-local datapaths may be created, which is unnecessary and > confusing. This patch avoids that by checking if a localnet port > belongs to local datapaths before creating the patch port. I

Re: [ovs-dev] [PATCH ovn] pinctrl: fix IP buffering with connection-tracking

2020-02-19 Thread Numan Siddique
On Wed, Feb 19, 2020 at 4:29 PM Dumitru Ceara wrote: > > On 2/19/20 11:02 AM, Lorenzo Bianconi wrote: > > On Feb 19, Dumitru Ceara wrote: > >> On 2/13/20 5:49 PM, Lorenzo Bianconi wrote: > >>> Whenever we need to reinject an IP packet buffered during L2 address > >>> resolution we need to preserve

Re: [ovs-dev] [PATCH v2 ovn] Save the addr set and port groups in lflow expr cache

2020-02-19 Thread Numan Siddique
On Wed, Feb 19, 2020 at 1:10 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 11:54 AM wrote: > > > > From: Numan Siddique > > > > After the patch [1], which added caching of lflow expr, the > lflow_resource_ref > > is not rebuilt properly when lflow_run() is called. If a lflow is already > cached

Re: [ovs-dev] [PATCH ovn] pinctrl: fix IP buffering with connection-tracking

2020-02-19 Thread Dumitru Ceara
On 2/19/20 11:02 AM, Lorenzo Bianconi wrote: > On Feb 19, Dumitru Ceara wrote: >> On 2/13/20 5:49 PM, Lorenzo Bianconi wrote: >>> Whenever we need to reinject an IP packet buffered during L2 address >>> resolution we need to preserve ovs ofport in order to let ovs >>> connection tracking to properl

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't clear the lflow resources ref during flow_output_run

2020-02-19 Thread Numan Siddique
On Wed, Feb 19, 2020 at 1:16 PM Han Zhou wrote: > > On Tue, Feb 18, 2020 at 11:56 AM Numan Siddique wrote: > > > > On Tue, Feb 18, 2020 at 11:50 PM Han Zhou wrote: > > > > > > On Tue, Feb 18, 2020 at 9:27 AM Numan Siddique wrote: > > > > > > > On Tue, Feb 18, 2020 at 10:34 PM Han Zhou wrote: >

Re: [ovs-dev] [PATCH ovn] pinctrl: fix IP buffering with connection-tracking

2020-02-19 Thread Lorenzo Bianconi
On Feb 19, Dumitru Ceara wrote: > On 2/13/20 5:49 PM, Lorenzo Bianconi wrote: > > Whenever we need to reinject an IP packet buffered during L2 address > > resolution we need to preserve ovs ofport in order to let ovs > > connection tracking to properly SNAT/DNAT the packet. > > Do not overwrite the

Re: [ovs-dev] [PATCH ovn] pinctrl: fix IP buffering with connection-tracking

2020-02-19 Thread Dumitru Ceara
On 2/13/20 5:49 PM, Lorenzo Bianconi wrote: > Whenever we need to reinject an IP packet buffered during L2 address > resolution we need to preserve ovs ofport in order to let ovs > connection tracking to properly SNAT/DNAT the packet. > Do not overwrite the MFF_IN_PORT in consider_port_binding rout