[ovs-dev] [PATCH 1/2] raft: Fix the problem of stuck in candidate role forever.

2020-03-05 Thread Han Zhou
Sometimes a server can stay in candidate role forever, even if the server already see the new leader and handles append-requests normally. However, because of the wrong role, it appears as disconnected from cluster and so the clients are disconnected. This problem happens when 2 servers become

[ovs-dev] [PATCH 2/2] raft: Unset leader when starting election.

2020-03-05 Thread Han Zhou
During election, there shouldn't be any leader. This change makes sure that a server in candidate role always report leader as "unknown". Signed-off-by: Han Zhou --- ovsdb/raft.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index 2e1144c..1717ccc 100644 ---

Re: [ovs-dev] [PATCH] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-05 Thread 0-day Robot
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (controller/pinctrl.c). error: could not build

[ovs-dev] [PATCH] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-05 Thread Ihar Hrachyshka
As per RFC2131, section 4.1: A server or relay agent sending or relaying a DHCP message directly to a DHCP client (i.e., not to a relay agent specified in the 'giaddr' field) SHOULD examine the BROADCAST bit in the 'flags' field. If this bit is set to 1, the DHCP message SHOULD be

Re: [ovs-dev] [PATCH] release-process: Describe how to branch and how to make a release.

2020-03-05 Thread Justin Pettit
Small point, but do you think it's worth pointing to the website repo in the instructions? (I suppose anyone who's doing branching probably knows it.) Acked-by: Justin Pettit --Justin > On Feb 14, 2020, at 4:18 PM, Ben Pfaff wrote: > > CC: Justin Pettit > Signed-off-by: Ben Pfaff > ---

Re: [ovs-dev] [PATCH ovn v4] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-05 Thread Ben Pfaff
On Thu, Mar 05, 2020 at 05:16:04PM -0500, Ihar Hrachyshka wrote: > On Thu, Mar 5, 2020, 15:15 Ben Pfaff wrote: > > > On Thu, Mar 05, 2020 at 02:56:17PM -0500, Ihar Hrachyshka wrote: > > > As per RFC2131, section 4.1: > > >A server or relay agent sending or relaying a DHCP message directly >

Re: [ovs-dev] [PATCH ovn v4] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-05 Thread Ihar Hrachyshka
On Thu, Mar 5, 2020, 15:15 Ben Pfaff wrote: > On Thu, Mar 05, 2020 at 02:56:17PM -0500, Ihar Hrachyshka wrote: > > As per RFC2131, section 4.1: > >A server or relay agent sending or relaying a DHCP message directly > >to a DHCP client (i.e., not to a relay agent specified in the > >

Re: [ovs-dev] [PATCH] ovs-dpctl-top: python3 compatibility

2020-03-05 Thread Ben Pfaff
On Mon, Mar 02, 2020 at 01:32:48PM -0300, Flavio Leitner wrote: > On Mon, Mar 02, 2020 at 11:05:06AM -0500, Aaron Conole wrote: > > During the transition to python3 support, some syntax errors weren't > > adequately cleaned. This addresses the various errors, plus one > > minor issue with string

Re: [ovs-dev] [PATCH] ovsdb-idl.c: Clear conditions when clearing IDL.

2020-03-05 Thread Ben Pfaff
On Tue, Mar 03, 2020 at 01:47:48PM +0100, Dumitru Ceara wrote: > CC-ing Andy and Ben. > > On 3/3/20 7:43 AM, Han Zhou wrote: > > > > > > On Mon, Mar 2, 2020 at 7:55 AM Dumitru Ceara > > wrote: > >> > >> On 2/29/20 12:00 AM, Dumitru Ceara wrote: > >> > If the

Re: [ovs-dev] [PATCH] release-process: Describe how to branch and how to make a release.

2020-03-05 Thread Ben Pfaff
On Fri, Feb 14, 2020 at 04:18:50PM -0800, Ben Pfaff wrote: > CC: Justin Pettit > Signed-off-by: Ben Pfaff This needs a review. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Cyber Security Users List

2020-03-05 Thread Amy Linda
Hi, Would you be interested in acquiring the below mentioned database for your marketing program. Target Titles: Decision Makers from - Corporate Security, Risk, Compliance & Fraud, IT Decision Makers, C-level, VP-level, Directors, Managers, Engineers, Networking professionals, and more.

Re: [ovs-dev] [PATCH] packets: Fix typo in comment.

2020-03-05 Thread Ben Pfaff
On Wed, Mar 04, 2020 at 12:09:20PM -0800, Han Zhou wrote: > On Tue, Mar 3, 2020 at 10:37 AM Ben Pfaff wrote: > > > > Reported-by: Toms Atteka > > Signed-off-by: Ben Pfaff > > --- > > lib/packets.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/packets.h

Re: [ovs-dev] [PATCH ovn v3] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-05 Thread Ben Pfaff
On Thu, Mar 05, 2020 at 12:22:18PM +0530, Numan Siddique wrote: > One small comment on the above function. How about doing this way > > static bool > is_dhcp_flags_broadcast(ovs_be16 flags) > { > return ntohs(flags) & DHCP_BROADCAST_FLAG; > } The canonical form is: return flags &

Re: [ovs-dev] [PATCH ovn v4] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-05 Thread Ben Pfaff
On Thu, Mar 05, 2020 at 02:56:17PM -0500, Ihar Hrachyshka wrote: > As per RFC2131, section 4.1: >A server or relay agent sending or relaying a DHCP message directly >to a DHCP client (i.e., not to a relay agent specified in the >'giaddr' field) SHOULD examine the BROADCAST bit in the

Re: [ovs-dev] [PATCH ovn] Improve documentation of gateways.

2020-03-05 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #600 FILE:

[ovs-dev] [PATCH ovn v4] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-05 Thread Ihar Hrachyshka
As per RFC2131, section 4.1: A server or relay agent sending or relaying a DHCP message directly to a DHCP client (i.e., not to a relay agent specified in the 'giaddr' field) SHOULD examine the BROADCAST bit in the 'flags' field. If this bit is set to 1, the DHCP message SHOULD be

[ovs-dev] [PATCH ovn] Improve documentation of gateways.

2020-03-05 Thread Ben Pfaff
I found the documentation for gateways, especially HA gateways, to be unclear and insufficient. This commit improves it. CC: Numan Siddique CC: Gurucharan Shetty Signed-off-by: Ben Pfaff --- ovn-architecture.7.xml | 440 +++-- ovn-nb.xml | 183

Re: [ovs-dev] [PATCH 00/25] netdev datapath vxlan offload

2020-03-05 Thread Pravin Shelar
On Sun, Mar 1, 2020 at 8:25 PM Sriharsha Basavapatna via dev wrote: > > On Tue, Feb 18, 2020 at 3:30 PM Eli Britstein wrote: > > > > > > On 2/10/2020 11:16 PM, Hemal Shah wrote: > > > Eli, > > > > > > There are some fundamental architecture issues (multi HW tables vs. > > > single HW table, use

Re: [ovs-dev] -

2020-03-05 Thread Francois Pinault
A donation was made in your favour by Francois Pinault, reply for more details. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovs v1 0/2] Allow setting MAC on DPDK interfaces

2020-03-05 Thread Noa Ezra
In cloud topology, when SR-IOV with port representors is in use and VM is not trusted, the orchestration should set the VF mac address. When using DPDK there is an architecture limitation to set the VF mac address from host (Linux tooling). According to previous discussion

[ovs-dev] [PATCH ovs v1 1/2] netdev-dpdk: Add ability to set MAC address.

2020-03-05 Thread Noa Ezra
From: Ilya Maximets It is possible to set MAC address for DPDK ports by calling rte_eth_dev_default_mac_addr_set(). For some reason OVS didn't use this functionality avoiding real MAC address configuration. With this change following command will result in real MAC address update on HW NIC:

[ovs-dev] [PATCH ovs v1 2/2] netdev-dpdk: Allow setting MAC on DPDK interfaces

2020-03-05 Thread Noa Ezra
Adding a command for setting MAC of DPDK interfaces using: ovs-appctl netdev-dpdk/set-mac Signed-off-by: Noa Ezra Acked-by: Roni Bar Yanai --- lib/netdev-dpdk.c | 36 1 file changed, 36 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c

Re: [ovs-dev] [patch]ofproto:fix use-after-free

2020-03-05 Thread 0-day Robot
Bleep bloop. Greetings guohongzhi (A), I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch fragment without header at line 16: @@ -2852,6 +2857,22 @@

[ovs-dev] [patch]ofproto:fix use-after-free

2020-03-05 Thread guohongzhi (A)
ASAN report use-after-free when destroy ofproto_rule, the rule->ofproto has freed in ofproto_destroy. here is the ASAN report: ==10399==ERROR: AddressSanitizer: heap-use-after-free on address

Re: [ovs-dev] [PATCH] conntrack: Reset ct_state when entering a new zone.

2020-03-05 Thread Dumitru Ceara
On 3/4/20 8:44 PM, Dumitru Ceara wrote: > On 3/4/20 7:45 PM, Ilya Maximets wrote: >> On 3/4/20 2:01 PM, Dumitru Ceara wrote: >>> On 1/30/20 3:16 PM, Dumitru Ceara wrote: When a new conntrack zone is entered, the ct_state field is zeroed in order to avoid using state information from

[ovs-dev] [PATCH v2] conntrack: Reset ct_state when entering a new zone.

2020-03-05 Thread Dumitru Ceara
When a new conntrack zone is entered, the ct_state field is zeroed in order to avoid using state information from different zones. One such scenario is when a packet is double NATed. Assuming two zones and 3 flows performing the following actions in order on the packet: 1. ct(zone=5,nat), recirc

Re: [ovs-dev] [patch]ofproto:fix use-after-free

2020-03-05 Thread 0-day Robot
Bleep bloop. Greetings guohongzhi (A), I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 22 error: could not build fake ancestor hint: Use 'git am

[ovs-dev] [patch]ofproto:fix use-after-free

2020-03-05 Thread guohongzhi (A)
When destroy ofproto_rule, the rule->ofproto has freed in ofproto_destroy. ASAN report use-after-free. here is the ASAN report ==10399==ERROR: AddressSanitizer: heap-use-after-free on address 0x61e1e420 at pc 0xdcc29d1c bp 0x6c5fde40 sp 0x6c5fde60 READ of size 8 at

[ovs-dev] (no subject)

2020-03-05 Thread Juanito S. Galang
Herzlichen Glückwunsch Lieber Begünstigter,Sie erhalten diese E-Mail von der Robert Bailey Foundation. Ich bin ein pensionierter Regierungsangestellter aus Harlem und ein Gewinner des Powerball Lottery Jackpot im Wert von 343,8 Millionen US-Dollar. Ich bin der größte Jackpot-Gewinner in der

Re: [ovs-dev] OVS-DPDK public meeting

2020-03-05 Thread Kevin Traynor
Next meeting Mar 18th 1700 UTC (Planning to continue discussion on DPDK rte_flow HwOl) March 4th Minutes Attendees: Edwin, Keith, Cristian, Aaron, Eli, Ilya, Majd, Ajit, Fouad, Jingjing, Malvika, Ameer, Harsha, Johann, Oz, David, Ian, Roni, Simon, Somnath, Thomas, William, Marcelo, Hemal, John