[ovs-dev] [PATCH RFC ovn] Add VXLAN support for non-VTEP datapath bindings

2020-03-19 Thread Ihar Hrachyshka
Hello, this patch is not ready, sending it to collect initial feedback on the path taken. Let me know. Because of limited space in VXLAN VNI to pass over all three of - datapath id, ingress port, egress port - the implementation ignores ingress; and splits the remaining 24 bits of VNI into two

Re: [ovs-dev] [PATCH v2 3/3] travis: Enable OvS Travis CI for arm

2020-03-19 Thread Yanqin Wei
Hi Ilya, The patch is updated for reducing Arm CI running time. Do you think if the time increment is acceptable? https://patchwork.ozlabs.org/patch/1258100/ Best Regards, Wei Yanqin > -Original Message- > From: Yanqin Wei > Sent: Thursday, March 12, 2020 5:39 PM > To: Ilya Maximets ;

[ovs-dev] Ranking within the Megaflow Cache

2020-03-19 Thread Vipul Ujawane
Hello all, I was looking into the ranking within the Megaflow Cache, especially this patch https://patchwork.ozlabs.org/patch/648896/ which is implemented for the DPDK userspace datapath in the lib/dpif-netdev.c file. As this increases the performance by improving the linear search function, I was

[ovs-dev] 答复: 答复: [PATCH v7] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-03-19 Thread 杨燚
William, this is just a simple experiment, I'm still trying other ideas to get higher performance improvement, final patch is for Linux kernel net tree, not for ovs. -邮件原件- 发件人: William Tu [mailto:u9012...@gmail.com] 发送时间: 2020年3月19日 22:53 收件人: Yi Yang (杨燚)-云服务集团 抄送:

Re: [ovs-dev] ovs-vswitchd is dropping packets injected by controller during upcall

2020-03-19 Thread Ben Pfaff
On Fri, Mar 13, 2020 at 04:14:33PM +0530, Numan Siddique wrote: > Hi Ben, > > Its regarding the issue I mentioned in yesterday's meeting. > > What's the issue: > --- > - ovs-vswitchd is dropping packet during upcall - if the packet was > generated by ovn-controller (or any

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation when in_port is OFPP_CONTROLLER.

2020-03-19 Thread Ben Pfaff
Recirculation usually requires finding the pre-recirculation input port. Packets sent by the controller, with in_port of OFPP_CONTROLLER or OFPP_NONE, do not have a real input port data structure, only a port number. The code in xlate_lookup_ofproto_() mishandled this case, failing to return the

Re: [ovs-dev] [PATCH] conntrack: Fix NULL pointer dereference.

2020-03-19 Thread William Tu
On Thu, Mar 19, 2020 at 08:33:24PM +0100, Dumitru Ceara wrote: > On 3/18/20 12:12 AM, William Tu wrote: > > Coverity CID 279957 reports NULL pointer derefence when > > 'conn' is NULL and calling ct_print_conn_info. > > > > Cc: Usman Ansari > > Signed-off-by: William Tu > > Acked-by: Dumitru

Re: [ovs-dev] [PATCH] ofproto: Fix typo in manpage fragment.

2020-03-19 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 110 characters long (recommended limit is 79) #22 FILE:

Re: [ovs-dev] [PATCH] Documentation: Add note about iproute2 requirements for check-kmod

2020-03-19 Thread William Tu
On Wed, Mar 11, 2020 at 10:49:17AM -0700, Greg Rose wrote: > On many systems the check-kmod and check-kernel test suites have > many failures due to the lack of feature support in the older > iproute2 utility packages shipped with those systems. Add a > note indicating that it might be necessary

[ovs-dev] [PATCHv8 2/2] tests: Add tests using tap device.

2020-03-19 Thread William Tu
Similar to using veth across namespaces, this patch creates tap devices, assigns to namespaces, and allows traffic to go through different test cases. Signed-off-by: William Tu --- tests/automake.mk | 1 + tests/system-tap.at | 34 ++

[ovs-dev] [PATCHv8 1/2] userspace: Enable TSO support for non-DPDK.

2020-03-19 Thread William Tu
This patch enables TSO support for non-DPDK use cases, and also add check-system-tso testsuite. Before TSO, we have to disable checksum offload, allowing the kernel to calculate the TCP/UDP packet checsum. With TSO, we can skip the checksum validation by enabling checksum offload, and with large

Re: [ovs-dev] [PATCHv7 1/2] userspace: Enable TSO support for non-DPDK.

2020-03-19 Thread William Tu
On Thu, Mar 19, 2020 at 2:14 PM Flavio Leitner wrote: > > > Hi William, > > Nice that the amount of specific DPDK and non-DPDK reduced a lot! > I haven't tried to build or test yet. > > It may be nitpicking because you didn't introduce some of the > names in this patch so I understand it is not

Re: [ovs-dev] [PATCH 2/2] Documentation: Add extra repo info for RHEL 8

2020-03-19 Thread Gregory Rose
On 3/19/2020 4:03 PM, 0-day Robot wrote: Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Ok sounds good. Will do that. Thanks a ton! On Thu, Mar 19, 2020 at 3:53 PM Ben Pfaff wrote: > I backported both to 2.12. > > They need a manual backport to 2.11, will you take care of it? > > On Thu, Mar 19, 2020 at 03:39:58PM -0700, aginwala wrote: > > Oh I see it seems the previous patch

Re: [ovs-dev] [PATCH 2/2] Documentation: Add extra repo info for RHEL 8

2020-03-19 Thread 0-day Robot
Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #22 FILE:

[ovs-dev] [PATCH] ofproto: Fix typo in manpage fragment.

2020-03-19 Thread Ben Pfaff
There was a missing ] and an extra space. Signed-off-by: Ben Pfaff --- ofproto/ofproto-unixctl.man | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-unixctl.man b/ofproto/ofproto-unixctl.man index 925752343e87..095afd57cc55 100644 ---

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread Ben Pfaff
I backported both to 2.12. They need a manual backport to 2.11, will you take care of it? On Thu, Mar 19, 2020 at 03:39:58PM -0700, aginwala wrote: > Oh I see it seems the previous patch needs to be backported too > https://lists.linuxfoundation.org/pipermail/ovs-dev/2019-September/362925.html >

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Ok sure, will do in a bit! On Thu, Mar 19, 2020 at 3:40 PM Ben Pfaff wrote: > There is a merge conflict. Post a backported version? > > On Thu, Mar 19, 2020 at 03:07:39PM -0700, aginwala wrote: > > Hi Ben: > > > > Thanks for backporting previous patches. Please see if you can back port > >

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Oh I see it seems the previous patch needs to be backported too https://lists.linuxfoundation.org/pipermail/ovs-dev/2019-September/362925.html . Please see if you can get that too on 2.11 and 2.12 On Thu, Mar 19, 2020 at 3:35 PM Ben Pfaff wrote: > It doesn't apply cleanly. > > On Thu, Mar

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread Ben Pfaff
There is a merge conflict. Post a backported version? On Thu, Mar 19, 2020 at 03:07:39PM -0700, aginwala wrote: > Hi Ben: > > Thanks for backporting previous patches. Please see if you can back port > this one too to 2.11 and 2.12. > > On Thu, Mar 19, 2020 at 1:53 PM aginwala wrote: > > > Hi

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread Ben Pfaff
It doesn't apply cleanly. On Thu, Mar 19, 2020 at 03:07:39PM -0700, aginwala wrote: > Hi Ben: > > Thanks for backporting previous patches. Please see if you can back port > this one too to 2.11 and 2.12. > > On Thu, Mar 19, 2020 at 1:53 PM aginwala wrote: > > > Hi Ben: > > Can you also

Re: [ovs-dev] [PATCH] Documentation: Add note about iproute2 requirements for check-kmod

2020-03-19 Thread Gregory Rose
On 3/11/2020 10:52 AM, William Tu wrote: On Wed, Mar 11, 2020 at 10:49 AM Greg Rose wrote: On many systems the check-kmod and check-kernel test suites have many failures due to the lack of feature support in the older iproute2 utility packages shipped with those systems. Add a note

Re: [ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

2020-03-19 Thread 0-day Robot
Bleep bloop. Greetings Usman Ansari, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Usman Ansari needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

2020-03-19 Thread Ben Pfaff
On Thu, Mar 19, 2020 at 02:47:17PM -0700, ua1...@gmail.com wrote: > From: Usman Ansari > > Coverity reports a false positive below: > Incorrect expression, Assign_where_compare_meant: use of "=" > where "==" may have been intended. > Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL),

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Hi Ben: Thanks for backporting previous patches. Please see if you can back port this one too to 2.11 and 2.12. On Thu, Mar 19, 2020 at 1:53 PM aginwala wrote: > Hi Ben: > Can you also backport this patch to 2.12 and 2.11 too? > > On Mon, Oct 7, 2019 at 11:22 AM Ben Pfaff wrote: > >> On Mon,

[ovs-dev] [PATCH 1/2] compat: Fix nf_ip_hook parameters for RHEL 8

2020-03-19 Thread Greg Rose
A RHEL release version check was only checking for RHEL releases greater than 7.0 so that ended up including a compat fixup that is not needed for 8.0. Fix up the version check. Signed-off-by: Greg Rose --- datapath/linux/compat/stt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[ovs-dev] [PATCH 2/2] Documentation: Add extra repo info for RHEL 8

2020-03-19 Thread Greg Rose
The extra development repo for RHEL 8 has changed. Document it. Signed-off-by: Greg Rose --- Documentation/intro/install/fedora.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/intro/install/fedora.rst b/Documentation/intro/install/fedora.rst index 6fe1fb5..de00c4c

[ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

2020-03-19 Thread ua1422
From: Usman Ansari Coverity reports a false positive below: Incorrect expression, Assign_where_compare_meant: use of "=" where "==" may have been intended. Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL), false)'. "make check" passes for this change Coverity reports over 500 errors

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while running "db-is-standalone" command

2020-03-19 Thread Ben Pfaff
OK, done. On Thu, Mar 19, 2020 at 01:53:40PM -0700, aginwala wrote: > Hi Ben: > Can you also backport this patch to 2.12 and 2.11 too? > > On Mon, Oct 7, 2019 at 11:21 AM Ben Pfaff wrote: > > > On Mon, Oct 07, 2019 at 10:30:07AM +0200, Damijan Skvarc wrote: > > > problem is reported by

Re: [ovs-dev] [PATCH RFC] github-ci: Enable github actions.

2020-03-19 Thread Flavio Leitner
On Tue, Mar 17, 2020 at 01:27:13PM -0700, William Tu wrote: > So far we only use travis to do run 'make check' per commit. > This enables per-commit check for 'make check-system-userspace' test. > We can think about what others to add using github actions. > > Example run: >

Re: [ovs-dev] [PATCHv7 1/2] userspace: Enable TSO support for non-DPDK.

2020-03-19 Thread Flavio Leitner
Hi William, Nice that the amount of specific DPDK and non-DPDK reduced a lot! I haven't tried to build or test yet. It may be nitpicking because you didn't introduce some of the names in this patch so I understand it is not the goal of your patch. However, I think it can take the opportunity

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Marcelo Ricardo Leitner
On Thu, Mar 19, 2020 at 02:30:14PM -0400, Tim Rozet wrote: > In addition I can see in my setup that conntrack and ovs-dpctl all the > states are established: >

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while running "db-is-standalone" command

2020-03-19 Thread aginwala
Hi Ben: Can you also backport this patch to 2.12 and 2.11 too? On Mon, Oct 7, 2019 at 11:21 AM Ben Pfaff wrote: > On Mon, Oct 07, 2019 at 10:30:07AM +0200, Damijan Skvarc wrote: > > problem is reported by valgrind while running functional tests: > > > > ==21043== 160 (88 direct, 72 indirect)

Re: [ovs-dev] [PATCH 1/1] ovsdb-tool: fix memory leak while converting cluster into standalone database

2020-03-19 Thread aginwala
Hi Ben: Can you also backport this patch to 2.12 and 2.11 too? On Mon, Oct 7, 2019 at 11:22 AM Ben Pfaff wrote: > On Mon, Oct 07, 2019 at 10:10:34AM +0200, Damijan Skvarc wrote: > > memory leak is reported by valgrind while executing functional test > > "ovsdb-tool convert-to-standalone" > > >

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Aaron Conole
Tim Rozet writes: > I filed https://bugzilla.redhat.com/show_bug.cgi?id=1815217 to track this > issue. Thanks! > Tim Rozet > Red Hat CTO Networking Team > > On Thu, Mar 19, 2020 at 3:11 PM Ben Pfaff wrote: > > On Thu, Mar 19, 2020 at 10:27:52AM -0400, Mark Michelson wrote: > > I've

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Mar 19, 2020 at 10:27:52AM -0400, Mark Michelson wrote: >> I've recently been working on adding support for SCTP load balancers in >> OVN[1]. In a recent test run by Tim Rozet, he ran into an issue with my >> patch[2]. > > Do we have any idea whether OVS conntrack

Re: [ovs-dev] [PATCH] conntrack: Fix NULL pointer dereference.

2020-03-19 Thread Dumitru Ceara
On 3/18/20 12:12 AM, William Tu wrote: > Coverity CID 279957 reports NULL pointer derefence when > 'conn' is NULL and calling ct_print_conn_info. > > Cc: Usman Ansari > Signed-off-by: William Tu Acked-by: Dumitru Ceara Thanks, Dumitru > --- > lib/conntrack.c | 2 +- > 1 file changed, 1

Re: [ovs-dev] [PATCH v2] conntrack: Reset ct_state when entering a new zone.

2020-03-19 Thread Dumitru Ceara
On 3/19/20 9:12 AM, Dumitru Ceara wrote: > On 3/18/20 2:57 PM, Ilya Maximets wrote: >> On 3/5/20 12:28 PM, Dumitru Ceara wrote: >>> When a new conntrack zone is entered, the ct_state field is zeroed in >>> order to avoid using state information from different zones. >>> >>> One such scenario is

[ovs-dev] [PATCH v3] conntrack: Reset ct_state when entering a new zone.

2020-03-19 Thread Dumitru Ceara
When a new conntrack zone is entered, the ct_state field is zeroed in order to avoid using state information from different zones. One such scenario is when a packet is double NATed. Assuming two zones and 3 flows performing the following actions in order on the packet: 1. ct(zone=5,nat), recirc

Re: [ovs-dev] [PATCH v2] bugtool: Fix for Python3

2020-03-19 Thread William Tu
On Thu, Mar 19, 2020 at 12:05 PM Timothy Redaelli wrote: > > Currently ovs-bugtool tool doesn't start on Python 3. > This commit fixes ovs-bugtool to make it works on Python 3. > > Replaced StringIO.StringIO with io.BytesIO since the script is > processing binary data. > > Reported-at:

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Tim Rozet
I filed https://bugzilla.redhat.com/show_bug.cgi?id=1815217 to track this issue. Tim Rozet Red Hat CTO Networking Team On Thu, Mar 19, 2020 at 3:11 PM Ben Pfaff wrote: > On Thu, Mar 19, 2020 at 10:27:52AM -0400, Mark Michelson wrote: > > I've recently been working on adding support for SCTP

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Ben Pfaff
On Thu, Mar 19, 2020 at 10:27:52AM -0400, Mark Michelson wrote: > I've recently been working on adding support for SCTP load balancers in > OVN[1]. In a recent test run by Tim Rozet, he ran into an issue with my > patch[2]. Do we have any idea whether OVS conntrack works for SCTP in general?

Re: [ovs-dev] [PATCH] conntrack: Fix NULL pointer dereference.

2020-03-19 Thread William Tu
On Thu, Mar 19, 2020 at 9:31 AM Dumitru Ceara wrote: > > On 3/19/20 4:02 PM, William Tu wrote: > > On Wed, Mar 18, 2020 at 8:23 AM Ben Pfaff wrote: > >> > >> On Wed, Mar 18, 2020 at 01:49:48PM +0100, Ilya Maximets wrote: > >>> On 3/18/20 12:12 AM, William Tu wrote: > Coverity CID 279957

[ovs-dev] [PATCH v2] bugtool: Fix for Python3

2020-03-19 Thread Timothy Redaelli
Currently ovs-bugtool tool doesn't start on Python 3. This commit fixes ovs-bugtool to make it works on Python 3. Replaced StringIO.StringIO with io.BytesIO since the script is processing binary data. Reported-at: https://bugzilla.redhat.com/1809241 Reported-by: Flavio Leitner Signed-off-by:

Re: [ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

2020-03-19 Thread Ben Pfaff
On Thu, Mar 19, 2020 at 11:50:55AM -0700, Usman Ansari wrote: > Coverity reports a false positive below: > > Incorrect expression, Assign_where_compare_meant: use of "=" > > where "==" may have been intended. > > Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL), false)'. > > "make

Re: [ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

2020-03-19 Thread Usman S. Ansari
Attachment is blocked, let me copy-paste. Sorry about so many emails. On Thu, Mar 19, 2020 at 11:51 AM Usman Ansari wrote: > Coverity reports a false positive below: > > Incorrect expression, Assign_where_compare_meant: use of "=" > > where "==" may have been intended. > > Fixed it by rewriting

[ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

2020-03-19 Thread Usman Ansari
Coverity reports a false positive below: Incorrect expression, Assign_where_compare_meant: use of "=" where "==" may have been intended. Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL), false)'. "make check" passes for this change Coverity reports 80 errors resolved Suggested-by:

Re: [ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

2020-03-19 Thread Usman Ansari
Resending, I hope it works this time! On Wed, Mar 18, 2020 at 5:36 PM Ben Pfaff wrote: > On Wed, Mar 18, 2020 at 05:32:03PM -0700, Usman Ansari wrote: > > Suggested-by: Ben Pfaff > > > > Coverity reports a false positive below: > > Incorrect expression, Assign_where_compare_meant: use of "=" >

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Tim Rozet
In addition I can see in my setup that conntrack and ovs-dpctl all the states are established:

Re: [ovs-dev] [PATCH] util: Update OVS_TYPEOF macro for Windows.

2020-03-19 Thread Ben Pfaff
On Thu, Mar 19, 2020 at 10:03:15AM -0700, Archana Holla via dev wrote: > OVS_TYPEOF macro doesn’t return the type of object for non __GNUC__ platforms. > Updating it for _WIN32 platforms when used from C++ code. > > Signed-off-by: Archana Holla > --- > include/openvswitch/util.h | 4 > 1

[ovs-dev] [PATCH] util: Update OVS_TYPEOF macro for Windows.

2020-03-19 Thread Archana Holla via dev
OVS_TYPEOF macro doesn’t return the type of object for non __GNUC__ platforms. Updating it for _WIN32 platforms when used from C++ code. Signed-off-by: Archana Holla --- include/openvswitch/util.h | 4 1 file changed, 4 insertions(+) diff --git a/include/openvswitch/util.h

Re: [ovs-dev] [PATCH] conntrack: Fix NULL pointer dereference.

2020-03-19 Thread Dumitru Ceara
On 3/19/20 4:02 PM, William Tu wrote: > On Wed, Mar 18, 2020 at 8:23 AM Ben Pfaff wrote: >> >> On Wed, Mar 18, 2020 at 01:49:48PM +0100, Ilya Maximets wrote: >>> On 3/18/20 12:12 AM, William Tu wrote: Coverity CID 279957 reports NULL pointer derefence when 'conn' is NULL and calling

Re: [ovs-dev] [PATCH ovn] ovn-northd: Don't add arp responder flows for lports with 'unknown' address.

2020-03-19 Thread Han Zhou
On Thu, Mar 19, 2020 at 5:27 AM wrote: > > From: Numan Siddique > > If a logical port has 'unknown' address, it means it can send and receive > packet with any IP and MAC and generally port security is not set for > such logical ports. If an lport has addresses set to - ["MAC1 IP1", unknown], >

Re: [ovs-dev] [PATCH] python: Handle refTable values with setkey()

2020-03-19 Thread Numan Siddique
On Sat, Mar 14, 2020 at 5:41 AM Terry Wilson wrote: > > For columns like QoS.queues where we have a map containing refTable > values, assigning w/ __setattr__ e.g. qos.queues={1: $queue_row} > works, but using using qos.setkey('queues', 1, $queue_row) results > in an Exception. The opdat argument

Re: [ovs-dev] [PATCH] conntrack: Fix NULL pointer dereference.

2020-03-19 Thread William Tu
On Wed, Mar 18, 2020 at 8:23 AM Ben Pfaff wrote: > > On Wed, Mar 18, 2020 at 01:49:48PM +0100, Ilya Maximets wrote: > > On 3/18/20 12:12 AM, William Tu wrote: > > > Coverity CID 279957 reports NULL pointer derefence when > > > 'conn' is NULL and calling ct_print_conn_info. > > > > > > Cc: Usman

Re: [ovs-dev] [RFC PATCH 0/5] XDP offload using flow API provider

2020-03-19 Thread William Tu
On Tue, Mar 17, 2020 at 2:26 AM 牧田俊明 wrote: > > Any more feedback? > I'll work on implementing missing parts in RFC and prepare v2. > If anyone has feedback on the concept at this point, it would be helpful. > Hi Toshiaki, Thanks, I've read through the v1. If you have v2, please send it.

Re: [ovs-dev] 答复: [PATCH v7] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-03-19 Thread William Tu
On Wed, Mar 18, 2020 at 8:12 PM Yi Yang (杨燚)-云服务集团 wrote: > > Hi, folks > > As I said, TPACKET_V3 does have kernel implementation issue, I tried to fix > it in Linux kernel 5.5.9, here is my test data with tpacket_v3 and tso > enabled. On my low end server, my goal is to reach 16Gbps at least,

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Mark Michelson
On 3/19/20 10:27 AM, Mark Michelson wrote: Hi, I've recently been working on adding support for SCTP load balancers in OVN[1]. In a recent test run by Tim Rozet, he ran into an issue with my patch[2]. In short, during a typical SCTP association, it appears that conntrack never reaches the

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Mark Michelson
On 3/19/20 10:27 AM, Mark Michelson wrote: Hi, I've recently been working on adding support for SCTP load balancers in OVN[1]. In a recent test run by Tim Rozet, he ran into an issue with my patch[2]. In short, during a typical SCTP association, it appears that conntrack never reaches the

Re: [ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

2020-03-19 Thread William Tu
On Wed, Mar 18, 2020 at 5:37 PM Ben Pfaff wrote: > > On Wed, Mar 18, 2020 at 05:32:03PM -0700, Usman Ansari wrote: > > Suggested-by: Ben Pfaff > > > > Coverity reports a false positive below: > > Incorrect expression, Assign_where_compare_meant: use of "=" > > where "==" may have been intended.

Re: [ovs-dev] [PATCH] bugtool: Fix for Python3

2020-03-19 Thread William Tu
On Thu, Mar 19, 2020 at 4:03 AM Timothy Redaelli wrote: > > On Wed, 18 Mar 2020 14:25:43 -0700 > William Tu wrote: > > > On Wed, Mar 18, 2020 at 8:23 AM Timothy Redaelli > > wrote: > > > > > > Currently ovs-bugtool tool doesn't start on Python3. > > > This commit fixes ovs-bugtool to make it

[ovs-dev] Conntrack with SCTP: +est is never reached.

2020-03-19 Thread Mark Michelson
Hi, I've recently been working on adding support for SCTP load balancers in OVN[1]. In a recent test run by Tim Rozet, he ran into an issue with my patch[2]. In short, during a typical SCTP association, it appears that conntrack never reaches the "+est" state. OVN installs the following

Re: [ovs-dev] [PATCH RFC] github-ci: Enable github actions.

2020-03-19 Thread William Tu
On Thu, Mar 19, 2020 at 6:09 AM Aaron Conole wrote: > > William Tu writes: > > > So far we only use travis to do run 'make check' per commit. > > This enables per-commit check for 'make check-system-userspace' test. > > We can think about what others to add using github actions. > > > > Example

Re: [ovs-dev] [PATCH] dpif-netlink: avoid netlink modify flow put op failed after tc modify flow put op failed.

2020-03-19 Thread Simon Horman
On Thu, Mar 19, 2020 at 12:04:40PM +0100, Simon Horman wrote: > On Thu, Mar 19, 2020 at 11:28:00AM +0200, Roi Dayan wrote: > > > > > > On 2020-03-11 7:39 AM, we...@ucloud.cn wrote: > > > From: wenxu > > > > > > The tc modify flow put always delete the original flow first and > > > then add the

Re: [ovs-dev] [PATCH RFC] github-ci: Enable github actions.

2020-03-19 Thread Aaron Conole
William Tu writes: > So far we only use travis to do run 'make check' per commit. > This enables per-commit check for 'make check-system-userspace' test. > We can think about what others to add using github actions. > > Example run: >

Re: [ovs-dev] [PATCH v2 ovn] Documentation: Change 'Open vSwitch' for 'OVN and logo

2020-03-19 Thread Numan Siddique
On Wed, Mar 18, 2020 at 10:29 PM Ben Pfaff wrote: > > On Wed, Mar 18, 2020 at 05:31:23PM +0100, Daniel Alvarez Sanchez wrote: > > On Tue, Mar 17, 2020 at 6:57 PM Ben Pfaff wrote: > > > > > On Tue, Mar 17, 2020 at 06:22:07PM +0100, Daniel Alvarez wrote: > > > > The current version of the

[ovs-dev] [PATCH ovn] ovn-northd: Don't add arp responder flows for lports with 'unknown' address.

2020-03-19 Thread numans
From: Numan Siddique If a logical port has 'unknown' address, it means it can send and receive packet with any IP and MAC and generally port security is not set for such logical ports. If an lport has addresses set to - ["MAC1 IP1", unknown], right now we add arp responder flows for IP1 and

Re: [ovs-dev] [PATCH] travis: Fix kernel download retry.

2020-03-19 Thread David Marchand
On Thu, Mar 19, 2020 at 12:44 PM Ilya Maximets wrote: > > On 3/19/20 8:32 AM, David Marchand wrote: > > wget stops retrying to download a file when hitting fatal http errors > > like 503. > > But if a previous try had resulted in a partially downloaded ${file}, the > > next wget call tries to

Re: [ovs-dev] [PATCH] travis: Fix kernel download retry.

2020-03-19 Thread Ilya Maximets
On 3/19/20 8:32 AM, David Marchand wrote: > wget stops retrying to download a file when hitting fatal http errors > like 503. > But if a previous try had resulted in a partially downloaded ${file}, the > next wget call tries to download to ${file}.1. > > Example: > +wget

Re: [ovs-dev] [PATCH v6] db-ctl-base: add uuid specified method for create cmd

2020-03-19 Thread 0-day Robot
Bleep bloop. Greetings Tao YunXiang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 198 characters long (recommended limit is 79) #102 FILE:

Re: [ovs-dev] [PATCH] dpif-netlink: avoid netlink modify flow put op failed after tc modify flow put op failed.

2020-03-19 Thread Simon Horman
On Thu, Mar 19, 2020 at 11:28:00AM +0200, Roi Dayan wrote: > > > On 2020-03-11 7:39 AM, we...@ucloud.cn wrote: > > From: wenxu > > > > The tc modify flow put always delete the original flow first and > > then add the new flow. If the modfiy flow put operation failed, > > the flow put operation

Re: [ovs-dev] [PATCH] bugtool: Fix for Python3

2020-03-19 Thread Timothy Redaelli
On Wed, 18 Mar 2020 14:25:43 -0700 William Tu wrote: > On Wed, Mar 18, 2020 at 8:23 AM Timothy Redaelli wrote: > > > > Currently ovs-bugtool tool doesn't start on Python3. > > This commit fixes ovs-bugtool to make it works on Python.3 > > > > Reported-at: https://bugzilla.redhat.com/1809241 > >

[ovs-dev] [ovs-dev,v3]travis: Enable OvS Travis CI for arm.

2020-03-19 Thread Lance Yang
Enable part of travis jobs with gcc compiler for arm64 architecture 1. Add arm jobs into the matrix in .travis.yml configuration file 2. To enable OVS-DPDK jobs, set the build target according to different CPU architectures 3. Temporarily disable sparse checker because of static code checking

Re: [ovs-dev] [PATCH v5] db-ctl-base: add uuid specified method for create cmd

2020-03-19 Thread taoyunxi...@cmss.chinamobile.com
Hi Ben,            Thanks for your review. I have summited v6. The new change has fixed the bug, and add a unit test in ovs-vsctl.at. Please review it again. Thanks, Yun  -- taoyunxi...@cmss.chinamobile.com >I guess it's a bug. > >Have you posted the code you tested?  Please post

[ovs-dev] [PATCH v6] db-ctl-base: add uuid specified method for create cmd

2020-03-19 Thread Tao YunXiang
Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the UUID for inserted rows) solves ovsdb-client specifing the UUID for insert operation. OVSDB now can support directly using uuid to identify a row. But for xxxctl tool,specifying uuid when creating a row is not yet supported . This

[ovs-dev] [PATCH v3]travis: Enable OvS Travis CI for arm.

2020-03-19 Thread Lance Yang
Enable part of travis jobs with gcc compiler for arm64 architecture 1. Add arm jobs into the matrix in .travis.yml configuration file 2. To enable OVS-DPDK jobs, set the build target according to different CPU architectures 3. Temporarily disable sparse checker because of static code checking

Re: [ovs-dev] [PATCH] dpif-netlink: avoid netlink modify flow put op failed after tc modify flow put op failed.

2020-03-19 Thread Roi Dayan
On 2020-03-11 7:39 AM, we...@ucloud.cn wrote: > From: wenxu > > The tc modify flow put always delete the original flow first and > then add the new flow. If the modfiy flow put operation failed, > the flow put operation will change from modify to create if success > to delete the original

Re: [ovs-dev] [PATCH v2] conntrack: Reset ct_state when entering a new zone.

2020-03-19 Thread Dumitru Ceara
On 3/18/20 2:57 PM, Ilya Maximets wrote: > On 3/5/20 12:28 PM, Dumitru Ceara wrote: >> When a new conntrack zone is entered, the ct_state field is zeroed in >> order to avoid using state information from different zones. >> >> One such scenario is when a packet is double NATed. Assuming two zones

[ovs-dev] [PATCH] travis: Fix kernel download retry.

2020-03-19 Thread David Marchand
wget stops retrying to download a file when hitting fatal http errors like 503. But if a previous try had resulted in a partially downloaded ${file}, the next wget call tries to download to ${file}.1. Example: +wget https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-4.16.18.tar.xz --2020-03-18